From: Cong Wang <xiyou.wangcong@gmail.com>
To: saeedm@dev.mellanox.co.il
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [Patch net] mlx5: check for malformed packets
Date: Tue, 4 Dec 2018 12:17:09 -0800 [thread overview]
Message-ID: <CAM_iQpXCJikUcpV_y_nFo+CS6SCM+3bvMD7ryrY5bK292Z_KVg@mail.gmail.com> (raw)
In-Reply-To: <CALzJLG9U_pcEyXxjCqD5eVqf+sh4A1OUZfasqK3sDHFPr2seyg@mail.gmail.com>
On Tue, Dec 4, 2018 at 11:28 AM Saeed Mahameed
<saeedm@dev.mellanox.co.il> wrote:
>
> We are against having inline keywords in c file, so better if you
> move this function to a header file an force the inline keyword there.
Two points:
1. The existing code without my patch has inline keyword. Why
not move it from the beginning?
2. As I already mentioned, inline doesn't work with my patch,
__always_inline does.
Therefore, moving inline to a header doesn't make any difference.
next prev parent reply other threads:[~2018-12-04 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 20:38 [Patch net] mlx5: check for malformed packets Cong Wang
2018-12-02 8:56 ` Tariq Toukan
2018-12-03 5:11 ` Cong Wang
2018-12-03 18:15 ` Cong Wang
2018-12-03 18:39 ` Cong Wang
2018-12-04 19:28 ` Saeed Mahameed
2018-12-04 20:17 ` Cong Wang [this message]
2018-12-04 19:32 ` Saeed Mahameed
2018-12-04 20:21 ` Cong Wang
2018-12-05 1:16 ` Saeed Mahameed
2018-12-05 2:12 ` Cong Wang
2018-12-04 20:23 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXCJikUcpV_y_nFo+CS6SCM+3bvMD7ryrY5bK292Z_KVg@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.