From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7621EC43387 for ; Thu, 17 Jan 2019 18:07:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BA9520851 for ; Thu, 17 Jan 2019 18:07:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cl5aYD6k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728292AbfAQSH4 (ORCPT ); Thu, 17 Jan 2019 13:07:56 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38464 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbfAQSHz (ORCPT ); Thu, 17 Jan 2019 13:07:55 -0500 Received: by mail-pg1-f194.google.com with SMTP id g189so4774528pgc.5 for ; Thu, 17 Jan 2019 10:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y/8WnZaFva7hDbO7u6hbWmstRLUQW+gyRY58IvSznRw=; b=Cl5aYD6kH6twm5FeF2LO0apqyCBhzQv5WjGwPZ27l3heUYJZjwa7PPMeZlJmA+ZZF7 ZosByLiKZIIQUUwDYFPjeQPn2Rmg/y1wCpIMPiZO1aFxrCTt3FGnitJdG7N3ISJBf7Rq tH3APXdWwijzL9XnkkOv9KKya13ihAy7f3Sz4zwd8XSG1Wqk5ji1APsWvKFBAe8k6i1h slBxT9wOwb5r7NTO4xqECY0WnJaoRWvjXRYU23ZGCyTtqUdLU9ROt0gdCENWbG4CeI4T NbnSJkzAe+tK9Zl92ff8UeUrX+/DY/JgryMlUsmngM2CDAoY1atGpce14gOeq/lSynFE bXsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y/8WnZaFva7hDbO7u6hbWmstRLUQW+gyRY58IvSznRw=; b=Ux6iQvuqgW36R4XYjP+SjpjIyTZBPDep3APGmKP2qGKkI1h/Fi2aPEIzTzLR+QXn6s z6WDctoQBLFvPQ/JzuFSvxyM0y+YdpaCFF6RIZfiOCo72PvH9elzykzQAShoMvg1wv1y jn6cMm+rtt59fqvv0Zti6hMplbogrGX7TlzOOO++HU97O256aAHPuAkuIzN7RnlmwY5b d/3v9QJDtpRbCjiRkoq9H1s1kqygYyJ8fSet0uN7UiL2uDudpxKyF9dpGhpOeSmF9RrZ A9FLfJ4TXw1hqq1re001BL+4n+B//4j9wGLtjkkVELa/5tsLAwRFQXZYtIsOj7rwSqih MtwA== X-Gm-Message-State: AJcUukfbBsKaxQmkJ9myEzGBovwZ0XpVSojL7oLgT9hVk0dJyk+nlf6t mr4Hnza8y6bXqnoY2tt+aKG8C9+IH7XjVcGLEfE= X-Google-Smtp-Source: ALg8bN40DeXKsYAuDFKS/hIAzv28nVnD4NLcj046cdwO5Tsk+OPlr6QxonD0jouBhcr0h/TImYci0KVtRcWymB1baY8= X-Received: by 2002:a62:c505:: with SMTP id j5mr15903744pfg.149.1547748475092; Thu, 17 Jan 2019 10:07:55 -0800 (PST) MIME-Version: 1.0 References: <20190117081847.7791-1-yupeng0921@gmail.com> In-Reply-To: <20190117081847.7791-1-yupeng0921@gmail.com> From: Cong Wang Date: Thu, 17 Jan 2019 10:07:43 -0800 Message-ID: Subject: Re: [PATCH net-next] remove TWKilled counter To: yupeng Cc: Linux Kernel Network Developers , David Miller , Alexey Kuznetsov , Hideaki YOSHIFUJI Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 17, 2019 at 3:43 AM yupeng wrote: > diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h > index 86dc24a96c90..fb0a17337bf2 100644 > --- a/include/uapi/linux/snmp.h > +++ b/include/uapi/linux/snmp.h > @@ -178,7 +178,6 @@ enum > LINUX_MIB_ARPFILTER, /* ArpFilter */ > LINUX_MIB_TIMEWAITED, /* TimeWaited */ > LINUX_MIB_TIMEWAITRECYCLED, /* TimeWaitRecycled */ > - LINUX_MIB_TIMEWAITKILLED, /* TimeWaitKilled */ > LINUX_MIB_PAWSACTIVEREJECTED, /* PAWSActiveRejected */ > LINUX_MIB_PAWSESTABREJECTED, /* PAWSEstabRejected */ > LINUX_MIB_DELAYEDACKS, /* DelayedACKs */ This is no way to go, it is breaking user-space. You should at least keep this definition even if this counter is unused.