From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC2CC433E0 for ; Mon, 6 Jul 2020 06:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 689382074F for ; Mon, 6 Jul 2020 06:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hds38zgb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728855AbgGFGAA (ORCPT ); Mon, 6 Jul 2020 02:00:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728747AbgGFGAA (ORCPT ); Mon, 6 Jul 2020 02:00:00 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 054A5C061794 for ; Sun, 5 Jul 2020 23:00:00 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id c16so38100526ioi.9 for ; Sun, 05 Jul 2020 22:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+FxNF1PEqalq+JMiTNZR5vlolFljitlQJwIIQxol2+Y=; b=Hds38zgb4I2pcnzS+NfyEXIEMjZlsrdfX0PdTd7JVb86ba40CUvzsyuQNr3vHE9XFu XbzhmvTOc8yxWfVrduifK42W4R3oE65YxRWBcUeUole+M7O/gt8KlLLi88ej8uESX6zX h7eWXueNuB0sgjohjzhz4ud6ORwfcqkrlCeTw8mTpG1YaZceutjjvzCsxaOqvVdPpMGV I3sqW5e8xwKs8M/vM3+Pj6D1qXKC7b6/WTwS06La8i6WyygTIEBUO/rm+T0YZJEh80gZ QfMndluuuXutGn5gyWg1P2PB4uRwqs0E1SjUhqsbRaHavPLRkItLSlAjJfa82Q8aoON1 OSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+FxNF1PEqalq+JMiTNZR5vlolFljitlQJwIIQxol2+Y=; b=SJNCC3g+B6QXJ2MN29kipNpj1tWNm/1dJVB6rGmQ3aLXf9CHjO4ywaKADsh5fLe8SD iI85ybtW5owGtx3GDg5zkiSs1F4f0QOK3hdtkNG6Tm+8zLyF/JAC8ozO7qEda/TZjFxx I3HWbik6ZbF3krdTkBHXUrPmnDVp+FgC5WGJs0d5swUZ+OAEGvAR36wkKX8WlNmv6x+k 7UivM90BZe9N2wamI+JTMysUqIXvOLG3mcP8ntvI9osN1PE0cIQybtXuQHwAqa2HQiZ/ Axqky31CZwGdxheRRVYNMcVZNGuGA2315X7JS3HGDcnK88gB34KKvILi+sdenenBFYxP QflQ== X-Gm-Message-State: AOAM5327k663ScztHJ4dl4jRjHRE1RaCQkEupPUZaAJWUslvbhF5958z cUoSjw5mzHiAZBdfzbVVjUa7JszUN77nxAlo+MY28g0Kcsk= X-Google-Smtp-Source: ABdhPJxMSne3acX2TuV0hWwNrt1CdNI/E39QdGaZGC8ZALZGjeqRSt9yydiULjNUUZIBy98apaZ9r66eC4E3O+q8wzs= X-Received: by 2002:a5d:858e:: with SMTP id f14mr24005376ioj.12.1594015199413; Sun, 05 Jul 2020 22:59:59 -0700 (PDT) MIME-Version: 1.0 References: <10af044d-c51b-9b85-04b9-ea97a3c3ebdb@ucloud.cn> <8b06ac17-e19b-90f3-6dd2-0274a0ee474b@ucloud.cn> <012daf78-a18f-3dde-778a-482204c5b6af@ucloud.cn> <7aaefcef-5709-04a8-0c54-c8c6066e1e90@ucloud.cn> <20200702173228.GH74252@localhost.localdomain> <20200703004727.GU2491@localhost.localdomain> In-Reply-To: <20200703004727.GU2491@localhost.localdomain> From: Cong Wang Date: Sun, 5 Jul 2020 22:59:48 -0700 Message-ID: Subject: Re: [PATCH net] net/sched: act_mirred: fix fragment the packet after defrag in act_ct To: Marcelo Ricardo Leitner Cc: wenxu , Linux Kernel Network Developers Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 2, 2020 at 5:47 PM Marcelo Ricardo Leitner wrote: > > in this case a act_output_it_well could do it. ;-) Yeah, still much better than making "mirred" do "mirror, redirect, frag, defrag", can't we all agree it is too late to rename mirred? :) Please do not try to add any arbitrary functionality into act_mirred. Just stop here and find a better way. Thanks.