From: Cong Wang <xiyou.wangcong@gmail.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Alexander Lobakin <alobakin@pm.me>,
Paolo Abeni <pabeni@redhat.com>,
Talal Ahmad <talalahmad@google.com>,
Kevin Hao <haokexin@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Kees Cook <keescook@chromium.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Antoine Tenart <atenart@kernel.org>, Wei Wang <weiwan@google.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [net-next v5 2/2] net: sched: support hash/classid/cpuid selecting tx queue
Date: Mon, 20 Dec 2021 09:57:08 -0800 [thread overview]
Message-ID: <CAM_iQpXfZq--ZCUQvggtqE7bEpZFRVcLTqN_R5kLiZj4Y75VAA@mail.gmail.com> (raw)
In-Reply-To: <20211220123839.54664-3-xiangxia.m.yue@gmail.com>
On Mon, Dec 20, 2021 at 4:39 AM <xiangxia.m.yue@gmail.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> This patch allows user to select queue_mapping, range
> from A to B. And user can use skbhash, cgroup classid
> and cpuid to select Tx queues. Then we can load balance
> packets from A to B queue. The range is an unsigned 16bit
> value in decimal format.
>
> $ tc filter ... action skbedit queue_mapping skbhash A B
>
> "skbedit queue_mapping QUEUE_MAPPING" (from "man 8 tc-skbedit")
> is enhanced with flags:
> * SKBEDIT_F_TXQ_SKBHASH
> * SKBEDIT_F_TXQ_CLASSID
> * SKBEDIT_F_TXQ_CPUID
Once again, you are enforcing policies in kernel, which is not good.
Kernel should just set whatever you give to it, not selecting policies
like a menu.
Any reason why you can't obtain these values in user-space?
next prev parent reply other threads:[~2021-12-20 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 12:38 [net-next v5 0/2] net: sched: allow user to select txqueue xiangxia.m.yue
2021-12-20 12:38 ` [net-next v5 1/2] net: sched: use queue_mapping to pick tx queue xiangxia.m.yue
2021-12-20 13:57 ` Eric Dumazet
2021-12-20 14:21 ` Tonghao Zhang
2021-12-20 14:31 ` Tonghao Zhang
2021-12-20 17:51 ` Cong Wang
2021-12-22 1:19 ` Tonghao Zhang
2021-12-29 19:13 ` Vinicius Costa Gomes
2021-12-30 5:02 ` Tonghao Zhang
2022-01-26 19:58 ` Cong Wang
2022-01-27 1:35 ` Tonghao Zhang
2021-12-20 12:38 ` [net-next v5 2/2] net: sched: support hash/classid/cpuid selecting " xiangxia.m.yue
2021-12-20 17:57 ` Cong Wang [this message]
2021-12-22 1:23 ` Tonghao Zhang
2021-12-24 19:26 ` Cong Wang
2021-12-25 1:41 ` Tonghao Zhang
2021-12-29 12:50 ` Tonghao Zhang
2022-01-06 1:28 ` Tonghao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_iQpXfZq--ZCUQvggtqE7bEpZFRVcLTqN_R5kLiZj4Y75VAA@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=alobakin@pm.me \
--cc=arnd@arndb.de \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haokexin@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=talalahmad@google.com \
--cc=weiwan@google.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.