From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexander Aring <aring@mojatatu.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>, David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
kernel@mojatatu.com, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 7/8] net: sched: cls: add extack support for tc_setup_cb_call
Date: Tue, 16 Jan 2018 15:14:48 -0800 [thread overview]
Message-ID: <CAM_iQpXjebN1ZxcFjUZUjY2t2MY1i9KX2hAMr1KGihE=RuVQTQ@mail.gmail.com> (raw)
In-Reply-To: <20180116172027.22128-8-aring@mojatatu.com>
On Tue, Jan 16, 2018 at 9:20 AM, Alexander Aring <aring@mojatatu.com> wrote:
> int tc_setup_cb_call(struct tcf_block *block, struct tcf_exts *exts,
> - enum tc_setup_type type, void *type_data, bool err_stop)
> + enum tc_setup_type type, void *type_data, bool err_stop,
> + struct netlink_ext_ack *extack)
> {
> int ok_count;
> int ret;
>
> ret = tcf_block_cb_call(block, type, type_data, err_stop);
> - if (ret < 0)
> + if (ret < 0) {
> + NL_SET_ERR_MSG(extack, "Failed to inialize tcf block");
s/inialize/initialize/
> return ret;
> + }
> ok_count = ret;
>
> if (!exts)
> return ok_count;
> ret = tc_exts_setup_cb_egdev_call(exts, type, type_data, err_stop);
> - if (ret < 0)
> + if (ret < 0) {
> + NL_SET_ERR_MSG(extack, "Failed to inialize tcf block extensions");
Ditto.
next prev parent reply other threads:[~2018-01-16 23:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 17:20 [PATCH net-next 0/8] net: sched: cls: add extack support Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 1/8] net: sched: cls: fix code style issues Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 2/8] net: sched: cls_api: handle generic cls errors Alexander Aring
2018-01-16 23:12 ` Cong Wang
2018-01-16 23:58 ` David Ahern
2018-01-17 0:19 ` Jamal Hadi Salim
2018-01-17 3:22 ` David Ahern
2018-01-17 14:32 ` Jamal Hadi Salim
2018-01-16 17:20 ` [PATCH net-next 3/8] net: sched: cls: add extack support for change callback Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 4/8] net: sched: cls: add extack support for tcf_exts_validate Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 5/8] net: sched: cls: add extack support for delete callback Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 6/8] net: sched: cls: add extack support for tcf_change_indev Alexander Aring
2018-01-16 17:20 ` [PATCH net-next 7/8] net: sched: cls: add extack support for tc_setup_cb_call Alexander Aring
2018-01-16 23:14 ` Cong Wang [this message]
2018-01-16 17:20 ` [PATCH net-next 8/8] net: sched: cls_u32: add extack support Alexander Aring
2018-01-16 21:50 ` Jakub Kicinski
2018-01-16 23:00 ` Cong Wang
2018-01-16 21:46 ` [PATCH net-next 0/8] net: sched: cls: " Jakub Kicinski
2018-01-16 22:12 ` Jamal Hadi Salim
2018-01-16 22:41 ` Jakub Kicinski
2018-01-16 23:27 ` Jamal Hadi Salim
2018-01-17 0:08 ` Daniel Borkmann
2018-01-17 1:10 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpXjebN1ZxcFjUZUjY2t2MY1i9KX2hAMr1KGihE=RuVQTQ@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=aring@mojatatu.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.