All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Alexander Ovechkin <ovov@yandex-team.ru>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	zeil@yandex-team.ru, dmtrmonakhov@yandex-team.ru
Subject: Re: [PATCH net] net: sched: replaced invalid qdisc tree flush helper in qdisc_replace
Date: Fri, 29 Jan 2021 15:22:50 -0800	[thread overview]
Message-ID: <CAM_iQpXm6FpaS2YiFE3br6Ktx0fR2xqxyAuJC_LzBcYYiwa9+w@mail.gmail.com> (raw)
In-Reply-To: <20210129120154.316324-1-ovov@yandex-team.ru>

On Fri, Jan 29, 2021 at 4:02 AM Alexander Ovechkin <ovov@yandex-team.ru> wrote:
>
> Commit e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
> introduced qdisc tree flush/purge helpers, but erroneously used flush helper
> instead of purge helper in qdisc_replace function.
> This issue was found in our CI, that tests various qdisc setups by configuring
> qdisc and sending data through it. Call of invalid helper sporadically leads
> to corruption of vt_tree/cf_tree of hfsc_class that causes kernel oops:
...
> Fixes: e5f0e8f8e456 ("net: sched: introduce and use qdisc tree flush/purge helpers")
> Signed-off-by: Alexander Ovechkin <ovov@yandex-team.ru>

Looks reasonable to me:

Acked-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks.

       reply	other threads:[~2021-01-29 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210129120154.316324-1-ovov@yandex-team.ru>
2021-01-29 23:22 ` Cong Wang [this message]
2021-02-01 20:00 [PATCH net] net: sched: replaced invalid qdisc tree flush helper in qdisc_replace Alexander Ovechkin
2021-02-02  2:41 ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2021-01-26 21:56 Alexander Ovechkin
2021-01-28 21:32 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM_iQpXm6FpaS2YiFE3br6Ktx0fR2xqxyAuJC_LzBcYYiwa9+w@mail.gmail.com \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dmtrmonakhov@yandex-team.ru \
    --cc=jhs@mojatatu.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ovov@yandex-team.ru \
    --cc=pabeni@redhat.com \
    --cc=zeil@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.