From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbbBQN5W (ORCPT ); Tue, 17 Feb 2015 08:57:22 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:57656 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932322AbbBQN5T (ORCPT ); Tue, 17 Feb 2015 08:57:19 -0500 MIME-Version: 1.0 In-Reply-To: <54E30CD6.6020905@ti.com> References: <1424101741-24152-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-4-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-5-git-send-email-rabel@cit-ec.uni-bielefeld.de> <54E30CD6.6020905@ti.com> Date: Tue, 17 Feb 2015 14:57:18 +0100 X-Google-Sender-Auth: XOmErCgNu75oA3Qhv5_Hi9v1q9g Message-ID: Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children From: Robert Abel To: Roger Quadros Cc: khilman@deeprootsystems.com, Tony Lindgren , linux@arm.linux.org.uk, linux-omap@vger.kernel.org, Linux Kernel Maling List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Roger, On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros wrote:> > Can we simply use only > of_platform_populate(child, NULL, NULL, &pdev->dev) > > That way we get rid of the if..else and let OF core take care of > creating buses or devices. Surely, you mean >of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev); ? If matches is NULL, we won't match any busses. Or did you mean to just replace the second conditional? I'll try that and see it works. Regards, Robert