From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DCDC54EE9 for ; Sat, 17 Sep 2022 01:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229831AbiIQBkZ (ORCPT ); Fri, 16 Sep 2022 21:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbiIQBkW (ORCPT ); Fri, 16 Sep 2022 21:40:22 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D10659C226; Fri, 16 Sep 2022 18:40:19 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id d2so3060380wrq.2; Fri, 16 Sep 2022 18:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=lIPZjSDpaEpyLGb30qkJZZTnrdz4VXMJzfCY4sA8XK7Lk3pWzWBBV0HneizM0Y27YU zzk9S3FLFJnnX43iFrRFtv41QZS2O+rOcQXm4KVPiVvILCE/gE1gGP+Ac2ew8AR18xyY Y9bn/cLS3oKmIQY/0z7+MBPLy5uuQ3j7h2aLvFkj/yqUNc0ez8JhhI0zKPuXVDc/i+GD OcgDae24sXTk07m2cPbBiqg/zFAYu5yZ0wmpv6s7Hjszq6XIksAV7+7Ps+YCJVKDzf+D wVvWXeaX8EWiAl0jaKTxnKzxt/v7fsekXh8/MvJYMEoSmsAt2fJPWjmNuuYNbTeUHClO SvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=mtvZ3WbLFtc/TFW9iAXsH3r233J+vYWodLj7YgqDV5tucO0pUWcf6sxxnezi71T41X 1Opwfjnum2AbpU5yShb2ZlVqEZJHzD86pv6vUWmhl10VYq0ejLeNUF9DWB2pBNw2HSlr 1GdKh8bqKGoDbOSJkc54cR3mNY5TSYIfZy6lZmDAO2RaGxnJhhIPjZZvPJUyN1m6QooI vQfGo5IWa4L+Ph20O593hXV1O2ksyCCa1WWqnzxYm+a+7Bvk6IWVIrIJN8TpxIi5mr5L hBtrETMEe0h/kuWhIcoKxUCPKQSZ9bgg/8DxcNX8PgoJ2WMQ8mDymx7r380WDPGQYRUQ pbaw== X-Gm-Message-State: ACrzQf0WEkp751whJ0C6dDPWSuFyn5Ru4AWCz0ff3hFXD8lFgkpYRCgK p8ZpSukeZbGg91CLW50YibwQaIjtORsXUC9tK6M= X-Google-Smtp-Source: AMsMyM4v0vEb/RzDwFzi8XMH1K+KBvYVKNWnXZo51ZhOesp+cgw/Z7rqE2eD3iHn7w+A53KKYl9PRUoK4tGE2QHMBOs= X-Received: by 2002:a5d:598a:0:b0:22a:45af:1ce2 with SMTP id n10-20020a5d598a000000b0022a45af1ce2mr4387382wri.539.1663378818197; Fri, 16 Sep 2022 18:40:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Geis Date: Fri, 16 Sep 2022 21:40:07 -0400 Message-ID: Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: k3566-quartz64-a: adds sata variant To: Alessandro Carminati Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 12:06 PM Alessandro Carminati wrote: > > The Quartz64 board is built upon Rockchip RK3566. > Rockchip RK3566 has two combo phys. > The first connects USB3 and SATA ctrl1, and the second PCIe lane and SATA > ctrl2. > The second combo phy is hardwired to the PCIe slot, where for the first, > the hardware on the board provides both the USB3 connector and the SATA > connector. > This DT allows the users to switch the combo phy to the SATA connector. Good Evening, NACK to this whole series. Neither works correctly in the hardware as is, and USB3 was decided to be left enabled as the SATA port will be removed completely in the next revision. Very Respectfully, Peter Geis > > Signed-off-by: Alessandro Carminati > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts | 9 +++++++++ > 2 files changed, 10 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 8c843f6fc3cc..1d5dd91d1a34 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -60,6 +60,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-usb3.dts > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-sata.dts > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-roc-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > new file mode 100644 > index 000000000000..8620df7ec01e > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > @@ -0,0 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > + > +#include "rk3566-quartz64-a.dtsi" > + > +&sata1 { > + status = "okay"; > +}; > -- > 2.34.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B18D4ECAAA1 for ; Sat, 17 Sep 2022 01:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4gaNl52kag5iSkWK35asa5WHCFePRG7/tApu7JQnYLw=; b=hcoEIag/HdPpiL FoIAOdPJt8UBsmdd5jnQlOdSLj0OjDj17nI8l40jPeXappKREp7q4xDqcBXPjKq1pfB9ZSR+0F6Cb Wy4rsz4c+t3UBv3lkKpOZHKLwXabfSrFHvjhm4sMBxoCW+68V4VjsNtXv39GpfEZZ/McutCpA66GT 9yF5HZ25up79RBy59RsZ3sBQ4v7Y8OrWvS9oZ1G+vntB1Mvlzl9Vtm3c/FX9NyJugridoM7WojFWk iO4BMYJxsfgtzTfo+v54hkxfjnNYSvijKUqtek5OS5O/a0KAFRwBiRQI3f3xlmVSTca2TuY0GU465 WN2CVvsQo5eWfF0jnipQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZMp4-001TRD-7a; Sat, 17 Sep 2022 01:40:46 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZMom-001TFQ-Pp; Sat, 17 Sep 2022 01:40:30 +0000 Received: by mail-wr1-x431.google.com with SMTP id g3so17714013wrq.13; Fri, 16 Sep 2022 18:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=lIPZjSDpaEpyLGb30qkJZZTnrdz4VXMJzfCY4sA8XK7Lk3pWzWBBV0HneizM0Y27YU zzk9S3FLFJnnX43iFrRFtv41QZS2O+rOcQXm4KVPiVvILCE/gE1gGP+Ac2ew8AR18xyY Y9bn/cLS3oKmIQY/0z7+MBPLy5uuQ3j7h2aLvFkj/yqUNc0ez8JhhI0zKPuXVDc/i+GD OcgDae24sXTk07m2cPbBiqg/zFAYu5yZ0wmpv6s7Hjszq6XIksAV7+7Ps+YCJVKDzf+D wVvWXeaX8EWiAl0jaKTxnKzxt/v7fsekXh8/MvJYMEoSmsAt2fJPWjmNuuYNbTeUHClO SvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=57DIAdna8+/r6kzaUEidqUrv2bcJLe0NCsadJjQtROZSq3NiiYzjONG7cs56qKnkOM qNwP6dIxgFKGjXIHUHMFBvApmzpzg1UGBLZb/IEMmlwT1qWrJ4CVAS6/ckmH0ZeJHNzN KQr5aekx3FrqeMgf5ua7kgSWk0g9IUd4OMNlCZI96ILFH0ySXfPCYsdRyeUR9EsWZT4k FrmVFJBSnJeVbif/Ffux6wmD+RdVuBbRuMyomAkM6x5dq0r7oDVe4atfIfen1xMYXIZy cWGGkDnY+9v3BYy9OI4T0znyooFpKHh77EPdZkiXdPjP4l+D2ffAH7BOzmcs8Vquc3cc RJ8w== X-Gm-Message-State: ACrzQf35q61UvzkZ/IQiv6/f75dinQ50RSqYRGrpBAH6mVn1cwjepKbm qcd/3sTgcfple3cKwZMdomq8o5qFx+PlvKlDyNkpypflb4s= X-Google-Smtp-Source: AMsMyM4v0vEb/RzDwFzi8XMH1K+KBvYVKNWnXZo51ZhOesp+cgw/Z7rqE2eD3iHn7w+A53KKYl9PRUoK4tGE2QHMBOs= X-Received: by 2002:a5d:598a:0:b0:22a:45af:1ce2 with SMTP id n10-20020a5d598a000000b0022a45af1ce2mr4387382wri.539.1663378818197; Fri, 16 Sep 2022 18:40:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Geis Date: Fri, 16 Sep 2022 21:40:07 -0400 Message-ID: Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: k3566-quartz64-a: adds sata variant To: Alessandro Carminati Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_184028_854742_EC5D1CD1 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Sep 16, 2022 at 12:06 PM Alessandro Carminati wrote: > > The Quartz64 board is built upon Rockchip RK3566. > Rockchip RK3566 has two combo phys. > The first connects USB3 and SATA ctrl1, and the second PCIe lane and SATA > ctrl2. > The second combo phy is hardwired to the PCIe slot, where for the first, > the hardware on the board provides both the USB3 connector and the SATA > connector. > This DT allows the users to switch the combo phy to the SATA connector. Good Evening, NACK to this whole series. Neither works correctly in the hardware as is, and USB3 was decided to be left enabled as the SATA port will be removed completely in the next revision. Very Respectfully, Peter Geis > > Signed-off-by: Alessandro Carminati > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts | 9 +++++++++ > 2 files changed, 10 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 8c843f6fc3cc..1d5dd91d1a34 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -60,6 +60,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-usb3.dts > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-sata.dts > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-roc-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > new file mode 100644 > index 000000000000..8620df7ec01e > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > @@ -0,0 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > + > +#include "rk3566-quartz64-a.dtsi" > + > +&sata1 { > + status = "okay"; > +}; > -- > 2.34.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F10EECAAD8 for ; Sat, 17 Sep 2022 01:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sYvKrKrScq+DeHXnoxEVRxtyW7oM1tlTds7Q0Z5Urog=; b=lTFocZe4b3/3FX 4bfapwo/GHi8b2Z9LQ5zYaU0/t/b0Uo/RkKLtUDoHJgd6Akkl8QNuGL78BtvD3U0SO3qx+WdrbLx+ jokM624yjEniyhUcrzR+Qmtn0fmAMPX0YDRo43fuVlMMQMeYDaHoPPHJrkxtUNgnqqvT9QIW2UTRY hnLNgQsMh/OS0S3Qmdkmj0wMN4mLaNpuFVLg56VsSXNmn75kA9m5ZlKRZOqvIKfoENlhybMpBXmov xdR/cK8VQLl8SWZNMO/trOq4RXl/Y5Fl6HD5FgllDU6rxGCMiKiagqxQvq3aCKwXA+iotsyeuXJe6 v+Bg4N5doBvz98LsmcMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZMor-001TLu-QA; Sat, 17 Sep 2022 01:40:34 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oZMom-001TFQ-Pp; Sat, 17 Sep 2022 01:40:30 +0000 Received: by mail-wr1-x431.google.com with SMTP id g3so17714013wrq.13; Fri, 16 Sep 2022 18:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=lIPZjSDpaEpyLGb30qkJZZTnrdz4VXMJzfCY4sA8XK7Lk3pWzWBBV0HneizM0Y27YU zzk9S3FLFJnnX43iFrRFtv41QZS2O+rOcQXm4KVPiVvILCE/gE1gGP+Ac2ew8AR18xyY Y9bn/cLS3oKmIQY/0z7+MBPLy5uuQ3j7h2aLvFkj/yqUNc0ez8JhhI0zKPuXVDc/i+GD OcgDae24sXTk07m2cPbBiqg/zFAYu5yZ0wmpv6s7Hjszq6XIksAV7+7Ps+YCJVKDzf+D wVvWXeaX8EWiAl0jaKTxnKzxt/v7fsekXh8/MvJYMEoSmsAt2fJPWjmNuuYNbTeUHClO SvPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=n9n8tkr4zFtS3Gqksx14AwLvb33nBr6DZn7TLl3O0b8=; b=57DIAdna8+/r6kzaUEidqUrv2bcJLe0NCsadJjQtROZSq3NiiYzjONG7cs56qKnkOM qNwP6dIxgFKGjXIHUHMFBvApmzpzg1UGBLZb/IEMmlwT1qWrJ4CVAS6/ckmH0ZeJHNzN KQr5aekx3FrqeMgf5ua7kgSWk0g9IUd4OMNlCZI96ILFH0ySXfPCYsdRyeUR9EsWZT4k FrmVFJBSnJeVbif/Ffux6wmD+RdVuBbRuMyomAkM6x5dq0r7oDVe4atfIfen1xMYXIZy cWGGkDnY+9v3BYy9OI4T0znyooFpKHh77EPdZkiXdPjP4l+D2ffAH7BOzmcs8Vquc3cc RJ8w== X-Gm-Message-State: ACrzQf35q61UvzkZ/IQiv6/f75dinQ50RSqYRGrpBAH6mVn1cwjepKbm qcd/3sTgcfple3cKwZMdomq8o5qFx+PlvKlDyNkpypflb4s= X-Google-Smtp-Source: AMsMyM4v0vEb/RzDwFzi8XMH1K+KBvYVKNWnXZo51ZhOesp+cgw/Z7rqE2eD3iHn7w+A53KKYl9PRUoK4tGE2QHMBOs= X-Received: by 2002:a5d:598a:0:b0:22a:45af:1ce2 with SMTP id n10-20020a5d598a000000b0022a45af1ce2mr4387382wri.539.1663378818197; Fri, 16 Sep 2022 18:40:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Peter Geis Date: Fri, 16 Sep 2022 21:40:07 -0400 Message-ID: Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: k3566-quartz64-a: adds sata variant To: Alessandro Carminati Cc: Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220916_184028_854742_EC5D1CD1 X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 16, 2022 at 12:06 PM Alessandro Carminati wrote: > > The Quartz64 board is built upon Rockchip RK3566. > Rockchip RK3566 has two combo phys. > The first connects USB3 and SATA ctrl1, and the second PCIe lane and SATA > ctrl2. > The second combo phy is hardwired to the PCIe slot, where for the first, > the hardware on the board provides both the USB3 connector and the SATA > connector. > This DT allows the users to switch the combo phy to the SATA connector. Good Evening, NACK to this whole series. Neither works correctly in the hardware as is, and USB3 was decided to be left enabled as the SATA port will be removed completely in the next revision. Very Respectfully, Peter Geis > > Signed-off-by: Alessandro Carminati > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts | 9 +++++++++ > 2 files changed, 10 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 8c843f6fc3cc..1d5dd91d1a34 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -60,6 +60,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-usb3.dts > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a-sata.dts > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-b.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-roc-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > new file mode 100644 > index 000000000000..8620df7ec01e > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a-sata.dts > @@ -0,0 +1,9 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > + > +#include "rk3566-quartz64-a.dtsi" > + > +&sata1 { > + status = "okay"; > +}; > -- > 2.34.1 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel