From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6988AC433EF for ; Fri, 24 Jun 2022 12:40:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B09DC10E33B; Fri, 24 Jun 2022 12:40:28 +0000 (UTC) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3170B10E33B for ; Fri, 24 Jun 2022 12:40:28 +0000 (UTC) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-2ef5380669cso23323247b3.9 for ; Fri, 24 Jun 2022 05:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=iwU4WAwYuY4nkLCJy0axAqGQoG42lj5PEowL1fzfUW1VZzpw1/JWJhdAXHS8VcTujk J5fH6JbEPmaRAOT0dBNudO6Csia2IYm+8+BZorymw71HaEIQaO0gekGz1aLnsYhJ6n8y cN0jvvlrqeMKRgih7BUcHlBuqsyukSc0/9f2iL29VpMnV0PvNQjD5GQWDbV3gym+XKct E271VdMxoeJdxXZvuKsc752Lz08Vnar6at93uoANsDPZ//DTcMmgTajkXuwNtwi0F7sY E/5FEF70ekzn+BR24HBj+Qci3izVWS4DQndVou0RRKj+BpMB8XpaucqCnwQOZP36EdMe mGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=QeNHBAri1RCTTuRQPvi0WMAk4mTfoJ1U6Kb2AHSOD63AOvnvri3Gr9V7ritfSSmPQk hcplvPbnU9diHgRZQx5/0rJX1AkRJYBesIJQU5FZgwtKZaRg8p9eIFpk6/E792EivOYT Q7r11YBZPbA2jMmjZyQKqzzGJsQmKvd3kqrQEQbOHujx8yQ77WhGAHxaLEBbGkSiB5tT /V33QYsPQzgPieIK6qJsaB/i/LxhIkT1nMtWacNUYoZS4D/7KCW3VwuGKg6LoGKDjwCX YLKOfGZWcUQdkCXAd0pKDACr7JFulQhGnpyCKUP5cW9terEjD/fy0OWEDXenKOacqirW +JEA== X-Gm-Message-State: AJIora+F0W1LqGZbgABATn42IRf3qOxCv0BsiNyOX2io5JqVborsIDk1 ePaat9EYpfhP4vv+0enpV4AcHreA8yNxGYQTS3A= X-Google-Smtp-Source: AGRyM1uhuP3HFOm268+6mHrbu8xCTmrxJLbj7jAnsvz7AhIXGUaUE3iuu/MCaQ9V+nE2SgjhttjDEqCcfT2jOeVl9kA= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr16908125ywd.378.1656074427236; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-21-s.hauer@pengutronix.de> <0E6FE020-C95E-47CF-A9D6-AC3F2B2D334F@gmail.com> <9F2D8CFF-1EAE-4586-9EE9-82A9D67840BB@gmail.com> <9567EECF-A154-4FE1-A03C-5ED080409030@gmail.com> <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> In-Reply-To: <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> From: Peter Geis Date: Fri, 24 Jun 2022 08:40:15 -0400 Message-ID: Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a To: Piotr Oniszczuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , Sascha Hauer , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, Andy Yan , "linux-arm-kernel@lists.infradead.org" , kernel test robot Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 24, 2022 at 4:30 AM Piotr Oniszczuk wrote: > > > > > Wiadomo=C5=9B=C4=87 napisana przez Piotr Oniszczuk w dniu 14.05.2022, o godz. 15:58: > > > > > > > >> Wiadomo=C5=9B=C4=87 napisana przez Peter Geis w = dniu 09.05.2022, o godz. 18:00: > >> > >> If you want to confirm the hardware is configured correctly you can > >> remove the cec pin from the hdmi node and set up a cec-gpio node. > >> https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/device= tree/bindings/media/cec-gpio.txt > > > > Peter, Sascha > > > > I configured cec-gpio and can confirm: with gpio cec works on my rock3-= a board v1.31. > > > > So summarising my tests: > > > > rock3-a v1.1 rock3-a v1.31 r= ock3-b > > > > radxa debian: ok ok = ok > > > > other ppl mainline 5.18: ok n/t = n/t > > > > me with mainline 5.18: n/t nok = ok > > > > me with mainline 5.18 gpio-cec: n/t ok n/t > > > > Non-working combination is: rock3-a v1.31 hw on mainline 5.18. > > For me it looks like there is bug in case when rk3568 using cec on hdmi= txm1_cec line. > > (The same binaries working ok on my rock3-b where cec is on hdmitxm0_ce= c line. It also works on Peter's rock3a v1.1 - which also uses hdmitxm0_cec= line). > > > > It looks like upper cec driver can talk to lower driver (dw-hdmi?) but = nothing is received from lower driver, as my app says: > > CECAdapter: CEC device can't poll TV: TV does not respond to CEC polls > > > > btw: I verified with oscilloscope connected to hdmitxm1_cec line: start= ing cec-compliance -v -T shows expected series of 0V pulses on hdmitxm1_cec= line.... > > > > > > Sascha, Peter > > I returned to trying to find why hdmi-cec is not working on rock3-a v1.31= hw. > > I'm on vop2 v11 on 5.18 mainline. > > Current findings: > > (1) the same sw. stack/binaries works on rock-3b (where cec uses hdmitx_m= 0 instead of hdmitx_m1 I/O line); > > (2) gpio-cec however works no problem on rock3-a; > > (3) monitoring cec messages with v4-utils 'cec-follower -s' shows exact t= he same events in non-working rock3-a and working rock3-b > (tested by issue configure cec by 'cec-ctl -d /dev/cec0 --phys-addr=3D1.0= .0.0 --playback' command) --phys-addr isn't a valid command for this controller. The device designation is only required if you have more than one cec device. > > --> i'm interpreting this as confirmation that low level phy layer receiv= es ok cec data from connected device on non-working rock3-a; > > (4) debug sysfs for cec shows "has CEC follower (in passthrough mode)" fo= r working rock-3b and there is NO "has CEC follower" debug message in faili= ng rock3-a. This makes me suspect you are in fact not using the same software stack, or are not running the same commands. Running `cec-follower -v -m -T` on a rk3566 device with working cec using 5.19-rc1, I see no mention of cec-follower in the debugfs cec0 status entry. > > For me It looks like low-level hdmi-cec works ok on failing rock3-a - but= upper layers (in hdmi vop2?) are not registering (or failing to register) = cec-follower filehandle. This happens just when hdmitx I/O in DT is changed= from hdmitx_m0 to hdmutx_m1. A bit strange - but all my tests consistently= confirming this observation.... There is nothing wrong with vop2 as it is not involved at all in this. The rockchip hdmi driver (which is not specific to vop2) does nothing more than call the cec registration method in the dw hdmi bridge driver, which then calls the kernel cec registration functions. Changing pinmux changes nothing in how this functions. > > I'm too weak in kernel cec internals - so maybe you have any pointers how= to further debug/investigate this issue? As we discussed in the pine64 room, this is still very likely a hardware issue with this board. A configuration issue with your u-boot or tf-a is also a possibility, but is less likely. You showed with your logic analyzer with nothing plugged in and cec not muxed to m1, data was present on m1. I requested you investigate the following, to which you haven't replied: Have you tried forcing m0 to be assigned to a device other than hdmi-cec? Have you checked if m1 is shorted to another pin? In regards to your data frames for 4.19 vs 5.18, image-view-on is not a valid command if the topology doesn't detect a device on the bus. I recommend running the same test, except run `cec-ctl -S --playback` and post the results for both. > > > > BTW: i'm not alone with cec issue on rock3a v1.31 - already 2 other users= contacted me with the same issue... > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBE5C43334 for ; Fri, 24 Jun 2022 12:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230513AbiFXMk3 (ORCPT ); Fri, 24 Jun 2022 08:40:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiFXMk3 (ORCPT ); Fri, 24 Jun 2022 08:40:29 -0400 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E3104ECCD for ; Fri, 24 Jun 2022 05:40:28 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-3137316bb69so23232287b3.10 for ; Fri, 24 Jun 2022 05:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=iwU4WAwYuY4nkLCJy0axAqGQoG42lj5PEowL1fzfUW1VZzpw1/JWJhdAXHS8VcTujk J5fH6JbEPmaRAOT0dBNudO6Csia2IYm+8+BZorymw71HaEIQaO0gekGz1aLnsYhJ6n8y cN0jvvlrqeMKRgih7BUcHlBuqsyukSc0/9f2iL29VpMnV0PvNQjD5GQWDbV3gym+XKct E271VdMxoeJdxXZvuKsc752Lz08Vnar6at93uoANsDPZ//DTcMmgTajkXuwNtwi0F7sY E/5FEF70ekzn+BR24HBj+Qci3izVWS4DQndVou0RRKj+BpMB8XpaucqCnwQOZP36EdMe mGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=lQx0B/HH0C6CWX9+Gtx9AumgJBmxNEjRxn7VgNSqXi+ILDDZK+wVqVQrL08RcT+oJM iVbT4wIidrMxGeSsqeyQff5zlNK41q8PBzu1WThepw1Hajk1iqvxfrfsupijqJHZBSjj nZTA/9TmTrOoqUPFDhEB6ngQs3yOojNEZ/7NLwRka4n+lv1i878i4A6sojpFVja3dr5t Wkymq1VpYH7CrHaKboaG2bCrmQc4cdfrOSbghQ2UgRAou3Omvs2Qw9E+DsQCwU1n/HY+ zQXLfoq4TUQKzYhs+7PV26xc+GL9We44It82pl037p6OpyAM0PPWh6Fb3kyX+4yxCLd6 rYVQ== X-Gm-Message-State: AJIora9UY6Nv15rH3+U3sZomCLNwatS4SWX0aa2ETLQM/DOtGZpVAR/g hegcvlzB0FpTuvsxpSlzDkeH0aCr2r7NCrW3jrw= X-Google-Smtp-Source: AGRyM1uhuP3HFOm268+6mHrbu8xCTmrxJLbj7jAnsvz7AhIXGUaUE3iuu/MCaQ9V+nE2SgjhttjDEqCcfT2jOeVl9kA= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr16908125ywd.378.1656074427236; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-21-s.hauer@pengutronix.de> <0E6FE020-C95E-47CF-A9D6-AC3F2B2D334F@gmail.com> <9F2D8CFF-1EAE-4586-9EE9-82A9D67840BB@gmail.com> <9567EECF-A154-4FE1-A03C-5ED080409030@gmail.com> <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> In-Reply-To: <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> From: Peter Geis Date: Fri, 24 Jun 2022 08:40:15 -0400 Message-ID: Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a To: Piotr Oniszczuk Cc: Sascha Hauer , Michael Riesch , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 24, 2022 at 4:30 AM Piotr Oniszczuk wrote: > > > > > Wiadomo=C5=9B=C4=87 napisana przez Piotr Oniszczuk w dniu 14.05.2022, o godz. 15:58: > > > > > > > >> Wiadomo=C5=9B=C4=87 napisana przez Peter Geis w = dniu 09.05.2022, o godz. 18:00: > >> > >> If you want to confirm the hardware is configured correctly you can > >> remove the cec pin from the hdmi node and set up a cec-gpio node. > >> https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/device= tree/bindings/media/cec-gpio.txt > > > > Peter, Sascha > > > > I configured cec-gpio and can confirm: with gpio cec works on my rock3-= a board v1.31. > > > > So summarising my tests: > > > > rock3-a v1.1 rock3-a v1.31 r= ock3-b > > > > radxa debian: ok ok = ok > > > > other ppl mainline 5.18: ok n/t = n/t > > > > me with mainline 5.18: n/t nok = ok > > > > me with mainline 5.18 gpio-cec: n/t ok n/t > > > > Non-working combination is: rock3-a v1.31 hw on mainline 5.18. > > For me it looks like there is bug in case when rk3568 using cec on hdmi= txm1_cec line. > > (The same binaries working ok on my rock3-b where cec is on hdmitxm0_ce= c line. It also works on Peter's rock3a v1.1 - which also uses hdmitxm0_cec= line). > > > > It looks like upper cec driver can talk to lower driver (dw-hdmi?) but = nothing is received from lower driver, as my app says: > > CECAdapter: CEC device can't poll TV: TV does not respond to CEC polls > > > > btw: I verified with oscilloscope connected to hdmitxm1_cec line: start= ing cec-compliance -v -T shows expected series of 0V pulses on hdmitxm1_cec= line.... > > > > > > Sascha, Peter > > I returned to trying to find why hdmi-cec is not working on rock3-a v1.31= hw. > > I'm on vop2 v11 on 5.18 mainline. > > Current findings: > > (1) the same sw. stack/binaries works on rock-3b (where cec uses hdmitx_m= 0 instead of hdmitx_m1 I/O line); > > (2) gpio-cec however works no problem on rock3-a; > > (3) monitoring cec messages with v4-utils 'cec-follower -s' shows exact t= he same events in non-working rock3-a and working rock3-b > (tested by issue configure cec by 'cec-ctl -d /dev/cec0 --phys-addr=3D1.0= .0.0 --playback' command) --phys-addr isn't a valid command for this controller. The device designation is only required if you have more than one cec device. > > --> i'm interpreting this as confirmation that low level phy layer receiv= es ok cec data from connected device on non-working rock3-a; > > (4) debug sysfs for cec shows "has CEC follower (in passthrough mode)" fo= r working rock-3b and there is NO "has CEC follower" debug message in faili= ng rock3-a. This makes me suspect you are in fact not using the same software stack, or are not running the same commands. Running `cec-follower -v -m -T` on a rk3566 device with working cec using 5.19-rc1, I see no mention of cec-follower in the debugfs cec0 status entry. > > For me It looks like low-level hdmi-cec works ok on failing rock3-a - but= upper layers (in hdmi vop2?) are not registering (or failing to register) = cec-follower filehandle. This happens just when hdmitx I/O in DT is changed= from hdmitx_m0 to hdmutx_m1. A bit strange - but all my tests consistently= confirming this observation.... There is nothing wrong with vop2 as it is not involved at all in this. The rockchip hdmi driver (which is not specific to vop2) does nothing more than call the cec registration method in the dw hdmi bridge driver, which then calls the kernel cec registration functions. Changing pinmux changes nothing in how this functions. > > I'm too weak in kernel cec internals - so maybe you have any pointers how= to further debug/investigate this issue? As we discussed in the pine64 room, this is still very likely a hardware issue with this board. A configuration issue with your u-boot or tf-a is also a possibility, but is less likely. You showed with your logic analyzer with nothing plugged in and cec not muxed to m1, data was present on m1. I requested you investigate the following, to which you haven't replied: Have you tried forcing m0 to be assigned to a device other than hdmi-cec? Have you checked if m1 is shorted to another pin? In regards to your data frames for 4.19 vs 5.18, image-view-on is not a valid command if the topology doesn't detect a device on the bus. I recommend running the same test, except run `cec-ctl -S --playback` and post the results for both. > > > > BTW: i'm not alone with cec issue on rock3a v1.31 - already 2 other users= contacted me with the same issue... > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BE90C433EF for ; Fri, 24 Jun 2022 12:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EAEHA0JdSt53CGWNnlA9USWvLZ1AQ/veI/qR04MOx4s=; b=JUSZCRKFBgMIxg jJmRZ8ysau05HcR+0OkBm6BEraL7dd1+dkGOWbBLVtsXegyILNKzFUWBE6W0E8tpxE+UDAFqZlFva xCzUhykekgaAHKbst40MpcwjzOdlDRkIfFQKZ6UbnUagAJDZPhmlCw/OrNs3XdFhnWzCJcpCxfvuJ FJJCY3sLkTom+WlCn3K5YjfvJqBX+HGKrDf9Tt+bWMmTju/zZOWyjqcQ36S85FbvDEZgSPoneRBwT AGOlI0XmK8lbEgrO6APIMPXzet92BvwYSEJeRhl+G74lO1tByRigFghmuIusEBDg2NK8xOYV3gNB/ H5xBRsRa7aTWr/2NPx1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4ic6-002Djz-Dz; Fri, 24 Jun 2022 12:40:42 +0000 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4ibu-002DgX-So; Fri, 24 Jun 2022 12:40:32 +0000 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-318889e6a2cso23309507b3.1; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=iwU4WAwYuY4nkLCJy0axAqGQoG42lj5PEowL1fzfUW1VZzpw1/JWJhdAXHS8VcTujk J5fH6JbEPmaRAOT0dBNudO6Csia2IYm+8+BZorymw71HaEIQaO0gekGz1aLnsYhJ6n8y cN0jvvlrqeMKRgih7BUcHlBuqsyukSc0/9f2iL29VpMnV0PvNQjD5GQWDbV3gym+XKct E271VdMxoeJdxXZvuKsc752Lz08Vnar6at93uoANsDPZ//DTcMmgTajkXuwNtwi0F7sY E/5FEF70ekzn+BR24HBj+Qci3izVWS4DQndVou0RRKj+BpMB8XpaucqCnwQOZP36EdMe mGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=VmwxgEoeGZecUfsc6ttAuApQNPIm7LpNprZBqUlOChXAbxA8fWU8/+TZ2g0BefWKFp 9p9sWyHvBiSZ9srEAaKl7ZbU8Zm4T5SRDRfuzwu6FZPFJNuC6yMU78ouA7YilEsRcKkG TOPteYTRGAYm/PSLRww3xM0Yf9nOFuyfBEOrSHeh7wWmVXa278v8g4UBoanJ7Aw02i7V E5vqxKERbp02eJFOot9AOkzcoO08dg37VpCwBwIhnSvo6oUjbH1Bsy2fR/jX4hm9F6NB ExdtPvlI1DcUHBpIxhD4hL7+JxkZwCF+jKKZdeB155RTOu3pqKVcjbJiLiLQ0MzNx3QX UfJQ== X-Gm-Message-State: AJIora8kKXb1e0X10bIkObVTSCEnWPmKJrBMfN1Ava7tLnLQIMJFMS9S jPgUWHzibXAxyOisM32+kjgiJOILFR3RSWDiHCk= X-Google-Smtp-Source: AGRyM1uhuP3HFOm268+6mHrbu8xCTmrxJLbj7jAnsvz7AhIXGUaUE3iuu/MCaQ9V+nE2SgjhttjDEqCcfT2jOeVl9kA= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr16908125ywd.378.1656074427236; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-21-s.hauer@pengutronix.de> <0E6FE020-C95E-47CF-A9D6-AC3F2B2D334F@gmail.com> <9F2D8CFF-1EAE-4586-9EE9-82A9D67840BB@gmail.com> <9567EECF-A154-4FE1-A03C-5ED080409030@gmail.com> <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> In-Reply-To: <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> From: Peter Geis Date: Fri, 24 Jun 2022 08:40:15 -0400 Message-ID: Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a To: Piotr Oniszczuk Cc: Sascha Hauer , Michael Riesch , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , kernel test robot X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_054030_977893_0A21B948 X-CRM114-Status: GOOD ( 30.19 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMjQsIDIwMjIgYXQgNDozMCBBTSBQaW90ciBPbmlzemN6dWsKPHBpb3RyLm9u aXN6Y3p1a0BnbWFpbC5jb20+IHdyb3RlOgo+Cj4KPgo+ID4gV2lhZG9tb8WbxIcgbmFwaXNhbmEg cHJ6ZXogUGlvdHIgT25pc3pjenVrIDxwaW90ci5vbmlzemN6dWtAZ21haWwuY29tPiB3IGRuaXUg MTQuMDUuMjAyMiwgbyBnb2R6LiAxNTo1ODoKPiA+Cj4gPgo+ID4KPiA+PiBXaWFkb21vxZvEhyBu YXBpc2FuYSBwcnpleiBQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29tPiB3IGRuaXUgMDku MDUuMjAyMiwgbyBnb2R6LiAxODowMDoKPiA+Pgo+ID4+IElmIHlvdSB3YW50IHRvIGNvbmZpcm0g dGhlIGhhcmR3YXJlIGlzIGNvbmZpZ3VyZWQgY29ycmVjdGx5IHlvdSBjYW4KPiA+PiByZW1vdmUg dGhlIGNlYyBwaW4gZnJvbSB0aGUgaGRtaSBub2RlIGFuZCBzZXQgdXAgYSBjZWMtZ3BpbyBub2Rl Lgo+ID4+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L3Y1LjE4LXJjNS9zb3VyY2Uv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lZGlhL2NlYy1ncGlvLnR4dAo+ID4K PiA+IFBldGVyLCBTYXNjaGEKPiA+Cj4gPiBJIGNvbmZpZ3VyZWQgY2VjLWdwaW8gYW5kIGNhbiBj b25maXJtOiB3aXRoIGdwaW8gY2VjIHdvcmtzIG9uIG15IHJvY2szLWEgYm9hcmQgdjEuMzEuCj4g Pgo+ID4gU28gc3VtbWFyaXNpbmcgbXkgdGVzdHM6Cj4gPgo+ID4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcm9jazMtYSB2MS4xICAgcm9jazMtYSB2MS4zMSAgIHJvY2sz LWIKPiA+Cj4gPiByYWR4YSBkZWJpYW46ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9r ICAgICAgICAgICAgIG9rICAgICAgICAgICAgICAgIG9rCj4gPgo+ID4gb3RoZXIgcHBsIG1haW5s aW5lIDUuMTg6ICAgICAgICAgICAgICAgb2sgICAgICAgICAgICAgbi90ICAgICAgICAgICAgICAg IG4vdAo+ID4KPiA+IG1lIHdpdGggbWFpbmxpbmUgNS4xODogICAgICAgICAgICAgICAgIG4vdCAg ICAgICAgICAgIG5vayAgICAgICAgICAgICAgb2sKPiA+Cj4gPiBtZSB3aXRoIG1haW5saW5lIDUu MTggZ3Bpby1jZWM6ICBuL3QgICAgICAgICAgICAgb2sgICAgICAgICAgICAgICAgbi90Cj4gPgo+ ID4gTm9uLXdvcmtpbmcgY29tYmluYXRpb24gaXM6IHJvY2szLWEgdjEuMzEgaHcgb24gbWFpbmxp bmUgNS4xOC4KPiA+IEZvciBtZSBpdCBsb29rcyBsaWtlIHRoZXJlIGlzIGJ1ZyBpbiBjYXNlIHdo ZW4gcmszNTY4IHVzaW5nIGNlYyBvbiBoZG1pdHhtMV9jZWMgbGluZS4KPiA+IChUaGUgc2FtZSBi aW5hcmllcyB3b3JraW5nIG9rIG9uIG15IHJvY2szLWIgd2hlcmUgY2VjIGlzIG9uIGhkbWl0eG0w X2NlYyBsaW5lLiBJdCBhbHNvIHdvcmtzIG9uIFBldGVyJ3Mgcm9jazNhIHYxLjEgLSB3aGljaCBh bHNvIHVzZXMgaGRtaXR4bTBfY2VjIGxpbmUpLgo+ID4KPiA+IEl0IGxvb2tzIGxpa2UgdXBwZXIg Y2VjIGRyaXZlciBjYW4gdGFsayB0byBsb3dlciBkcml2ZXIgKGR3LWhkbWk/KSBidXQgbm90aGlu ZyBpcyByZWNlaXZlZCBmcm9tIGxvd2VyIGRyaXZlciwgYXMgbXkgYXBwIHNheXM6Cj4gPiBDRUNB ZGFwdGVyOiBDRUMgZGV2aWNlIGNhbid0IHBvbGwgVFY6IFRWIGRvZXMgbm90IHJlc3BvbmQgdG8g Q0VDIHBvbGxzCj4gPgo+ID4gYnR3OiBJIHZlcmlmaWVkIHdpdGggb3NjaWxsb3Njb3BlIGNvbm5l Y3RlZCB0byBoZG1pdHhtMV9jZWMgbGluZTogc3RhcnRpbmcgY2VjLWNvbXBsaWFuY2UgLXYgLVQg c2hvd3MgZXhwZWN0ZWQgc2VyaWVzIG9mIDBWIHB1bHNlcyBvbiBoZG1pdHhtMV9jZWMgbGluZS4u Li4KPiA+Cj4gPgo+Cj4gU2FzY2hhLCBQZXRlcgo+Cj4gSSByZXR1cm5lZCB0byB0cnlpbmcgdG8g ZmluZCB3aHkgaGRtaS1jZWMgaXMgbm90IHdvcmtpbmcgb24gcm9jazMtYSB2MS4zMSBody4KPgo+ IEknbSBvbiB2b3AyIHYxMSBvbiA1LjE4IG1haW5saW5lLgo+Cj4gQ3VycmVudCBmaW5kaW5nczoK Pgo+ICgxKSB0aGUgc2FtZSBzdy4gc3RhY2svYmluYXJpZXMgd29ya3Mgb24gcm9jay0zYiAod2hl cmUgY2VjIHVzZXMgaGRtaXR4X20wIGluc3RlYWQgb2YgaGRtaXR4X20xIEkvTyBsaW5lKTsKPgo+ ICgyKSBncGlvLWNlYyBob3dldmVyIHdvcmtzIG5vIHByb2JsZW0gb24gcm9jazMtYTsKPgo+ICgz KSBtb25pdG9yaW5nIGNlYyBtZXNzYWdlcyB3aXRoIHY0LXV0aWxzICdjZWMtZm9sbG93ZXIgLXMn IHNob3dzIGV4YWN0IHRoZSBzYW1lIGV2ZW50cyBpbiBub24td29ya2luZyByb2NrMy1hIGFuZCB3 b3JraW5nIHJvY2szLWIKPiAodGVzdGVkIGJ5IGlzc3VlIGNvbmZpZ3VyZSBjZWMgYnkgJ2NlYy1j dGwgLWQgL2Rldi9jZWMwIC0tcGh5cy1hZGRyPTEuMC4wLjAgLS1wbGF5YmFjaycgY29tbWFuZCkK Ci0tcGh5cy1hZGRyIGlzbid0IGEgdmFsaWQgY29tbWFuZCBmb3IgdGhpcyBjb250cm9sbGVyLiBU aGUgZGV2aWNlCmRlc2lnbmF0aW9uIGlzIG9ubHkgcmVxdWlyZWQgaWYgeW91IGhhdmUgbW9yZSB0 aGFuIG9uZSBjZWMgZGV2aWNlLgoKPgo+IC0tPiBpJ20gaW50ZXJwcmV0aW5nIHRoaXMgYXMgY29u ZmlybWF0aW9uIHRoYXQgbG93IGxldmVsIHBoeSBsYXllciByZWNlaXZlcyBvayBjZWMgZGF0YSBm cm9tIGNvbm5lY3RlZCBkZXZpY2Ugb24gbm9uLXdvcmtpbmcgcm9jazMtYTsKPgo+ICg0KSBkZWJ1 ZyBzeXNmcyBmb3IgY2VjIHNob3dzICJoYXMgQ0VDIGZvbGxvd2VyIChpbiBwYXNzdGhyb3VnaCBt b2RlKSIgZm9yIHdvcmtpbmcgcm9jay0zYiBhbmQgdGhlcmUgaXMgTk8gImhhcyBDRUMgZm9sbG93 ZXIiIGRlYnVnIG1lc3NhZ2UgaW4gZmFpbGluZyByb2NrMy1hLgoKVGhpcyBtYWtlcyBtZSBzdXNw ZWN0IHlvdSBhcmUgaW4gZmFjdCBub3QgdXNpbmcgdGhlIHNhbWUgc29mdHdhcmUKc3RhY2ssIG9y IGFyZSBub3QgcnVubmluZyB0aGUgc2FtZSBjb21tYW5kcy4KUnVubmluZyBgY2VjLWZvbGxvd2Vy IC12IC1tIC1UYCBvbiBhIHJrMzU2NiBkZXZpY2Ugd2l0aCB3b3JraW5nIGNlYwp1c2luZyA1LjE5 LXJjMSwgSSBzZWUgbm8gbWVudGlvbiBvZiBjZWMtZm9sbG93ZXIgaW4gdGhlIGRlYnVnZnMgY2Vj MApzdGF0dXMgZW50cnkuCgo+Cj4gRm9yIG1lIEl0IGxvb2tzIGxpa2UgbG93LWxldmVsIGhkbWkt Y2VjIHdvcmtzIG9rIG9uIGZhaWxpbmcgcm9jazMtYSAtIGJ1dCB1cHBlciBsYXllcnMgKGluIGhk bWkgdm9wMj8pIGFyZSBub3QgcmVnaXN0ZXJpbmcgKG9yIGZhaWxpbmcgdG8gcmVnaXN0ZXIpIGNl Yy1mb2xsb3dlciBmaWxlaGFuZGxlLiBUaGlzIGhhcHBlbnMganVzdCB3aGVuIGhkbWl0eCBJL08g aW4gRFQgaXMgY2hhbmdlZCBmcm9tIGhkbWl0eF9tMCB0byBoZG11dHhfbTEuIEEgYml0IHN0cmFu Z2UgLSBidXQgYWxsIG15IHRlc3RzIGNvbnNpc3RlbnRseSBjb25maXJtaW5nIHRoaXMgb2JzZXJ2 YXRpb24uLi4uCgpUaGVyZSBpcyBub3RoaW5nIHdyb25nIHdpdGggdm9wMiBhcyBpdCBpcyBub3Qg aW52b2x2ZWQgYXQgYWxsIGluIHRoaXMuClRoZSByb2NrY2hpcCBoZG1pIGRyaXZlciAod2hpY2gg aXMgbm90IHNwZWNpZmljIHRvIHZvcDIpIGRvZXMgbm90aGluZwptb3JlIHRoYW4gY2FsbCB0aGUg Y2VjIHJlZ2lzdHJhdGlvbiBtZXRob2QgaW4gdGhlIGR3IGhkbWkgYnJpZGdlCmRyaXZlciwgd2hp Y2ggdGhlbiBjYWxscyB0aGUga2VybmVsIGNlYyByZWdpc3RyYXRpb24gZnVuY3Rpb25zLgpDaGFu Z2luZyBwaW5tdXggY2hhbmdlcyBub3RoaW5nIGluIGhvdyB0aGlzIGZ1bmN0aW9ucy4KCj4KPiBJ J20gdG9vIHdlYWsgaW4ga2VybmVsIGNlYyBpbnRlcm5hbHMgLSBzbyBtYXliZSB5b3UgaGF2ZSBh bnkgcG9pbnRlcnMgaG93IHRvIGZ1cnRoZXIgZGVidWcvaW52ZXN0aWdhdGUgdGhpcyBpc3N1ZT8K CkFzIHdlIGRpc2N1c3NlZCBpbiB0aGUgcGluZTY0IHJvb20sIHRoaXMgaXMgc3RpbGwgdmVyeSBs aWtlbHkgYQpoYXJkd2FyZSBpc3N1ZSB3aXRoIHRoaXMgYm9hcmQuIEEgY29uZmlndXJhdGlvbiBp c3N1ZSB3aXRoIHlvdXIgdS1ib290Cm9yIHRmLWEgaXMgYWxzbyBhIHBvc3NpYmlsaXR5LCBidXQg aXMgbGVzcyBsaWtlbHkuCgpZb3Ugc2hvd2VkIHdpdGggeW91ciBsb2dpYyBhbmFseXplciB3aXRo IG5vdGhpbmcgcGx1Z2dlZCBpbiBhbmQgY2VjCm5vdCBtdXhlZCB0byBtMSwgZGF0YSB3YXMgcHJl c2VudCBvbiBtMS4gSSByZXF1ZXN0ZWQgeW91IGludmVzdGlnYXRlCnRoZSBmb2xsb3dpbmcsIHRv IHdoaWNoIHlvdSBoYXZlbid0IHJlcGxpZWQ6CkhhdmUgeW91IHRyaWVkIGZvcmNpbmcgbTAgdG8g YmUgYXNzaWduZWQgdG8gYSBkZXZpY2Ugb3RoZXIgdGhhbiBoZG1pLWNlYz8KSGF2ZSB5b3UgY2hl Y2tlZCBpZiBtMSBpcyBzaG9ydGVkIHRvIGFub3RoZXIgcGluPwoKSW4gcmVnYXJkcyB0byB5b3Vy IGRhdGEgZnJhbWVzIGZvciA0LjE5IHZzIDUuMTgsIGltYWdlLXZpZXctb24gaXMgbm90CmEgdmFs aWQgY29tbWFuZCBpZiB0aGUgdG9wb2xvZ3kgZG9lc24ndCBkZXRlY3QgYSBkZXZpY2Ugb24gdGhl IGJ1cy4KSSByZWNvbW1lbmQgcnVubmluZyB0aGUgc2FtZSB0ZXN0LCBleGNlcHQgcnVuIGBjZWMt Y3RsIC1TIC0tcGxheWJhY2tgCmFuZCBwb3N0IHRoZSByZXN1bHRzIGZvciBib3RoLgoKPgo+Cj4K PiBCVFc6IGknbSBub3QgYWxvbmUgd2l0aCBjZWMgaXNzdWUgb24gcm9jazNhIHYxLjMxIC0gYWxy ZWFkeSAyIG90aGVyIHVzZXJzIGNvbnRhY3RlZCBtZSB3aXRoIHRoZSBzYW1lIGlzc3VlLi4uCj4K PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt cm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hp cAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A632AC433EF for ; Fri, 24 Jun 2022 12:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E882a1eUqtTRGzcGD/wvchbXAuXLopZRxHHNu3/vRU8=; b=Vkw3mEgqyE/z9Q uyqTpCgyfuhieX85MIdNXNVQxJWLd2OyqhH7MRmQVZJsEJieW76rwHqQvrUH5qI1m5IercBZmj61S BOsq3EoBITXhfq+XE7+D+7V79ho0LmRCiWt6OWDJGV2QolJzyphW4T+vcPW6JoBk6VoTs3Aa/yi1u EO+pvSWswEDot56+4XBv9Ii2DhjTCYcxVJqeB9ecJpFoW6Wm9iueGdv4PIDlql0z717LGkZ57zl8b 7Z2vSFaeigiM4LKplQoE0kus8ewfUDR5uuU09SlM4JqdF20M+uFpnecgf3atESVIy24yY4fmmiDPJ xpqb7yEWrkXrglmfvrcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4iby-002Dhw-F8; Fri, 24 Jun 2022 12:40:34 +0000 Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4ibu-002DgX-So; Fri, 24 Jun 2022 12:40:32 +0000 Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-318889e6a2cso23309507b3.1; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=iwU4WAwYuY4nkLCJy0axAqGQoG42lj5PEowL1fzfUW1VZzpw1/JWJhdAXHS8VcTujk J5fH6JbEPmaRAOT0dBNudO6Csia2IYm+8+BZorymw71HaEIQaO0gekGz1aLnsYhJ6n8y cN0jvvlrqeMKRgih7BUcHlBuqsyukSc0/9f2iL29VpMnV0PvNQjD5GQWDbV3gym+XKct E271VdMxoeJdxXZvuKsc752Lz08Vnar6at93uoANsDPZ//DTcMmgTajkXuwNtwi0F7sY E/5FEF70ekzn+BR24HBj+Qci3izVWS4DQndVou0RRKj+BpMB8XpaucqCnwQOZP36EdMe mGig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XZAwzSvN1418WBrWmnDVbHQmccxtnQQCuTfqFJ1iD/M=; b=VmwxgEoeGZecUfsc6ttAuApQNPIm7LpNprZBqUlOChXAbxA8fWU8/+TZ2g0BefWKFp 9p9sWyHvBiSZ9srEAaKl7ZbU8Zm4T5SRDRfuzwu6FZPFJNuC6yMU78ouA7YilEsRcKkG TOPteYTRGAYm/PSLRww3xM0Yf9nOFuyfBEOrSHeh7wWmVXa278v8g4UBoanJ7Aw02i7V E5vqxKERbp02eJFOot9AOkzcoO08dg37VpCwBwIhnSvo6oUjbH1Bsy2fR/jX4hm9F6NB ExdtPvlI1DcUHBpIxhD4hL7+JxkZwCF+jKKZdeB155RTOu3pqKVcjbJiLiLQ0MzNx3QX UfJQ== X-Gm-Message-State: AJIora8kKXb1e0X10bIkObVTSCEnWPmKJrBMfN1Ava7tLnLQIMJFMS9S jPgUWHzibXAxyOisM32+kjgiJOILFR3RSWDiHCk= X-Google-Smtp-Source: AGRyM1uhuP3HFOm268+6mHrbu8xCTmrxJLbj7jAnsvz7AhIXGUaUE3iuu/MCaQ9V+nE2SgjhttjDEqCcfT2jOeVl9kA= X-Received: by 2002:a81:315:0:b0:317:6789:a0c1 with SMTP id 21-20020a810315000000b003176789a0c1mr16908125ywd.378.1656074427236; Fri, 24 Jun 2022 05:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20220422072841.2206452-1-s.hauer@pengutronix.de> <20220422072841.2206452-21-s.hauer@pengutronix.de> <0E6FE020-C95E-47CF-A9D6-AC3F2B2D334F@gmail.com> <9F2D8CFF-1EAE-4586-9EE9-82A9D67840BB@gmail.com> <9567EECF-A154-4FE1-A03C-5ED080409030@gmail.com> <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> In-Reply-To: <190C3FD3-0185-4A99-B10E-A5790047D993@gmail.com> From: Peter Geis Date: Fri, 24 Jun 2022 08:40:15 -0400 Message-ID: Subject: Re: [PATCH v11 20/24] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a To: Piotr Oniszczuk Cc: Sascha Hauer , Michael Riesch , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , kernel test robot X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220624_054030_977893_0A21B948 X-CRM114-Status: GOOD ( 30.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMjQsIDIwMjIgYXQgNDozMCBBTSBQaW90ciBPbmlzemN6dWsKPHBpb3RyLm9u aXN6Y3p1a0BnbWFpbC5jb20+IHdyb3RlOgo+Cj4KPgo+ID4gV2lhZG9tb8WbxIcgbmFwaXNhbmEg cHJ6ZXogUGlvdHIgT25pc3pjenVrIDxwaW90ci5vbmlzemN6dWtAZ21haWwuY29tPiB3IGRuaXUg MTQuMDUuMjAyMiwgbyBnb2R6LiAxNTo1ODoKPiA+Cj4gPgo+ID4KPiA+PiBXaWFkb21vxZvEhyBu YXBpc2FuYSBwcnpleiBQZXRlciBHZWlzIDxwZ3dpcGVvdXRAZ21haWwuY29tPiB3IGRuaXUgMDku MDUuMjAyMiwgbyBnb2R6LiAxODowMDoKPiA+Pgo+ID4+IElmIHlvdSB3YW50IHRvIGNvbmZpcm0g dGhlIGhhcmR3YXJlIGlzIGNvbmZpZ3VyZWQgY29ycmVjdGx5IHlvdSBjYW4KPiA+PiByZW1vdmUg dGhlIGNlYyBwaW4gZnJvbSB0aGUgaGRtaSBub2RlIGFuZCBzZXQgdXAgYSBjZWMtZ3BpbyBub2Rl Lgo+ID4+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L3Y1LjE4LXJjNS9zb3VyY2Uv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lZGlhL2NlYy1ncGlvLnR4dAo+ID4K PiA+IFBldGVyLCBTYXNjaGEKPiA+Cj4gPiBJIGNvbmZpZ3VyZWQgY2VjLWdwaW8gYW5kIGNhbiBj b25maXJtOiB3aXRoIGdwaW8gY2VjIHdvcmtzIG9uIG15IHJvY2szLWEgYm9hcmQgdjEuMzEuCj4g Pgo+ID4gU28gc3VtbWFyaXNpbmcgbXkgdGVzdHM6Cj4gPgo+ID4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcm9jazMtYSB2MS4xICAgcm9jazMtYSB2MS4zMSAgIHJvY2sz LWIKPiA+Cj4gPiByYWR4YSBkZWJpYW46ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9r ICAgICAgICAgICAgIG9rICAgICAgICAgICAgICAgIG9rCj4gPgo+ID4gb3RoZXIgcHBsIG1haW5s aW5lIDUuMTg6ICAgICAgICAgICAgICAgb2sgICAgICAgICAgICAgbi90ICAgICAgICAgICAgICAg IG4vdAo+ID4KPiA+IG1lIHdpdGggbWFpbmxpbmUgNS4xODogICAgICAgICAgICAgICAgIG4vdCAg ICAgICAgICAgIG5vayAgICAgICAgICAgICAgb2sKPiA+Cj4gPiBtZSB3aXRoIG1haW5saW5lIDUu MTggZ3Bpby1jZWM6ICBuL3QgICAgICAgICAgICAgb2sgICAgICAgICAgICAgICAgbi90Cj4gPgo+ ID4gTm9uLXdvcmtpbmcgY29tYmluYXRpb24gaXM6IHJvY2szLWEgdjEuMzEgaHcgb24gbWFpbmxp bmUgNS4xOC4KPiA+IEZvciBtZSBpdCBsb29rcyBsaWtlIHRoZXJlIGlzIGJ1ZyBpbiBjYXNlIHdo ZW4gcmszNTY4IHVzaW5nIGNlYyBvbiBoZG1pdHhtMV9jZWMgbGluZS4KPiA+IChUaGUgc2FtZSBi aW5hcmllcyB3b3JraW5nIG9rIG9uIG15IHJvY2szLWIgd2hlcmUgY2VjIGlzIG9uIGhkbWl0eG0w X2NlYyBsaW5lLiBJdCBhbHNvIHdvcmtzIG9uIFBldGVyJ3Mgcm9jazNhIHYxLjEgLSB3aGljaCBh bHNvIHVzZXMgaGRtaXR4bTBfY2VjIGxpbmUpLgo+ID4KPiA+IEl0IGxvb2tzIGxpa2UgdXBwZXIg Y2VjIGRyaXZlciBjYW4gdGFsayB0byBsb3dlciBkcml2ZXIgKGR3LWhkbWk/KSBidXQgbm90aGlu ZyBpcyByZWNlaXZlZCBmcm9tIGxvd2VyIGRyaXZlciwgYXMgbXkgYXBwIHNheXM6Cj4gPiBDRUNB ZGFwdGVyOiBDRUMgZGV2aWNlIGNhbid0IHBvbGwgVFY6IFRWIGRvZXMgbm90IHJlc3BvbmQgdG8g Q0VDIHBvbGxzCj4gPgo+ID4gYnR3OiBJIHZlcmlmaWVkIHdpdGggb3NjaWxsb3Njb3BlIGNvbm5l Y3RlZCB0byBoZG1pdHhtMV9jZWMgbGluZTogc3RhcnRpbmcgY2VjLWNvbXBsaWFuY2UgLXYgLVQg c2hvd3MgZXhwZWN0ZWQgc2VyaWVzIG9mIDBWIHB1bHNlcyBvbiBoZG1pdHhtMV9jZWMgbGluZS4u Li4KPiA+Cj4gPgo+Cj4gU2FzY2hhLCBQZXRlcgo+Cj4gSSByZXR1cm5lZCB0byB0cnlpbmcgdG8g ZmluZCB3aHkgaGRtaS1jZWMgaXMgbm90IHdvcmtpbmcgb24gcm9jazMtYSB2MS4zMSBody4KPgo+ IEknbSBvbiB2b3AyIHYxMSBvbiA1LjE4IG1haW5saW5lLgo+Cj4gQ3VycmVudCBmaW5kaW5nczoK Pgo+ICgxKSB0aGUgc2FtZSBzdy4gc3RhY2svYmluYXJpZXMgd29ya3Mgb24gcm9jay0zYiAod2hl cmUgY2VjIHVzZXMgaGRtaXR4X20wIGluc3RlYWQgb2YgaGRtaXR4X20xIEkvTyBsaW5lKTsKPgo+ ICgyKSBncGlvLWNlYyBob3dldmVyIHdvcmtzIG5vIHByb2JsZW0gb24gcm9jazMtYTsKPgo+ICgz KSBtb25pdG9yaW5nIGNlYyBtZXNzYWdlcyB3aXRoIHY0LXV0aWxzICdjZWMtZm9sbG93ZXIgLXMn IHNob3dzIGV4YWN0IHRoZSBzYW1lIGV2ZW50cyBpbiBub24td29ya2luZyByb2NrMy1hIGFuZCB3 b3JraW5nIHJvY2szLWIKPiAodGVzdGVkIGJ5IGlzc3VlIGNvbmZpZ3VyZSBjZWMgYnkgJ2NlYy1j dGwgLWQgL2Rldi9jZWMwIC0tcGh5cy1hZGRyPTEuMC4wLjAgLS1wbGF5YmFjaycgY29tbWFuZCkK Ci0tcGh5cy1hZGRyIGlzbid0IGEgdmFsaWQgY29tbWFuZCBmb3IgdGhpcyBjb250cm9sbGVyLiBU aGUgZGV2aWNlCmRlc2lnbmF0aW9uIGlzIG9ubHkgcmVxdWlyZWQgaWYgeW91IGhhdmUgbW9yZSB0 aGFuIG9uZSBjZWMgZGV2aWNlLgoKPgo+IC0tPiBpJ20gaW50ZXJwcmV0aW5nIHRoaXMgYXMgY29u ZmlybWF0aW9uIHRoYXQgbG93IGxldmVsIHBoeSBsYXllciByZWNlaXZlcyBvayBjZWMgZGF0YSBm cm9tIGNvbm5lY3RlZCBkZXZpY2Ugb24gbm9uLXdvcmtpbmcgcm9jazMtYTsKPgo+ICg0KSBkZWJ1 ZyBzeXNmcyBmb3IgY2VjIHNob3dzICJoYXMgQ0VDIGZvbGxvd2VyIChpbiBwYXNzdGhyb3VnaCBt b2RlKSIgZm9yIHdvcmtpbmcgcm9jay0zYiBhbmQgdGhlcmUgaXMgTk8gImhhcyBDRUMgZm9sbG93 ZXIiIGRlYnVnIG1lc3NhZ2UgaW4gZmFpbGluZyByb2NrMy1hLgoKVGhpcyBtYWtlcyBtZSBzdXNw ZWN0IHlvdSBhcmUgaW4gZmFjdCBub3QgdXNpbmcgdGhlIHNhbWUgc29mdHdhcmUKc3RhY2ssIG9y IGFyZSBub3QgcnVubmluZyB0aGUgc2FtZSBjb21tYW5kcy4KUnVubmluZyBgY2VjLWZvbGxvd2Vy IC12IC1tIC1UYCBvbiBhIHJrMzU2NiBkZXZpY2Ugd2l0aCB3b3JraW5nIGNlYwp1c2luZyA1LjE5 LXJjMSwgSSBzZWUgbm8gbWVudGlvbiBvZiBjZWMtZm9sbG93ZXIgaW4gdGhlIGRlYnVnZnMgY2Vj MApzdGF0dXMgZW50cnkuCgo+Cj4gRm9yIG1lIEl0IGxvb2tzIGxpa2UgbG93LWxldmVsIGhkbWkt Y2VjIHdvcmtzIG9rIG9uIGZhaWxpbmcgcm9jazMtYSAtIGJ1dCB1cHBlciBsYXllcnMgKGluIGhk bWkgdm9wMj8pIGFyZSBub3QgcmVnaXN0ZXJpbmcgKG9yIGZhaWxpbmcgdG8gcmVnaXN0ZXIpIGNl Yy1mb2xsb3dlciBmaWxlaGFuZGxlLiBUaGlzIGhhcHBlbnMganVzdCB3aGVuIGhkbWl0eCBJL08g aW4gRFQgaXMgY2hhbmdlZCBmcm9tIGhkbWl0eF9tMCB0byBoZG11dHhfbTEuIEEgYml0IHN0cmFu Z2UgLSBidXQgYWxsIG15IHRlc3RzIGNvbnNpc3RlbnRseSBjb25maXJtaW5nIHRoaXMgb2JzZXJ2 YXRpb24uLi4uCgpUaGVyZSBpcyBub3RoaW5nIHdyb25nIHdpdGggdm9wMiBhcyBpdCBpcyBub3Qg aW52b2x2ZWQgYXQgYWxsIGluIHRoaXMuClRoZSByb2NrY2hpcCBoZG1pIGRyaXZlciAod2hpY2gg aXMgbm90IHNwZWNpZmljIHRvIHZvcDIpIGRvZXMgbm90aGluZwptb3JlIHRoYW4gY2FsbCB0aGUg Y2VjIHJlZ2lzdHJhdGlvbiBtZXRob2QgaW4gdGhlIGR3IGhkbWkgYnJpZGdlCmRyaXZlciwgd2hp Y2ggdGhlbiBjYWxscyB0aGUga2VybmVsIGNlYyByZWdpc3RyYXRpb24gZnVuY3Rpb25zLgpDaGFu Z2luZyBwaW5tdXggY2hhbmdlcyBub3RoaW5nIGluIGhvdyB0aGlzIGZ1bmN0aW9ucy4KCj4KPiBJ J20gdG9vIHdlYWsgaW4ga2VybmVsIGNlYyBpbnRlcm5hbHMgLSBzbyBtYXliZSB5b3UgaGF2ZSBh bnkgcG9pbnRlcnMgaG93IHRvIGZ1cnRoZXIgZGVidWcvaW52ZXN0aWdhdGUgdGhpcyBpc3N1ZT8K CkFzIHdlIGRpc2N1c3NlZCBpbiB0aGUgcGluZTY0IHJvb20sIHRoaXMgaXMgc3RpbGwgdmVyeSBs aWtlbHkgYQpoYXJkd2FyZSBpc3N1ZSB3aXRoIHRoaXMgYm9hcmQuIEEgY29uZmlndXJhdGlvbiBp c3N1ZSB3aXRoIHlvdXIgdS1ib290Cm9yIHRmLWEgaXMgYWxzbyBhIHBvc3NpYmlsaXR5LCBidXQg aXMgbGVzcyBsaWtlbHkuCgpZb3Ugc2hvd2VkIHdpdGggeW91ciBsb2dpYyBhbmFseXplciB3aXRo IG5vdGhpbmcgcGx1Z2dlZCBpbiBhbmQgY2VjCm5vdCBtdXhlZCB0byBtMSwgZGF0YSB3YXMgcHJl c2VudCBvbiBtMS4gSSByZXF1ZXN0ZWQgeW91IGludmVzdGlnYXRlCnRoZSBmb2xsb3dpbmcsIHRv IHdoaWNoIHlvdSBoYXZlbid0IHJlcGxpZWQ6CkhhdmUgeW91IHRyaWVkIGZvcmNpbmcgbTAgdG8g YmUgYXNzaWduZWQgdG8gYSBkZXZpY2Ugb3RoZXIgdGhhbiBoZG1pLWNlYz8KSGF2ZSB5b3UgY2hl Y2tlZCBpZiBtMSBpcyBzaG9ydGVkIHRvIGFub3RoZXIgcGluPwoKSW4gcmVnYXJkcyB0byB5b3Vy IGRhdGEgZnJhbWVzIGZvciA0LjE5IHZzIDUuMTgsIGltYWdlLXZpZXctb24gaXMgbm90CmEgdmFs aWQgY29tbWFuZCBpZiB0aGUgdG9wb2xvZ3kgZG9lc24ndCBkZXRlY3QgYSBkZXZpY2Ugb24gdGhl IGJ1cy4KSSByZWNvbW1lbmQgcnVubmluZyB0aGUgc2FtZSB0ZXN0LCBleGNlcHQgcnVuIGBjZWMt Y3RsIC1TIC0tcGxheWJhY2tgCmFuZCBwb3N0IHRoZSByZXN1bHRzIGZvciBib3RoLgoKPgo+Cj4K PiBCVFc6IGknbSBub3QgYWxvbmUgd2l0aCBjZWMgaXNzdWUgb24gcm9jazNhIHYxLjMxIC0gYWxy ZWFkeSAyIG90aGVyIHVzZXJzIGNvbnRhY3RlZCBtZSB3aXRoIHRoZSBzYW1lIGlzc3VlLi4uCj4K PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=