From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF09C4338F for ; Wed, 28 Jul 2021 15:17:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19D9660F91 for ; Wed, 28 Jul 2021 15:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235574AbhG1PRK (ORCPT ); Wed, 28 Jul 2021 11:17:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235546AbhG1PRJ (ORCPT ); Wed, 28 Jul 2021 11:17:09 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75430C061757; Wed, 28 Jul 2021 08:17:07 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id j77so2567724ybj.3; Wed, 28 Jul 2021 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=XJZLSfz498/PpYdOyshbjuXRO586ZzyWYWVLc01A2rkLHglPeh5q0WZC1seQeA2hSL NC13pCwL7i1Myc6lwlvK/jlZ6EAe6+TAa4rHwXDcwD6w9azITNt6z0qT7IkUeoZTvULk PcdnI/Jc7BKmKvS/YieMitzuvDRII0DtmwR39uQjdK1Q3rpn/usFnZbFT+SJYwMvJTOa IJP+MTrNs8B/QqjyBYal0hiYq2sxJQJhIcQKxZg/Z4LGRVuiTGpXjAKNfFTjJCjjhTFY qDtYyvYCL83aVv+mreQkKUHzv4eZMY96HqAxf6/QSJ8QOfo6vFwRGQpru8QBVlJ83O+m xekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=YGqStpL2dXJGxPDF6pANUhmON5kMwBQ8M/djC+2tgAGswDMjD30HC3Pl/xHbiMXVox LXY+Oh37MZD34smyurwBtXQHphMOZmwQ3g/AXPGYdCKfQAiFdNWe+BJ0+gwBXTtI6CHj E2xEm81+AJdW1BUhLC7CAUHx1Xi+7Z8j63t8pGOOOZ0Jyz/LLVXNYdy1wp70xhlg5T6X QjalWbSRw4npqflkw/gF1Vsdd/bI1tZd0LbxsY08IQOldAdjYdMlOrD4/gWAIVZ2b9e/ 58OT5hHZU8zGdUUcTSFzbFUgUOrv046CVOIXfTLjrus2UlwovAvN+kaWD9GMBRjqPjWQ wQ3g== X-Gm-Message-State: AOAM533nyVlJafLj1f5d35HiCl1DardbHKXTCkFPVi8mYR5EqvNyK/EX Z6vbWsTangai1HiuqIuVIXEUlSva+9EQdqnwQiE= X-Google-Smtp-Source: ABdhPJw66uV4pmVHCu4cBfxtOOl41cuXnbEcQs0rCshQ8A82EetArMTQgWhBjTyHiepjqSDensKvqgi0F2KfvBRwC+g= X-Received: by 2002:a25:808b:: with SMTP id n11mr272052ybk.141.1627485426763; Wed, 28 Jul 2021 08:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20210728135534.703028-1-pgwipeout@gmail.com> <13247009.uLZWGnKmhe@diego> <6063626.MhkbZ0Pkbq@diego> In-Reply-To: <6063626.MhkbZ0Pkbq@diego> From: Peter Geis Date: Wed, 28 Jul 2021 11:16:54 -0400 Message-ID: Subject: Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , "open list:GPIO SUBSYSTEM" , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jul 28, 2021 at 10:41 AM Heiko St=C3=BCbner wrote= : > > Am Mittwoch, 28. Juli 2021, 16:18:49 CEST schrieb Peter Geis: > > On Wed, Jul 28, 2021 at 10:06 AM Heiko St=C3=BCbner w= rote: > > > > > > Hi Peter, > > > > > > Am Mittwoch, 28. Juli 2021, 15:55:31 CEST schrieb Peter Geis: > > > > The grf and pmugrf phandles are necessary for the pmucru and cru to > > > > modify clocks. Add these phandles to permit adjusting the clock rat= es > > > > and muxes. > > > > > > > > Signed-off-by: Peter Geis > > > > --- > > > > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 3 +++ > > > > 1 file changed, 3 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/= boot/dts/rockchip/rk356x.dtsi > > > > index 0905fac0726a..8ba0516eedd8 100644 > > > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > > > @@ -218,6 +218,8 @@ grf: syscon@fdc60000 { > > > > pmucru: clock-controller@fdd00000 { > > > > compatible =3D "rockchip,rk3568-pmucru"; > > > > reg =3D <0x0 0xfdd00000 0x0 0x1000>; > > > > + rockchip,grf =3D <&grf>; > > > > + rockchip,pmugrf =3D <&pmugrf>; > > > > > > I don't think the pmucru needs both and in fact the mainline > > > clock driver should just reference its specific grf at all, i.e. > > > pmucru -> pmugrf (via the rockchip,grf handle) > > > cru -> grf > > > > > > I've not seen anything breaking this scope so far. > > > > I thought the same thing as well, but for some reason the driver > > refuses to apply assigned-clocks to the plls unless these are all > > present. > > If the driver can get these assignments automatically eventually, > > perhaps it's a loading order issue? > > > > Thinking about it, it's probably the grf and pmugrf haven't probed > > when the driver is attempting to assign these, and tying them together > > forces the probe to happen first. > > though nothing references the regular grf from the pmucru I think. > > I.e. the pmucru PLL read their lock state from RK3568_PMU_MODE_CON > > The rk3568 reuses the pll_rk3328-type which in turn is a modified pll_rk3= 036 > and uses their ops. Which in turn means the pll shouldn't access the GRF = at > all, as it uses the pll's own register to check the locked state. > > Can you try to change clk-pll.c from > > switch (pll_type) { > case pll_rk3036: > case pll_rk3328: > if (!pll->rate_table || IS_ERR(ctx->grf)) > init.ops =3D &rockchip_rk3036_pll_clk_norate_ops; > ... > to > switch (pll_type) { > case pll_rk3036: > case pll_rk3328: > if (!pll->rate_table) > init.ops =3D &rockchip_rk3036_pll_clk_norate_ops; > > similar to rk3399? Thanks, I'll test this! > > Heiko > > > > > #clock-cells =3D <1>; > > > > #reset-cells =3D <1>; > > > > }; > > > > @@ -225,6 +227,7 @@ pmucru: clock-controller@fdd00000 { > > > > cru: clock-controller@fdd20000 { > > > > compatible =3D "rockchip,rk3568-cru"; > > > > reg =3D <0x0 0xfdd20000 0x0 0x1000>; > > > > + rockchip,grf =3D <&grf>; > > > > #clock-cells =3D <1>; > > > > #reset-cells =3D <1>; > > > > }; > > > > > > > > > > > > > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B1DC4338F for ; Wed, 28 Jul 2021 15:17:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6D006023F for ; Wed, 28 Jul 2021 15:17:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B6D006023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2TeQVZmNu4fA98UiEYmzy5VmfT//AUMsyB+NnfCqkss=; b=q8wj54R2lWTTQr eDlVQycTd7KBIvacV/9+1u9I8avnfh5tx9IDKBb9ztWgFAUHLm/T3imNi7x6iTV6Mh+3ZcbO5Tp0M AEkE1BYyBSMC6v0BC8O5T486uIu4Z5qTNQfmmVfgEJdu7dLIwx+v+7iwsQQFusVS3LV7+ii1wt59n J8Z4v+C60BjIK8C0+VtmfOeuPqtr2aa6/EMgZpC5g/d9Y4pSJUQJ2l8gAhbiZAuG3M0SClM23cq2B MkXyRQbQYEygILWY804RIqxnGEz7yEPKQxPZ5RAko/H40NiosY7sw5o7LuA6vbVQ+8hVB0sUZyAAs fry4PibKi5ojhITmXHhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8lJE-001FGA-R3; Wed, 28 Jul 2021 15:17:24 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8lIy-001FBz-B5; Wed, 28 Jul 2021 15:17:09 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id a93so4568974ybi.1; Wed, 28 Jul 2021 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=XJZLSfz498/PpYdOyshbjuXRO586ZzyWYWVLc01A2rkLHglPeh5q0WZC1seQeA2hSL NC13pCwL7i1Myc6lwlvK/jlZ6EAe6+TAa4rHwXDcwD6w9azITNt6z0qT7IkUeoZTvULk PcdnI/Jc7BKmKvS/YieMitzuvDRII0DtmwR39uQjdK1Q3rpn/usFnZbFT+SJYwMvJTOa IJP+MTrNs8B/QqjyBYal0hiYq2sxJQJhIcQKxZg/Z4LGRVuiTGpXjAKNfFTjJCjjhTFY qDtYyvYCL83aVv+mreQkKUHzv4eZMY96HqAxf6/QSJ8QOfo6vFwRGQpru8QBVlJ83O+m xekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=qeYaHW92SEElWYXRrAGw2LHIiDI76IbAdh5eCsQmYSepIaDwfNqpNJOUX9Q7ytVxEd SiT+zHY0dxOUpXe6Fb99gnMPrAsl0xg6N41Y8xxHNPnp44fDADETKRIx0oUEdtHeSt8u /zYZ8UzCFYRiv7aimdfYqqdENauvv0YuS05U4xnWEYL+W2oYngN8mLVDvKlITx2iKq3k YjDSAXe98UEUJFYdnEv7+/9j4kycORn2W7tFk+BKF+Ms4eOa4QFP+qK494u1ibdjM69X FizwU55r7QXPrVKkeLcUgDDX3nGfjXgc4OBpM0TM96CZ5a5DviABNdvWrqR1zZJZcKyb BBKQ== X-Gm-Message-State: AOAM533uYAFbXawkFEVC8JoxD5j4qeBrTD8yI2Zapt+7gUbkiMoEuAqd S3NbafkpOr4t3Aj1u5R+dBcb75/k7/f1dNoIiiA= X-Google-Smtp-Source: ABdhPJw66uV4pmVHCu4cBfxtOOl41cuXnbEcQs0rCshQ8A82EetArMTQgWhBjTyHiepjqSDensKvqgi0F2KfvBRwC+g= X-Received: by 2002:a25:808b:: with SMTP id n11mr272052ybk.141.1627485426763; Wed, 28 Jul 2021 08:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20210728135534.703028-1-pgwipeout@gmail.com> <13247009.uLZWGnKmhe@diego> <6063626.MhkbZ0Pkbq@diego> In-Reply-To: <6063626.MhkbZ0Pkbq@diego> From: Peter Geis Date: Wed, 28 Jul 2021 11:16:54 -0400 Message-ID: Subject: Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , "open list:GPIO SUBSYSTEM" , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_081708_446781_0EE487ED X-CRM114-Status: GOOD ( 30.06 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMjgsIDIwMjEgYXQgMTA6NDEgQU0gSGVpa28gU3TDvGJuZXIgPGhlaWtvQHNu dGVjaC5kZT4gd3JvdGU6Cj4KPiBBbSBNaXR0d29jaCwgMjguIEp1bGkgMjAyMSwgMTY6MTg6NDkg Q0VTVCBzY2hyaWViIFBldGVyIEdlaXM6Cj4gPiBPbiBXZWQsIEp1bCAyOCwgMjAyMSBhdCAxMDow NiBBTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250ZWNoLmRlPiB3cm90ZToKPiA+ID4KPiA+ID4g SGkgUGV0ZXIsCj4gPiA+Cj4gPiA+IEFtIE1pdHR3b2NoLCAyOC4gSnVsaSAyMDIxLCAxNTo1NToz MSBDRVNUIHNjaHJpZWIgUGV0ZXIgR2VpczoKPiA+ID4gPiBUaGUgZ3JmIGFuZCBwbXVncmYgcGhh bmRsZXMgYXJlIG5lY2Vzc2FyeSBmb3IgdGhlIHBtdWNydSBhbmQgY3J1IHRvCj4gPiA+ID4gbW9k aWZ5IGNsb2Nrcy4gQWRkIHRoZXNlIHBoYW5kbGVzIHRvIHBlcm1pdCBhZGp1c3RpbmcgdGhlIGNs b2NrIHJhdGVzCj4gPiA+ID4gYW5kIG11eGVzLgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1i eTogUGV0ZXIgR2VpcyA8cGd3aXBlb3V0QGdtYWlsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAg YXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NnguZHRzaSB8IDMgKysrCj4gPiA+ID4g IDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1n aXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2eC5kdHNpIGIvYXJjaC9hcm02 NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NnguZHRzaQo+ID4gPiA+IGluZGV4IDA5MDVmYWMwNzI2 YS4uOGJhMDUxNmVlZGQ4IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszNTZ4LmR0c2kKPiA+ID4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzU2eC5kdHNpCj4gPiA+ID4gQEAgLTIxOCw2ICsyMTgsOCBAQCBncmY6IHN5c2Nv bkBmZGM2MDAwMCB7Cj4gPiA+ID4gICAgICAgcG11Y3J1OiBjbG9jay1jb250cm9sbGVyQGZkZDAw MDAwIHsKPiA+ID4gPiAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszNTY4 LXBtdWNydSI7Cj4gPiA+ID4gICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmRkMDAwMDAgMHgw IDB4MTAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICByb2NrY2hpcCxncmYgPSA8JmdyZj47Cj4g PiA+ID4gKyAgICAgICAgICAgICByb2NrY2hpcCxwbXVncmYgPSA8JnBtdWdyZj47Cj4gPiA+Cj4g PiA+IEkgZG9uJ3QgdGhpbmsgdGhlIHBtdWNydSBuZWVkcyBib3RoIGFuZCBpbiBmYWN0IHRoZSBt YWlubGluZQo+ID4gPiBjbG9jayBkcml2ZXIgc2hvdWxkIGp1c3QgcmVmZXJlbmNlIGl0cyBzcGVj aWZpYyBncmYgYXQgYWxsLCBpLmUuCj4gPiA+ICAgICAgICAgcG11Y3J1IC0+IHBtdWdyZiAodmlh IHRoZSByb2NrY2hpcCxncmYgaGFuZGxlKQo+ID4gPiAgICAgICAgIGNydSAtPiBncmYKPiA+ID4K PiA+ID4gSSd2ZSBub3Qgc2VlbiBhbnl0aGluZyBicmVha2luZyB0aGlzIHNjb3BlIHNvIGZhci4K PiA+Cj4gPiBJIHRob3VnaHQgdGhlIHNhbWUgdGhpbmcgYXMgd2VsbCwgYnV0IGZvciBzb21lIHJl YXNvbiB0aGUgZHJpdmVyCj4gPiByZWZ1c2VzIHRvIGFwcGx5IGFzc2lnbmVkLWNsb2NrcyB0byB0 aGUgcGxscyB1bmxlc3MgdGhlc2UgYXJlIGFsbAo+ID4gcHJlc2VudC4KPiA+IElmIHRoZSBkcml2 ZXIgY2FuIGdldCB0aGVzZSBhc3NpZ25tZW50cyBhdXRvbWF0aWNhbGx5IGV2ZW50dWFsbHksCj4g PiBwZXJoYXBzIGl0J3MgYSBsb2FkaW5nIG9yZGVyIGlzc3VlPwo+ID4KPiA+IFRoaW5raW5nIGFi b3V0IGl0LCBpdCdzIHByb2JhYmx5IHRoZSBncmYgYW5kIHBtdWdyZiBoYXZlbid0IHByb2JlZAo+ ID4gd2hlbiB0aGUgZHJpdmVyIGlzIGF0dGVtcHRpbmcgdG8gYXNzaWduIHRoZXNlLCBhbmQgdHlp bmcgdGhlbSB0b2dldGhlcgo+ID4gZm9yY2VzIHRoZSBwcm9iZSB0byBoYXBwZW4gZmlyc3QuCj4K PiB0aG91Z2ggbm90aGluZyByZWZlcmVuY2VzIHRoZSByZWd1bGFyIGdyZiBmcm9tIHRoZSBwbXVj cnUgSSB0aGluay4KPgo+IEkuZS4gdGhlIHBtdWNydSBQTEwgcmVhZCB0aGVpciBsb2NrIHN0YXRl IGZyb20gUkszNTY4X1BNVV9NT0RFX0NPTgo+Cj4gVGhlIHJrMzU2OCByZXVzZXMgdGhlIHBsbF9y azMzMjgtdHlwZSB3aGljaCBpbiB0dXJuIGlzIGEgbW9kaWZpZWQgcGxsX3JrMzAzNgo+IGFuZCB1 c2VzIHRoZWlyIG9wcy4gV2hpY2ggaW4gdHVybiBtZWFucyB0aGUgcGxsIHNob3VsZG4ndCBhY2Nl c3MgdGhlIEdSRiBhdAo+IGFsbCwgYXMgaXQgdXNlcyB0aGUgcGxsJ3Mgb3duIHJlZ2lzdGVyIHRv IGNoZWNrIHRoZSBsb2NrZWQgc3RhdGUuCj4KPiBDYW4geW91IHRyeSB0byBjaGFuZ2UgY2xrLXBs bC5jIGZyb20KPgo+ICAgICAgICAgc3dpdGNoIChwbGxfdHlwZSkgewo+ICAgICAgICAgY2FzZSBw bGxfcmszMDM2Ogo+ICAgICAgICAgY2FzZSBwbGxfcmszMzI4Ogo+ICAgICAgICAgICAgICAgICBp ZiAoIXBsbC0+cmF0ZV90YWJsZSB8fCBJU19FUlIoY3R4LT5ncmYpKQo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGluaXQub3BzID0gJnJvY2tjaGlwX3JrMzAzNl9wbGxfY2xrX25vcmF0ZV9vcHM7 Cj4gLi4uCj4gdG8KPiAgICAgICAgIHN3aXRjaCAocGxsX3R5cGUpIHsKPiAgICAgICAgIGNhc2Ug cGxsX3JrMzAzNjoKPiAgICAgICAgIGNhc2UgcGxsX3JrMzMyODoKPiAgICAgICAgICAgICAgICAg aWYgKCFwbGwtPnJhdGVfdGFibGUpCj4gICAgICAgICAgICAgICAgICAgICAgICAgaW5pdC5vcHMg PSAmcm9ja2NoaXBfcmszMDM2X3BsbF9jbGtfbm9yYXRlX29wczsKPgo+IHNpbWlsYXIgdG8gcmsz Mzk5PwoKVGhhbmtzLCBJJ2xsIHRlc3QgdGhpcyEKCj4KPiBIZWlrbwo+Cj4gPiA+ID4gICAgICAg ICAgICAgICAjY2xvY2stY2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAgICAgICAgICAjcmVzZXQt Y2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAgfTsKPiA+ID4gPiBAQCAtMjI1LDYgKzIyNyw3IEBA IHBtdWNydTogY2xvY2stY29udHJvbGxlckBmZGQwMDAwMCB7Cj4gPiA+ID4gICAgICAgY3J1OiBj bG9jay1jb250cm9sbGVyQGZkZDIwMDAwIHsKPiA+ID4gPiAgICAgICAgICAgICAgIGNvbXBhdGli bGUgPSAicm9ja2NoaXAscmszNTY4LWNydSI7Cj4gPiA+ID4gICAgICAgICAgICAgICByZWcgPSA8 MHgwIDB4ZmRkMjAwMDAgMHgwIDB4MTAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICByb2NrY2hp cCxncmYgPSA8JmdyZj47Cj4gPiA+ID4gICAgICAgICAgICAgICAjY2xvY2stY2VsbHMgPSA8MT47 Cj4gPiA+ID4gICAgICAgICAgICAgICAjcmVzZXQtY2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAg fTsKPiA+ID4gPgo+ID4gPgo+ID4gPgo+ID4gPgo+ID4gPgo+ID4KPgo+Cj4KPgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFp bGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D673C4338F for ; Wed, 28 Jul 2021 15:19:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D48960F91 for ; Wed, 28 Jul 2021 15:19:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D48960F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mPPEX6hpWwloX3EhadIFlerdwetg8IUDRbei76gmExI=; b=5CCZT4fA3Byn9K dWs0TuVCYkNW+8StniooUBlWuQvhN19hzPFpAJ5prkkOjocTHFpJK0z/uelwgF3B/y4/sVnLqGCzE 9xKgLj/FuLbvpJHPA2IhSEFGJiqRdEgoBGnSCB0wcMgcs327smCMYnD7NG3gizeTyZb122Q5oV310 aoVQ1wq6wovBXdmrYy86FVeOZC6m7UIadw7QPbUYKs/8hUlTTcxjK1pu1LnxG0kDdDUKFFxgDF/9i B3IvtUBiKVpapEzsVRjf1IV74ApsCBhmfxRgOEgK/ck6xguaPUf6SVsvSVVNmihqfxpfytZel5GNH o/vR1NTSvLyd1777g+WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8lJ2-001FDE-0I; Wed, 28 Jul 2021 15:17:12 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8lIy-001FBz-B5; Wed, 28 Jul 2021 15:17:09 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id a93so4568974ybi.1; Wed, 28 Jul 2021 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=XJZLSfz498/PpYdOyshbjuXRO586ZzyWYWVLc01A2rkLHglPeh5q0WZC1seQeA2hSL NC13pCwL7i1Myc6lwlvK/jlZ6EAe6+TAa4rHwXDcwD6w9azITNt6z0qT7IkUeoZTvULk PcdnI/Jc7BKmKvS/YieMitzuvDRII0DtmwR39uQjdK1Q3rpn/usFnZbFT+SJYwMvJTOa IJP+MTrNs8B/QqjyBYal0hiYq2sxJQJhIcQKxZg/Z4LGRVuiTGpXjAKNfFTjJCjjhTFY qDtYyvYCL83aVv+mreQkKUHzv4eZMY96HqAxf6/QSJ8QOfo6vFwRGQpru8QBVlJ83O+m xekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ESrezXcwKkqa6xx20d3Rb22HD68EBnHXQ0zjk4sO7Sk=; b=qeYaHW92SEElWYXRrAGw2LHIiDI76IbAdh5eCsQmYSepIaDwfNqpNJOUX9Q7ytVxEd SiT+zHY0dxOUpXe6Fb99gnMPrAsl0xg6N41Y8xxHNPnp44fDADETKRIx0oUEdtHeSt8u /zYZ8UzCFYRiv7aimdfYqqdENauvv0YuS05U4xnWEYL+W2oYngN8mLVDvKlITx2iKq3k YjDSAXe98UEUJFYdnEv7+/9j4kycORn2W7tFk+BKF+Ms4eOa4QFP+qK494u1ibdjM69X FizwU55r7QXPrVKkeLcUgDDX3nGfjXgc4OBpM0TM96CZ5a5DviABNdvWrqR1zZJZcKyb BBKQ== X-Gm-Message-State: AOAM533uYAFbXawkFEVC8JoxD5j4qeBrTD8yI2Zapt+7gUbkiMoEuAqd S3NbafkpOr4t3Aj1u5R+dBcb75/k7/f1dNoIiiA= X-Google-Smtp-Source: ABdhPJw66uV4pmVHCu4cBfxtOOl41cuXnbEcQs0rCshQ8A82EetArMTQgWhBjTyHiepjqSDensKvqgi0F2KfvBRwC+g= X-Received: by 2002:a25:808b:: with SMTP id n11mr272052ybk.141.1627485426763; Wed, 28 Jul 2021 08:17:06 -0700 (PDT) MIME-Version: 1.0 References: <20210728135534.703028-1-pgwipeout@gmail.com> <13247009.uLZWGnKmhe@diego> <6063626.MhkbZ0Pkbq@diego> In-Reply-To: <6063626.MhkbZ0Pkbq@diego> From: Peter Geis Date: Wed, 28 Jul 2021 11:16:54 -0400 Message-ID: Subject: Re: [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , "open list:GPIO SUBSYSTEM" , devicetree@vger.kernel.org, arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_081708_446781_0EE487ED X-CRM114-Status: GOOD ( 30.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMjgsIDIwMjEgYXQgMTA6NDEgQU0gSGVpa28gU3TDvGJuZXIgPGhlaWtvQHNu dGVjaC5kZT4gd3JvdGU6Cj4KPiBBbSBNaXR0d29jaCwgMjguIEp1bGkgMjAyMSwgMTY6MTg6NDkg Q0VTVCBzY2hyaWViIFBldGVyIEdlaXM6Cj4gPiBPbiBXZWQsIEp1bCAyOCwgMjAyMSBhdCAxMDow NiBBTSBIZWlrbyBTdMO8Ym5lciA8aGVpa29Ac250ZWNoLmRlPiB3cm90ZToKPiA+ID4KPiA+ID4g SGkgUGV0ZXIsCj4gPiA+Cj4gPiA+IEFtIE1pdHR3b2NoLCAyOC4gSnVsaSAyMDIxLCAxNTo1NToz MSBDRVNUIHNjaHJpZWIgUGV0ZXIgR2VpczoKPiA+ID4gPiBUaGUgZ3JmIGFuZCBwbXVncmYgcGhh bmRsZXMgYXJlIG5lY2Vzc2FyeSBmb3IgdGhlIHBtdWNydSBhbmQgY3J1IHRvCj4gPiA+ID4gbW9k aWZ5IGNsb2Nrcy4gQWRkIHRoZXNlIHBoYW5kbGVzIHRvIHBlcm1pdCBhZGp1c3RpbmcgdGhlIGNs b2NrIHJhdGVzCj4gPiA+ID4gYW5kIG11eGVzLgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1i eTogUGV0ZXIgR2VpcyA8cGd3aXBlb3V0QGdtYWlsLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAg YXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NnguZHRzaSB8IDMgKysrCj4gPiA+ID4g IDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiA+ID4gPgo+ID4gPiA+IGRpZmYgLS1n aXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzU2eC5kdHNpIGIvYXJjaC9hcm02 NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NnguZHRzaQo+ID4gPiA+IGluZGV4IDA5MDVmYWMwNzI2 YS4uOGJhMDUxNmVlZGQ4IDEwMDY0NAo+ID4gPiA+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszNTZ4LmR0c2kKPiA+ID4gPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3Jv Y2tjaGlwL3JrMzU2eC5kdHNpCj4gPiA+ID4gQEAgLTIxOCw2ICsyMTgsOCBAQCBncmY6IHN5c2Nv bkBmZGM2MDAwMCB7Cj4gPiA+ID4gICAgICAgcG11Y3J1OiBjbG9jay1jb250cm9sbGVyQGZkZDAw MDAwIHsKPiA+ID4gPiAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszNTY4 LXBtdWNydSI7Cj4gPiA+ID4gICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmRkMDAwMDAgMHgw IDB4MTAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICByb2NrY2hpcCxncmYgPSA8JmdyZj47Cj4g PiA+ID4gKyAgICAgICAgICAgICByb2NrY2hpcCxwbXVncmYgPSA8JnBtdWdyZj47Cj4gPiA+Cj4g PiA+IEkgZG9uJ3QgdGhpbmsgdGhlIHBtdWNydSBuZWVkcyBib3RoIGFuZCBpbiBmYWN0IHRoZSBt YWlubGluZQo+ID4gPiBjbG9jayBkcml2ZXIgc2hvdWxkIGp1c3QgcmVmZXJlbmNlIGl0cyBzcGVj aWZpYyBncmYgYXQgYWxsLCBpLmUuCj4gPiA+ICAgICAgICAgcG11Y3J1IC0+IHBtdWdyZiAodmlh IHRoZSByb2NrY2hpcCxncmYgaGFuZGxlKQo+ID4gPiAgICAgICAgIGNydSAtPiBncmYKPiA+ID4K PiA+ID4gSSd2ZSBub3Qgc2VlbiBhbnl0aGluZyBicmVha2luZyB0aGlzIHNjb3BlIHNvIGZhci4K PiA+Cj4gPiBJIHRob3VnaHQgdGhlIHNhbWUgdGhpbmcgYXMgd2VsbCwgYnV0IGZvciBzb21lIHJl YXNvbiB0aGUgZHJpdmVyCj4gPiByZWZ1c2VzIHRvIGFwcGx5IGFzc2lnbmVkLWNsb2NrcyB0byB0 aGUgcGxscyB1bmxlc3MgdGhlc2UgYXJlIGFsbAo+ID4gcHJlc2VudC4KPiA+IElmIHRoZSBkcml2 ZXIgY2FuIGdldCB0aGVzZSBhc3NpZ25tZW50cyBhdXRvbWF0aWNhbGx5IGV2ZW50dWFsbHksCj4g PiBwZXJoYXBzIGl0J3MgYSBsb2FkaW5nIG9yZGVyIGlzc3VlPwo+ID4KPiA+IFRoaW5raW5nIGFi b3V0IGl0LCBpdCdzIHByb2JhYmx5IHRoZSBncmYgYW5kIHBtdWdyZiBoYXZlbid0IHByb2JlZAo+ ID4gd2hlbiB0aGUgZHJpdmVyIGlzIGF0dGVtcHRpbmcgdG8gYXNzaWduIHRoZXNlLCBhbmQgdHlp bmcgdGhlbSB0b2dldGhlcgo+ID4gZm9yY2VzIHRoZSBwcm9iZSB0byBoYXBwZW4gZmlyc3QuCj4K PiB0aG91Z2ggbm90aGluZyByZWZlcmVuY2VzIHRoZSByZWd1bGFyIGdyZiBmcm9tIHRoZSBwbXVj cnUgSSB0aGluay4KPgo+IEkuZS4gdGhlIHBtdWNydSBQTEwgcmVhZCB0aGVpciBsb2NrIHN0YXRl IGZyb20gUkszNTY4X1BNVV9NT0RFX0NPTgo+Cj4gVGhlIHJrMzU2OCByZXVzZXMgdGhlIHBsbF9y azMzMjgtdHlwZSB3aGljaCBpbiB0dXJuIGlzIGEgbW9kaWZpZWQgcGxsX3JrMzAzNgo+IGFuZCB1 c2VzIHRoZWlyIG9wcy4gV2hpY2ggaW4gdHVybiBtZWFucyB0aGUgcGxsIHNob3VsZG4ndCBhY2Nl c3MgdGhlIEdSRiBhdAo+IGFsbCwgYXMgaXQgdXNlcyB0aGUgcGxsJ3Mgb3duIHJlZ2lzdGVyIHRv IGNoZWNrIHRoZSBsb2NrZWQgc3RhdGUuCj4KPiBDYW4geW91IHRyeSB0byBjaGFuZ2UgY2xrLXBs bC5jIGZyb20KPgo+ICAgICAgICAgc3dpdGNoIChwbGxfdHlwZSkgewo+ICAgICAgICAgY2FzZSBw bGxfcmszMDM2Ogo+ICAgICAgICAgY2FzZSBwbGxfcmszMzI4Ogo+ICAgICAgICAgICAgICAgICBp ZiAoIXBsbC0+cmF0ZV90YWJsZSB8fCBJU19FUlIoY3R4LT5ncmYpKQo+ICAgICAgICAgICAgICAg ICAgICAgICAgIGluaXQub3BzID0gJnJvY2tjaGlwX3JrMzAzNl9wbGxfY2xrX25vcmF0ZV9vcHM7 Cj4gLi4uCj4gdG8KPiAgICAgICAgIHN3aXRjaCAocGxsX3R5cGUpIHsKPiAgICAgICAgIGNhc2Ug cGxsX3JrMzAzNjoKPiAgICAgICAgIGNhc2UgcGxsX3JrMzMyODoKPiAgICAgICAgICAgICAgICAg aWYgKCFwbGwtPnJhdGVfdGFibGUpCj4gICAgICAgICAgICAgICAgICAgICAgICAgaW5pdC5vcHMg PSAmcm9ja2NoaXBfcmszMDM2X3BsbF9jbGtfbm9yYXRlX29wczsKPgo+IHNpbWlsYXIgdG8gcmsz Mzk5PwoKVGhhbmtzLCBJJ2xsIHRlc3QgdGhpcyEKCj4KPiBIZWlrbwo+Cj4gPiA+ID4gICAgICAg ICAgICAgICAjY2xvY2stY2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAgICAgICAgICAjcmVzZXQt Y2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAgfTsKPiA+ID4gPiBAQCAtMjI1LDYgKzIyNyw3IEBA IHBtdWNydTogY2xvY2stY29udHJvbGxlckBmZGQwMDAwMCB7Cj4gPiA+ID4gICAgICAgY3J1OiBj bG9jay1jb250cm9sbGVyQGZkZDIwMDAwIHsKPiA+ID4gPiAgICAgICAgICAgICAgIGNvbXBhdGli bGUgPSAicm9ja2NoaXAscmszNTY4LWNydSI7Cj4gPiA+ID4gICAgICAgICAgICAgICByZWcgPSA8 MHgwIDB4ZmRkMjAwMDAgMHgwIDB4MTAwMD47Cj4gPiA+ID4gKyAgICAgICAgICAgICByb2NrY2hp cCxncmYgPSA8JmdyZj47Cj4gPiA+ID4gICAgICAgICAgICAgICAjY2xvY2stY2VsbHMgPSA8MT47 Cj4gPiA+ID4gICAgICAgICAgICAgICAjcmVzZXQtY2VsbHMgPSA8MT47Cj4gPiA+ID4gICAgICAg fTsKPiA+ID4gPgo+ID4gPgo+ID4gPgo+ID4gPgo+ID4gPgo+ID4KPgo+Cj4KPgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=