From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C18CCC433F5 for ; Thu, 21 Apr 2022 11:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbiDULNt (ORCPT ); Thu, 21 Apr 2022 07:13:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbiDULNq (ORCPT ); Thu, 21 Apr 2022 07:13:46 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68B29DF69 for ; Thu, 21 Apr 2022 04:10:57 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d15so4510955pll.10 for ; Thu, 21 Apr 2022 04:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5mDQNWE6CHbxD5RppFkYKwLi4HSMIbAeHaJuTv1BRD0=; b=joxbRWZL34N6wRmRFL2QNDESl9kKHHoFkc1TBgwu+vOWLqbwgebGY0J7IWsC8OOslo 63Zae0O30/OtzO36UDhvAdh8gyewNzrbrj2obOs5mJwZTZZsbAHk2npZU7hsVtoaO3x2 osrwOz0/jFx4rLKbiqrQ1wEq2YachOZLh966JhbWuH8gjTffQrekJ3eBKgJCUmE64rJX s+2+D906rSGh3+yZhvBMg8eHbyKPjRqzEPLUNKw3Ad2C+rvo5u32rrihqSq1I32gBSAj sqNWvJkqyMVWRCAZFcrcP8AhKgjGrFGuwbVweJEva+dzwMuDJFrWQiNW65CtqbBgjZ/o bKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5mDQNWE6CHbxD5RppFkYKwLi4HSMIbAeHaJuTv1BRD0=; b=CR038YMbr+YuJI9vSc8LC6Xkq5Os4wI7QYpja0sQs7vG1KoQuPLLhui+02pTDVDE3g rInYAFk1Kv7yAQ9M1pxNL2yo21NhwhoJlmMPwgkjxaawvW4qZ3O7Y+4ceSbBhfymvb95 L5LZZYeAc8jeCbv1Qy2w4PzlrxsKWLytulYIP3zUi6fVxPq80rQRd0f6pzMKJl8aB+NI DyEDaRlXZT9M/8P3h/BqfC2/eCZ90UN1jzaODEblzTsNPldLrjvbGZlzbaqzJURjIJko xjHDaJgkIwsrvp+B20TGPocsXwtyyGi9vc1CgwxM7cNsZHOuQ5HAuRs2nntCtnXJmpHm gIag== X-Gm-Message-State: AOAM5312kBsPYNh0pp/qVqfLdsKiVVI/Kk++xaR304JYUbuZ92HV8UFD eoiPf3Za2NY1J9w2k9VmZvhj+M+7oUeTP67mdTs= X-Google-Smtp-Source: ABdhPJzBAjIJ/bWhTBjQlovjTGFiTqWvWgSvsp2xnthBIu2Xzx4vXVzEqaIo6lVNO66mFWxCZ6tswhnESYJYESjQ83Q= X-Received: by 2002:a17:90a:3e48:b0:1cd:34ec:c72f with SMTP id t8-20020a17090a3e4800b001cd34ecc72fmr9897582pjm.65.1650539456849; Thu, 21 Apr 2022 04:10:56 -0700 (PDT) MIME-Version: 1.0 References: <20220409042321.3184493-1-james.hilliard1@gmail.com> In-Reply-To: From: Patrik Jakobsson Date: Thu, 21 Apr 2022 13:10:44 +0200 Message-ID: Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer To: James Hilliard Cc: dri-devel , Randy Dunlap , David Airlie , Daniel Vetter , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 1:42 AM James Hilliard wrote: > > On Tue, Apr 12, 2022 at 3:30 AM Patrik Jakobsson > wrote: > > > > On Tue, Apr 12, 2022 at 3:48 AM James Hilliard > > wrote: > > > > > > On Mon, Apr 11, 2022 at 3:27 AM Patrik Jakobsson > > > wrote: > > > > > > > > On Sun, Apr 10, 2022 at 10:05 PM James Hilliard > > > > wrote: > > > > > > > > > > On Sun, Apr 10, 2022 at 1:52 PM Patrik Jakobsson > > > > > wrote: > > > > > > > > > > > > On Sun, Apr 10, 2022 at 9:40 PM James Hilliard > > > > > > wrote: > > > > > > > > > > > > > > On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson > > > > > > > wrote: > > > > > > > > > > > > > > > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard wrote: > > > > > > > > > > > > > > > > > > Select the efi framebuffer if efi is enabled. > > > > > > > > > > > > > > > > > > This appears to be needed for video output to function correctly. > > > > > > > > > > > > > > > > > > Signed-off-by: James Hilliard > > > > > > > > > > > > > > > > Hi James, > > > > > > > > EFI_FB is its own driver and not needed by gma500 to drive its > > > > > > > > hardware. What makes you think it's required? > > > > > > > > > > > > > > I wasn't getting any HDMI video output without it enabled for some reason, > > > > > > > I assume it is doing some sort of initialization needed by gma500 > > > > > > > during startup. > > > > > > > > > > > > Then it sounds like you might just be using EFI_FB and not gma500. Can > > > > > > you provide the kernel log with drm.debug=0x1f set on kernel > > > > > > command-line. > > > > > > > > > > Seems efifb loads first and then hands off to gma500 > > > > > > > > That is how it normally works but efifb shouldn't change the state of > > > > the currently set mode so shouldn't affect gma500. > > > > From the logs I can see that you have LVDS (internal panel), HDMI and > > > > DP (3 displays in total) connected. This sounds wrong. Your version of > > > > gma500 (Cedarview) doesn't support more than 2 crtcs/pipes. This might > > > > be a problem. > > > > > > Yeah, there's a bug there with the connector status, only DVI-D-1 is actually > > > connected, I have DP-2 and LVDS-1 turned off in weston. > > > > Ok, but are the connectors physically connected to anything? > > There is one HDMI cable physically connected to the board > > > Regardless of what you do in Weston, the connectors shouldn't be > > getting modes if they aren't used. > > Yeah, it seems there's a bug there, not sure if that's related to the > output failure when efifb isn't available. > > > LVDS might be from VBIOS but I'm > > not sure where the DP modes come from. It would help if you also > > provide kernel logs with drm.debug=0x1f when the outputs doesn't work > > so I have something to compare with. > > Log with efifb/fb not enabled in kernel build which causes no > HDMI output: After examining the logs I cannot see anything that stands out except for fbdev emulation not being enabled. Are you sure you just don't need to compile your kernel with FB support (CONFIG_FB)? If you are running weston on the fbdev backend then you would obviously not get any output if FB is not compiled into the kernel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC109C433F5 for ; Thu, 21 Apr 2022 11:10:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0507F10E7A6; Thu, 21 Apr 2022 11:10:58 +0000 (UTC) Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B36410E7D1 for ; Thu, 21 Apr 2022 11:10:57 +0000 (UTC) Received: by mail-pl1-x635.google.com with SMTP id h12so850872plf.12 for ; Thu, 21 Apr 2022 04:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5mDQNWE6CHbxD5RppFkYKwLi4HSMIbAeHaJuTv1BRD0=; b=joxbRWZL34N6wRmRFL2QNDESl9kKHHoFkc1TBgwu+vOWLqbwgebGY0J7IWsC8OOslo 63Zae0O30/OtzO36UDhvAdh8gyewNzrbrj2obOs5mJwZTZZsbAHk2npZU7hsVtoaO3x2 osrwOz0/jFx4rLKbiqrQ1wEq2YachOZLh966JhbWuH8gjTffQrekJ3eBKgJCUmE64rJX s+2+D906rSGh3+yZhvBMg8eHbyKPjRqzEPLUNKw3Ad2C+rvo5u32rrihqSq1I32gBSAj sqNWvJkqyMVWRCAZFcrcP8AhKgjGrFGuwbVweJEva+dzwMuDJFrWQiNW65CtqbBgjZ/o bKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5mDQNWE6CHbxD5RppFkYKwLi4HSMIbAeHaJuTv1BRD0=; b=COge8GAxd5Y+vkHEXaFllsoWPj6O4EDJ7lCZihG0Uz+5izPdsStA4v0/73VQyJisKP Wcps1qD7IATT21ZmHDzKLjmn2TkgbbRC1gSChlNBHRusqUvLpBSNYqVzuNxwBE2sKqUU JRjyNwBfGvTnua5KiLSvQdTtBVuut4T4g++Wl5f8BDdlJTVA+4VHbvI5lJZNxYXJJsAY F4Udiol6QnLtonm64shOz4V1grJVqGRUxDowL1AxZKScJp/qIHF88a2PDyjlGj81u6we a51w/DmVo/rGVMNw3GzJRwebekT8M6Gc+FfO+7XsggMkd60PPNsulw5EVqURFaAVNJpN tkkQ== X-Gm-Message-State: AOAM533ge3QxWgG8nD1MyKeERotsBYtgBPH7eZYpEZ6CeTXoWaWzNr6t aOLxLq2GxXjJQQXfz25HfhjL9sF7G1aGapYybso= X-Google-Smtp-Source: ABdhPJzBAjIJ/bWhTBjQlovjTGFiTqWvWgSvsp2xnthBIu2Xzx4vXVzEqaIo6lVNO66mFWxCZ6tswhnESYJYESjQ83Q= X-Received: by 2002:a17:90a:3e48:b0:1cd:34ec:c72f with SMTP id t8-20020a17090a3e4800b001cd34ecc72fmr9897582pjm.65.1650539456849; Thu, 21 Apr 2022 04:10:56 -0700 (PDT) MIME-Version: 1.0 References: <20220409042321.3184493-1-james.hilliard1@gmail.com> In-Reply-To: From: Patrik Jakobsson Date: Thu, 21 Apr 2022 13:10:44 +0200 Message-ID: Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer To: James Hilliard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Randy Dunlap , dri-devel , linux-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 20, 2022 at 1:42 AM James Hilliard wrote: > > On Tue, Apr 12, 2022 at 3:30 AM Patrik Jakobsson > wrote: > > > > On Tue, Apr 12, 2022 at 3:48 AM James Hilliard > > wrote: > > > > > > On Mon, Apr 11, 2022 at 3:27 AM Patrik Jakobsson > > > wrote: > > > > > > > > On Sun, Apr 10, 2022 at 10:05 PM James Hilliard > > > > wrote: > > > > > > > > > > On Sun, Apr 10, 2022 at 1:52 PM Patrik Jakobsson > > > > > wrote: > > > > > > > > > > > > On Sun, Apr 10, 2022 at 9:40 PM James Hilliard > > > > > > wrote: > > > > > > > > > > > > > > On Sun, Apr 10, 2022 at 1:36 PM Patrik Jakobsson > > > > > > > wrote: > > > > > > > > > > > > > > > > On Sat, Apr 9, 2022 at 6:23 AM James Hilliard wrote: > > > > > > > > > > > > > > > > > > Select the efi framebuffer if efi is enabled. > > > > > > > > > > > > > > > > > > This appears to be needed for video output to function correctly. > > > > > > > > > > > > > > > > > > Signed-off-by: James Hilliard > > > > > > > > > > > > > > > > Hi James, > > > > > > > > EFI_FB is its own driver and not needed by gma500 to drive its > > > > > > > > hardware. What makes you think it's required? > > > > > > > > > > > > > > I wasn't getting any HDMI video output without it enabled for some reason, > > > > > > > I assume it is doing some sort of initialization needed by gma500 > > > > > > > during startup. > > > > > > > > > > > > Then it sounds like you might just be using EFI_FB and not gma500. Can > > > > > > you provide the kernel log with drm.debug=0x1f set on kernel > > > > > > command-line. > > > > > > > > > > Seems efifb loads first and then hands off to gma500 > > > > > > > > That is how it normally works but efifb shouldn't change the state of > > > > the currently set mode so shouldn't affect gma500. > > > > From the logs I can see that you have LVDS (internal panel), HDMI and > > > > DP (3 displays in total) connected. This sounds wrong. Your version of > > > > gma500 (Cedarview) doesn't support more than 2 crtcs/pipes. This might > > > > be a problem. > > > > > > Yeah, there's a bug there with the connector status, only DVI-D-1 is actually > > > connected, I have DP-2 and LVDS-1 turned off in weston. > > > > Ok, but are the connectors physically connected to anything? > > There is one HDMI cable physically connected to the board > > > Regardless of what you do in Weston, the connectors shouldn't be > > getting modes if they aren't used. > > Yeah, it seems there's a bug there, not sure if that's related to the > output failure when efifb isn't available. > > > LVDS might be from VBIOS but I'm > > not sure where the DP modes come from. It would help if you also > > provide kernel logs with drm.debug=0x1f when the outputs doesn't work > > so I have something to compare with. > > Log with efifb/fb not enabled in kernel build which causes no > HDMI output: After examining the logs I cannot see anything that stands out except for fbdev emulation not being enabled. Are you sure you just don't need to compile your kernel with FB support (CONFIG_FB)? If you are running weston on the fbdev backend then you would obviously not get any output if FB is not compiled into the kernel.