From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D61D9CA9EA0 for ; Tue, 22 Oct 2019 15:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB476214E0 for ; Tue, 22 Oct 2019 15:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UcYTz4a7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388928AbfJVPx6 (ORCPT ); Tue, 22 Oct 2019 11:53:58 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:38221 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388866AbfJVPx6 (ORCPT ); Tue, 22 Oct 2019 11:53:58 -0400 Received: by mail-lj1-f193.google.com with SMTP id q78so2627604lje.5 for ; Tue, 22 Oct 2019 08:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BhtC62v3n6zmy08FKulqslkQbjt/OC56JJA6sqKbbEI=; b=UcYTz4a7WI8YJuFZ85FxcekxfaPXLr7TxsJ2U6KWML5x+HxuEl2IvCvKhALdV3vz/S iSXd9yW+BB/SRFFZO2moBPElSPog8UZfyOYp/+a30LMJEWBpMaxU5Xq9PcLjK/ol0fY1 VmRkXk6iYklRWmO5pNt9bgmgzaL8I9njwDTEZgaQmEUV8xiMCGTQNoaTVO/Udd2lCga4 NJH6KxJyXm42dj8KjH+XBPxv5NxF0a2WlJywFVd4q7ztJrC5xV9xfXfGFKKrr66FgMSM x8w4TyqkvdtyLq3TlHmWDkI6UEjblKeTOCGZ9az8QUsLKez0b9G5miqI6gjHN4gIPmzq iJ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BhtC62v3n6zmy08FKulqslkQbjt/OC56JJA6sqKbbEI=; b=jBktcsLG5GTirp5shqXj5pqo36KJXqjVDx8A24Y2Xzq0/2o7ODWSNFwDpzix3aXLmM PMdPTwr6bunZXKtSzFF1ZdbnfUNKXboaKHAManFQhd9EdFlfiw3CKfkIuCYHR74Nemc3 bAa21kQxRsqiwwFyI1d9DBpDqXTapniMEcOYbDbQUJSU/hcqXIErInepWpBqq/EFF9tA lHe3Soxsk6S/4AFt9YREvojY25J8to1y0aGTTRfYg1ia7kNmkMZRfGqL9nw85eZKlEPh ojbAa3n6zykdbGzzyBIVvNnz0vtIhLpifB/fPn/a/tZvjndQ3lE1rDwXN9tkkbR0UyCJ gWqw== X-Gm-Message-State: APjAAAVwBnQ/9K9j4E6ViulcpsH7fB2YPWDesVvopXGjGctBMXvylFF2 lx4NyVvpiGYaSaajPNE5w0Ta8ZKZeyoWrAe1PrY= X-Google-Smtp-Source: APXvYqwMAh2Xf8XGTmUZ0oAFhZ+aXz7e3Xm4is5aYh8CbOVrKF19FvuDYEfcrvLjMVfNISfByHZYxzhm66qKmBvqX7E= X-Received: by 2002:a2e:8417:: with SMTP id z23mr19232916ljg.46.1571759635304; Tue, 22 Oct 2019 08:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com> <87lftdfb4c.fsf@intel.com> <20191022084423.GB1531961@ulmo> <87imohf6rf.fsf@intel.com> In-Reply-To: <87imohf6rf.fsf@intel.com> From: Patrik Jakobsson Date: Tue, 22 Oct 2019 17:53:44 +0200 Message-ID: Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS To: Jani Nikula Cc: Thierry Reding , dri-devel , Thierry Reding , David Airlie , Sean Paul , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula wrote: > > On Tue, 22 Oct 2019, Thierry Reding wrote: > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > >> On Wed, 16 Oct 2019, Patrik Jakobsson wrote: > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > >> > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > >> Cc: Thierry Reding > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > used anywhere, so technically there's no bug. > > Yeah well, I just logged it here as I happened to do the drive-by git > blame. I think we can skip the fixes tag here. Thanks for review! Did anyone apply this or can I take it through drm-misc-next? -Patrik > > BR, > Jani. > > > > > > > Thierry > > > >> > >> > Signed-off-by: Patrik Jakobsson > >> > --- > >> > include/drm/drm_scdc_helper.h | 6 +++--- > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > >> > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > >> > index f92eb2094d6b..6a483533aae4 100644 > >> > --- a/include/drm/drm_scdc_helper.h > >> > +++ b/include/drm/drm_scdc_helper.h > >> > @@ -50,9 +50,9 @@ > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > >> > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > >> > -#define SCDC_CH2_LOCK (1 < 3) > >> > -#define SCDC_CH1_LOCK (1 < 2) > >> > -#define SCDC_CH0_LOCK (1 < 1) > >> > +#define SCDC_CH2_LOCK (1 << 3) > >> > +#define SCDC_CH1_LOCK (1 << 2) > >> > +#define SCDC_CH0_LOCK (1 << 1) > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > >> > #define SCDC_CLOCK_DETECT (1 << 0) > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrik Jakobsson Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Date: Tue, 22 Oct 2019 17:53:44 +0200 Message-ID: References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com> <87lftdfb4c.fsf@intel.com> <20191022084423.GB1531961@ulmo> <87imohf6rf.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 36F426E85E for ; Tue, 22 Oct 2019 15:53:57 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id v24so17772198ljj.3 for ; Tue, 22 Oct 2019 08:53:57 -0700 (PDT) In-Reply-To: <87imohf6rf.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: David Airlie , linux-kernel , dri-devel , Thierry Reding , Thierry Reding , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMjIsIDIwMTkgYXQgMTE6NTEgQU0gSmFuaSBOaWt1bGEKPGphbmkubmlrdWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4KPiBPbiBUdWUsIDIyIE9jdCAyMDE5LCBUaGllcnJ5 IFJlZGluZyA8dGhpZXJyeS5yZWRpbmdAZ21haWwuY29tPiB3cm90ZToKPiA+IE9uIFR1ZSwgT2N0 IDIyLCAyMDE5IGF0IDExOjE2OjUxQU0gKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4+IE9u IFdlZCwgMTYgT2N0IDIwMTksIFBhdHJpayBKYWtvYnNzb24gPHBhdHJpay5yLmpha29ic3NvbkBn bWFpbC5jb20+IHdyb3RlOgo+ID4+ID4gRml4IHR5cG8gd2hlcmUgYml0cyBnb3QgY29tcGFyZWQg KHggPCB5KSBpbnN0ZWFkIG9mIHNoaWZ0ZWQgKHggPDwgeSkuCj4gPj4KPiA+PiBGaXhlczogM2Fk MzNhZTJiYzgwICgiZHJtOiBBZGQgU0NEQyBoZWxwZXJzIikKPiA+PiBDYzogVGhpZXJyeSBSZWRp bmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiA+Cj4gPiBJJ20gbm90IHN1cmUgd2UgcmVhbGx5IG5l ZWQgdGhlIEZpeGVzOiB0YWcgaGVyZS4gVGhlc2UgZGVmaW5lcyBhcmVuJ3QKPiA+IHVzZWQgYW55 d2hlcmUsIHNvIHRlY2huaWNhbGx5IHRoZXJlJ3Mgbm8gYnVnLgo+Cj4gWWVhaCB3ZWxsLCBJIGp1 c3QgbG9nZ2VkIGl0IGhlcmUgYXMgSSBoYXBwZW5lZCB0byBkbyB0aGUgZHJpdmUtYnkgZ2l0Cj4g YmxhbWUuCgpJIHRoaW5rIHdlIGNhbiBza2lwIHRoZSBmaXhlcyB0YWcgaGVyZS4gVGhhbmtzIGZv ciByZXZpZXchCgpEaWQgYW55b25lIGFwcGx5IHRoaXMgb3IgY2FuIEkgdGFrZSBpdCB0aHJvdWdo IGRybS1taXNjLW5leHQ/CgotUGF0cmlrCgo+Cj4gQlIsCj4gSmFuaS4KPgo+Cj4KPiA+Cj4gPiBU aGllcnJ5Cj4gPgo+ID4+Cj4gPj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXRyaWsgSmFrb2Jzc29uIDxw YXRyaWsuci5qYWtvYnNzb25AZ21haWwuY29tPgo+ID4+ID4gLS0tCj4gPj4gPiAgaW5jbHVkZS9k cm0vZHJtX3NjZGNfaGVscGVyLmggfCA2ICsrKy0tLQo+ID4+ID4gIDEgZmlsZSBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPj4gPgo+ID4+ID4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvZHJtL2RybV9zY2RjX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX3NjZGNfaGVs cGVyLmgKPiA+PiA+IGluZGV4IGY5MmViMjA5NGQ2Yi4uNmE0ODM1MzNhYWU0IDEwMDY0NAo+ID4+ ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3NjZGNfaGVscGVyLmgKPiA+PiA+ICsrKyBiL2luY2x1 ZGUvZHJtL2RybV9zY2RjX2hlbHBlci5oCj4gPj4gPiBAQCAtNTAsOSArNTAsOSBAQAo+ID4+ID4g ICNkZWZpbmUgIFNDRENfUkVBRF9SRVFVRVNUX0VOQUJMRSAoMSA8PCAwKQo+ID4+ID4KPiA+PiA+ ICAjZGVmaW5lIFNDRENfU1RBVFVTX0ZMQUdTXzAgMHg0MAo+ID4+ID4gLSNkZWZpbmUgIFNDRENf Q0gyX0xPQ0sgKDEgPCAzKQo+ID4+ID4gLSNkZWZpbmUgIFNDRENfQ0gxX0xPQ0sgKDEgPCAyKQo+ ID4+ID4gLSNkZWZpbmUgIFNDRENfQ0gwX0xPQ0sgKDEgPCAxKQo+ID4+ID4gKyNkZWZpbmUgIFND RENfQ0gyX0xPQ0sgKDEgPDwgMykKPiA+PiA+ICsjZGVmaW5lICBTQ0RDX0NIMV9MT0NLICgxIDw8 IDIpCj4gPj4gPiArI2RlZmluZSAgU0NEQ19DSDBfTE9DSyAoMSA8PCAxKQo+ID4+ID4gICNkZWZp bmUgIFNDRENfQ0hfTE9DS19NQVNLIChTQ0RDX0NIMl9MT0NLIHwgU0NEQ19DSDFfTE9DSyB8IFND RENfQ0gwX0xPQ0spCj4gPj4gPiAgI2RlZmluZSAgU0NEQ19DTE9DS19ERVRFQ1QgKDEgPDwgMCkK PiA+Pgo+ID4+IC0tCj4gPj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNz IENlbnRlcgo+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiA+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo+Cj4gLS0KPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2Ug R3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA==