From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023A1CA9ECF for ; Mon, 4 Nov 2019 17:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEC4A2080F for ; Mon, 4 Nov 2019 17:05:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="geeqURtu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbfKDRFf (ORCPT ); Mon, 4 Nov 2019 12:05:35 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:41749 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728216AbfKDRFf (ORCPT ); Mon, 4 Nov 2019 12:05:35 -0500 Received: by mail-lj1-f196.google.com with SMTP id m9so18445792ljh.8 for ; Mon, 04 Nov 2019 09:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4qJiFRAU1ANgQBEoCGJorJXFwWND9KhJu4ptLqqShZY=; b=geeqURtuQ0iMZyZU2JHAx0IIgyNxihwJ/tz8LlMhNGKscQrPvXfVI8M1H/YMxQWlFT qF16TQZ6/ZmOk8D9ptBrhEfRY5oamsNqOKOni0Gs51K/BAbboo/7TXPH9ivalonLHLUf DUEm+AD37BwvxAT03Aa2Po2MXd0Rerh4qM+7/4IYIv/6zP/OrZsfVnmUuWTwTeD/MgGu siSUtozk/md7BLOwWuE1gpANrNX2/T6ZV5bYQC7F04frd7IH/HozwBNqMkfvhYfYBANf ckkDHSv+dNqQAFmUDUIq9zbRBZFTjTtBWOtVzV/XQe5btPcwmCDS2RIL9zeX8C2Rg6Wl q3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4qJiFRAU1ANgQBEoCGJorJXFwWND9KhJu4ptLqqShZY=; b=BDmN4mt0dHNke7UjHBYbqPq7fuyds+gche2/8x4/3Ubf6+mob8SREFdMSKbr+ziWkg mvjAY8BkyIhLSbH035fVMwBzhhONwoPisVnFpLQYexAzoTasZzOZpc7PV4+Vb4wA4xgG 1RbVldCo4T606g2sjzBGjMSUacEct9V0U5n0QBio0fxJ2omEtuitsiY5BGZL13qQZVih owdY8B2iNoabp7xIRAGn+agu05BjkaKimkXifA+rQ8bNqAb2xoQ3lOwiareR3O8VbL5Q jCMaEknB7h28ULC3A+wRDTLjlP/HpqF9i4yFy3zqo8kiqBG+s75W4Z6UJVC2fYCmyXyt 8qnQ== X-Gm-Message-State: APjAAAVS0RGmlIsm40vkFUxeUAYxOCgIeGxugf410klDTZ68nIeoumxy 1xks3DSk4cFuU3dnXeEwaz+m6tDl70ckdFyLDoQ= X-Google-Smtp-Source: APXvYqwJDCfSR1r8hM4MJdBNSycomr3d/Yl4nSIe1J1+qFv3cbMoiF0nRwJfSkMA4D4BnhqwxP5Me1aU8/u2x0tDkVQ= X-Received: by 2002:a2e:9e45:: with SMTP id g5mr2776409ljk.58.1572887131574; Mon, 04 Nov 2019 09:05:31 -0800 (PST) MIME-Version: 1.0 References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com> <87lftdfb4c.fsf@intel.com> <20191022084423.GB1531961@ulmo> <87imohf6rf.fsf@intel.com> In-Reply-To: From: Patrik Jakobsson Date: Mon, 4 Nov 2019 18:05:20 +0100 Message-ID: Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS To: Jani Nikula Cc: Thierry Reding , dri-devel , Thierry Reding , David Airlie , Sean Paul , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 5:53 PM Patrik Jakobsson wrote: > > On Tue, Oct 22, 2019 at 11:51 AM Jani Nikula > wrote: > > > > On Tue, 22 Oct 2019, Thierry Reding wrote: > > > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: > > >> On Wed, 16 Oct 2019, Patrik Jakobsson wrote: > > >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). > > >> > > >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") > > >> Cc: Thierry Reding > > > > > > I'm not sure we really need the Fixes: tag here. These defines aren't > > > used anywhere, so technically there's no bug. > > > > Yeah well, I just logged it here as I happened to do the drive-by git > > blame. > > I think we can skip the fixes tag here. Thanks for review! > > Did anyone apply this or can I take it through drm-misc-next? > > -Patrik Applied to drm-misc-next > > > > > BR, > > Jani. > > > > > > > > > > > > Thierry > > > > > >> > > >> > Signed-off-by: Patrik Jakobsson > > >> > --- > > >> > include/drm/drm_scdc_helper.h | 6 +++--- > > >> > 1 file changed, 3 insertions(+), 3 deletions(-) > > >> > > > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h > > >> > index f92eb2094d6b..6a483533aae4 100644 > > >> > --- a/include/drm/drm_scdc_helper.h > > >> > +++ b/include/drm/drm_scdc_helper.h > > >> > @@ -50,9 +50,9 @@ > > >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) > > >> > > > >> > #define SCDC_STATUS_FLAGS_0 0x40 > > >> > -#define SCDC_CH2_LOCK (1 < 3) > > >> > -#define SCDC_CH1_LOCK (1 < 2) > > >> > -#define SCDC_CH0_LOCK (1 < 1) > > >> > +#define SCDC_CH2_LOCK (1 << 3) > > >> > +#define SCDC_CH1_LOCK (1 << 2) > > >> > +#define SCDC_CH0_LOCK (1 << 1) > > >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) > > >> > #define SCDC_CLOCK_DETECT (1 << 0) > > >> > > >> -- > > >> Jani Nikula, Intel Open Source Graphics Center > > >> _______________________________________________ > > >> dri-devel mailing list > > >> dri-devel@lists.freedesktop.org > > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1562CA9EB5 for ; Mon, 4 Nov 2019 17:05:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FB372080F for ; Mon, 4 Nov 2019 17:05:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FB372080F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B10546E626; Mon, 4 Nov 2019 17:05:34 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 393066E626 for ; Mon, 4 Nov 2019 17:05:33 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id v2so18480138lji.4 for ; Mon, 04 Nov 2019 09:05:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4qJiFRAU1ANgQBEoCGJorJXFwWND9KhJu4ptLqqShZY=; b=ILpiXpR9HTWRjrcm1210vJTP9TO6R7wkPJo+Pm+/Ay/C/G5phYBkSR5xUGPHpELhP1 cqjWaH3byFVrsgT0zUAxOBC17g80UiYSiiacK5Oo6Es1DxPDIWVEmuHjl39AWJCrKQOt PYYOzY/aekWWNy/Yt2xqohZ200wZqf7vWizVc+N/ozvOvI0WksqbefgL7nbnLnNPx8Yq ezoMfB+KvYp/nM/TbbTaRWI28XxSrdcjnM+5PqzsPhhVz//00OFOlBaHDYZnt+Hp5VQ1 OhcYzs4OJmcp2ntOy02W8q5Bttc79r8KSLgCmEFfMPaa00PguKT7FzFkppBasgpOHzrS yafQ== X-Gm-Message-State: APjAAAWagmBeWdLHG0Iy+1YBxzQYBXc+7xufrdg+cBT9V2ytn0wDWoJ5 Z1g5TfcWMsuGR8mffhomSRwc+VTHV9ph3ZhJQi8= X-Google-Smtp-Source: APXvYqwJDCfSR1r8hM4MJdBNSycomr3d/Yl4nSIe1J1+qFv3cbMoiF0nRwJfSkMA4D4BnhqwxP5Me1aU8/u2x0tDkVQ= X-Received: by 2002:a2e:9e45:: with SMTP id g5mr2776409ljk.58.1572887131574; Mon, 04 Nov 2019 09:05:31 -0800 (PST) MIME-Version: 1.0 References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com> <87lftdfb4c.fsf@intel.com> <20191022084423.GB1531961@ulmo> <87imohf6rf.fsf@intel.com> In-Reply-To: From: Patrik Jakobsson Date: Mon, 4 Nov 2019 18:05:20 +0100 Message-ID: Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS To: Jani Nikula X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4qJiFRAU1ANgQBEoCGJorJXFwWND9KhJu4ptLqqShZY=; b=geeqURtuQ0iMZyZU2JHAx0IIgyNxihwJ/tz8LlMhNGKscQrPvXfVI8M1H/YMxQWlFT qF16TQZ6/ZmOk8D9ptBrhEfRY5oamsNqOKOni0Gs51K/BAbboo/7TXPH9ivalonLHLUf DUEm+AD37BwvxAT03Aa2Po2MXd0Rerh4qM+7/4IYIv/6zP/OrZsfVnmUuWTwTeD/MgGu siSUtozk/md7BLOwWuE1gpANrNX2/T6ZV5bYQC7F04frd7IH/HozwBNqMkfvhYfYBANf ckkDHSv+dNqQAFmUDUIq9zbRBZFTjTtBWOtVzV/XQe5btPcwmCDS2RIL9zeX8C2Rg6Wl q3Rw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel , dri-devel , Thierry Reding , Thierry Reding , Sean Paul Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191104170520.rLnWXniqdZcN9XLb68yhXAGT8O0ZJ3xdaVinn5Otr4Q@z> T24gVHVlLCBPY3QgMjIsIDIwMTkgYXQgNTo1MyBQTSBQYXRyaWsgSmFrb2Jzc29uCjxwYXRyaWsu ci5qYWtvYnNzb25AZ21haWwuY29tPiB3cm90ZToKPgo+IE9uIFR1ZSwgT2N0IDIyLCAyMDE5IGF0 IDExOjUxIEFNIEphbmkgTmlrdWxhCj4gPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4gd3Jv dGU6Cj4gPgo+ID4gT24gVHVlLCAyMiBPY3QgMjAxOSwgVGhpZXJyeSBSZWRpbmcgPHRoaWVycnku cmVkaW5nQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgT2N0IDIyLCAyMDE5IGF0IDEx OjE2OjUxQU0gKzAzMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+ID4gPj4gT24gV2VkLCAxNiBPY3Qg MjAxOSwgUGF0cmlrIEpha29ic3NvbiA8cGF0cmlrLnIuamFrb2Jzc29uQGdtYWlsLmNvbT4gd3Jv dGU6Cj4gPiA+PiA+IEZpeCB0eXBvIHdoZXJlIGJpdHMgZ290IGNvbXBhcmVkICh4IDwgeSkgaW5z dGVhZCBvZiBzaGlmdGVkICh4IDw8IHkpLgo+ID4gPj4KPiA+ID4+IEZpeGVzOiAzYWQzM2FlMmJj ODAgKCJkcm06IEFkZCBTQ0RDIGhlbHBlcnMiKQo+ID4gPj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0 cmVkaW5nQG52aWRpYS5jb20+Cj4gPiA+Cj4gPiA+IEknbSBub3Qgc3VyZSB3ZSByZWFsbHkgbmVl ZCB0aGUgRml4ZXM6IHRhZyBoZXJlLiBUaGVzZSBkZWZpbmVzIGFyZW4ndAo+ID4gPiB1c2VkIGFu eXdoZXJlLCBzbyB0ZWNobmljYWxseSB0aGVyZSdzIG5vIGJ1Zy4KPiA+Cj4gPiBZZWFoIHdlbGws IEkganVzdCBsb2dnZWQgaXQgaGVyZSBhcyBJIGhhcHBlbmVkIHRvIGRvIHRoZSBkcml2ZS1ieSBn aXQKPiA+IGJsYW1lLgo+Cj4gSSB0aGluayB3ZSBjYW4gc2tpcCB0aGUgZml4ZXMgdGFnIGhlcmUu IFRoYW5rcyBmb3IgcmV2aWV3IQo+Cj4gRGlkIGFueW9uZSBhcHBseSB0aGlzIG9yIGNhbiBJIHRh a2UgaXQgdGhyb3VnaCBkcm0tbWlzYy1uZXh0Pwo+Cj4gLVBhdHJpawoKQXBwbGllZCB0byBkcm0t bWlzYy1uZXh0Cgo+Cj4gPgo+ID4gQlIsCj4gPiBKYW5pLgo+ID4KPiA+Cj4gPgo+ID4gPgo+ID4g PiBUaGllcnJ5Cj4gPiA+Cj4gPiA+Pgo+ID4gPj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXRyaWsgSmFr b2Jzc29uIDxwYXRyaWsuci5qYWtvYnNzb25AZ21haWwuY29tPgo+ID4gPj4gPiAtLS0KPiA+ID4+ ID4gIGluY2x1ZGUvZHJtL2RybV9zY2RjX2hlbHBlci5oIHwgNiArKystLS0KPiA+ID4+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiA+PiA+Cj4g PiA+PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2RybS9kcm1fc2NkY19oZWxwZXIuaCBiL2luY2x1 ZGUvZHJtL2RybV9zY2RjX2hlbHBlci5oCj4gPiA+PiA+IGluZGV4IGY5MmViMjA5NGQ2Yi4uNmE0 ODM1MzNhYWU0IDEwMDY0NAo+ID4gPj4gPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fc2NkY19oZWxw ZXIuaAo+ID4gPj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1fc2NkY19oZWxwZXIuaAo+ID4gPj4g PiBAQCAtNTAsOSArNTAsOSBAQAo+ID4gPj4gPiAgI2RlZmluZSAgU0NEQ19SRUFEX1JFUVVFU1Rf RU5BQkxFICgxIDw8IDApCj4gPiA+PiA+Cj4gPiA+PiA+ICAjZGVmaW5lIFNDRENfU1RBVFVTX0ZM QUdTXzAgMHg0MAo+ID4gPj4gPiAtI2RlZmluZSAgU0NEQ19DSDJfTE9DSyAoMSA8IDMpCj4gPiA+ PiA+IC0jZGVmaW5lICBTQ0RDX0NIMV9MT0NLICgxIDwgMikKPiA+ID4+ID4gLSNkZWZpbmUgIFND RENfQ0gwX0xPQ0sgKDEgPCAxKQo+ID4gPj4gPiArI2RlZmluZSAgU0NEQ19DSDJfTE9DSyAoMSA8 PCAzKQo+ID4gPj4gPiArI2RlZmluZSAgU0NEQ19DSDFfTE9DSyAoMSA8PCAyKQo+ID4gPj4gPiAr I2RlZmluZSAgU0NEQ19DSDBfTE9DSyAoMSA8PCAxKQo+ID4gPj4gPiAgI2RlZmluZSAgU0NEQ19D SF9MT0NLX01BU0sgKFNDRENfQ0gyX0xPQ0sgfCBTQ0RDX0NIMV9MT0NLIHwgU0NEQ19DSDBfTE9D SykKPiA+ID4+ID4gICNkZWZpbmUgIFNDRENfQ0xPQ0tfREVURUNUICgxIDw8IDApCj4gPiA+Pgo+ ID4gPj4gLS0KPiA+ID4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBD ZW50ZXIKPiA+ID4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiA+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+PiBkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gPiA+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+ID4KPiA+IC0tCj4gPiBKYW5pIE5pa3VsYSwgSW50ZWwg T3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbA==