From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrik Jakobsson Subject: Re: [PATCH 26/50] drm/gma500: Remove dead code Date: Wed, 11 Dec 2013 11:46:15 +0100 Message-ID: References: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch> <1386758111-3446-27-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vb0-f45.google.com (mail-vb0-f45.google.com [209.85.212.45]) by gabe.freedesktop.org (Postfix) with ESMTP id DCC8BFB590 for ; Wed, 11 Dec 2013 02:46:15 -0800 (PST) Received: by mail-vb0-f45.google.com with SMTP id i12so1468000vbh.4 for ; Wed, 11 Dec 2013 02:46:15 -0800 (PST) In-Reply-To: <1386758111-3446-27-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development , Alan Cox List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 11, 2013 at 11:34 AM, Daniel Vetter wrote: > This has the nice advantage that we'll get rid of a DRM_WAIT_ON user > for free. > > Cc: Patrik Jakobsson > Cc: Alan Cox > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/gma500/psb_irq.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c > index a9bb34704738..f883f9e4c524 100644 > --- a/drivers/gpu/drm/gma500/psb_irq.c > +++ b/drivers/gpu/drm/gma500/psb_irq.c > @@ -450,21 +450,6 @@ int psb_irq_disable_dpst(struct drm_device *dev) > return 0; > } > > -#ifdef PSB_FIXME > -static int psb_vblank_do_wait(struct drm_device *dev, > - unsigned int *sequence, atomic_t *counter) > -{ > - unsigned int cur_vblank; > - int ret = 0; > - DRM_WAIT_ON(ret, dev->vblank.queue, 3 * HZ, > - (((cur_vblank = atomic_read(counter)) > - - *sequence) <= (1 << 23))); > - *sequence = cur_vblank; > - > - return ret; > -} > -#endif > - > /* > * It is used to enable VBLANK interrupt > */ > -- > 1.8.4.3 > Yes, that can just go away. Thanks. Acked-by: Patrik Jakobsson