From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EACCDC433F5 for ; Thu, 21 Apr 2022 12:39:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DA9210E106; Thu, 21 Apr 2022 12:39:22 +0000 (UTC) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85A7910E106 for ; Thu, 21 Apr 2022 12:39:20 +0000 (UTC) Received: by mail-pl1-x631.google.com with SMTP id n8so4745918plh.1 for ; Thu, 21 Apr 2022 05:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nssjfya3+9VTlrQeOXbk1Fnunfs1cJh58vKzBuqD+5w=; b=pIeQUahUEw73/0XELeSGeveLsVNRSo3mUBldB2hgxa51jomlq8h+OiyitGRnWJ+4BK Bvwc7ENq6ZVhtbzcIxC52/o3UeA3ag5bciQsHqThadcTnSmQFJPT9i5NHauFMmNkMZND 27haqYujf2wKniMfksGkGof29htMzGVVzPhNzDu5YhaeO3By25BLa3LZILWbm7Hg8X8z 9W1g/5HjhR2uOiRGl2pLNsAOGzQON1T7vHNHiAmGOSOA1Th3j7uZpzCfm6u7zse/hG91 D1xLqeRFu1Bfufg+PxXA044rlFO2dp6PsGX/J9yHFtOS7rX06qTnS1b2M9FTyUV2IotV uPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nssjfya3+9VTlrQeOXbk1Fnunfs1cJh58vKzBuqD+5w=; b=sxs6fewH8jJZAlt4gYJ7E/58eUJQeE4tFZNmqLGaQE2WFj5aMISFBC8YuYVV9LgWO2 HkOwnGKnxMrdRu+71zlDHrg8jqeb+C8QVLjtHCELvXxw2ETFvnfT1ZhZvntQ89oWvr1w 0Jj4ziKOZ2wuk9CRQhzWeRq0+oOJqf0SQOAkQuTLzNLHS2Jzi1hEKA/Ij+nsRKhNwZ/t HPEGnKOZJgnkF9x3K9fQ3DZpOuNe8LdSwEwSeD61QokroxBSt7vjrbzD9eH2H3WTPxdp QfL+HjCy/c6KT75ojI9UyFnauyewa0Q8TlWD5dHqwVjsVe4bAn5Wuj4mYMz5BzLT8+/q nbEQ== X-Gm-Message-State: AOAM531F1s2qDSUOAaXNIHiqkZSc/ai75cCcFodLa7OzLoPIq0BLOV7L 8G54qKwfpi9KVS41sigapzsyygHsBU1UnGsJeGk= X-Google-Smtp-Source: ABdhPJydPCqhqGo0Ypkm47vjMGBgOdnq/oMsB6raDz0GdtqLPYfAOOwVPepZ7ZvInejprP2fCo8W0387QvKQTPdm/yc= X-Received: by 2002:a17:90b:1a8a:b0:1d2:e93e:6604 with SMTP id ng10-20020a17090b1a8a00b001d2e93e6604mr10172088pjb.233.1650544760102; Thu, 21 Apr 2022 05:39:20 -0700 (PDT) MIME-Version: 1.0 References: <20220409042321.3184493-1-james.hilliard1@gmail.com> In-Reply-To: From: Patrik Jakobsson Date: Thu, 21 Apr 2022 14:39:08 +0200 Message-ID: Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer To: Thomas Zimmermann Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , James Hilliard , Randy Dunlap , linux-kernel , dri-devel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann wrote: > > Hi > > Am 09.04.22 um 06:23 schrieb James Hilliard: > > Select the efi framebuffer if efi is enabled. > > > > This appears to be needed for video output to function correctly. > > > > Signed-off-by: James Hilliard > > --- > > Changes v2 -> v3: > > - select EFI_FB instead of depending on it > > Changes v1 -> v2: > > - use depends instead of select > > --- > > drivers/gpu/drm/gma500/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 0cff20265f97..a422fa84d53b 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -2,11 +2,13 @@ > > config DRM_GMA500 > > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" > > depends on DRM && PCI && X86 && MMU > > + depends on FB > > Why do we need FB here? Framebuffer support should be hidden by DRM's > fbdev helpers. It is not needed but gives him video output since it enables the drm fbdev emulation. I looked some more at the logs and it seems weston doesn't work on his system without the fbdev backend. So the question is why weston isn't working without fbdev? Perhaps this is just a Weston configuration issue? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 563CCC433FE for ; Thu, 21 Apr 2022 12:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385008AbiDUMmN (ORCPT ); Thu, 21 Apr 2022 08:42:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358695AbiDUMmL (ORCPT ); Thu, 21 Apr 2022 08:42:11 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE35623BC4 for ; Thu, 21 Apr 2022 05:39:20 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id bx5so4859913pjb.3 for ; Thu, 21 Apr 2022 05:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nssjfya3+9VTlrQeOXbk1Fnunfs1cJh58vKzBuqD+5w=; b=pIeQUahUEw73/0XELeSGeveLsVNRSo3mUBldB2hgxa51jomlq8h+OiyitGRnWJ+4BK Bvwc7ENq6ZVhtbzcIxC52/o3UeA3ag5bciQsHqThadcTnSmQFJPT9i5NHauFMmNkMZND 27haqYujf2wKniMfksGkGof29htMzGVVzPhNzDu5YhaeO3By25BLa3LZILWbm7Hg8X8z 9W1g/5HjhR2uOiRGl2pLNsAOGzQON1T7vHNHiAmGOSOA1Th3j7uZpzCfm6u7zse/hG91 D1xLqeRFu1Bfufg+PxXA044rlFO2dp6PsGX/J9yHFtOS7rX06qTnS1b2M9FTyUV2IotV uPJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nssjfya3+9VTlrQeOXbk1Fnunfs1cJh58vKzBuqD+5w=; b=4QJmgon0k7F96C7I0XgqrTPQlScbdDLvErTYLQprQ0ivV3xzocjiNwZuwT+eD6T0c2 /SgLYbIZqCawpb7ZfbFBERvC/ViM/9C2/lB5Z/EfWs3KsPjQCNWhHEM1fTSBbvV+6SfM VQOB4U/m8lCu9tgksfiEFkcEWcetv3eSFBYwxFURpuAvAJbiNct0qtYjUeTepxrJN8Lp oGLsVGPXd/YlZPZgG0bXPgEpIQVEp/n23ZXBbh7rmcaK5FT6OGH0M9n4SyyvDvpx+3ds 7+sOXdwetUi5vq2i0KbZH5wbHcZiPggNNdiX5+fgQiO1ONoHPe6p1WQH7hdRln7P8ieQ BLfg== X-Gm-Message-State: AOAM5309pPhmtg5zpvORQdUGr/stJ17jsildFYnona0alljdthC0HBHd h3t7mw/Rohe9MMjhygkkShqzdDJwK6oQTPnsgtE= X-Google-Smtp-Source: ABdhPJydPCqhqGo0Ypkm47vjMGBgOdnq/oMsB6raDz0GdtqLPYfAOOwVPepZ7ZvInejprP2fCo8W0387QvKQTPdm/yc= X-Received: by 2002:a17:90b:1a8a:b0:1d2:e93e:6604 with SMTP id ng10-20020a17090b1a8a00b001d2e93e6604mr10172088pjb.233.1650544760102; Thu, 21 Apr 2022 05:39:20 -0700 (PDT) MIME-Version: 1.0 References: <20220409042321.3184493-1-james.hilliard1@gmail.com> In-Reply-To: From: Patrik Jakobsson Date: Thu, 21 Apr 2022 14:39:08 +0200 Message-ID: Subject: Re: [PATCH v3] drm/gma500: depend on framebuffer To: Thomas Zimmermann Cc: James Hilliard , dri-devel , David Airlie , Randy Dunlap , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 1:49 PM Thomas Zimmermann wrote: > > Hi > > Am 09.04.22 um 06:23 schrieb James Hilliard: > > Select the efi framebuffer if efi is enabled. > > > > This appears to be needed for video output to function correctly. > > > > Signed-off-by: James Hilliard > > --- > > Changes v2 -> v3: > > - select EFI_FB instead of depending on it > > Changes v1 -> v2: > > - use depends instead of select > > --- > > drivers/gpu/drm/gma500/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > > index 0cff20265f97..a422fa84d53b 100644 > > --- a/drivers/gpu/drm/gma500/Kconfig > > +++ b/drivers/gpu/drm/gma500/Kconfig > > @@ -2,11 +2,13 @@ > > config DRM_GMA500 > > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" > > depends on DRM && PCI && X86 && MMU > > + depends on FB > > Why do we need FB here? Framebuffer support should be hidden by DRM's > fbdev helpers. It is not needed but gives him video output since it enables the drm fbdev emulation. I looked some more at the logs and it seems weston doesn't work on his system without the fbdev backend. So the question is why weston isn't working without fbdev? Perhaps this is just a Weston configuration issue?