From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72E4C4724C for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A58E62073E for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X+kNky8F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728142AbgEACi0 (ORCPT ); Thu, 30 Apr 2020 22:38:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33694 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728065AbgEACiZ (ORCPT ); Thu, 30 Apr 2020 22:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=X+kNky8FxvVt4czptIdJNzpjOTygN2raEEp0wFsi0Athju4aulnSJQuVY0TkeQo0wAZEA0 c3IVN06HAPUKUtEBtE6r1BTTxEhh21viVgRmRrXLqEW2rc12ce1p/vc9t5//pffmjcrOk/ kmfDbQXXw1XSR/oS8EwhSnLZbykGyj0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-D8Uv3tAHPE-HuQba-Og9rA-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: D8Uv3tAHPE-HuQba-Og9rA-1 Received: by mail-ua1-f72.google.com with SMTP id u16so3663406ual.11 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=JT1Pdocj9IRaATcwgLG52BOL9PYXTJps210KSdGLXplCo49k6CF2aOX8jt5npEshYM ksZGsGMMTiccv6UJKJXNCzia2LPgmc9yKxluaplYbw2IPY2PNV2MKxR+bcuz9BVmb02N s7+wYRAFp6qfLFjmw75Agx52n0XyhTYcd+RxTiSTTiwc4SDaaVliIA5K9XEGHUos9wj0 IaIyKXJ91rmzDD8KtvcLplTmmWUS5/3qZfnrTowVcEeTUkd2tDi+w/XMzrCD/2m59aqo 2ZkJogUejslPqe2axLIX4VjNsSeVFgTPGRiqRpzM9+RisE8+i1eoPNgyHlr3ikbgEzpq RlKw== X-Gm-Message-State: AGi0PubgEsTX4QrjI8yehVEHlWrGIh7xCXDeVt8WLS3rsgA0yxArHnRu nU+S9RDUNjD3PrIPX4a6ROTuKKKbOPdd748BZzM+zwwxCMtEnIo0IZwWQGEwzFBMKhWU1wZ0183 sqwlQfOtzZN45vdwQFeim/FOxA9XUsY4wdkxR/gi5 X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848894vsp.198.1588300701708; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, Linux Kernel Mailing List , Michael Kelley , Gao Xiang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Dorminy Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21372 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728008AbgEACiZ (ORCPT ); Thu, 30 Apr 2020 22:38:25 -0400 Received: by mail-ua1-f72.google.com with SMTP id v17so3666675uao.7 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAB0C47254 for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B196F2071C for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IxIFXsjo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B196F2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 304E88E0005; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B49E8E0001; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A3D78E0005; Thu, 30 Apr 2020 22:38:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F3C058E0001 for ; Thu, 30 Apr 2020 22:38:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1858181AEF00 for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) X-FDA: 76766591412.19.army49_66c9ed6c83215 X-HE-Tag: army49_66c9ed6c83215 X-Filterd-Recvd-Size: 4839 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 1 May 2020 02:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=IxIFXsjohq7cKf2OG8hXZSe6CgFuo5tdJNLeMn1Wiu35PsL7Qtndts4hPXyC4giSpwT4VK lAwcNwEjmS7Io1EwNbLixqASaFiOpTIrR9l5stUOQOJGjMsg+FoQF1HHHdFpreCwBWJZSO IIcAxM3GRo7V2AGGyShIxz+BPD1D/4Q= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-NSikBMmtOCyACrC8LiH4sA-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: NSikBMmtOCyACrC8LiH4sA-1 Received: by mail-ua1-f72.google.com with SMTP id m26so3684835uao.2 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=M1UwkJQ3kjFNeGhZaiuXm71F5C/zdYRyDk1sEFWO67L9pO+Z76MeI55FCG8R5JV8cQ l75caoxUiAu82VtJmPMIMBHihwfr3oZxcVxMj7OgI6Q20chcWOVcuxXGuP2omoED2su0 ZctAwxsTVJTb8aj1Dre3XSxnFgIzYP2K9zgIlzOlIAn6CckU1lk304MOINCgA8Nh+RLu PxjKeXbpon3DX683btHIWPmCJIU/4SpokR3K/GclsaV2tlqXiSwtvJJwADKs5jV5ficT 5MD7w3DQRM0vr5vSgOdrJ1yzr4eyhL89hqqnjYgHc/4B8Jqsx2lk/OZK6Tv1Am4ORiwE 7muQ== X-Gm-Message-State: AGi0PuY2j6Lek9SjPTSuhecQh21zrah7K6whr8T4fh9ahOot+b9FjA66 tOs8oeS3ESuhADO9/hbUP5G/qegjHAP3A0IOazMgDKlphSqscX/hMUQzEF9lCuFd3ijf5fyOkE/ FSb7luQMTSp7Ki5gttfmhfp7X9yk= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848898vsp.198.1588300701714; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, Linux Kernel Mailing List , Michael Kelley , Gao Xiang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46852C47254 for ; Fri, 1 May 2020 03:23:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9E02206B8 for ; Fri, 1 May 2020 03:23:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EZFHzxDs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EZFHzxDs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9E02206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49CyHn5zZ1zDrN0 for ; Fri, 1 May 2020 13:23:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=207.211.31.120; helo=us-smtp-1.mimecast.com; envelope-from=sweettea@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EZFHzxDs; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EZFHzxDs; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49CxJR3xBjzDr8r for ; Fri, 1 May 2020 12:38:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=EZFHzxDs+yFX1DPcPibDZVjrHw/dqrkXSg1amJCKUbOH9jTROVWtue2AFjemYSRx0Tij/X UQi5sPrPgyloKwH3JkN7Sduy5nVqtcI8STPKaIHixoVUAHFqcAsj7ta3zHGeCk4qhSCaQG nnocvaMwW3j1md8RnBpGDOlfF8Orbb4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=EZFHzxDs+yFX1DPcPibDZVjrHw/dqrkXSg1amJCKUbOH9jTROVWtue2AFjemYSRx0Tij/X UQi5sPrPgyloKwH3JkN7Sduy5nVqtcI8STPKaIHixoVUAHFqcAsj7ta3zHGeCk4qhSCaQG nnocvaMwW3j1md8RnBpGDOlfF8Orbb4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-Z6tXzWRhNmSaJyJhzf1EhQ-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: Z6tXzWRhNmSaJyJhzf1EhQ-1 Received: by mail-ua1-f69.google.com with SMTP id z20so3649902uag.19 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=PckBchnxqSRRMERHpD7Vlz59ptCSR/kPa1mOpWQLfwaRKzjHKtVJT1OpEtGFTM4Mxx 6LoVNaG9ydZb/eficqF/oS+4RUVeVoCHK25sCY3FXj4Kb983SEGdz/gJ7qtpl6fii5aB gf2dDb5Mh2VnWxo5nINVXkeCwoCwaWFbps5hg0hYc9/yhXNJzXCQ+mr93FrIBnJSinQZ KG70KOL9Ap32CMf3Lvj1qRXXzgR36qeladEAgv1Nu2jDlTdV4NO0w+smutwWJY5YQqg5 e8wAlbfz8vp7SBv7cRy8YgQp+jipi+ksEx4mgguBm715oGt72hhOiw3FE4lYwA7JVgXG MttA== X-Gm-Message-State: AGi0PuYDVvMqcMa2wvG1l4bioe3LZEjHBYty76IFwHRmHaIVCIELY/Am wJyd391k5jxnedEI8x38MD4G9mjIJMBarFCY5bsxDFXu1ILzmlg+a+kpu8VT2dWgo68Qc1IQz+1 dYhN7zl7HzFTTJPoGqIaE23Yv6q1WsWlFWrsW3HmmIQ== X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848899vsp.198.1588300701719; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Fri, 01 May 2020 13:16:54 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Michael Kelley , linux-mm@kvack.org, "K. Y. Srinivasan" , Sumit Semwal , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Stephen Hemminger , x86@kernel.org, Christoph Hellwig , Peter Zijlstra , Gao Xiang , Laura Abbott , Nitin Gupta , Daniel Vetter , Haiyang Zhang , linaro-mm-sig@lists.linaro.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Robin Murphy , Linux Kernel Mailing List , Minchan Kim , iommu@lists.linux-foundation.org, Sakari Ailus , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0E3C47254 for ; Fri, 1 May 2020 04:48:04 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D55E72073E for ; Fri, 1 May 2020 04:48:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OQjNORms" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D55E72073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B493D882CD; Fri, 1 May 2020 04:48:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q960EYBPiZK7; Fri, 1 May 2020 04:48:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 79B25882C4; Fri, 1 May 2020 04:48:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 727CCC0864; Fri, 1 May 2020 04:48:02 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3EAB3C016F for ; Fri, 1 May 2020 02:38:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2701988B52 for ; Fri, 1 May 2020 02:38:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JL9CWGpoKCSl for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by hemlock.osuosl.org (Postfix) with ESMTPS id 2B13588B10 for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=OQjNORmsSLYYujNiIOWKWp3ybwru/UmntRHxje++DKPQ5vd6LZX5r+YQRZGeFs0D4yKYkO K4AfDlhZOGIeiASF7cErLGKhwFkOudTPowZhUkO4tFT7264qhKEXdT6RIPDXzwQWzWMCBu /Kss3WMvqsB47TmsomWDfB3lO+bf+ok= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-RQCyzGnAN4yPA1iVxKNE6g-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: RQCyzGnAN4yPA1iVxKNE6g-1 Received: by mail-ua1-f69.google.com with SMTP id t26so3656653uar.14 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=K4cm2Mg6viIezc4WwUQmE327N6LBhDVkfVTY0GHuOkyBtO/xhmZo0DLIspirl+OgdS NMcuEkxKY+p/Y37NPKhxIw+OCzwdQUcUPoAZNRWoqGCbat2tmUgVVpsvSTf1W2m1g6tH t/AWlM60QxS9NAFJhtLV3oHDdL5lraZO+ZS6f2PzBwAr50hDqfsMm+ZmvZUgEgSJQXwI Io0WUk/X3KONc4F7jaz3/w3l0e3VMnoHFZjQmV7409lMcpYJqv96Tb5ljJFLXP+4qNQy Sh/YlXThkU23fOjJy53zLpmrWofiMtgc/riiz5hQtcuirvBIBInJrnhO4iezsLZSKIfT eCPA== X-Gm-Message-State: AGi0Pub3EJhEymIkK3Ku2nXQc+B46IHm7sKOlqx5AlIafPC3uFl8/xCI hZi1sDRnh956duPjzLU911EpuoaVKvJ43jdfDjFE7FkmmG20bpfhrsUteBV205n756iabOx7Xi6 9PE3eLDx2kFhkvsbdaxVsV+S1cEdRyNckTK0UNng8i24N2w== X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848897vsp.198.1588300701711; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Mailman-Approved-At: Fri, 01 May 2020 04:48:01 +0000 Cc: linux-hyperv@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Michael Kelley , linux-mm@kvack.org, "K. Y. Srinivasan" , Sumit Semwal , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Stephen Hemminger , x86@kernel.org, Christoph Hellwig , Peter Zijlstra , Gao Xiang , Laura Abbott , Nitin Gupta , Daniel Vetter , Haiyang Zhang , linaro-mm-sig@lists.linaro.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Robin Murphy , Linux Kernel Mailing List , Minchan Kim , iommu@lists.linux-foundation.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DBAC28CBC for ; Fri, 1 May 2020 02:38:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8716A2071C for ; Fri, 1 May 2020 02:38:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Oq5pBoJd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EZFHzxDs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8716A2071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NvbBicBiFjWNNvJ3k3yOU2IeyKFwjxB/xGZRpQguwbY=; b=Oq5pBoJdDnsnAY Aw1GP2u4XHFb5ZN1GpZwvtJ/BdTNQXkatOOyswNtOzAebbNgr19+6dQqBxpaiMSho9ACKxhSjn9E2 4poAvnQRKTZiGF6O7oaqsBmBh43kTF1+3jNRlnFJtEISNhFsmlojR7tDEjFZiia2SO5Hn1QcuEScJ zPyTdqD9zR0iKNCFbPk25cmasCu+lheILzUCvaBz4cNaNDQKde3rjNguASf+/UYIzWOm5YPFeYe0B 7yWWoTSgp3WLd7tYmBNP/jYn3bcAm79t6PBPy0YqG6ygaW01/Amfnrse3KITwMh4dvmbSJ2Lgc5Bx pWm4XluwohCKC0lgolrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jULZM-0002uX-CD; Fri, 01 May 2020 02:38:28 +0000 Received: from us-smtp-2.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jULZJ-0002tm-3j for linux-arm-kernel@lists.infradead.org; Fri, 01 May 2020 02:38:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=EZFHzxDs+yFX1DPcPibDZVjrHw/dqrkXSg1amJCKUbOH9jTROVWtue2AFjemYSRx0Tij/X UQi5sPrPgyloKwH3JkN7Sduy5nVqtcI8STPKaIHixoVUAHFqcAsj7ta3zHGeCk4qhSCaQG nnocvaMwW3j1md8RnBpGDOlfF8Orbb4= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-0qSi8ONMM8K8Hy5tSJ91BQ-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: 0qSi8ONMM8K8Hy5tSJ91BQ-1 Received: by mail-vk1-f197.google.com with SMTP id h63so4161040vkh.10 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=cwatL4hq5togfZU+yP17+C+ihz37K+kYMt8ApJHhf20/oEz3doVPzwS4mB+nM88doy Bbi7Bph/NoCaTY7bsb8QaI6RhSji7VWWM2W3Xc0AeMh7OrJ3KrPIeH4YyclpTnx0R5ng 3PAir48ZdYmy+dtL3GnlCO07joJNFGTdImSZ1GKaS/PGRZu95MJdugHLsJVTjpZ4StWq woiO6mmgj93abnDx/BC/QlaORJFScXY0aV1m4N/daDtrwH1XfhtGZPr8Cp2BXUxTVIrp uNMjEOF539Ql5d9JovBo57TGZJro7g6psMleFze9eRoJBOZkSq0BLU8m/Ct4xMlv0+qQ Q17g== X-Gm-Message-State: AGi0PuZ8842ymzwHZYF0vMOBfyn0BjIJwTKDbc2MWSZkrQpqevfzGDms CXo7gz/NjPbWSCUQqDo6KoRziGvoNIwPdF/8C5bJGPtGNX74J5/bj0qS6g3C7PVUwfYqq8YRjn0 hAhpeYf8C9WEQV3tHcGgahksakSgjEsGGx34X1XmP8b00BsyQa0Y= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848883vsp.198.1588300701704; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_193825_222508_58E296AB X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Michael Kelley , linux-mm@kvack.org, "K. Y. Srinivasan" , Sumit Semwal , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Stephen Hemminger , x86@kernel.org, Christoph Hellwig , Peter Zijlstra , Gao Xiang , Laura Abbott , Nitin Gupta , Daniel Vetter , Haiyang Zhang , linaro-mm-sig@lists.linaro.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Robin Murphy , Linux Kernel Mailing List , Minchan Kim , iommu@lists.linux-foundation.org, Sakari Ailus , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B09C28CBC for ; Fri, 1 May 2020 02:38:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD482071C for ; Fri, 1 May 2020 02:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iDuSKx6w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD482071C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EA386E200; Fri, 1 May 2020 02:38:28 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F17B6E200 for ; Fri, 1 May 2020 02:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588300706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=iDuSKx6wUSQHiVhDo3SnlmiOzi51Bn9nmlQYnDXQfttTwFFQKD/Tzu+sRC57qfdxb4MmCf hdGbRQ05lg6QDGAC0/OhfXO8zQ3btV4bwwziVkV5YKATwtsFzxRfMJk+BDmV1WcAzGlQCE DO8DadEG1afNmalt6kzNJo94jOTRrxk= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-VEb0kuXJM5iPhGfacczs5w-1; Thu, 30 Apr 2020 22:38:22 -0400 X-MC-Unique: VEb0kuXJM5iPhGfacczs5w-1 Received: by mail-vk1-f197.google.com with SMTP id j206so4154371vke.11 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8k2aTeCbIA0Pe5nqRNlnguJBbZob6iEKj+wNv40n6s=; b=VGTNIpH9v+6KqsfJFzMeBFzuaU5mpOoeT0hQAJUZq45ylAaAHzxd5i8cyExKbd4/p1 FZmJz7re+SmElS+B752IPik0K3iSIVbf4qoML35iKfA//5e2RO2g3ajqcwTBn+yU75DD x7G8isdCfWz5/yFLVRa3gomg1CXr+Rc+/jjRg5mYeZerVt7+sfvcPhgPTUMD6m8goilR 8qWpHC6bnBrGjk+Ce9LZezvHI1TACGxFNI9KYPz5ldRIHUrpUDBYV0zuhAs8QGox5YCp ov6IcKXhLFKmoR+KT+/m4cEC2btHdALPgzkKiRZphk7fV35tg0HBhZcxlXYUAG3xZglU ZMqw== X-Gm-Message-State: AGi0PuZaRRKWA1f0lIkQ+8aBUlhNT6BYspk4DB+p2FzyyVAt1k1kKDk7 6NdEL1leWavvmhj8y5VHKBX33iHcAyM/SR2s0JFX1YoK9RWK8z07bkiRIwKUHSEhNCFKpCsLmo/ rCB8ti0pP2lrNl4nRt1vg+sC8qyf6cRHrjvLw5IvzhHo8 X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848882vsp.198.1588300701704; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKu6ClZ61atP80MD4lQJkn2FtP3gZkiC+YuTXU2rwKV21SshkG1nW93zQxISm3Y7jRVOl6JpuyIYF8Yu55j3FA= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr1848869vsp.198.1588300701546; Thu, 30 Apr 2020 19:38:21 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc To: Wei Liu X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Michael Kelley , linux-mm@kvack.org, "K. Y. Srinivasan" , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Stephen Hemminger , x86@kernel.org, Christoph Hellwig , Peter Zijlstra , Gao Xiang , Laura Abbott , Nitin Gupta , Haiyang Zhang , linaro-mm-sig@lists.linaro.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Christophe Leroy , Robin Murphy , Linux Kernel Mailing List , Minchan Kim , iommu@lists.linux-foundation.org, Sakari Ailus , Andrew Morton , linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel