From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42356C64E8A for ; Sun, 29 Nov 2020 06:10:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAE422080C for ; Sun, 29 Nov 2020 06:10:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Qh2PVWDD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgK2GKZ (ORCPT ); Sun, 29 Nov 2020 01:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgK2GKY (ORCPT ); Sun, 29 Nov 2020 01:10:24 -0500 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CD69C0613D3 for ; Sat, 28 Nov 2020 22:09:38 -0800 (PST) Received: by mail-ej1-x643.google.com with SMTP id d17so12425161ejy.9 for ; Sat, 28 Nov 2020 22:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fu+OLgh33kd4c7uWtP+T5ynLNcOve17zeiTVDhx2z0E=; b=Qh2PVWDDKHbM51luphJ8s7JPsgXiObRyw72WqBT9N9N9or5ya0Z6xdKAxIwuNUEGY/ nRDDC6DFhZvs5Tr3NxBaaAGWcbCV5CdvNRXmECCTBQFvGE0vsJCZrXTSkJPVV3YOCFzE Lmp+hcqE7JreKxxzd4FjCfh4cR29RXg3n1f/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fu+OLgh33kd4c7uWtP+T5ynLNcOve17zeiTVDhx2z0E=; b=K8P2qtYY9DbiAuRma2/yp588WSBQ3U/Bb9SFVILSHm+zOkN0UdbniXteiLnMOYfD3Z G2yyXp+Gd9iHqm6tMKTsXObBLEF8PGOfks6YwgPdyQWJJqfo5ic5n6Fw0YJL5SDUEudn 701qgLyY3xm4vuWi5RLZumVrOhA0bT4npbeMUMFTMRQ4x0rjCKyBNuq8SSyGtJvCPvsA 9sTDFso06g2LgL27XX139sRNMypKU0MLPnZbjDxias8VAeTVT9Qg2cJ9qLqJTG+UbxqY XPq7EOGL9nhZ60nNwGVWcyoei1AmqWuAUaK4cQs6SxiTXGhi06Aayij0sf6hyB9GN73a BZqA== X-Gm-Message-State: AOAM5321H47FlbvVcD+08NNWXjkmk8vEIcKMeWtOTYHI8HoCGFXpkmm4 IPklaVpdB58FTKpCWJwnBBhNc9ZYGFMjfg== X-Google-Smtp-Source: ABdhPJzeKkx+R7TDa1iPDchRyop3/wJmJu7+mC3IMcPK19TDgof3m19+OjpR4CyXBlQC82GfPCjR3A== X-Received: by 2002:a17:906:a195:: with SMTP id s21mr15379838ejy.146.1606630177004; Sat, 28 Nov 2020 22:09:37 -0800 (PST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com. [209.85.128.54]) by smtp.gmail.com with ESMTPSA id n23sm835096edv.12.2020.11.28.22.09.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Nov 2020 22:09:36 -0800 (PST) Received: by mail-wm1-f54.google.com with SMTP id k10so5435689wmi.3 for ; Sat, 28 Nov 2020 22:09:36 -0800 (PST) X-Received: by 2002:a1c:8155:: with SMTP id c82mr10594340wmd.49.1606630175847; Sat, 28 Nov 2020 22:09:35 -0800 (PST) MIME-Version: 1.0 References: <20201111143755.24541-1-stanimir.varbanov@linaro.org> <20201111143755.24541-9-stanimir.varbanov@linaro.org> In-Reply-To: <20201111143755.24541-9-stanimir.varbanov@linaro.org> From: Fritz Koenig Date: Sat, 28 Nov 2020 22:09:23 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 8/8] venus: helpers: Delete unused stop streaming helper To: Stanimir Varbanov Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia , Alexandre Courbot , Fritz Koenig Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov wrote: > > After re-design of encoder driver this helper is not needed > anymore. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/helpers.c | 43 --------------------- > drivers/media/platform/qcom/venus/helpers.h | 1 - > 2 files changed, 44 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index 490c026b58a3..51c80417f361 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -1406,49 +1406,6 @@ void venus_helper_buffers_done(struct venus_inst *inst, unsigned int type, > } > EXPORT_SYMBOL_GPL(venus_helper_buffers_done); > > -void venus_helper_vb2_stop_streaming(struct vb2_queue *q) > -{ > - struct venus_inst *inst = vb2_get_drv_priv(q); > - struct venus_core *core = inst->core; > - int ret; > - > - mutex_lock(&inst->lock); > - > - if (inst->streamon_out & inst->streamon_cap) { > - ret = hfi_session_stop(inst); > - ret |= hfi_session_unload_res(inst); > - ret |= venus_helper_unregister_bufs(inst); > - ret |= venus_helper_intbufs_free(inst); > - ret |= hfi_session_deinit(inst); > - > - if (inst->session_error || core->sys_error) > - ret = -EIO; > - > - if (ret) > - hfi_session_abort(inst); > - > - venus_helper_free_dpb_bufs(inst); > - > - venus_pm_load_scale(inst); > - INIT_LIST_HEAD(&inst->registeredbufs); > - } > - > - venus_helper_buffers_done(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, > - VB2_BUF_STATE_ERROR); > - venus_helper_buffers_done(inst, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > - VB2_BUF_STATE_ERROR); > - > - if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) > - inst->streamon_out = 0; > - else > - inst->streamon_cap = 0; > - > - venus_pm_release_core(inst); > - > - mutex_unlock(&inst->lock); > -} > -EXPORT_SYMBOL_GPL(venus_helper_vb2_stop_streaming); > - > int venus_helper_process_initial_cap_bufs(struct venus_inst *inst) > { > struct v4l2_m2m_ctx *m2m_ctx = inst->m2m_ctx; > diff --git a/drivers/media/platform/qcom/venus/helpers.h b/drivers/media/platform/qcom/venus/helpers.h > index 231af29667e7..3eae2acbcc8e 100644 > --- a/drivers/media/platform/qcom/venus/helpers.h > +++ b/drivers/media/platform/qcom/venus/helpers.h > @@ -20,7 +20,6 @@ int venus_helper_vb2_buf_init(struct vb2_buffer *vb); > int venus_helper_vb2_buf_prepare(struct vb2_buffer *vb); > void venus_helper_vb2_buf_queue(struct vb2_buffer *vb); > void venus_helper_process_buf(struct vb2_buffer *vb); > -void venus_helper_vb2_stop_streaming(struct vb2_queue *q); > int venus_helper_vb2_start_streaming(struct venus_inst *inst); > void venus_helper_m2m_device_run(void *priv); > void venus_helper_m2m_job_abort(void *priv); > -- > 2.17.1 > Reviewed-by: Fritz Koenig