From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5F0C433EF for ; Wed, 13 Apr 2022 09:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230388AbiDMJ3k (ORCPT ); Wed, 13 Apr 2022 05:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbiDMJ3h (ORCPT ); Wed, 13 Apr 2022 05:29:37 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E75A853B69; Wed, 13 Apr 2022 02:27:16 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id 2so1408038pjw.2; Wed, 13 Apr 2022 02:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aWHwuVM56mGn8hBqdvVQF2h0/hgZKGEUzuVUodXvntM=; b=aB5TwnS2HFOxmF1b4l/z53MXkVL/ul/v+PNiOchygCcKgXValBvZeliRKQJV9gj+Vc slXEpmzWh4+qwCgizBHHcwatvJK+yGMbDQVlcKamI7mLLHsWbqqaGCoNgwgU7NkvhjjN 4anPrku0hGi4Gnx1ceAqVwoBcAoPsQJ5bCKeR0q6lvogtnEtu7A0CelRpz9PRQsQvCq/ C4cpmbhO+PVUMP+LHcAPLZBkYd2uRpGA2RfWNySq9ltXftbkhX5Z4qfOk05h/WmjCH4T R8pQWKToUbzigm26AAkQkemT3Oi6+vTYyaPdt0Q686WhH4YfAwo3EFk51RineGqM/R5e xVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aWHwuVM56mGn8hBqdvVQF2h0/hgZKGEUzuVUodXvntM=; b=35rz8bpTb+Yr94p9BF5Qx6Bqn/OmueOiirla1K8uyBD9joZ8/T7acyMS7FhPyYZcLN Q/CsyyLbChLaFbOaMzke3118DOBPQ171h+jJDEVkKbGtgpq6PAtPCHn5Gs0+X1/0l9gt qITHiLKzD0eKLUQN4CA84f1YZAWrf8PHR41BuLHem9IvrO9DyNNOZVO7NepkCb10Ciym JHAUsqj6M7QPDAH2IxlGeXtSNc7s32yyRlmQgKsiJWmmCbBAM5gw/s99dnZBAHZo23NM qvB4s6tOVOS8lyFk5r1GAh+Kq0NuN4uqMdM6yJgEZoTXrnDjc7ndwKgx7DEog7D1XuXq fMEg== X-Gm-Message-State: AOAM530O6iu/KxGqKwAVlA/WpBpKm9iskQcd+aXqP1UePDjjHAJtmIDn Po7ycAGtP7jwcAAzqJcmZw/5Tg5QuQ/+y6q4Sw== X-Google-Smtp-Source: ABdhPJz9O5s6O8Bzb1wJFWqKHLGPLctQp79wNjlG9K87jHZwVNQ1wY2A1CSv2mriOcsbvGMVcNcMLrNXE9xUX/PJAU4= X-Received: by 2002:a17:90a:fb97:b0:1cb:adf9:88ba with SMTP id cp23-20020a17090afb9700b001cbadf988bamr9766014pjb.46.1649842036480; Wed, 13 Apr 2022 02:27:16 -0700 (PDT) MIME-Version: 1.0 References: <20220409134926.331728-1-zheyuma97@gmail.com> In-Reply-To: From: Zheyu Ma Date: Wed, 13 Apr 2022 17:27:04 +0800 Message-ID: Subject: Re: [PATCH] scsi: mpi3mr: Fix an error code when probing the driver To: Sathya Prakash Veerichetty Cc: Kashyap Desai , Sumit Saxena , Sreekanth Reddy , jejb@linux.ibm.com, "Martin K. Petersen" , mpi3mr-drvr-developers , linux-scsi , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 1:58 AM Sathya Prakash Veerichetty wrote: > > On Sat, Apr 9, 2022 at 7:49 AM Zheyu Ma wrote: > > > > During the process of driver probing, probe function should return < 0 > > for failure, otherwise kernel will treat value >= 0 as success. > > > > Signed-off-by: Zheyu Ma > > --- > > drivers/scsi/mpi3mr/mpi3mr_os.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c > > index f7cd70a15ea6..240bfdf9788b 100644 > > --- a/drivers/scsi/mpi3mr/mpi3mr_os.c > > +++ b/drivers/scsi/mpi3mr/mpi3mr_os.c > > @@ -4222,9 +4222,10 @@ mpi3mr_probe(struct pci_dev *pdev, const struct pci_device_id *id) > > struct Scsi_Host *shost = NULL; > > int retval = 0, i; > > > > - if (osintfc_mrioc_security_status(pdev)) { > > + retval = osintfc_mrioc_security_status(pdev); > > + if (retval) { > > warn_non_secure_ctlr = 1; > > - return 1; /* For Invalid and Tampered device */ > > + return retval; /* For Invalid and Tampered device */ > > } > NAK. The driver has to return 1 when invalid/tampered controllers are > detected just to say the controller is held by the mpi3mr driver > without any actual operation. Thanks for your explanation, I will drop this patch. Zheyu Ma