From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f176.google.com ([209.85.220.176]:45298 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbeBUUBe (ORCPT ); Wed, 21 Feb 2018 15:01:34 -0500 MIME-Version: 1.0 In-Reply-To: References: <1513333486.28703.9.camel@regit.org> <20171215.105338.2092740911243038177.davem@davemloft.net> From: Peter Manev Date: Wed, 21 Feb 2018 15:01:33 -0500 Message-ID: Subject: Re: ixgbe tuning reset when XDP is setup To: Alexander Duyck Cc: John Fastabend , David Miller , Eric Leblond , Netdev , xdp-newbies@vger.kernel.org, Emil Tantilov Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: >> >> Hi, >> >> We were wondering if there is any follow up/potential solution for that? >> If there is something we could help out testing with regards to that >> - please let us know. >> >> Thank you >> >> -- >> Regards, >> Peter Manev > > We don't have a solution available for this yet. Basically what it > comes down to is that we have to change the driver code so that if > assumes it is going to need to alloc Tx rings for XDP always, and then > if it can't we have to disable the XDP feature. The current logic is > to advertise the XDP feature, and then allocate the rings when XDP is > actually used, and if that fails we fail to load the XDP program. > > Unfortunately I don't have an ETA for when we can get to that. It may > be a while, however patches are always welcome. > > Thanks. > > - Alex It seems the issue is not present on 4.15.2 (while it is in 4.13.10 for example) using the ixgbe available in tree (/lib/modules/4.15.2-amd64/kernel/drivers/net/ethernet/intel/ixgbe) Not sure what triggered the fix - thought here would be a good place to ask for some pointers. Thank you -- Regards, Peter Manev