From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A61C64E8A for ; Mon, 30 Nov 2020 14:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C12320684 for ; Mon, 30 Nov 2020 14:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WvasUvHC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727070AbgK3OfS (ORCPT ); Mon, 30 Nov 2020 09:35:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbgK3OfS (ORCPT ); Mon, 30 Nov 2020 09:35:18 -0500 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78CD2C0613CF for ; Mon, 30 Nov 2020 06:34:38 -0800 (PST) Received: by mail-oo1-xc43.google.com with SMTP id t142so2713768oot.7 for ; Mon, 30 Nov 2020 06:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xx61GuftaKYVa9WLN4j9k312lVeLN++lqfRINw9TeD0=; b=WvasUvHCh+NQ/HAdniplRO/L7h44qR9ya9sJScI5FO76kHFJgrC37WrAne73fHlx0b mZwcbf3T8wjHUvjbRLX58jL+fnO4FQ9RVR13vVV74kEKKNyjzGp+Hj8pp6DqIPUUs55s Pse3v04OBszrAnMCcoeD55GXcMfa3TtarygagT/YcUYSWb3ImrXh2iBzHa2+/vjm6oiA jSLhMeweGnjxccUqFU3F3MzJCfe46wl8R774u412Hua+XyR+hOL9+5VLLqWxaNWljjYJ qH2ogauF4hTlChv91lTfurxuup5+ZIPf2L5JaSWuKS3NNNbmDrmaTttoByvKl53OVJsf J3iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xx61GuftaKYVa9WLN4j9k312lVeLN++lqfRINw9TeD0=; b=REweZw+I87P5r44yQco43K2wcRR19UBf6DrMy4kZlXCwVpFhnDJpgbtWnIUodcJnlA hFtqc4GY4bZlo18cZZbwOclHxKlvki/GkcmaA0+t1pCGFEJH/bDr4b7kbJLcrskXy68E JvDqLgM9Em6+hp8UiXDVdnybun3tWTO3eJYlWRm7yi52QZI2mCzel7MLz6Av8T9C559K v8/CNNu+wjPmlDMlpIwGpCOmyTGEyQSP+hGdArEDnujj6A1xXTXHwCQm/5JEmruEJwQ0 CQhv6jYRWWxXcjmpJQZ2sIUcDrNDcgP2eOuI1006XDtXqXn2XSxm0j9/7JcZ4XVoPWyq znhA== X-Gm-Message-State: AOAM530pkgsH+bIbBlyn54nk6FVzWZ6b/NxHE9mjX9LxB5bgAlR5ryw7 ypyVvRKZj1yrzFNEAaStp2Plm98HikxeESksl6A= X-Google-Smtp-Source: ABdhPJwTlSnkqi4iPQ9HKCKFmiuc9jxwRXyrTcUCYiuHR/IbRtKNumJ3rGJCbvQon2i1zByXq2aJM8nRe0AuA19qpAQ= X-Received: by 2002:a4a:b548:: with SMTP id s8mr15521966ooo.77.1606746877873; Mon, 30 Nov 2020 06:34:37 -0800 (PST) MIME-Version: 1.0 References: <20201031122246.16497-1-sergio.paracuellos@gmail.com> <20201031122246.16497-3-sergio.paracuellos@gmail.com> <20201119053059.GY50232@vkoul-mobl> <20201130121506.GB2767@kadam> In-Reply-To: <20201130121506.GB2767@kadam> From: Sergio Paracuellos Date: Mon, 30 Nov 2020 15:34:26 +0100 Message-ID: Subject: Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY To: Dan Carpenter Cc: Vinod Koul , "open list:STAGING SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg KH , Kishon Vijay Abraham I , Rob Herring , NeilBrown Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Dan, On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter wrote: > > On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 reg) > > > > +{ > > > > + regmap_write(phy->regmap, reg, val); > > > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > > > This is because name was the dummy names are a bit shorter :) but if > > it is also necessary I will use directly regmap_ functions. > > At least don't swap the last two arguments around. You are right. I don't really know why I changed the order there but those have been deleted in applied series. > > regards, > dan carpenter Best regards, Sergio Paracuellos > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87899C64E8A for ; Mon, 30 Nov 2020 14:34:44 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE4E020684 for ; Mon, 30 Nov 2020 14:34:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WvasUvHC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4E020684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4C1961FFFE; Mon, 30 Nov 2020 14:34:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r9hpD425-dRU; Mon, 30 Nov 2020 14:34:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 01AB920011; Mon, 30 Nov 2020 14:34:41 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 71C321BF418 for ; Mon, 30 Nov 2020 14:34:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 6C7C8871F0 for ; Mon, 30 Nov 2020 14:34:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m2LLZdeIOBm0 for ; Mon, 30 Nov 2020 14:34:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9C33E871DB for ; Mon, 30 Nov 2020 14:34:38 +0000 (UTC) Received: by mail-oo1-f66.google.com with SMTP id z13so2719797ooa.5 for ; Mon, 30 Nov 2020 06:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xx61GuftaKYVa9WLN4j9k312lVeLN++lqfRINw9TeD0=; b=WvasUvHCh+NQ/HAdniplRO/L7h44qR9ya9sJScI5FO76kHFJgrC37WrAne73fHlx0b mZwcbf3T8wjHUvjbRLX58jL+fnO4FQ9RVR13vVV74kEKKNyjzGp+Hj8pp6DqIPUUs55s Pse3v04OBszrAnMCcoeD55GXcMfa3TtarygagT/YcUYSWb3ImrXh2iBzHa2+/vjm6oiA jSLhMeweGnjxccUqFU3F3MzJCfe46wl8R774u412Hua+XyR+hOL9+5VLLqWxaNWljjYJ qH2ogauF4hTlChv91lTfurxuup5+ZIPf2L5JaSWuKS3NNNbmDrmaTttoByvKl53OVJsf J3iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xx61GuftaKYVa9WLN4j9k312lVeLN++lqfRINw9TeD0=; b=fLO2R9o6vEVec8FejKJM9Cqau/TmrJuUVleIEetx62kHKmBSEFv/4y4mYkZEeoOGG0 7MxcAb0SeU7z0f8qO1TQqT0F0p2AHVwWxddcegBnlxSAv0UhR9nPqBTH3Oss96y0XrKh LKYDlmY6mBzALJpiyVFTy3cXH/gBloBq01JyUBAED488uimNe+oyeBjECzCnDn669hO7 q6536eVuQz31F9nqoyZPfP6XA8Cn5FD86UCN/ziCmUeaDIUmqPviWL7RdZzZS6RwO2ev e3CZwHLl92T+jv6BqcCwxeKV13vqiH8S4CHBgnWfXWaxEJaeXgpDHZyJ+m6VGwfEHxCr FBWQ== X-Gm-Message-State: AOAM531LIUKmSHB1RSQJi0SL8s/in8C+Qtf/UaB2b0WU6h4CCyPdh91b LDNr/OJ3c34lQSWXJDzEqA0eFFqJEs6kSRvTA/8= X-Google-Smtp-Source: ABdhPJwTlSnkqi4iPQ9HKCKFmiuc9jxwRXyrTcUCYiuHR/IbRtKNumJ3rGJCbvQon2i1zByXq2aJM8nRe0AuA19qpAQ= X-Received: by 2002:a4a:b548:: with SMTP id s8mr15521966ooo.77.1606746877873; Mon, 30 Nov 2020 06:34:37 -0800 (PST) MIME-Version: 1.0 References: <20201031122246.16497-1-sergio.paracuellos@gmail.com> <20201031122246.16497-3-sergio.paracuellos@gmail.com> <20201119053059.GY50232@vkoul-mobl> <20201130121506.GB2767@kadam> In-Reply-To: <20201130121506.GB2767@kadam> From: Sergio Paracuellos Date: Mon, 30 Nov 2020 15:34:26 +0100 Message-ID: Subject: Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY To: Dan Carpenter X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:STAGING SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Greg KH , Kishon Vijay Abraham I , Vinod Koul , Rob Herring , NeilBrown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Dan, On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter wrote: > > On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 reg) > > > > +{ > > > > + regmap_write(phy->regmap, reg, val); > > > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > > > This is because name was the dummy names are a bit shorter :) but if > > it is also necessary I will use directly regmap_ functions. > > At least don't swap the last two arguments around. You are right. I don't really know why I changed the order there but those have been deleted in applied series. > > regards, > dan carpenter Best regards, Sergio Paracuellos > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel