From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, NeilBrown <neil@brown.name>,
DENG Qingfang <dqfext@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/4] staging: mt7621-dts: fix formatting
Date: Tue, 25 Jan 2022 15:08:55 +0100 [thread overview]
Message-ID: <CAMhs-H8hMERY76SRcQtCRvUq2x6Z-d7GE6NLKPj=j0X=6e2m+w@mail.gmail.com> (raw)
In-Reply-To: <20220124124351.4604-2-arinc.unal@arinc9.com>
Hi Arinc,
On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
We need a body for the commit also and not only a short description
for the commit.
> ---
> drivers/staging/mt7621-dts/mt7621.dtsi | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
> index 644a65d1a6a1..d120e5872165 100644
> --- a/drivers/staging/mt7621-dts/mt7621.dtsi
> +++ b/drivers/staging/mt7621-dts/mt7621.dtsi
> @@ -44,9 +44,9 @@ mmc_fixed_3v3: fixedregulator@0 {
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> regulator-always-on;
> - };
> + };
>
> - mmc_fixed_1v8_io: fixedregulator@1 {
> + mmc_fixed_1v8_io: fixedregulator@1 {
> compatible = "regulator-fixed";
> regulator-name = "mmc_io";
> regulator-min-microvolt = <1800000>;
> @@ -325,17 +325,18 @@ ethernet: ethernet@1e100000 {
>
> mediatek,ethsys = <&sysc>;
>
> -
> gmac0: mac@0 {
> compatible = "mediatek,eth-mac";
> reg = <0>;
> phy-mode = "rgmii";
> +
> fixed-link {
> speed = <1000>;
> full-duplex;
> pause;
> };
> };
> +
> gmac1: mac@1 {
> compatible = "mediatek,eth-mac";
> reg = <1>;
> @@ -343,6 +344,7 @@ gmac1: mac@1 {
> phy-mode = "rgmii-rxid";
> phy-handle = <&phy_external>;
> };
> +
> mdio-bus {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -373,36 +375,43 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0>;
> +
> port@0 {
> status = "off";
> reg = <0>;
> label = "lan0";
> };
> +
> port@1 {
> status = "off";
> reg = <1>;
> label = "lan1";
> };
> +
> port@2 {
> status = "off";
> reg = <2>;
> label = "lan2";
> };
> +
> port@3 {
> status = "off";
> reg = <3>;
> label = "lan3";
> };
> +
> port@4 {
> status = "off";
> reg = <4>;
> label = "lan4";
> };
> +
> port@6 {
> reg = <6>;
> label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
> +
> fixed-link {
> speed = <1000>;
> full-duplex;
> --
> 2.25.1
>
>
Other than that, this looks good. So feel free to add my:
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
when submitting a new version of this series.
Best regards,
Sergio Paracuellos
next prev parent reply other threads:[~2022-01-25 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 12:43 Arınç ÜNAL
2022-01-24 12:43 ` [PATCH 1/4] staging: mt7621-dts: fix formatting Arınç ÜNAL
2022-01-25 14:08 ` Sergio Paracuellos [this message]
2022-01-24 12:43 ` [PATCH 2/4] staging: mt7621-dts: fix switch0@0 warnings Arınç ÜNAL
2022-01-25 14:12 ` Sergio Paracuellos
2022-01-24 12:43 ` [PATCH 3/4] staging: mt7621-dts: use trgmii on gmac0 and enable flow control on port@6 Arınç ÜNAL
2022-01-25 14:37 ` Sergio Paracuellos
2022-01-24 12:43 ` [PATCH 4/4] staging: mt7621-dts: fix pinctrl properties for ethernet Arınç ÜNAL
2022-01-25 14:39 ` Sergio Paracuellos
2022-01-25 14:03 ` Sergio Paracuellos
2022-01-25 15:24 ` Re: Arınç ÜNAL
2022-01-25 15:50 ` Re: Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H8hMERY76SRcQtCRvUq2x6Z-d7GE6NLKPj=j0X=6e2m+w@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=dqfext@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=luizluca@gmail.com \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.