From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3D1F91BF2B5 for ; Sat, 6 Jul 2019 09:00:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 38BBB84837 for ; Sat, 6 Jul 2019 09:00:17 +0000 (UTC) Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bRXTqTmfFLah for ; Sat, 6 Jul 2019 09:00:16 +0000 (UTC) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 14EEB84545 for ; Sat, 6 Jul 2019 09:00:16 +0000 (UTC) Received: by mail-ot1-f65.google.com with SMTP id r21so6569622otq.6 for ; Sat, 06 Jul 2019 02:00:16 -0700 (PDT) MIME-Version: 1.0 References: <20190621061517.24089-1-sergio.paracuellos@gmail.com> <24106212-9bf9-867c-fed8-8ad828431cd7@kernel.org> <554866dd-9b81-5854-628e-cceabcdebe5b@kernel.org> In-Reply-To: From: Sergio Paracuellos Date: Sat, 6 Jul 2019 11:00:04 +0200 Message-ID: Subject: Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Brett Neumeier Cc: Neil Brown , driverdev-devel@linuxdriverproject.org, Greg Ungerer Hi Brett, On Fri, Jul 5, 2019 at 8:44 PM Brett Neumeier wrote: > > On Wed, Jun 26, 2019 at 7:45 AM Sergio Paracuellos > wrote: > > No problem, I also miss them rewritting code. That is bad :((. > > > BTW, I applied that on top of your other recent fixes (that ones > > > you pushed to gregkh for staging). So I tested with the > > > updated GPIO reset code. > > Ok, anyway.. I have just sent the change jus to have the same code behaviour > > that was being there before. > > FWIW, I have the same results as Greg -- the 4.2 driver works every > time, staging-next frequently hangs. I see, thanks for letting me know. We have to figure out what is wrong and why we don't get an stable pci link. > > Out of curiosity, if it's not too complex an answer to go into, what's > the benefit of the staging-next driver? Is there a reason to prefer it > to the 4.2 driver? In terms of stability, the driver which is in staging-next now is not always working as expected, so I really apologize for that because main changes have been done by myself. In the other hand, you have to think what is staging tree for. Staging contains drivers that are not ready to be properly mainlined into the "real" tree because they are not clean enough, the use old apis and so on. The idea of staging is to have a temporal place to properly clean drivers in order to get them properly added into the official mainline tree and directories. Doing that it will always be supported in the kernel and it won't be deleted for the tree. The mt7621 pci driver is now clean enough to give it a try to be mainlined but we have to achieve the problem of pci link stability that sometimes gets the driver to hang. Again, sorry for the inconvenience and any debug traces searching for the problem, ideas or patches repairing the current problem are very welcome. I don't have hardware to test my changes on, so it is a bit difficult for me to help more in these days. Hope this helps. Best regards, Sergio Paracuellos > > -- > Brett Neumeier (bneumeier@gmail.com) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel