From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D474C1BF20D for ; Sun, 23 Jun 2019 05:59:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id CE0EF81C39 for ; Sun, 23 Jun 2019 05:59:03 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D9NkV7Xl6ywD for ; Sun, 23 Jun 2019 05:59:03 +0000 (UTC) Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by whitealder.osuosl.org (Postfix) with ESMTPS id 3C10F81926 for ; Sun, 23 Jun 2019 05:59:03 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id 65so7434581oid.13 for ; Sat, 22 Jun 2019 22:59:03 -0700 (PDT) MIME-Version: 1.0 References: <20190621061517.24089-1-sergio.paracuellos@gmail.com> In-Reply-To: From: Sergio Paracuellos Date: Sun, 23 Jun 2019 07:58:51 +0200 Message-ID: Subject: Re: [PATCH 0/4] staging: mt7621-pci: Handle minor issues List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Brett Neumeier Cc: Neil Brown , Greg KH , Greg Ungerer , driverdev-devel@linuxdriverproject.org Hi Brett, On Sun, Jun 23, 2019 at 4:15 AM Brett Neumeier wrote: > > On Fri, Jun 21, 2019 at 7:35 AM Greg Ungerer wrote: > > > > Hi Sergio, > > > > On 21/6/19 4:15 pm, Sergio Paracuellos wrote: > > > This patch series properly handle minor issues in this driver. These are: > > > * Disable pcie port clock on pci dirver instead of doing it in the phy > > > driver. The pci driver is the correct place to do this. > > > * Add a missing call to phy_exit function to properly handle the function > > > 'mt7621_pcie_init_port' error path. > > > * Move driver to init in a later stage using 'module_init' instead of using > > > 'arch_initcall'. > > > > > > Patches are only compile-tested. It would be awasome to be tested before applied > > > them (mainly the change to 'module_init' stuff). > > I have similar results to Greg -- on GnuBee PC1 and PC2, six boot > attempts each on a kernel built from staging-next, I have four hangs > and eight successful boots. The hanging patterns are similar to > previous results. If the full boot logs would be helpful let me know, > I can provide them. Thanks for letting me know. One thing we can try is check init order in v4.20 kernel. Can you please try to compile pci driver for the kernel v4.20 tag changing driver's last line 'arch_initcall' into 'module_init'? Just to know if at that working driver putting all the stuff in a later stage stills work as expected. Full dmesg's of this v4.20 wih the change would be helpful. Best regards, Sergio Paracuellos > > -- > Brett Neumeier (bneumeier@gmail.com) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel