From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7F4C4360F for ; Thu, 4 Apr 2019 12:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1077206B7 for ; Thu, 4 Apr 2019 12:56:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HtrR8/wX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728983AbfDDM4J (ORCPT ); Thu, 4 Apr 2019 08:56:09 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33148 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbfDDM4I (ORCPT ); Thu, 4 Apr 2019 08:56:08 -0400 Received: by mail-ot1-f68.google.com with SMTP id j10so2243974otq.0 for ; Thu, 04 Apr 2019 05:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NYZMNAPLGU41XgbKnE/RSIbXA6GnVE1WHvYSyKBc/fI=; b=HtrR8/wXqvFLY8Rw/1pQtBfDFYcqWS2T8cj1maQwvcH9KzQKZSKkZC/LZJeNaw5JqH +luCbddtF9Bz/HnGThWe2L0seGnyPETQi8HD8SGPuLmVVXvOVERkUmfi8M9i2bXlLRra 0tsIv97C6uTUa+kYLaivZNQjSPyYWw1uYUegIo8rDyFfBz5V10sSkf9aEA1GmSE5zShl t7zDRmYv6/B9FadxGGzUqrWXZuPqz6imU7+mMBSvF6tg+mX5zCf9b+VOiqY2ZvJATBB0 l+1oLbcpFuXP3LdAV0oldgBIql2S2oMinSF2DPfwIGitbmru16tSmZV/iIgkSovu+wZL hvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NYZMNAPLGU41XgbKnE/RSIbXA6GnVE1WHvYSyKBc/fI=; b=RTJ1/9KOreeIVsWz+MiYOf8XM+ZHxGb/a3tenX5z+tjMCxX0fD9OLQ7Xb8lY3gM0RC FS0JjsJof8+uNfyua/mUkUwdykfGbAoWoiq/FAmCjU+a7qfDMJkYBmRAsRAvYJTuVLIo ZIZob1n1Py7/GyJ/mEYmbFHHYz3lIjEQzElRpPQAzui6PaQdaxVs/bIU5mBNok31KE1y k9l4gPE3n6BpsG62JZM+fFAfIyxpE//Klw7/Bj3em9GD5KMlrDL8nAM6YRs2VDh5CNr5 jTB45DNsITHTMIMCcgsvPUZfufCI+UN270Md8r+EDitQsExpaTwJkH527XgQAKykAge+ cwYw== X-Gm-Message-State: APjAAAW0AAOm1fVb3LyZu+0dbaUhumtdQNopRRRNMrwPAXWzDk10ahb+ yOMEI2lJfgZ6Q3ye8TwCwEL6jYgmwWc81Y061xyKFyVF X-Google-Smtp-Source: APXvYqwnm0vn9iU1sY8pFlDjY4NfW3VCGJ9vEI3vUeQUJpUs7na/GiskEPokvYzy6xgrxnQjm+Jeh8UZqQYCZf95X+8= X-Received: by 2002:a05:6830:13cd:: with SMTP id e13mr4062621otq.139.1554382568206; Thu, 04 Apr 2019 05:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20190404124414.22846-1-detegr@gmail.com> In-Reply-To: <20190404124414.22846-1-detegr@gmail.com> From: Sergio Paracuellos Date: Thu, 4 Apr 2019 14:55:56 +0200 Message-ID: Subject: Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable To: =?UTF-8?Q?Antti_Ker=C3=A4nen?= Cc: Matthias Brugger , Greg KH , benniciemanuel78@gmail.com, NeilBrown , devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 4, 2019 at 2:46 PM Antti Ker=C3=A4nen wrote: > > Do not use uninitialized variable 'port' when printing an error message > > Signed-off-by: Antti Ker=C3=A4nen > --- > drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/st= aging/mt7621-pci-phy/pci-mt7621-phy.c > index 118302c122ee..aa3ae7777632 100644 > --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c > +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c > @@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_devic= e *pdev) > > ret =3D of_address_to_resource(np, 0, &res); > if (ret) { > - dev_err(dev, "failed to get address resource(id-%d)\n", p= ort); > + dev_err(dev, "failed to get address resource\n"); > return ret; > } Reviewed-by: Sergio Paracuellos Thanks, Sergio Paracuellos > > -- > 2.21.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2560C4360F for ; Thu, 4 Apr 2019 12:56:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80A05206B7 for ; Thu, 4 Apr 2019 12:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YxYCehoR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HtrR8/wX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80A05206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JJQgELFdQNnH09GGwfIEHAwtd9498Mtoo+BjWFmcdB4=; b=YxYCehoRgYavJI jcqd83li2sZ23+ZvFb8UE+9FVRixnJLFlnImyZJaOaMtMPwfe55ErYCBorOfVrJwPMVLPyHCn2D6F MiwCBPIGul3b0FWFEJZ0/GThjAf4pun3a1S+PD3yPsB10Yv3XQDdIKi4kVOtHrdodEX99MOFRejeB zM4RhNS5PnAa+kA5/cq/dsoZTXXkIbaGJsV1ecIHFR2Y/XodrrpxziS5OF2PdDCV4PZOCxOqCso/A kR7iwvtfN4roVFvNc5cFyOPR2Z5gWdq3JdXw6ycToabA1qK+wGWW6bPqSK1fcdVekn6Ife+bvPw5t 1yvGhGMWttD6Fkug8yOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC1uf-0001tS-TR; Thu, 04 Apr 2019 12:56:13 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC1ub-0001si-SP; Thu, 04 Apr 2019 12:56:11 +0000 Received: by mail-ot1-x342.google.com with SMTP id k21so2238735otf.1; Thu, 04 Apr 2019 05:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NYZMNAPLGU41XgbKnE/RSIbXA6GnVE1WHvYSyKBc/fI=; b=HtrR8/wXqvFLY8Rw/1pQtBfDFYcqWS2T8cj1maQwvcH9KzQKZSKkZC/LZJeNaw5JqH +luCbddtF9Bz/HnGThWe2L0seGnyPETQi8HD8SGPuLmVVXvOVERkUmfi8M9i2bXlLRra 0tsIv97C6uTUa+kYLaivZNQjSPyYWw1uYUegIo8rDyFfBz5V10sSkf9aEA1GmSE5zShl t7zDRmYv6/B9FadxGGzUqrWXZuPqz6imU7+mMBSvF6tg+mX5zCf9b+VOiqY2ZvJATBB0 l+1oLbcpFuXP3LdAV0oldgBIql2S2oMinSF2DPfwIGitbmru16tSmZV/iIgkSovu+wZL hvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NYZMNAPLGU41XgbKnE/RSIbXA6GnVE1WHvYSyKBc/fI=; b=aEbzizL3veFtZwW6sO31W998KTm2O6TMbIei5cRvg15M89VcsmIRAijIdzHVGWL5k6 rjRbJ04ZW1tUvdFk/3lmOzm3UgHihyx3IHiHc2XBg61ARvTKzrs0OcgUNkQ2+dUnEJs4 oF+VJaw+JjnMZHIT8eEEDjFIhY5LhgiqQatmbp2TlEUVhun3pI1LAgRI9SRR8nxXAdAK aWyEZHbb+KmAboZHU9R1FI+vsI/m4Gd18fSAQAFV5QWfpNqFSN5PKY8aGYhzjZMuWfO3 k+fu4OmuUJ1dnL+qHXD0IO06ViGLcS+LarfAapXcbia0gABVKRSUS4dpeH9k6jFQYB2I zmbQ== X-Gm-Message-State: APjAAAWISUy4Yqte/w767ycDpWcjo/7rQGDWvMlSiwpfY8MQdLbW8rsp 5YJIV918TS7Fsz27aaLVQST/SyCPFcL5xhQC/Hk= X-Google-Smtp-Source: APXvYqwnm0vn9iU1sY8pFlDjY4NfW3VCGJ9vEI3vUeQUJpUs7na/GiskEPokvYzy6xgrxnQjm+Jeh8UZqQYCZf95X+8= X-Received: by 2002:a05:6830:13cd:: with SMTP id e13mr4062621otq.139.1554382568206; Thu, 04 Apr 2019 05:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20190404124414.22846-1-detegr@gmail.com> In-Reply-To: <20190404124414.22846-1-detegr@gmail.com> From: Sergio Paracuellos Date: Thu, 4 Apr 2019 14:55:56 +0200 Message-ID: Subject: Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable To: =?UTF-8?Q?Antti_Ker=C3=A4nen?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_055609_940021_9905334D X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg KH , linux-kernel , NeilBrown , linux-mediatek@lists.infradead.org, benniciemanuel78@gmail.com, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgNCwgMjAxOSBhdCAyOjQ2IFBNIEFudHRpIEtlcsOkbmVuIDxkZXRlZ3JAZ21h aWwuY29tPiB3cm90ZToKPgo+IERvIG5vdCB1c2UgdW5pbml0aWFsaXplZCB2YXJpYWJsZSAncG9y dCcgd2hlbiBwcmludGluZyBhbiBlcnJvciBtZXNzYWdlCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbnR0 aSBLZXLDpG5lbiA8ZGV0ZWdyQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9zdGFnaW5nL210 NzYyMS1wY2ktcGh5L3BjaS1tdDc2MjEtcGh5LmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3Rh Z2luZy9tdDc2MjEtcGNpLXBoeS9wY2ktbXQ3NjIxLXBoeS5jIGIvZHJpdmVycy9zdGFnaW5nL210 NzYyMS1wY2ktcGh5L3BjaS1tdDc2MjEtcGh5LmMKPiBpbmRleCAxMTgzMDJjMTIyZWUuLmFhM2Fl Nzc3NzYzMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvbXQ3NjIxLXBjaS1waHkvcGNp LW10NzYyMS1waHkuYwo+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tdDc2MjEtcGNpLXBoeS9wY2kt bXQ3NjIxLXBoeS5jCj4gQEAgLTMzMSw3ICszMzEsNyBAQCBzdGF0aWMgaW50IG10NzYyMV9wY2lf cGh5X3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4KPiAgICAgICAgIHJldCA9 IG9mX2FkZHJlc3NfdG9fcmVzb3VyY2UobnAsIDAsICZyZXMpOwo+ICAgICAgICAgaWYgKHJldCkg ewo+IC0gICAgICAgICAgICAgICBkZXZfZXJyKGRldiwgImZhaWxlZCB0byBnZXQgYWRkcmVzcyBy ZXNvdXJjZShpZC0lZClcbiIsIHBvcnQpOwo+ICsgICAgICAgICAgICAgICBkZXZfZXJyKGRldiwg ImZhaWxlZCB0byBnZXQgYWRkcmVzcyByZXNvdXJjZVxuIik7Cj4gICAgICAgICAgICAgICAgIHJl dHVybiByZXQ7Cj4gICAgICAgICB9CgpSZXZpZXdlZC1ieTogU2VyZ2lvIFBhcmFjdWVsbG9zIDxz ZXJnaW8ucGFyYWN1ZWxsb3NAZ21haWwuY29tPgoKVGhhbmtzLAogICAgIFNlcmdpbyBQYXJhY3Vl bGxvcwoKPgo+IC0tCj4gMi4yMS4wCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK