From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25E46C433FE for ; Thu, 30 Sep 2021 19:49:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 102E561A3C for ; Thu, 30 Sep 2021 19:49:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347391AbhI3Tvc (ORCPT ); Thu, 30 Sep 2021 15:51:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbhI3Tvb (ORCPT ); Thu, 30 Sep 2021 15:51:31 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC014C06176C for ; Thu, 30 Sep 2021 12:49:47 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id s20so9080195ioa.4 for ; Thu, 30 Sep 2021 12:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EB277iFt75fl+4aHOINXc6MZFx1y8U+fiFPNDywa6l0=; b=sVwEennI3YOv/UrOQmnsqVqIhhmjAqxaNwYAVxmqBTd4rixuqJ97suJdLoBCvAYXsq vqUyUs6E/zFeeVvYYctFUEAvSIJUjkLfscDw1/XGt8HMdQH02ZPsajyKFSOGMMQnQBE7 OMZNJzxZZVH/zuzFfgFLZ7OO5ZUexLEoQULY0HRt9la5ssJXraGbEWXERcIxAXj/Y4iL GbovCIs9o8pOzBpoOA6W3+iSevcBLzocfy3UW8lbRum4hnIXQ32Q6Z4QMmXqv3ToB55w +b0xMP9oWaRrnUXapNlG4vPu4Xu9sUJA3SxgVX6Z9uQmLuh97KpN3INV6q1zl525Tu7h +LSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EB277iFt75fl+4aHOINXc6MZFx1y8U+fiFPNDywa6l0=; b=vIQbZQURH5vac0245/KAKGc0J8xO8Bil5F+Bt/RjP1/sZRb1nB6QD87BxABPfSFm15 MzTpIlOteKrAisugyQbwsehqexZRHzUkCUMB67N5xTU6zSspNM56ulf5KVxTcGrI0SzV ahxySAqTlAJX2GPomROYUa1g9sp+KNcGeK3kWiDWqUFhg4DNPVIU2oyJFR4Jm8qESK4/ lQ8iJBfU+I7vaYfzPOGaFUgvwMUukY3yoB23EUtQt1uw1yrdLvWYKn6pUPjFpIbLpPIl N+WF9rK1L+irX1QHjiUTAPiT9Np0yjLGvXhV/GJT7kbReiZ2CI0jyo/B3qGhGEJiMWqg gIQA== X-Gm-Message-State: AOAM5318bOe/YDoZGgrJIiDfmbyuF1EW3wR5NkFN4v/Z0/pC0kUikN5/ r85zZflzLZz3S0M0n599JXJFY4iW1MvHHFW2zG5dzQ== X-Google-Smtp-Source: ABdhPJwJrWmWi/hsIsUS4oPU9/SBSkqOkq20r51rFH2xJ/wOLttpZT4oZowTFy/G1fwZD09J6piBpcqyb2OELajF8rg= X-Received: by 2002:a05:6638:2650:: with SMTP id n16mr6428740jat.30.1633031387130; Thu, 30 Sep 2021 12:49:47 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: Amit Pundir Date: Fri, 1 Oct 2021 01:19:11 +0530 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Rob Clark Cc: John Stultz , Maxime Ripard , Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > > The best practice to avoid those issues is to register its functions only after > > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > > to play nice with the other components that are waiting for us, so in our case > > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > > and I wasn't confortable doing them. > > > > > > > > > > > > Hey Maxime, > > > > Sorry for taking so long to get to this, but now that plumbers is > > > > over I've had a chance to check it out on kirin > > > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > > I'll retest and let you know. > > > > Ok, just retested including the kirin patch and unfortunately I'm > > still seeing the same thing. :( > > > > Will dig a bit and let you know when I find more. > > Did you have a chance to test it on anything using drm/msm with DSI > panels? That would at least confirm that I didn't miss anything in > the drm/msm patch to swap the dsi-host vs bridge ordering.. Hi, smoke tested https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework on Pocophone F1 (sdm845 / A630) with v5.15-rc3. I see no obvious regressions in my limited testing so far including video (youtube) playback. > > BR, > -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C0CC433EF for ; Thu, 30 Sep 2021 19:49:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76D2C61A3B for ; Thu, 30 Sep 2021 19:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 76D2C61A3B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1473E6E45D; Thu, 30 Sep 2021 19:49:48 +0000 (UTC) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by gabe.freedesktop.org (Postfix) with ESMTPS id D989B6E45D for ; Thu, 30 Sep 2021 19:49:47 +0000 (UTC) Received: by mail-io1-xd34.google.com with SMTP id z184so9092586iof.5 for ; Thu, 30 Sep 2021 12:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EB277iFt75fl+4aHOINXc6MZFx1y8U+fiFPNDywa6l0=; b=sVwEennI3YOv/UrOQmnsqVqIhhmjAqxaNwYAVxmqBTd4rixuqJ97suJdLoBCvAYXsq vqUyUs6E/zFeeVvYYctFUEAvSIJUjkLfscDw1/XGt8HMdQH02ZPsajyKFSOGMMQnQBE7 OMZNJzxZZVH/zuzFfgFLZ7OO5ZUexLEoQULY0HRt9la5ssJXraGbEWXERcIxAXj/Y4iL GbovCIs9o8pOzBpoOA6W3+iSevcBLzocfy3UW8lbRum4hnIXQ32Q6Z4QMmXqv3ToB55w +b0xMP9oWaRrnUXapNlG4vPu4Xu9sUJA3SxgVX6Z9uQmLuh97KpN3INV6q1zl525Tu7h +LSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EB277iFt75fl+4aHOINXc6MZFx1y8U+fiFPNDywa6l0=; b=HVHR3/JfLmUQEI0pOmy2err783HO0GTQOW32nZUzaUhpEz3cP7P46DGGQw9EsDyuP0 MHIOSrSkVkf0dNeVy8CdG2rbqN6XxjeI6s8/vFY/lBRMPrQZt6FmqgjBt9INXvYBvSAC n/GlFDr5FCxYlZogCQw5iGEhkBrL00j1f7b9yCVToqQG8SdOr5+Xzbsj5GVH2z9hU+vo txtXiZcuKHJAcXuK/ibWZbcgP83S8hQNfieLSMHNBKNGzA9RSKMSdCo0ZDOAEORw9mG+ NQaPFuy7f+qtbB58FIHgzdRk4yUyKJsbPrNvxKrLfJ0aE936J9L7Mhd7mJRPB6GvM6/6 yrbQ== X-Gm-Message-State: AOAM530I860VpDujf+hH0npz8LYB48eFlpvEYZ0N4kqZ7TwouDE2Ttl+ Me+IPB6wgAVFyzyhE9Yuo4vHwiJ6GxcrY3SYejL5Jg== X-Google-Smtp-Source: ABdhPJwJrWmWi/hsIsUS4oPU9/SBSkqOkq20r51rFH2xJ/wOLttpZT4oZowTFy/G1fwZD09J6piBpcqyb2OELajF8rg= X-Received: by 2002:a05:6638:2650:: with SMTP id n16mr6428740jat.30.1633031387130; Thu, 30 Sep 2021 12:49:47 -0700 (PDT) MIME-Version: 1.0 References: <20210910101218.1632297-1-maxime@cerno.tech> In-Reply-To: From: Amit Pundir Date: Fri, 1 Oct 2021 01:19:11 +0530 Message-ID: Subject: Re: [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent To: Rob Clark Cc: John Stultz , Maxime Ripard , Andrzej Hajda , Sam Ravnborg , Daniel Vetter , David Airlie , Jonas Karlman , Laurent Pinchart , Thierry Reding , Maarten Lankhorst , Thomas Zimmermann , Neil Armstrong , Robert Foss , Jernej Skrabec , Sean Paul , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Kyungmin Park , lkml , Xinliang Liu , Seung-Woo Kim , Tian Tao , Inki Dae , Linux Samsung SOC , linux-arm-msm , dri-devel , Chen Feng , Xinwei Kong , Joonyoung Shim Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > > > The best practice to avoid those issues is to register its functions only after > > > > > all its dependencies are live. We also shouldn't wait any longer than we should > > > > > to play nice with the other components that are waiting for us, so in our case > > > > > that would mean moving the DSI device registration to the bridge probe. > > > > > > > > > > I also had a look at all the DSI hosts, and it seems that exynos, kirin and msm > > > > > would be affected by this and wouldn't probe anymore after those changes. > > > > > Exynos and kirin seems to be simple enough for a mechanical change (that still > > > > > requires to be tested), but the changes in msm seemed to be far more important > > > > > and I wasn't confortable doing them. > > > > > > > > > > > > Hey Maxime, > > > > Sorry for taking so long to get to this, but now that plumbers is > > > > over I've had a chance to check it out on kirin > > > > > > > > Rob Clark pointed me to his branch with some fixups here: > > > > https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework > > > > > > > > But trying to boot hikey with that, I see the following loop indefinitely: > > > > [ 4.632132] adv7511 2-0039: supply avdd not found, using dummy regulator > > > > [ 4.638961] adv7511 2-0039: supply dvdd not found, using dummy regulator > > > > [ 4.645741] adv7511 2-0039: supply pvdd not found, using dummy regulator > > > > [ 4.652483] adv7511 2-0039: supply a2vdd not found, using dummy regulator > > > > [ 4.659342] adv7511 2-0039: supply v3p3 not found, using dummy regulator > > > > [ 4.666086] adv7511 2-0039: supply v1p2 not found, using dummy regulator > > > > [ 4.681898] adv7511 2-0039: failed to find dsi host > > > > > > I just realized Rob's tree is missing the kirin patch. My apologies! > > > I'll retest and let you know. > > > > Ok, just retested including the kirin patch and unfortunately I'm > > still seeing the same thing. :( > > > > Will dig a bit and let you know when I find more. > > Did you have a chance to test it on anything using drm/msm with DSI > panels? That would at least confirm that I didn't miss anything in > the drm/msm patch to swap the dsi-host vs bridge ordering.. Hi, smoke tested https://gitlab.freedesktop.org/robclark/msm/-/commits/for-mripard/bridge-rework on Pocophone F1 (sdm845 / A630) with v5.15-rc3. I see no obvious regressions in my limited testing so far including video (youtube) playback. > > BR, > -R