From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDA9C43387 for ; Mon, 7 Jan 2019 10:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA83E20859 for ; Mon, 7 Jan 2019 10:31:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="iJLg8ZlP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726625AbfAGKbS (ORCPT ); Mon, 7 Jan 2019 05:31:18 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38218 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfAGKbS (ORCPT ); Mon, 7 Jan 2019 05:31:18 -0500 Received: by mail-wr1-f68.google.com with SMTP id v13so42592298wrw.5 for ; Mon, 07 Jan 2019 02:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s1bK33lD4FkN2gbcyxZoAVisgRnF4OP9ulqVlZvrHrk=; b=iJLg8ZlPjEFPGSTWJCdkahoa0O9TALGm4uANh+TBxPpPngGy908hOELvL5pgTfIIyS XXNgLf2qFXZi8OSKIag/CqMXGNQrgpaPji4aRpipO3hAXEpUIYhh+17ZNFE3CM1XDaDh 3Zg4kVvmFoqsAn8unAIik36QavI7jHrtpbFJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s1bK33lD4FkN2gbcyxZoAVisgRnF4OP9ulqVlZvrHrk=; b=g16AXRomkqiWzB/PVW069RAyXjY6Kejn2zbwQ+khF/zifB4cf3dD8zd5reiJWbb12H bvhEM7om70mhZ8vswfbdpQaP6ghLkMIRdKSYHHUlVTmd72j7/c9V4wSuqwtb4eZqE5Be 5ly4OcFfWfLqVmV1nI3YTNAejqsBzKQOT8NIEe1K3ahaDb8QTORTuy2HvGFS/AK8aVeT QMqvca4JH4dqR5vyocsAR4IemzaDaTE2601AZx0KJHcpAiv7Y8EjDNqcw8Xo3ZTcFubO VJG/Y/rcGlPdnamHBmSWmAWSPIPUf7Wid0fBDmHOMAf0rg5n0cv1GKIsn81MlI5VqdXh AS3Q== X-Gm-Message-State: AJcUukcJwdkO6ntAcTMOEcwkvxIe+sScH1rmNkEAL+iburqPh5/LP8+H Yz9B7LC7qB0IBGmmVeiP3kiYSGc6QLiBtOhmg2atTqnjAF0= X-Google-Smtp-Source: ALg8bN7/dVAyyCeuAoot9BEY2Hmu2UutOpmoAURsf97Sn1T6fg/YPyUG9EiAqmAkpms1KzuIecaI6EwPPd4FB8soTn0= X-Received: by 2002:adf:9323:: with SMTP id 32mr50875508wro.213.1546857076028; Mon, 07 Jan 2019 02:31:16 -0800 (PST) MIME-Version: 1.0 References: <20190107094852.GA31759@kroah.com> <20190107100722.GC1314@kroah.com> In-Reply-To: <20190107100722.GC1314@kroah.com> From: Amit Pundir Date: Mon, 7 Jan 2019 16:00:39 +0530 Message-ID: Subject: Re: [for-4.9.y] Patch series "use up highorder free pages before OOM", v3. To: Greg Kroah-Hartman Cc: Minchan Kim , stable Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 7 Jan 2019 at 15:37, Greg Kroah-Hartman wrote: > > On Mon, Jan 07, 2019 at 03:25:42PM +0530, Amit Pundir wrote: > > On Mon, 7 Jan 2019 at 15:18, Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jan 07, 2019 at 03:10:35PM +0530, Amit Pundir wrote: > > > > Hi Greg, > > > > > > > > Kindly review and consider following mm/OOM upstream fixes for stable 4.9.y. > > > > > > > > 88ed365ea227 ("mm: don't steal highatomic pageblock") > > > > 04c8716f7b00 ("mm: try to exhaust highatomic reserve before the OOM") > > > > 29fac03bef72 ("mm: make unreserve highatomic functions reliable") > > > > > > > > The original 4 patch series is archived here > > > > https://lkml.org/lkml/2016/10/12/77 for review. > > > > One of the patch from this series: > > > > 4855e4a7f29d ("mm: prevent double decrease of nr_reserved_highatomic") > > > > has already been picked up for 4.9.y and 4.4.y. > > > > > > > > I ran into these fixes in one of the msm-4.9(android) trees. > > > > Cherry-picked and build tested on Linux 4.9.148 for > > > > ARCH=arm/arm64 defconfig. > > > > > > > > Only the first patch from this series can be applied cleanly on > > > > v4.4.y, while others fail to apply cleanly due to OOM rework done in > > > > v4.7 release cycle, 0a0337e0d1d1 ("mm, oom: rework oom detection"). > > > > Plus I don't see this series backported to v4.4 in any of the > > > > msm-4.4(android) trees either. So I'm skipping it for v4.4.y. > > > > > > Can you get an ack from the mm developers that these really are viable > > > for backporting to older kernel trees as they solve a real issue? > > > > I forgot to mention that marking the original series for stable > > (v4.4+) was discussed as well, and was sort of NACked > > https://lkml.org/lkml/2016/10/12/655 because no one else reported this > > OOM behavior. And the only reason I submitted this series for v4.9 is > > msm-4.9 Android trees which cherry-picked this whole series as is. > > I remember that thread, which is why I asked for explicit "yes this is > good" for 4.9. Just because a crazy vendor dropped patches in their > tree is not always a good reason to actually put them in everyone's > tree. That vendor is liable for the fallout as-is, do not transfer that > liability to upstream when they explicitly said "do not apply these"... Got it. Thanks. > > thanks, > > greg k-h