All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Pundir <amit.pundir@linaro.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH for-4.4 7/7] MIPS: Lantiq: Fix cascaded IRQ setup
Date: Thu, 6 Apr 2017 18:55:17 +0530	[thread overview]
Message-ID: <CAMi1Hd1b+CAzR==WvgPRAdFWfpMzTFrZtrcioTbOveBXNWa6ow@mail.gmail.com> (raw)
In-Reply-To: <20170406131900.GS31606@jhogan-linux.le.imgtec.org>

Hi,

On 6 April 2017 at 18:49, James Hogan <james.hogan@imgtec.com> wrote:
> Hi Amit,
>
> On Thu, Apr 06, 2017 at 06:19:00PM +0530, Amit Pundir wrote:
>> From: Felix Fietkau <nbd@nbd.name>
>>
>> With the IRQ stack changes integrated, the XRX200 devices started
>> emitting a constant stream of kernel messages like this:
>>
>> [  565.415310] Spurious IRQ: CAUSE=0x1100c300
>>
>> This is caused by IP0 getting handled by plat_irq_dispatch() rather than
>> its vectored interrupt handler, which is fixed by commit de856416e714
>> ("MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch").
>>
>> Fix plat_irq_dispatch() to handle non-vectored IPI interrupts correctly
>> by setting up IP2-6 as proper chained IRQ handlers and calling do_IRQ
>> for all MIPS CPU interrupts.
>>
>> Signed-off-by: Felix Fietkau <nbd@nbd.name>
>> Acked-by: John Crispin <john@phrozen.org>
>> Cc: linux-mips@linux-mips.org
>> Patchwork: https://patchwork.linux-mips.org/patch/15077/
>> [james.hogan@imgtec.com: tweaked commit message]
>> Signed-off-by: James Hogan <james.hogan@imgtec.com>
>>
>> (cherry picked from commit 6c356eda225e3ee134ed4176b9ae3a76f793f4dd)
>> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
>
> Weren't you going to drop this one?

I thought you wanted me to drop this one because the
dependent/relevant patches were not pushed to stable at that time. But
I re-read your email and I missed one important part that this
particular patch is valid for a separate bug introduced in IRQ stack
stuff in 4.11. I missed that important part. My apologies for that.
Again.

Greg please drop this one for both 4.4 and 4.9.

Regards,
Amit Pundir

>
> Cheers
> James

      reply	other threads:[~2017-04-06 13:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 12:48 [PATCH for-4.4 0/7] mips: IRQ stack patches from LEDE Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 1/7] MIPS: Introduce irq_stack Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 2/7] MIPS: Stack unwinding while on IRQ stack Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 3/7] MIPS: Only change $28 to thread_info if coming from user mode Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 4/7] MIPS: Switch to the irq_stack in interrupts Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 5/7] MIPS: Select HAVE_IRQ_EXIT_ON_IRQ_STACK Amit Pundir
2017-04-06 12:48 ` [PATCH for-4.4 6/7] MIPS: IRQ Stack: Fix erroneous jal to plat_irq_dispatch Amit Pundir
2017-04-06 12:49 ` [PATCH for-4.4 7/7] MIPS: Lantiq: Fix cascaded IRQ setup Amit Pundir
2017-04-06 13:19   ` James Hogan
2017-04-06 13:19     ` James Hogan
2017-04-06 13:25     ` Amit Pundir [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMi1Hd1b+CAzR==WvgPRAdFWfpMzTFrZtrcioTbOveBXNWa6ow@mail.gmail.com' \
    --to=amit.pundir@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hogan@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=nbd@nbd.name \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.