From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D93F7C2D0A3 for ; Tue, 3 Nov 2020 07:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B3BB22384 for ; Tue, 3 Nov 2020 07:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bFV6uczO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727956AbgKCHsy (ORCPT ); Tue, 3 Nov 2020 02:48:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbgKCHsv (ORCPT ); Tue, 3 Nov 2020 02:48:51 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BCD1C061A47 for ; Mon, 2 Nov 2020 23:48:50 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id c18so11702314wme.2 for ; Mon, 02 Nov 2020 23:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tUGaeM8Mnf/FUCVI3KiAYmAdi9a2oLtRodyvcvLcqLs=; b=bFV6uczOZdEu2X41lTzQJm8V8VQDTE3pWtlE6Tp8MD+Nx1HjP+D0YYsHs6nPAeXR3/ hRKLZ+vkcnx+33fPceH+Pb7Mx0POz4pZcWqJK3Q98k/EetyMA/zmuhdTOj5fQ38nOc5H VxljblMI5DlEMaC4kAeMupEG0zY8ou1YC5IzarsvlUUxKbiti0So65SEtAU919xrb+f6 fH9E4L6M9i84V4XY5ZxvvvfMeac+k7afWr50fOGholdPzvlvcT9OSwnwsMdbZEgaN2U0 4uEBqi5UHHJy/lU4bBSTxyD6EWEqNjfMuhoM+5esqzhxazSYNm8QagucDMUPJRKEIz+s /EqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tUGaeM8Mnf/FUCVI3KiAYmAdi9a2oLtRodyvcvLcqLs=; b=pV02vOXuM9QaX7c5LrdT1a293qveZiJjV3qsw6O2l1L2JrL60NHF0rhtsHywuYQE9G bxPfHKabDOK5ejXK+jcNjEM4f7+SDedJ976GTKsyx/Joe0RLqtP4ucA560YAExxTZV+E aPLqvGJekXGhZvkKdXySHUXDXBo6fRPBcSIfhEOoVp5cdrkBS84Y0l/9lAcvtw5d8NXC 4PMYmtvi34puKObbsHcH+eDC3cSgz8KQQoLiqyHDcC3CtikAtdP+B7+dJwXfb20J86LZ WwUhNFK9Vyg7K0fZHScgV4v94cpe7NREaGIF0yyD0EapuSkT9vy0XIabdaijIZAVv2fe ZsxQ== X-Gm-Message-State: AOAM533XaZ7VuobdURL5tpH6yN70/Bfk4OER8cmByAfZdzpMpa5XgaOP PdyMX9/9g5ku/gi8X7p3l64zsSGOm99BC0lg732ZIw== X-Google-Smtp-Source: ABdhPJx9ZcceuRnyasRN+tUhLDlW5agjweOQW/eO5nyTUhbn2MvXHT0gzlFn4Oww3KesuquyOtjOc0SLjijnLxJ94tE= X-Received: by 2002:a1c:1c1:: with SMTP id 184mr2149519wmb.16.1604389728675; Mon, 02 Nov 2020 23:48:48 -0800 (PST) MIME-Version: 1.0 References: <1601058581-19461-1-git-send-email-amit.pundir@linaro.org> <20200929190817.GA968845@bogus> <20201029134017.GA807@yoga> In-Reply-To: <20201029134017.GA807@yoga> From: Amit Pundir Date: Tue, 3 Nov 2020 13:18:12 +0530 Message-ID: Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests To: Bjorn Andersson Cc: Rob Herring , Kalle Valo , David S Miller , Jakub Kicinski , Jeffrey Hugo , John Stultz , Sumit Semwal , Konrad Dybcio , ath10k , dt , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Rob, Bjorn, Kalle, On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson wrote: > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > > There are firmware versions which do not support host capability > > > QMI request. We suspect either the host cap is not implemented or > > > there may be firmware specific issues, but apparently there seem > > > to be a generation of firmware that has this particular behavior. > > > > > > For example, firmware build on Xiaomi Poco F1 (sdm845) phone: > > > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1" > > > > > > If we do not skip the host cap QMI request on Poco F1, then we > > > get a QMI_ERR_MALFORMED_MSG_V01 error message in the > > > ath10k_qmi_host_cap_send_sync(). But this error message is not > > > fatal to the firmware nor to the ath10k driver and we can still > > > bring up the WiFi services successfully if we just ignore it. > > > > > > Hence introducing this DeviceTree quirk to skip host capability > > > QMI request for the firmware versions which do not support this > > > feature. > > > > So if you change the WiFi firmware, you may force a DT change too. Those > > are pretty independent things otherwise. > > > > Yes and that's not good. But I looked at somehow derive this from > firmware version numbers etc and it's not working out, so I'm out of > ideas for alternatives. > > > Why can't you just always ignore this error? If you can't deal with this > > entirely in the driver, then it should be part of the WiFi firmware so > > it's always in sync. > > > > Unfortunately the firmware versions I've hit this problem on has gone > belly up when receiving this request, that's why I asked Amit to add a > flag to skip it. So what is next for this DT quirk? I'm OK to go back to my previous of_machine_is_compatible() device specific hack, for now, https://patchwork.kernel.org/project/linux-wireless/patch/1600328501-8832-1-git-send-email-amit.pundir@linaro.org/ till we have a reasonable fix in place or receive a vendor firmware drop which fixes this problem (which I believe is highly unlikely though, for this 2+ years old device). Regards, Amit Pundir > > That said, in the devices I've hit this I've managed to get newer > firmware working, which doesn't have either problem. > > Regards, > Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZr3j-0002yE-87 for ath10k@lists.infradead.org; Tue, 03 Nov 2020 07:48:52 +0000 Received: by mail-wm1-x344.google.com with SMTP id v5so11693068wmh.1 for ; Mon, 02 Nov 2020 23:48:49 -0800 (PST) MIME-Version: 1.0 References: <1601058581-19461-1-git-send-email-amit.pundir@linaro.org> <20200929190817.GA968845@bogus> <20201029134017.GA807@yoga> In-Reply-To: <20201029134017.GA807@yoga> From: Amit Pundir Date: Tue, 3 Nov 2020 13:18:12 +0530 Message-ID: Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Bjorn Andersson Cc: Rob Herring , lkml , Jeffrey Hugo , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Konrad Dybcio , ath10k , Sumit Semwal , dt , John Stultz , Jakub Kicinski , David S Miller , Kalle Valo Hi Rob, Bjorn, Kalle, On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson wrote: > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > > There are firmware versions which do not support host capability > > > QMI request. We suspect either the host cap is not implemented or > > > there may be firmware specific issues, but apparently there seem > > > to be a generation of firmware that has this particular behavior. > > > > > > For example, firmware build on Xiaomi Poco F1 (sdm845) phone: > > > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1" > > > > > > If we do not skip the host cap QMI request on Poco F1, then we > > > get a QMI_ERR_MALFORMED_MSG_V01 error message in the > > > ath10k_qmi_host_cap_send_sync(). But this error message is not > > > fatal to the firmware nor to the ath10k driver and we can still > > > bring up the WiFi services successfully if we just ignore it. > > > > > > Hence introducing this DeviceTree quirk to skip host capability > > > QMI request for the firmware versions which do not support this > > > feature. > > > > So if you change the WiFi firmware, you may force a DT change too. Those > > are pretty independent things otherwise. > > > > Yes and that's not good. But I looked at somehow derive this from > firmware version numbers etc and it's not working out, so I'm out of > ideas for alternatives. > > > Why can't you just always ignore this error? If you can't deal with this > > entirely in the driver, then it should be part of the WiFi firmware so > > it's always in sync. > > > > Unfortunately the firmware versions I've hit this problem on has gone > belly up when receiving this request, that's why I asked Amit to add a > flag to skip it. So what is next for this DT quirk? I'm OK to go back to my previous of_machine_is_compatible() device specific hack, for now, https://patchwork.kernel.org/project/linux-wireless/patch/1600328501-8832-1-git-send-email-amit.pundir@linaro.org/ till we have a reasonable fix in place or receive a vendor firmware drop which fixes this problem (which I believe is highly unlikely though, for this 2+ years old device). Regards, Amit Pundir > > That said, in the devices I've hit this I've managed to get newer > firmware working, which doesn't have either problem. > > Regards, > Bjorn _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k