* [PATCH for-4.9 00/33] Stable commits picked up from lede project
@ 2017-04-04 6:12 Amit Pundir
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 6:12 UTC (permalink / raw)
To: gregkh; +Cc: stable
Hi Greg,
For your consideration, stable commits taken from lede source
tree for 4.9.y. Cherry-picked and build tested on Linux 4.9.20
for ARCH=arm/arm64/i386/x86_64 + allmodconfig.
Arnd Bergmann (1):
rt2500usb: don't mark register accesses as inline
Bjorn Helgaas (1):
PCI: iproc: Save host bridge window resource in struct iproc_pcie
Boris Brezillon (3):
clk: bcm: Support rate change propagation on bcm2835 clocks
clk: bcm: Allow rate change propagation to PLLH_AUX on VEC clock
clk: bcm: Fix 'maybe-uninitialized' warning in
bcm2835_clock_choose_div_and_prate()
Eric Anholt (3):
clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers.
clk: bcm2835: Register the DSI0/DSI1 pixel clocks.
clk: bcm2835: Add leaf clock measurement support, disabled by default
Felix Fietkau (1):
MIPS: Lantiq: Fix cascaded IRQ setup
John Youn (1):
usb: dwc2: Remove unnecessary kfree
Jon Mason (1):
ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags
Matthias Reichl (1):
dmaengine: bcm2835: Fix cyclic DMA period splitting
Noralf Trønnes (4):
i2c: bcm2835: Fix hang for writing messages larger than 16 bytes
i2c: bcm2835: Protect against unexpected TXW/RXR interrupts
i2c: bcm2835: Use dev_dbg logging on transfer errors
i2c: bcm2835: Can't support I2C_M_IGNORE_NAK
Rafał Miłecki (11):
ARM: BCM5301X: Add back handler ignoring external imprecise aborts
ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear
R8000
mtd: bcm47xxpart: fix parsing first block after aligned TRX
net: add devm version of alloc_etherdev_mqs function
net: bgmac: allocate struct bgmac just once & don't copy it
net: bgmac: drop struct bcma_mdio we don't need anymore
brcmfmac: check brcmf_bus_get_memdump result for error
brcmfmac: be more verbose when PSM's watchdog fires
brcmfmac: merge two brcmf_err macros into one
brcmfmac: switch to C function (__brcmf_err) for printing errors
brcmfmac: merge two remaining brcmf_err macros
Stanislaw Gruszka (3):
rt2x00usb: do not anchor rx and tx urb's
rt2x00usb: fix anchor initialization
rt2x00: avoid introducing a USB dependency in the rt2x00lib module
Tobias Klauser (1):
brcmfmac: Use net_device_stats from struct net_device
Tobias Wolf (1):
of: Add check to of_scan_flat_dt() before accessing
initial_boot_params
Vishal Thanki (1):
rt2x00: Fix incorrect usage of CONFIG_RT2X00_LIB_USB
.../bindings/clock/brcm,bcm2835-cprman.txt | 15 +-
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 48 +++
arch/arm/boot/dts/bcm5301x.dtsi | 12 +-
arch/arm/mach-bcm/bcm_5301x.c | 28 ++
arch/mips/lantiq/irq.c | 38 +--
drivers/clk/bcm/clk-bcm2835.c | 375 ++++++++++++++++++---
drivers/dma/bcm2835-dma.c | 5 +-
drivers/i2c/busses/i2c-bcm2835.c | 68 ++--
drivers/mtd/bcm47xxpart.c | 10 +-
drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 98 +++---
drivers/net/ethernet/broadcom/bgmac-bcma.c | 6 +-
drivers/net/ethernet/broadcom/bgmac-platform.c | 2 +-
drivers/net/ethernet/broadcom/bgmac.c | 25 +-
drivers/net/ethernet/broadcom/bgmac.h | 5 +-
.../wireless/broadcom/brcm80211/brcmfmac/common.c | 16 +
.../wireless/broadcom/brcm80211/brcmfmac/core.c | 26 +-
.../wireless/broadcom/brcm80211/brcmfmac/core.h | 2 -
.../wireless/broadcom/brcm80211/brcmfmac/debug.c | 35 +-
.../wireless/broadcom/brcm80211/brcmfmac/debug.h | 24 +-
drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 19 +-
drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 23 +-
drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 22 +-
drivers/of/fdt.c | 9 +-
drivers/pci/host/pcie-iproc-bcma.c | 24 +-
drivers/pci/host/pcie-iproc-platform.c | 19 +-
drivers/pci/host/pcie-iproc.h | 1 +
drivers/usb/dwc2/hcd.c | 1 -
include/dt-bindings/clock/bcm2835.h | 2 +
include/linux/etherdevice.h | 5 +
net/ethernet/eth.c | 28 ++
30 files changed, 704 insertions(+), 287 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
@ 2017-04-04 6:12 ` Amit Pundir
2017-04-04 9:31 ` Rafał Miłecki
2017-04-04 6:12 ` [PATCH 02/33] ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear R8000 Amit Pundir
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 6:12 UTC (permalink / raw)
To: gregkh; +Cc: stable, Rafał Miłecki, Florian Fainelli
From: Rafał Miłecki <rafal@milecki.pl>
Since early BCM5301X days we got abort handler that was removed by
commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
fault handler"). It assumed we need to deal only with pending aborts
left by the bootloader. Unfortunately this isn't true for BCM5301X.
When probing PCI config space (device enumeration) it is expected to
have master aborts on the PCI bus. Most bridges don't forward (or they
allow disabling it) these errors onto the AXI/AMBA bus but not the
Northstar (BCM5301X) one.
iProc PCIe controller on Northstar seems to be some older one, without
a control register for errors forwarding. It means we need to workaround
this at platform level. All newer platforms are not affected by this
issue.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
(cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
arch/arm/mach-bcm/bcm_5301x.c | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/mach-bcm/bcm_5301x.c b/arch/arm/mach-bcm/bcm_5301x.c
index c8830a2..fe067f6 100644
--- a/arch/arm/mach-bcm/bcm_5301x.c
+++ b/arch/arm/mach-bcm/bcm_5301x.c
@@ -9,14 +9,42 @@
#include <asm/hardware/cache-l2x0.h>
#include <asm/mach/arch.h>
+#include <asm/siginfo.h>
+#include <asm/signal.h>
+
+#define FSR_EXTERNAL (1 << 12)
+#define FSR_READ (0 << 10)
+#define FSR_IMPRECISE 0x0406
static const char *const bcm5301x_dt_compat[] __initconst = {
"brcm,bcm4708",
NULL,
};
+static int bcm5301x_abort_handler(unsigned long addr, unsigned int fsr,
+ struct pt_regs *regs)
+{
+ /*
+ * We want to ignore aborts forwarded from the PCIe bus that are
+ * expected and shouldn't really be passed by the PCIe controller.
+ * The biggest disadvantage is the same FSR code may be reported when
+ * reading non-existing APB register and we shouldn't ignore that.
+ */
+ if (fsr == (FSR_EXTERNAL | FSR_READ | FSR_IMPRECISE))
+ return 0;
+
+ return 1;
+}
+
+static void __init bcm5301x_init_early(void)
+{
+ hook_fault_code(16 + 6, bcm5301x_abort_handler, SIGBUS, BUS_OBJERR,
+ "imprecise external abort");
+}
+
DT_MACHINE_START(BCM5301X, "BCM5301X")
.l2c_aux_val = 0,
.l2c_aux_mask = ~0,
.dt_compat = bcm5301x_dt_compat,
+ .init_early = bcm5301x_init_early,
MACHINE_END
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 02/33] ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear R8000
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
@ 2017-04-04 6:12 ` Amit Pundir
2017-04-04 6:12 ` [PATCH 03/33] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags Amit Pundir
2017-04-04 6:30 ` [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
3 siblings, 0 replies; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 6:12 UTC (permalink / raw)
To: gregkh; +Cc: stable, Rafał Miłecki, Florian Fainelli
From: Rafał Miłecki <rafal@milecki.pl>
Netgear R8000 is a tri-band home router. It has three BCM43602 chipsets
two of them for 5 GHz band. Both seem the same and their firmwares
report the same set of channels. The problem is due to hardware / board
design there are extra limitations that should be respected.
First PHY should be used for U-NII-2 and U-NII-3. Third PHY should be
used for U-NII-1. Using them in a different way may result in wireless
not working or in noticeably reduced performance. Basic version of this
info was provided by Broadcom employee, then it has been verified by me
using original vendor firmware (which has limitations hardcoded in UI).
This patch uses recently introduced ieee80211-freq-limit property to
describe these limitations at DT level.
Referencing PCIe devices in DT required specifying all related bridges.
Below you can see (a bit complex) PCI tree from R8000 that explains all
entries that I needed to put in DT.
0000:00:00.0 14e4:8012 Bridge Device
└─ 0000:01:00.0 14e4:aa52 Network Controller
0001:00:00.0 14e4:8012 Bridge Device
└─ 0001:01:00.0 10b5:8603 Bridge Device
├─ 0001:02:01.0 10b5:8603 Bridge Device
│ └─ 0001:03:00.0 14e4:aa52 Network Controller
├─ 0001:02:02.0 10b5:8603 Bridge Device
│ └─ 0001:04:00.0 14e4:aa52 Network Controller
├─ 0001:02:03.0 000d:0000 0x000000
├─ 0001:02:04.0 000d:0000 0x000000
├─ 0001:02:05.0 000d:0000 0x000000
├─ 0001:02:06.0 000d:0000 0x000000
├─ (...)
├─ 0001:02:1d.0 000d:0000 0x000000
├─ 0001:02:1e.0 000d:0000 0x000000
└─ 0001:02:1f.0 000d:0000 0x000000
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
(cherry picked from commit 5d1f2d2c253037a5d89b48347d90868fa9407102)
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 48 +++++++++++++++++++++++++++++
arch/arm/boot/dts/bcm5301x.dtsi | 8 +++++
2 files changed, 56 insertions(+)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index ca18151..3551718 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -107,6 +107,54 @@
};
};
+&pcie0 {
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bridge@0,0,0 {
+ reg = <0x0000 0 0 0 0>;
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ wifi@0,1,0 {
+ reg = <0x0000 0 0 0 0>;
+ ieee80211-freq-limit = <5735000 5835000>;
+ };
+ };
+};
+
+&pcie1 {
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bridge@1,0,0 {
+ reg = <0x0000 0 0 0 0>;
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bridge@1,1,0 {
+ reg = <0x0000 0 0 0 0>;
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ bridge@1,2,2 {
+ reg = <0x1000 0 0 0 0>;
+
+ #address-cells = <3>;
+ #size-cells = <2>;
+
+ wifi@1,4,0 {
+ reg = <0x0000 0 0 0 0>;
+ ieee80211-freq-limit = <5170000 5730000>;
+ };
+ };
+ };
+ };
+};
+
&usb2 {
vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
};
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index ae4b388..c52711b 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -236,6 +236,14 @@
#gpio-cells = <2>;
};
+ pcie0: pcie@12000 {
+ reg = <0x00012000 0x1000>;
+ };
+
+ pcie1: pcie@13000 {
+ reg = <0x00013000 0x1000>;
+ };
+
usb2: usb2@21000 {
reg = <0x00021000 0x1000>;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 03/33] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
2017-04-04 6:12 ` [PATCH 02/33] ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear R8000 Amit Pundir
@ 2017-04-04 6:12 ` Amit Pundir
2017-04-04 6:30 ` [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
3 siblings, 0 replies; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 6:12 UTC (permalink / raw)
To: gregkh; +Cc: stable, Jon Mason, Florian Fainelli
From: Jon Mason <jon.mason@broadcom.com>
GIC_PPI flags were misconfigured for the timers, resulting in errors
like:
[ 0.000000] GIC: PPI11 is secure or misconfigured
Changing them to being edge triggered corrects the issue
Suggested-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Jon Mason <jon.mason@broadcom.com>
Fixes: d27509f1 ("ARM: BCM5301X: add dts files for BCM4708 SoC")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
(cherry picked from commit 0c2bf9f95983fe30aa2f6463cb761cd42c2d521a)
Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
---
arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index c52711b..0e929d4 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -66,14 +66,14 @@
timer@20200 {
compatible = "arm,cortex-a9-global-timer";
reg = <0x20200 0x100>;
- interrupts = <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_PPI 11 IRQ_TYPE_EDGE_RISING>;
clocks = <&periph_clk>;
};
local-timer@20600 {
compatible = "arm,cortex-a9-twd-timer";
reg = <0x20600 0x100>;
- interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_PPI 13 IRQ_TYPE_EDGE_RISING>;
clocks = <&periph_clk>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH for-4.9 00/33] Stable commits picked up from lede project
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
` (2 preceding siblings ...)
2017-04-04 6:12 ` [PATCH 03/33] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags Amit Pundir
@ 2017-04-04 6:30 ` Amit Pundir
3 siblings, 0 replies; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 6:30 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable
On 4 April 2017 at 11:42, Amit Pundir <amit.pundir@linaro.org> wrote:
> Hi Greg,
>
> For your consideration, stable commits taken from lede source
> tree for 4.9.y. Cherry-picked and build tested on Linux 4.9.20
> for ARCH=arm/arm64/i386/x86_64 + allmodconfig.
Forgot to update the Subject line of the individual patches in this
series. So they don't explicitly mention that they are targeted for
4.9. Sorry for the confusion. They don't need a resend, do they?
Regards,
Amit Pundir
>
> Arnd Bergmann (1):
> rt2500usb: don't mark register accesses as inline
>
> Bjorn Helgaas (1):
> PCI: iproc: Save host bridge window resource in struct iproc_pcie
>
> Boris Brezillon (3):
> clk: bcm: Support rate change propagation on bcm2835 clocks
> clk: bcm: Allow rate change propagation to PLLH_AUX on VEC clock
> clk: bcm: Fix 'maybe-uninitialized' warning in
> bcm2835_clock_choose_div_and_prate()
>
> Eric Anholt (3):
> clk: bcm2835: Don't rate change PLLs on behalf of DSI PLL dividers.
> clk: bcm2835: Register the DSI0/DSI1 pixel clocks.
> clk: bcm2835: Add leaf clock measurement support, disabled by default
>
> Felix Fietkau (1):
> MIPS: Lantiq: Fix cascaded IRQ setup
>
> John Youn (1):
> usb: dwc2: Remove unnecessary kfree
>
> Jon Mason (1):
> ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags
>
> Matthias Reichl (1):
> dmaengine: bcm2835: Fix cyclic DMA period splitting
>
> Noralf Trønnes (4):
> i2c: bcm2835: Fix hang for writing messages larger than 16 bytes
> i2c: bcm2835: Protect against unexpected TXW/RXR interrupts
> i2c: bcm2835: Use dev_dbg logging on transfer errors
> i2c: bcm2835: Can't support I2C_M_IGNORE_NAK
>
> Rafał Miłecki (11):
> ARM: BCM5301X: Add back handler ignoring external imprecise aborts
> ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear
> R8000
> mtd: bcm47xxpart: fix parsing first block after aligned TRX
> net: add devm version of alloc_etherdev_mqs function
> net: bgmac: allocate struct bgmac just once & don't copy it
> net: bgmac: drop struct bcma_mdio we don't need anymore
> brcmfmac: check brcmf_bus_get_memdump result for error
> brcmfmac: be more verbose when PSM's watchdog fires
> brcmfmac: merge two brcmf_err macros into one
> brcmfmac: switch to C function (__brcmf_err) for printing errors
> brcmfmac: merge two remaining brcmf_err macros
>
> Stanislaw Gruszka (3):
> rt2x00usb: do not anchor rx and tx urb's
> rt2x00usb: fix anchor initialization
> rt2x00: avoid introducing a USB dependency in the rt2x00lib module
>
> Tobias Klauser (1):
> brcmfmac: Use net_device_stats from struct net_device
>
> Tobias Wolf (1):
> of: Add check to of_scan_flat_dt() before accessing
> initial_boot_params
>
> Vishal Thanki (1):
> rt2x00: Fix incorrect usage of CONFIG_RT2X00_LIB_USB
>
> .../bindings/clock/brcm,bcm2835-cprman.txt | 15 +-
> arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 48 +++
> arch/arm/boot/dts/bcm5301x.dtsi | 12 +-
> arch/arm/mach-bcm/bcm_5301x.c | 28 ++
> arch/mips/lantiq/irq.c | 38 +--
> drivers/clk/bcm/clk-bcm2835.c | 375 ++++++++++++++++++---
> drivers/dma/bcm2835-dma.c | 5 +-
> drivers/i2c/busses/i2c-bcm2835.c | 68 ++--
> drivers/mtd/bcm47xxpart.c | 10 +-
> drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 98 +++---
> drivers/net/ethernet/broadcom/bgmac-bcma.c | 6 +-
> drivers/net/ethernet/broadcom/bgmac-platform.c | 2 +-
> drivers/net/ethernet/broadcom/bgmac.c | 25 +-
> drivers/net/ethernet/broadcom/bgmac.h | 5 +-
> .../wireless/broadcom/brcm80211/brcmfmac/common.c | 16 +
> .../wireless/broadcom/brcm80211/brcmfmac/core.c | 26 +-
> .../wireless/broadcom/brcm80211/brcmfmac/core.h | 2 -
> .../wireless/broadcom/brcm80211/brcmfmac/debug.c | 35 +-
> .../wireless/broadcom/brcm80211/brcmfmac/debug.h | 24 +-
> drivers/net/wireless/ralink/rt2x00/rt2500usb.c | 19 +-
> drivers/net/wireless/ralink/rt2x00/rt2x00dev.c | 23 +-
> drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 22 +-
> drivers/of/fdt.c | 9 +-
> drivers/pci/host/pcie-iproc-bcma.c | 24 +-
> drivers/pci/host/pcie-iproc-platform.c | 19 +-
> drivers/pci/host/pcie-iproc.h | 1 +
> drivers/usb/dwc2/hcd.c | 1 -
> include/dt-bindings/clock/bcm2835.h | 2 +
> include/linux/etherdevice.h | 5 +
> net/ethernet/eth.c | 28 ++
> 30 files changed, 704 insertions(+), 287 deletions(-)
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
@ 2017-04-04 9:31 ` Rafał Miłecki
2017-04-04 9:45 ` Amit Pundir
2017-04-05 10:12 ` Greg KH
0 siblings, 2 replies; 8+ messages in thread
From: Rafał Miłecki @ 2017-04-04 9:31 UTC (permalink / raw)
To: Amit Pundir; +Cc: gregkh, stable, Florian Fainelli
Hi Amit,
On 2017-04-04 08:12, Amit Pundir wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Since early BCM5301X days we got abort handler that was removed by
> commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
> fault handler"). It assumed we need to deal only with pending aborts
> left by the bootloader. Unfortunately this isn't true for BCM5301X.
>
> When probing PCI config space (device enumeration) it is expected to
> have master aborts on the PCI bus. Most bridges don't forward (or they
> allow disabling it) these errors onto the AXI/AMBA bus but not the
> Northstar (BCM5301X) one.
>
> iProc PCIe controller on Northstar seems to be some older one, without
> a control register for errors forwarding. It means we need to
> workaround
> this at platform level. All newer platforms are not affected by this
> issue.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
I'm sorry but I'm not familiar with your work and I'm missing some cover
letter explaining what these patches are about.
You seem to be sending this stuff to Greg. Do you wan to have to
included in
some particular stable branch? Which one? Why? Some of these patches are
clean
ups, not a really important fixes.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts
2017-04-04 9:31 ` Rafał Miłecki
@ 2017-04-04 9:45 ` Amit Pundir
2017-04-05 10:12 ` Greg KH
1 sibling, 0 replies; 8+ messages in thread
From: Amit Pundir @ 2017-04-04 9:45 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Greg Kroah-Hartman, stable, Florian Fainelli
Hi Rafal,
On 4 April 2017 at 15:01, Rafał Miłecki <rafal@milecki.pl> wrote:
> Hi Amit,
>
> On 2017-04-04 08:12, Amit Pundir wrote:
>>
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> Since early BCM5301X days we got abort handler that was removed by
>> commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
>> fault handler"). It assumed we need to deal only with pending aborts
>> left by the bootloader. Unfortunately this isn't true for BCM5301X.
>>
>> When probing PCI config space (device enumeration) it is expected to
>> have master aborts on the PCI bus. Most bridges don't forward (or they
>> allow disabling it) these errors onto the AXI/AMBA bus but not the
>> Northstar (BCM5301X) one.
>>
>> iProc PCIe controller on Northstar seems to be some older one, without
>> a control register for errors forwarding. It means we need to workaround
>> this at platform level. All newer platforms are not affected by this
>> issue.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
>> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
>
>
> I'm sorry but I'm not familiar with your work and I'm missing some cover
> letter explaining what these patches are about.
>
> You seem to be sending this stuff to Greg. Do you wan to have to included in
> some particular stable branch? Which one? Why? Some of these patches are
> clean
> ups, not a really important fixes.
My fault indeed. Apologies for that. I did send cover letter
https://www.spinics.net/lists/stable/msg165892.html but forgot to
update the Subject line of the individual patches in this series. So
they don't explicitly mention that they are targeted for stable-4.9.
Sorry for the confusion.
I cherry-picked these patches from Lede source tree
https://github.com/lede-project/source and they seemed reasonable
enough for stable-4.9. But I'll take your word if they are indeed
stable material or not. Thanks.
Regards,
Amit Pundir
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts
2017-04-04 9:31 ` Rafał Miłecki
2017-04-04 9:45 ` Amit Pundir
@ 2017-04-05 10:12 ` Greg KH
1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-04-05 10:12 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: Amit Pundir, stable, Florian Fainelli
On Tue, Apr 04, 2017 at 11:31:46AM +0200, Rafał Miłecki wrote:
> Hi Amit,
>
> On 2017-04-04 08:12, Amit Pundir wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> >
> > Since early BCM5301X days we got abort handler that was removed by
> > commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort
> > fault handler"). It assumed we need to deal only with pending aborts
> > left by the bootloader. Unfortunately this isn't true for BCM5301X.
> >
> > When probing PCI config space (device enumeration) it is expected to
> > have master aborts on the PCI bus. Most bridges don't forward (or they
> > allow disabling it) these errors onto the AXI/AMBA bus but not the
> > Northstar (BCM5301X) one.
> >
> > iProc PCIe controller on Northstar seems to be some older one, without
> > a control register for errors forwarding. It means we need to workaround
> > this at platform level. All newer platforms are not affected by this
> > issue.
> >
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820)
> > Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
>
> I'm sorry but I'm not familiar with your work and I'm missing some cover
> letter explaining what these patches are about.
>
> You seem to be sending this stuff to Greg. Do you wan to have to included in
> some particular stable branch? Which one? Why? Some of these patches are
> clean
> ups, not a really important fixes.
Are the cleanups needed for the "important fixes" that happen later in
the patch series? If not, why would they be in the repo that Amit
pulled these from? Do those developers just blindly backport stuff in?
(might be true, don't know who they are...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-04-05 10:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 6:12 [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
2017-04-04 6:12 ` [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts Amit Pundir
2017-04-04 9:31 ` Rafał Miłecki
2017-04-04 9:45 ` Amit Pundir
2017-04-05 10:12 ` Greg KH
2017-04-04 6:12 ` [PATCH 02/33] ARM: dts: BCM5301X: Set 5 GHz wireless frequency limits on Netgear R8000 Amit Pundir
2017-04-04 6:12 ` [PATCH 03/33] ARM: dts: BCM5301X: Correct GIC_PPI interrupt flags Amit Pundir
2017-04-04 6:30 ` [PATCH for-4.9 00/33] Stable commits picked up from lede project Amit Pundir
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.