From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f169.google.com ([209.85.223.169]:33231 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbdDDJpq (ORCPT ); Tue, 4 Apr 2017 05:45:46 -0400 Received: by mail-io0-f169.google.com with SMTP id f84so91675314ioj.0 for ; Tue, 04 Apr 2017 02:45:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1491286366-30720-1-git-send-email-amit.pundir@linaro.org> <1491286366-30720-2-git-send-email-amit.pundir@linaro.org> From: Amit Pundir Date: Tue, 4 Apr 2017 15:15:04 +0530 Message-ID: Subject: Re: [PATCH 01/33] ARM: BCM5301X: Add back handler ignoring external imprecise aborts To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Florian Fainelli Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: stable-owner@vger.kernel.org List-ID: Hi Rafal, On 4 April 2017 at 15:01, Rafa=C5=82 Mi=C5=82ecki wrote: > Hi Amit, > > On 2017-04-04 08:12, Amit Pundir wrote: >> >> From: Rafa=C5=82 Mi=C5=82ecki >> >> Since early BCM5301X days we got abort handler that was removed by >> commit 937b12306ea79 ("ARM: BCM5301X: remove workaround imprecise abort >> fault handler"). It assumed we need to deal only with pending aborts >> left by the bootloader. Unfortunately this isn't true for BCM5301X. >> >> When probing PCI config space (device enumeration) it is expected to >> have master aborts on the PCI bus. Most bridges don't forward (or they >> allow disabling it) these errors onto the AXI/AMBA bus but not the >> Northstar (BCM5301X) one. >> >> iProc PCIe controller on Northstar seems to be some older one, without >> a control register for errors forwarding. It means we need to workaround >> this at platform level. All newer platforms are not affected by this >> issue. >> >> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki >> Signed-off-by: Florian Fainelli >> (cherry picked from commit 09f3510fb70a46c8921f2cf4a90dbcae460a6820) >> Signed-off-by: Amit Pundir > > > I'm sorry but I'm not familiar with your work and I'm missing some cover > letter explaining what these patches are about. > > You seem to be sending this stuff to Greg. Do you wan to have to included= in > some particular stable branch? Which one? Why? Some of these patches are > clean > ups, not a really important fixes. My fault indeed. Apologies for that. I did send cover letter https://www.spinics.net/lists/stable/msg165892.html but forgot to update the Subject line of the individual patches in this series. So they don't explicitly mention that they are targeted for stable-4.9. Sorry for the confusion. I cherry-picked these patches from Lede source tree https://github.com/lede-project/source and they seemed reasonable enough for stable-4.9. But I'll take your word if they are indeed stable material or not. Thanks. Regards, Amit Pundir