From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DA73C433F5 for ; Tue, 30 Nov 2021 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dI9ubZu15vpltmkx2/ygQUWk7ZGH5BRal3b5OnTrS88=; b=Id8+ZhoRrrmJ30 HoY4yg2VfmQCxB9CAU6jGsAJqINWKXTxCZGffuPguCQdUHiYVBrxs0eicPuhhe3lxqbOVCv78edwf OLp5FGG1KRTKaF/ccV9MbpylQ3AvQ1cU2QF/P8jQnssfMN0wW39ZBS4X3FsQtOxbckL7pCkVVEuF6 8SJ2MGEXO2fc3zAUSpwwNK5pSoyu6XjAsANqp3hcWcMz5lEptJm536n3P2bgGPpV4oxRThZf/mQ9d qZI3F83qvYMRBgRdJ+LkcJ1tNrmt+egurJHgIJa1CkDXQgX4rN+2bbrEmFouufID8t7JTP7CJbyoT ICi/TLq4VxieuWlgp8ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms5Jw-005z2t-Mn; Tue, 30 Nov 2021 15:45:28 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms5Js-005z1o-Ef for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 15:45:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7584BB81A2B for ; Tue, 30 Nov 2021 15:45:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34E6AC53FCD for ; Tue, 30 Nov 2021 15:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638287121; bh=09ylkPdrTh9EDvz0lldDm4vfQjACjxORBjUmDBlOw50=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ir/TDxiqVxObjJDk3aQGL0foKzCrFfROSx+/eRU8Z9ecxBTz8CfywlJnCXXggXQRG IvQcAASGpXMO/XcNvwRLkzsYV2zLxnZ338opD7BaeHVL4FDdXdDczan39XoBe4WlO1 g674L5GMsqOVN2bpiKx7GhZX9FaCWRkuOPrkEXQTv5ArKN1DLoMFGr+8ayWJkeA+kZ H5lDiYe4F7e55mqy1+w59Aj5ld9V3T9isuom03TMeNUZv4BiZmfgSU39acPPAs+oQI jPLjkMJQTVxpO+5afbwoqMDFQnqs5LUqXElumXtB36WX+yCzBn+HNnz8UABA9R/3ZB 6v+cTbWqyu6sg== Received: by mail-oo1-f53.google.com with SMTP id v19-20020a4a2453000000b002bb88bfb594so6827993oov.4 for ; Tue, 30 Nov 2021 07:45:21 -0800 (PST) X-Gm-Message-State: AOAM5310bYb3TFJhWSYJSAM9Kfb+jse6qKrGRdVv2F8u7MSVejrW7yne GvNgg8d2kBlODoyqpMdPmJP3VyYMya+9N5gp6Xk= X-Google-Smtp-Source: ABdhPJyFyIBz+So1mKhZkbJUfOMuEBo6reFxrB5irLomZe2Z+SvoOeJ1Cp+urrKgIcLKbTUFFCKJTRmtmV5j6sq+BqA= X-Received: by 2002:a4a:5a43:: with SMTP id v64mr59388ooa.26.1638287120429; Tue, 30 Nov 2021 07:45:20 -0800 (PST) MIME-Version: 1.0 References: <20211130125901.3054-1-ardb@kernel.org> <20211130125901.3054-10-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 30 Nov 2021 16:45:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/12] ARM: percpu: add SMP_ON_UP support To: "Russell King (Oracle)" Cc: Linux ARM , Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_074524_680748_109A0011 X-CRM114-Status: GOOD ( 18.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Nov 2021 at 16:12, Russell King (Oracle) wrote: > > On Tue, Nov 30, 2021 at 01:58:58PM +0100, Ard Biesheuvel wrote: > > diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h > > index e2fcb3cfd3de..ff8f0829e041 100644 > > --- a/arch/arm/include/asm/percpu.h > > +++ b/arch/arm/include/asm/percpu.h > > @@ -5,15 +5,22 @@ > > #ifndef _ASM_ARM_PERCPU_H_ > > #define _ASM_ARM_PERCPU_H_ > > > > +#include > > + > > register unsigned long current_stack_pointer asm ("sp"); > > > > /* > > * Same as asm-generic/percpu.h, except that we store the per cpu offset > > * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7 > > */ > > -#if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6) > > +#ifdef CONFIG_SMP > > +extern unsigned int smp_on_up; > > I would much rather we kept this hidden from global view by placing it > inside the set_my_cpu_offset() body. > Good point, I'll change that. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel