From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB90C433B4 for ; Fri, 16 Apr 2021 21:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C98B0610CD for ; Fri, 16 Apr 2021 21:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243556AbhDPVkz (ORCPT ); Fri, 16 Apr 2021 17:40:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:36512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235540AbhDPVkx (ORCPT ); Fri, 16 Apr 2021 17:40:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15D47610CD; Fri, 16 Apr 2021 21:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618609228; bh=f9EMaN2F4fCZmxXmeuotxslIHmkZ/94dl7T4HpTXfNI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u+fyM+ZwLXAlJk8yv0LciwwSykMvw0Rc9UjpyPdZA7Lk93OU7QwRUNHRqXuOSnROY g83g7pLGFUu2SA7KOIAfcduuez9vNFxXG81RRqY1OgYz/Flq/WrMmMs4zQASzUQrjf HUg7PfOekKDh/CFmTqsnVAiu8qXONIecZ0KVtpn8SnDb3ELNDExByYlYV6yDKW64RP 0sLEm2lp/RMZIh+MswcJ6ewa7TV4NQz++xnc9a0egpCdsWk9B3Lhx1V1P8eoa1JLRq +APmYuo902xg5JSmvdqlvMDLhs6g7OzcXbUTQL71G78imxv2fECBLXjFAWDXXO+xtL wtJi59SKr9skw== Received: by mail-oo1-f46.google.com with SMTP id t140-20020a4a3e920000b02901e5c1add773so5199882oot.1; Fri, 16 Apr 2021 14:40:28 -0700 (PDT) X-Gm-Message-State: AOAM5332FexiILrjDk1SeWTnMo8Vez9fJv0DXcxfIG+yXA1rIAlLNihh TV93miBjrfb0H7oDr8birho7lgFqd/hUTple/rU= X-Google-Smtp-Source: ABdhPJxdMfsuLGWVNA5ayxm2yN4i+p/QjzTTX7AmIEAoxUU4u9K4CkFF2lNyvgjAd1ckXELnyhHc/v9XkbxeNcsWg0c= X-Received: by 2002:a4a:b997:: with SMTP id e23mr4811719oop.13.1618609227327; Fri, 16 Apr 2021 14:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20210416181421.2374588-1-jiancai@google.com> <20210416203522.2397801-1-jiancai@google.com> In-Reply-To: <20210416203522.2397801-1-jiancai@google.com> From: Ard Biesheuvel Date: Fri, 16 Apr 2021 23:40:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: vdso: remove commas between macro name and arguments To: Jian Cai Cc: "# 3.4.x" , Greg Kroah-Hartman , Sasha Levin , Nick Desaulniers , Nathan Chancellor , Manoj Gupta , Luis Lozano , clang-built-linux , Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Apr 2021 at 22:35, Jian Cai wrote: > > LLVM's integrated assembler does not support using commas separating > the name and arguments in .macro. However, only spaces are used in the > manual page. This replaces commas between macro names and the subsequent > arguments with space in calls to clock_gettime_return to make it > compatible with IAS. > > Link: > https://sourceware.org/binutils/docs/as/Macro.html#Macro > https://github.com/ClangBuiltLinux/linux/issues/1349 > > Suggested-by: Ard Biesheuvel Please remove this tag - the only thing I suggested was to drop part of the original patch. > Signed-off-by: Jian Cai > --- > > Changes v1 -> v2: > Keep the comma in the macro definition to be consistent with other > definitions. > > arch/arm64/kernel/vdso/gettimeofday.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/vdso/gettimeofday.S b/arch/arm64/kernel/vdso/gettimeofday.S > index 856fee6d3512..b6faf8b5d1fe 100644 > --- a/arch/arm64/kernel/vdso/gettimeofday.S > +++ b/arch/arm64/kernel/vdso/gettimeofday.S > @@ -227,7 +227,7 @@ realtime: > seqcnt_check fail=realtime > get_ts_realtime res_sec=x10, res_nsec=x11, \ > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic: > @@ -250,7 +250,7 @@ monotonic: > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x3, ts_nsec=x4, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic_raw: > @@ -271,7 +271,7 @@ monotonic_raw: > clock_nsec=x15, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x13, ts_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > realtime_coarse: > -- > 2.31.1.368.gbe11c130af-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B98C433B4 for ; Fri, 16 Apr 2021 21:42:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51700610CC for ; Fri, 16 Apr 2021 21:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51700610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UsQgCIFOhho02kEybWyXOIBaKL/eios1H0B2/eE3nMk=; b=N2AxNhweLWA0K3iEGtWtvwl9S XFgRIUZuCtHbVncTJVtLI6YZoXXF12UvbzaRq2yvJnZb0Tw4xYMNOLuk/218B48rTBRs+4SAZ+ksI Q0FvDWi/6KwewwFx76ZU5jwAMjjLeeEd6VmVzQ+nsj9TWE9TmA5hLyiJPDW5l4e1flc5dIu2q9aUm yujVRrY1o1HFnxFNjnsDisaj6hCbHGhmdZC44IY7jXb5WT96n3wCsGFWl1pW9BvGsOfGj2pSlxPzx Un0SMyKS6ZJb8GepxiL6GWOMVRuG4holztAELlIjsI+mYf5t8gFbIlXDIinS2M4IE6tmexNmbZuJI UJe/5zgKw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXWCa-003Tm5-Fy; Fri, 16 Apr 2021 21:40:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXWCV-003TkX-KV for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 21:40:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p7j7YD4iVE/Z62KME0g++6YLX424KCuhg/eYuxmEXjA=; b=tjCQIKk8a86OwFnv872KCMDG/G WM59lkLc6KGsYct+ib2IAqwYcSTlm2ylE8Xbxf5zRMQjGFfZ8CBYASMlaTW9dN4g4PJlIxqRoV1FB L5rrNRVbyKcyk8T8v2fTw03u+Xe8kYbxEJim7W6NZjxtlYMhANq6nIXbkyN7pGa8X3PZWqEWNsoj0 h3fzEQmqJfPVzBSPMz62BAcWnqITBFBCNa8StTv/QsBgiamR0Ea5TmEI1bZzzeyfwqUNPzTGPgkFz SjVegnBEG9BVGukJj6ecXRuoNLutqvEGv/SkRiDlLxaf0j9qgUTUPVm/aaL9k7PsW5P6aDdb7z10t ezqDzGkQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXWCS-009idu-S3 for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 21:40:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1DF286115B for ; Fri, 16 Apr 2021 21:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618609228; bh=f9EMaN2F4fCZmxXmeuotxslIHmkZ/94dl7T4HpTXfNI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u+fyM+ZwLXAlJk8yv0LciwwSykMvw0Rc9UjpyPdZA7Lk93OU7QwRUNHRqXuOSnROY g83g7pLGFUu2SA7KOIAfcduuez9vNFxXG81RRqY1OgYz/Flq/WrMmMs4zQASzUQrjf HUg7PfOekKDh/CFmTqsnVAiu8qXONIecZ0KVtpn8SnDb3ELNDExByYlYV6yDKW64RP 0sLEm2lp/RMZIh+MswcJ6ewa7TV4NQz++xnc9a0egpCdsWk9B3Lhx1V1P8eoa1JLRq +APmYuo902xg5JSmvdqlvMDLhs6g7OzcXbUTQL71G78imxv2fECBLXjFAWDXXO+xtL wtJi59SKr9skw== Received: by mail-oo1-f45.google.com with SMTP id c12-20020a4ae24c0000b02901bad05f40e4so6435450oot.4 for ; Fri, 16 Apr 2021 14:40:28 -0700 (PDT) X-Gm-Message-State: AOAM530DCYCqAhZxHivEjVJEAyyvOWCRc6pFhpCz88YTjlMjTb6NBQxu TY+V2U8L5yuHe+vV3XI7a+moiNvXW1T+jFS/5B8= X-Google-Smtp-Source: ABdhPJxdMfsuLGWVNA5ayxm2yN4i+p/QjzTTX7AmIEAoxUU4u9K4CkFF2lNyvgjAd1ckXELnyhHc/v9XkbxeNcsWg0c= X-Received: by 2002:a4a:b997:: with SMTP id e23mr4811719oop.13.1618609227327; Fri, 16 Apr 2021 14:40:27 -0700 (PDT) MIME-Version: 1.0 References: <20210416181421.2374588-1-jiancai@google.com> <20210416203522.2397801-1-jiancai@google.com> In-Reply-To: <20210416203522.2397801-1-jiancai@google.com> From: Ard Biesheuvel Date: Fri, 16 Apr 2021 23:40:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: vdso: remove commas between macro name and arguments To: Jian Cai Cc: "# 3.4.x" , Greg Kroah-Hartman , Sasha Levin , Nick Desaulniers , Nathan Chancellor , Manoj Gupta , Luis Lozano , clang-built-linux , Catalin Marinas , Will Deacon , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_144029_005748_7BD3AD1D X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 16 Apr 2021 at 22:35, Jian Cai wrote: > > LLVM's integrated assembler does not support using commas separating > the name and arguments in .macro. However, only spaces are used in the > manual page. This replaces commas between macro names and the subsequent > arguments with space in calls to clock_gettime_return to make it > compatible with IAS. > > Link: > https://sourceware.org/binutils/docs/as/Macro.html#Macro > https://github.com/ClangBuiltLinux/linux/issues/1349 > > Suggested-by: Ard Biesheuvel Please remove this tag - the only thing I suggested was to drop part of the original patch. > Signed-off-by: Jian Cai > --- > > Changes v1 -> v2: > Keep the comma in the macro definition to be consistent with other > definitions. > > arch/arm64/kernel/vdso/gettimeofday.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/vdso/gettimeofday.S b/arch/arm64/kernel/vdso/gettimeofday.S > index 856fee6d3512..b6faf8b5d1fe 100644 > --- a/arch/arm64/kernel/vdso/gettimeofday.S > +++ b/arch/arm64/kernel/vdso/gettimeofday.S > @@ -227,7 +227,7 @@ realtime: > seqcnt_check fail=realtime > get_ts_realtime res_sec=x10, res_nsec=x11, \ > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic: > @@ -250,7 +250,7 @@ monotonic: > clock_nsec=x15, xtime_sec=x13, xtime_nsec=x14, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x3, ts_nsec=x4, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > monotonic_raw: > @@ -271,7 +271,7 @@ monotonic_raw: > clock_nsec=x15, nsec_to_sec=x9 > > add_ts sec=x10, nsec=x11, ts_sec=x13, ts_nsec=x14, nsec_to_sec=x9 > - clock_gettime_return, shift=1 > + clock_gettime_return shift=1 > > ALIGN > realtime_coarse: > -- > 2.31.1.368.gbe11c130af-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel