From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC12C38145 for ; Thu, 8 Sep 2022 08:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbiIHI4o (ORCPT ); Thu, 8 Sep 2022 04:56:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbiIHI4o (ORCPT ); Thu, 8 Sep 2022 04:56:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ABFBD51C6 for ; Thu, 8 Sep 2022 01:56:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA6AF61BEC for ; Thu, 8 Sep 2022 08:56:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 499D6C4347C for ; Thu, 8 Sep 2022 08:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662627402; bh=zXD0AhIkAs9V9ujmbhY+ItD4u4SB0nRzuzTmbqt13Nk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Cu1m4CWz2lDiSxNPa0/CLUV0zrxoViOugUPioSZ+wTCsBQSyY55w7K7OadtEQU5UQ cxaFLEZi54G29alXivtIxnS6M60JqZoZdPn9NigT3cquV82PBwfcJGyaOAL/YE/QTT tsn+5Fdb7ZnNrxVhRIj6oOAIgfVzALUSamb9E7TJsiydCaMZkZN/QLD4f0Uencm2aq m6G2lzls4xvf0j6Wk2IP+9osIGL2/WI/y44ZH53sMhunDyF4lN889JVdOJSbTv0yke I30MQYuKdtH7d1NLBl9SFwTSN/g/qiYavF50i6R4XkFgH8WU67e9lmRm8G5BPVpLA8 UtVIVG7GYuOMw== Received: by mail-lj1-f176.google.com with SMTP id z23so19099987ljk.1 for ; Thu, 08 Sep 2022 01:56:42 -0700 (PDT) X-Gm-Message-State: ACgBeo3mJGLRcwd6zYRgjIZB/a1Wiu1sotivP5/2S8uYnhxSQ3MoK7+m K458er2QOtThJXI1AHGd8OTkKW5PMKAlDzKWm5k= X-Google-Smtp-Source: AA6agR4kxwUVNNkpcbi+yox6dCY4sg4NP3PS5hDfkUXqVOOxolWBGrqZzuZh5ifSB/NQHLftbTlCFI4Ko0wETR7WDXY= X-Received: by 2002:a2e:7314:0:b0:26a:ca18:60eb with SMTP id o20-20020a2e7314000000b0026aca1860ebmr1994798ljc.69.1662627400199; Thu, 08 Sep 2022 01:56:40 -0700 (PDT) MIME-Version: 1.0 References: <20220907023255.35237-1-chenzhang@kylinos.cn> In-Reply-To: From: Ard Biesheuvel Date: Thu, 8 Sep 2022 10:56:29 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] efi/x86: libstub: remove unused variables To: Evgeniy Baskov Cc: chen zhang , ilias.apalodimas@linaro.org, chenzhang_0901@163.com, linux-efi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Thu, 8 Sept 2022 at 10:48, Evgeniy Baskov wrote: > > On 2022-09-08 11:43, Ard Biesheuvel wrote: > > On Thu, 8 Sept 2022 at 10:42, Evgeniy Baskov wrote: > >> > >> On 2022-09-07 05:32, chen zhang wrote: > >> > The variable "has_system_memory" is unused in > >> > function =E2=80=98adjust_memory_range_protection=E2=80=99, remove it= . > >> > > >> > >> Thanks for pointing out. > >> Will change that in v2. > >> > > > > v2 of what? Isn't this code already in mainline? > > Oh, right. > > There are just more patches pending that change > that function. I can do that via separate patch later > today, I guess. > But Chen Zhang already sent a patch that fixes this, so why bother? I will queue this as a fix. Please rebase your patches on top if this causes a conflict. Thanks,