From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83CFC5519F for ; Fri, 20 Nov 2020 23:30:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D55822470 for ; Fri, 20 Nov 2020 23:30:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RZzdH79P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728650AbgKTXap (ORCPT ); Fri, 20 Nov 2020 18:30:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:49456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgKTXap (ORCPT ); Fri, 20 Nov 2020 18:30:45 -0500 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E21D92240B; Fri, 20 Nov 2020 23:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605915044; bh=pAOPOCc79X5vSW6IJcHVGfCdHUlnqpSzr+lv+zQxwCc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RZzdH79P6J5urfJDjwQdKxx5LnTEOmSru+Pngr2whnPMGGF/5iys8b3oGoRp3fiC2 B9zPEK+hV1YvwzBAM2H5HZymjsteXPWwOamkRpmbJpb2YTeAXwp7dY7auSdWBrz/F2 /N80r04AHKKCoaM6D2sPwvKPyEcCtIgwahDH+KeA= Received: by mail-oi1-f171.google.com with SMTP id a130so4261361oif.7; Fri, 20 Nov 2020 15:30:43 -0800 (PST) X-Gm-Message-State: AOAM533pXk4s93Kp6xS5SPeBjmQHE6F7HrGLtTmGW9MvJrhvPJEB/PXB Igq2Kgez7AHQx295Eujy15HDa2XxY6dtvlnIMBk= X-Google-Smtp-Source: ABdhPJydXVeIwFrz87ExsApybJ0EuK40nIe6165egNvLnhUN+I4Xd9fvkCEU5QPaIxetxiAiYULX8LNHUT5DTI1cr7A= X-Received: by 2002:aca:5c82:: with SMTP id q124mr8196235oib.33.1605915043305; Fri, 20 Nov 2020 15:30:43 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> In-Reply-To: From: Ard Biesheuvel Date: Sat, 21 Nov 2020 00:30:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 00/17] Add support for Clang LTO To: Nick Desaulniers Cc: Sami Tolvanen , Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , Linux Kbuild mailing list , LKML , PCI , Alistair Delva Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Nov 2020 at 21:19, Nick Desaulniers wrote: > > On Fri, Nov 20, 2020 at 2:30 AM Ard Biesheuvel wrote: > > > > On Thu, 19 Nov 2020 at 00:42, Nick Desaulniers wrote: > > > > > > Thanks for continuing to drive this series Sami. For the series, > > > > > > Tested-by: Nick Desaulniers > > > > > > I did virtualized boot tests with the series applied to aarch64 > > > defconfig without CONFIG_LTO, with CONFIG_LTO_CLANG, and a third time > > > with CONFIG_THINLTO. If you make changes to the series in follow ups, > > > please drop my tested by tag from the modified patches and I'll help > > > re-test. Some minor feedback on the Kconfig change, but I'll post it > > > off of that patch. > > > > > > > When you say 'virtualized" do you mean QEMU on x86? Or actual > > virtualization on an AArch64 KVM host? > > aarch64 guest on x86_64 host. If you have additional configurations > that are important to you, additional testing help would be > appreciated. > Could you run this on an actual phone? Or does Android already ship with this stuff? > > > > The distinction is important here, given the potential impact of LTO > > on things that QEMU simply does not model when it runs in TCG mode on > > a foreign host architecture. > > -- > Thanks, > ~Nick Desaulniers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02129C2D0E4 for ; Fri, 20 Nov 2020 23:31:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C732240B for ; Fri, 20 Nov 2020 23:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dh7bIJgr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RZzdH79P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C732240B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2hv259+VQ07WK4AglRzl6jMQLykg4uPESdh/3CCe9bI=; b=dh7bIJgrRAdqdZ3M7nL45fbk2 9ueQZrBkRHCBAYeQbVUgFco+NzGKlbHctgHIixmCqJAsNxYEHdhung7U8v3B4ReTqkz3Dfih6F7bb 9b4lXT08+vy7vMksZ4ReTNJrowcdV+m3fvGJ/bf0VknEakX7cIj1B0uTmM12A0/o2mzZEhhCXZyWH R+lLGo5eI3iVWgd5wsxUrAFVm3l4QuuZIltDWOLdQmMQCkNmU+QPdu8f9+FnbRIvQk33uwemAcWgq 0jr/aXuw635S+wOGFXNrwsc/YMCUsfbSzb3JtY1rS9wHrgfg1Is+8jSiv2ckjn48WFlH2z3fW0FHQ 1xvVWoFhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgFrb-0006su-V4; Fri, 20 Nov 2020 23:30:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kgFrZ-0006sB-8w for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 23:30:46 +0000 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0A3B12415A for ; Fri, 20 Nov 2020 23:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605915044; bh=pAOPOCc79X5vSW6IJcHVGfCdHUlnqpSzr+lv+zQxwCc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RZzdH79P6J5urfJDjwQdKxx5LnTEOmSru+Pngr2whnPMGGF/5iys8b3oGoRp3fiC2 B9zPEK+hV1YvwzBAM2H5HZymjsteXPWwOamkRpmbJpb2YTeAXwp7dY7auSdWBrz/F2 /N80r04AHKKCoaM6D2sPwvKPyEcCtIgwahDH+KeA= Received: by mail-oi1-f173.google.com with SMTP id a130so4261365oif.7 for ; Fri, 20 Nov 2020 15:30:44 -0800 (PST) X-Gm-Message-State: AOAM531muvi+djScapOG3cRQjFzt4/kj4KyBBcWGZdska7euK639vmPe tEuQWwPy3WOiejFJnLuL1Qp0gw/LDzHe/cVtDl4= X-Google-Smtp-Source: ABdhPJydXVeIwFrz87ExsApybJ0EuK40nIe6165egNvLnhUN+I4Xd9fvkCEU5QPaIxetxiAiYULX8LNHUT5DTI1cr7A= X-Received: by 2002:aca:5c82:: with SMTP id q124mr8196235oib.33.1605915043305; Fri, 20 Nov 2020 15:30:43 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> In-Reply-To: From: Ard Biesheuvel Date: Sat, 21 Nov 2020 00:30:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 00/17] Add support for Clang LTO To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_183045_494666_E081105B X-CRM114-Status: GOOD ( 26.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Alistair Delva , Kees Cook , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , Linux Kbuild mailing list , PCI , LKML , Steven Rostedt , clang-built-linux , Sami Tolvanen , Josh Poimboeuf , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 20 Nov 2020 at 21:19, Nick Desaulniers wrote: > > On Fri, Nov 20, 2020 at 2:30 AM Ard Biesheuvel wrote: > > > > On Thu, 19 Nov 2020 at 00:42, Nick Desaulniers wrote: > > > > > > Thanks for continuing to drive this series Sami. For the series, > > > > > > Tested-by: Nick Desaulniers > > > > > > I did virtualized boot tests with the series applied to aarch64 > > > defconfig without CONFIG_LTO, with CONFIG_LTO_CLANG, and a third time > > > with CONFIG_THINLTO. If you make changes to the series in follow ups, > > > please drop my tested by tag from the modified patches and I'll help > > > re-test. Some minor feedback on the Kconfig change, but I'll post it > > > off of that patch. > > > > > > > When you say 'virtualized" do you mean QEMU on x86? Or actual > > virtualization on an AArch64 KVM host? > > aarch64 guest on x86_64 host. If you have additional configurations > that are important to you, additional testing help would be > appreciated. > Could you run this on an actual phone? Or does Android already ship with this stuff? > > > > The distinction is important here, given the potential impact of LTO > > on things that QEMU simply does not model when it runs in TCG mode on > > a foreign host architecture. > > -- > Thanks, > ~Nick Desaulniers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF04C2D0E4 for ; Fri, 20 Nov 2020 23:31:06 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 33F9D2240B for ; Fri, 20 Nov 2020 23:31:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RZzdH79P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33F9D2240B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-20438-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 14313 invoked by uid 550); 20 Nov 2020 23:30:57 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 14293 invoked from network); 20 Nov 2020 23:30:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605915044; bh=pAOPOCc79X5vSW6IJcHVGfCdHUlnqpSzr+lv+zQxwCc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RZzdH79P6J5urfJDjwQdKxx5LnTEOmSru+Pngr2whnPMGGF/5iys8b3oGoRp3fiC2 B9zPEK+hV1YvwzBAM2H5HZymjsteXPWwOamkRpmbJpb2YTeAXwp7dY7auSdWBrz/F2 /N80r04AHKKCoaM6D2sPwvKPyEcCtIgwahDH+KeA= X-Gm-Message-State: AOAM531NgBvdjLO/regjjJygTyprv9hPsLKlIx39wUHqssIXtCm4GWRp AdpTpUficPcwePoWJ71/lkYKyITt86P16IZvbpI= X-Google-Smtp-Source: ABdhPJydXVeIwFrz87ExsApybJ0EuK40nIe6165egNvLnhUN+I4Xd9fvkCEU5QPaIxetxiAiYULX8LNHUT5DTI1cr7A= X-Received: by 2002:aca:5c82:: with SMTP id q124mr8196235oib.33.1605915043305; Fri, 20 Nov 2020 15:30:43 -0800 (PST) MIME-Version: 1.0 References: <20201118220731.925424-1-samitolvanen@google.com> In-Reply-To: From: Ard Biesheuvel Date: Sat, 21 Nov 2020 00:30:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 00/17] Add support for Clang LTO To: Nick Desaulniers Cc: Sami Tolvanen , Masahiro Yamada , Steven Rostedt , Will Deacon , Josh Poimboeuf , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , clang-built-linux , Kernel Hardening , linux-arch , Linux ARM , Linux Kbuild mailing list , LKML , PCI , Alistair Delva Content-Type: text/plain; charset="UTF-8" On Fri, 20 Nov 2020 at 21:19, Nick Desaulniers wrote: > > On Fri, Nov 20, 2020 at 2:30 AM Ard Biesheuvel wrote: > > > > On Thu, 19 Nov 2020 at 00:42, Nick Desaulniers wrote: > > > > > > Thanks for continuing to drive this series Sami. For the series, > > > > > > Tested-by: Nick Desaulniers > > > > > > I did virtualized boot tests with the series applied to aarch64 > > > defconfig without CONFIG_LTO, with CONFIG_LTO_CLANG, and a third time > > > with CONFIG_THINLTO. If you make changes to the series in follow ups, > > > please drop my tested by tag from the modified patches and I'll help > > > re-test. Some minor feedback on the Kconfig change, but I'll post it > > > off of that patch. > > > > > > > When you say 'virtualized" do you mean QEMU on x86? Or actual > > virtualization on an AArch64 KVM host? > > aarch64 guest on x86_64 host. If you have additional configurations > that are important to you, additional testing help would be > appreciated. > Could you run this on an actual phone? Or does Android already ship with this stuff? > > > > The distinction is important here, given the potential impact of LTO > > on things that QEMU simply does not model when it runs in TCG mode on > > a foreign host architecture. > > -- > Thanks, > ~Nick Desaulniers