From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0190AC43334 for ; Sun, 5 Jun 2022 14:59:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245476AbiFEO7d (ORCPT ); Sun, 5 Jun 2022 10:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237838AbiFEO7b (ORCPT ); Sun, 5 Jun 2022 10:59:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5561FCE4; Sun, 5 Jun 2022 07:59:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14EF2B80DAD; Sun, 5 Jun 2022 14:59:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B25B3C34115; Sun, 5 Jun 2022 14:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654441166; bh=yO8sK4GA4oi2wE61QwnwNeFEL4N9bZFVguHqyvO1Mzg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Rpx0QtvP3OAEnVJTixTh8HY6tbax6mGj7K9c6NngTFlHmc6FTGio7ehu8ftzLojXd jHaDSsX8FnBaLQmHcpHRcLMQuCEWABulcvKVGCBK2MkkTjEPRk6whdEwpogpJPVDpl WtcrQOMi69NEw3mh8dznD94xqkqa9JHwUlUWLdMiHSHUIyNKFK3xvU4PGnYxDNCl4r j2avMjRYrKugCOM5YR1iv8DwLOHOkTT9o1tSv73SRQCw9SxB03htrDU78PFd2fOfoj sU/s8Y5M3kRWkp6mF4I9bIrhWfYsCTIhySfny/dSUmjhvpUdD81STpUhbTe/9z9aS5 9s5fkjLZD0kFw== Received: by mail-ot1-f47.google.com with SMTP id r14-20020a056830418e00b0060b8da9ff75so9061444otu.11; Sun, 05 Jun 2022 07:59:26 -0700 (PDT) X-Gm-Message-State: AOAM5325qOpkiVXoWEkvNDCFXquh2XiqZecBhhxCuIiIe6nbJcqaEyR/ B7bmek/PuYQFQxPuHUx7QecEM3QEFVRoS/OoBi4= X-Google-Smtp-Source: ABdhPJyCWqBoqXwsEu9hOeuWUnIcpP2DSHl1ydlpagstI1NVmseMrv7ch9qdqJ9amFY2RQLE5GxctR+FAhM0jfEi8Hc= X-Received: by 2002:a9d:76d5:0:b0:60b:1882:78bd with SMTP id p21-20020a9d76d5000000b0060b188278bdmr8393936otl.71.1654441165799; Sun, 05 Jun 2022 07:59:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Sun, 5 Jun 2022 16:59:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Arnd Bergmann Cc: Yegor Yefremov , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Fri, 3 Jun 2022 at 22:47, Arnd Bergmann wrote: > > On Fri, Jun 3, 2022 at 9:11 PM Yegor Yefremov > wrote: > > > > With compiled-in drivers the system doesn't stall. All other tests and > > related outputs will come next week. > > Ah, nice! > > It's probably a reasonable assumption that the smp-patched get_current() > is (at least sometimes) broken in modules but working in the kernel itself. > I suppose that means in the worst case we can hot-fix the issue by > having an 'extern' version of get_current() for the case of > armv6+smp+module ;-) > I've coded something up along those lines, and pushed it to my am335x-stall-test branch. > Maybe start with the ".long 0xe7f001f2" hack I suggested in my last > mail. If that gives you an oops for the module case, then we know > that the patching doesn't work at all and you don't have to try anything > else, otherwise it's more likely that an incorrect instruction sequence > is patched in. > Yeah, I'd be really surprised if the patching misses some occurrences, so I have no clue what is going on here. Yegor, can you please try my branch with the original config (i.e., slcan and ftdio as modules) https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=am335x-stall-test From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCFDBC433EF for ; Sun, 5 Jun 2022 15:00:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qxq6gZ4dKk0cuCGebHpUTNgVcONXkHFHJEwjC0Ixyak=; b=o2s3rplP+WrQkr AtqsROJW9eh2tOnY/QeU2ymhCI62BzFT1AnhhdSgkFJRWfBCRadcI0g4f/VLlEZaGierDYBUrYhuj TFdghdwKLqUaQ4ZXoXQhwxCAj7iirPB73GEIgSSBoPmdyBfbJhCweZ5WmnLR9q+LRVgG1YoIGums7 m4HXP2HCY+nhg55dU/B+DsfEmngRnZiz8BAW+f8oDlGJOQAbrZwomPwHOn7Bf02PJ8ofxfUg0973X GcFoCpDa2wfN7J/xgBsM/Y2FU9xL2x/aM4Ujx2B9llZvhMbKOCnqtBaWEOQcm+nlh40PwVKu7tA6U W2PZ0n0QaorpKG4geRTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxrj3-00Egyi-SS; Sun, 05 Jun 2022 14:59:34 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxrj0-00Egxl-9u for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 14:59:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EA9E0B80DAC for ; Sun, 5 Jun 2022 14:59:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8F72C34119 for ; Sun, 5 Jun 2022 14:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654441166; bh=yO8sK4GA4oi2wE61QwnwNeFEL4N9bZFVguHqyvO1Mzg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Rpx0QtvP3OAEnVJTixTh8HY6tbax6mGj7K9c6NngTFlHmc6FTGio7ehu8ftzLojXd jHaDSsX8FnBaLQmHcpHRcLMQuCEWABulcvKVGCBK2MkkTjEPRk6whdEwpogpJPVDpl WtcrQOMi69NEw3mh8dznD94xqkqa9JHwUlUWLdMiHSHUIyNKFK3xvU4PGnYxDNCl4r j2avMjRYrKugCOM5YR1iv8DwLOHOkTT9o1tSv73SRQCw9SxB03htrDU78PFd2fOfoj sU/s8Y5M3kRWkp6mF4I9bIrhWfYsCTIhySfny/dSUmjhvpUdD81STpUhbTe/9z9aS5 9s5fkjLZD0kFw== Received: by mail-ot1-f52.google.com with SMTP id 61-20020a9d0bc3000000b0060b9bfcfe76so9072607oth.9 for ; Sun, 05 Jun 2022 07:59:26 -0700 (PDT) X-Gm-Message-State: AOAM532skzkRUaphjZ8VaOgwAnYu4y3Zp0TTBCoM216lVYbbJlk1REpS 4yihbnXU1yFOQngaeF/UV9XALqqwoBrWUm0xHh0= X-Google-Smtp-Source: ABdhPJyCWqBoqXwsEu9hOeuWUnIcpP2DSHl1ydlpagstI1NVmseMrv7ch9qdqJ9amFY2RQLE5GxctR+FAhM0jfEi8Hc= X-Received: by 2002:a9d:76d5:0:b0:60b:1882:78bd with SMTP id p21-20020a9d76d5000000b0060b188278bdmr8393936otl.71.1654441165799; Sun, 05 Jun 2022 07:59:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Sun, 5 Jun 2022 16:59:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Arnd Bergmann Cc: Yegor Yefremov , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_075930_669142_54E7F1EF X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 3 Jun 2022 at 22:47, Arnd Bergmann wrote: > > On Fri, Jun 3, 2022 at 9:11 PM Yegor Yefremov > wrote: > > > > With compiled-in drivers the system doesn't stall. All other tests and > > related outputs will come next week. > > Ah, nice! > > It's probably a reasonable assumption that the smp-patched get_current() > is (at least sometimes) broken in modules but working in the kernel itself. > I suppose that means in the worst case we can hot-fix the issue by > having an 'extern' version of get_current() for the case of > armv6+smp+module ;-) > I've coded something up along those lines, and pushed it to my am335x-stall-test branch. > Maybe start with the ".long 0xe7f001f2" hack I suggested in my last > mail. If that gives you an oops for the module case, then we know > that the patching doesn't work at all and you don't have to try anything > else, otherwise it's more likely that an incorrect instruction sequence > is patched in. > Yeah, I'd be really surprised if the patching misses some occurrences, so I have no clue what is going on here. Yegor, can you please try my branch with the original config (i.e., slcan and ftdio as modules) https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=am335x-stall-test _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel