From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091F8C77B7A for ; Fri, 2 Jun 2023 09:50:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234366AbjFBJuN (ORCPT ); Fri, 2 Jun 2023 05:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235196AbjFBJuJ (ORCPT ); Fri, 2 Jun 2023 05:50:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC051C0 for ; Fri, 2 Jun 2023 02:50:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 836E46498A for ; Fri, 2 Jun 2023 09:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5853C4339C for ; Fri, 2 Jun 2023 09:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685699406; bh=ml+OtQ6gScit3HvDHenHLPajGbsiR/AkLIHrw7hr7tA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HRwISgR/mFFyIga3EdpZvGkg3jSA0uOWkufKHH7A3UNc99l2fchlSeJnk883ahqbn jT8a27uYSGk1NxKGjbykDIguak61lTALWGQBItSGyguA9cp33hpvlTWrUoGKcFvO7q Y4RA8Swc+TSyev03IKPhTl/tCJu/EdAEb8Rg2kqYoVNK5vXRTO9o78iuVurU9g04ax 9IxMNzDdmZn7HYB6E1UuEoLMZYOjQL4KeN44q/spK2vTSsX1EEFKfJP0thPq/d5GDr 3uwZ4qKJe9y8KBUDZo220vmimSWVCBv/IrH3At7wKrNsvKSOylOiTDsmsO47wfjJfr HeRG2lwupG2Qw== Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b1ac373c9eso6621511fa.0 for ; Fri, 02 Jun 2023 02:50:06 -0700 (PDT) X-Gm-Message-State: AC+VfDx52qbnwc9ef7a5QyumV02APU2SHK3G/Zfnqz+GQovhP2WYF9iW lMF/6Jx19bchQzZCOFyKJqFGoEO9itqu2aBpJc8= X-Google-Smtp-Source: ACHHUZ7glhe0f52XYxjB5lz/ekUDyMjbJIr8UzeMHEk+AbSm14q/Xto4kYaKeA29PFIuLgT+5+lORhOvbxTMn1/WfM0= X-Received: by 2002:a2e:8e8a:0:b0:2ad:bedc:995b with SMTP id z10-20020a2e8e8a000000b002adbedc995bmr1431723ljk.16.1685699404991; Fri, 02 Jun 2023 02:50:04 -0700 (PDT) MIME-Version: 1.0 References: <20210529034138.83384-1-wangkefeng.wang@huawei.com> <20210529034138.83384-2-wangkefeng.wang@huawei.com> <20210601143125.GB30436@shell.armlinux.org.uk> In-Reply-To: <20210601143125.GB30436@shell.armlinux.org.uk> From: Ard Biesheuvel Date: Fri, 2 Jun 2023 11:49:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] ARM: mm: Refactor __do_page_fault() To: "Russell King (Oracle)" Cc: Kefeng Wang , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Jun 2021 at 16:32, Russell King (Oracle) wrote: > > On Sat, May 29, 2021 at 11:41:37AM +0800, Kefeng Wang wrote: > > 1. cleanup access_error(), make vma flags set and check into > > __do_page_fault() and do_page_fault() directly. > > > > 2. drop fsr and task argument, instead, using vm_flags in > > __do_page_fault(). > > > > 3. cleans up the multiple goto statements in __do_page_fault(). > > > > 4. use current->mm directly in do_page_fault(). > > > > Signed-off-by: Kefeng Wang > > This patch is a really good example of something that is very difficult > to review and see that there are no unintended changes. > > Many people have complained about my patches, where I create a series of > many patches where each patch does exactly _one_ simple transformation to > the code. This is a good example _why_ I do that - a step by step single > transformation approach is way easier to review. > > Sorry, but I'm not able to sensibly review this patch, and therefore > I won't apply it. Please split it into smaller changes. > Agreed. If your commit message contains an enumeration of things the patch does, it is a very strong hint that each of those things needs to be a separate patch if at all possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 420C7C77B7A for ; Fri, 2 Jun 2023 09:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5SwXIQ4WHFm9fwiTTafF22FK4gseAbDYTV5zVoo3dvk=; b=dgdhUcGQkuAOCz 6C6pgHocIHY8LrmDWHzwGnxklDo3DuZJ94pkmU4Mw4/B3qK9Eie1W7YFbIGxgK9EpE6P/flsoZtXu YUFVlaGiXjx3iX2ZIDd9pO4358qnUplYqYYSmr4btbn1ayDFSGBI5H67cX6KedXrHrdhIgqmQva0v VhTemBwOFFRFgvnRrp9zd2sjUFvHhdYs96FIcUAHwiVoCJb0D7KzX0rekSU6Jn5upczHh8VfGW12X rVBaU7PepHFCzJdD8Y9lpwEKrAAhYbzjGl2aXH2Mq+jXDlIgFP27H6Lzy4Y58tk+xhd8IcC3KWvxF GPSbXXlBaeQNCWKnPm8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q51QB-006R7d-1A; Fri, 02 Jun 2023 09:50:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q51Q8-006R6g-29 for linux-arm-kernel@lists.infradead.org; Fri, 02 Jun 2023 09:50:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 86D5764D4E for ; Fri, 2 Jun 2023 09:50:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E95B7C433D2 for ; Fri, 2 Jun 2023 09:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685699406; bh=ml+OtQ6gScit3HvDHenHLPajGbsiR/AkLIHrw7hr7tA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HRwISgR/mFFyIga3EdpZvGkg3jSA0uOWkufKHH7A3UNc99l2fchlSeJnk883ahqbn jT8a27uYSGk1NxKGjbykDIguak61lTALWGQBItSGyguA9cp33hpvlTWrUoGKcFvO7q Y4RA8Swc+TSyev03IKPhTl/tCJu/EdAEb8Rg2kqYoVNK5vXRTO9o78iuVurU9g04ax 9IxMNzDdmZn7HYB6E1UuEoLMZYOjQL4KeN44q/spK2vTSsX1EEFKfJP0thPq/d5GDr 3uwZ4qKJe9y8KBUDZo220vmimSWVCBv/IrH3At7wKrNsvKSOylOiTDsmsO47wfjJfr HeRG2lwupG2Qw== Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2b1ac373c9eso6621531fa.0 for ; Fri, 02 Jun 2023 02:50:06 -0700 (PDT) X-Gm-Message-State: AC+VfDxXD6gIF10TtRIteqD3PRsqvHW8Fi7u4NbxXKCvR7Qmiyx8KT/v 2BKDGrOTcwVNMvbNUy2G67QBZzSBMiERYEezGeI= X-Google-Smtp-Source: ACHHUZ7glhe0f52XYxjB5lz/ekUDyMjbJIr8UzeMHEk+AbSm14q/Xto4kYaKeA29PFIuLgT+5+lORhOvbxTMn1/WfM0= X-Received: by 2002:a2e:8e8a:0:b0:2ad:bedc:995b with SMTP id z10-20020a2e8e8a000000b002adbedc995bmr1431723ljk.16.1685699404991; Fri, 02 Jun 2023 02:50:04 -0700 (PDT) MIME-Version: 1.0 References: <20210529034138.83384-1-wangkefeng.wang@huawei.com> <20210529034138.83384-2-wangkefeng.wang@huawei.com> <20210601143125.GB30436@shell.armlinux.org.uk> In-Reply-To: <20210601143125.GB30436@shell.armlinux.org.uk> From: Ard Biesheuvel Date: Fri, 2 Jun 2023 11:49:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] ARM: mm: Refactor __do_page_fault() To: "Russell King (Oracle)" Cc: Kefeng Wang , linux-arm-kernel@lists.infradead.org, Catalin Marinas , linux-kernel@vger.kernel.org, Andrew Morton , Jungseung Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230602_025008_772514_7D3AC226 X-CRM114-Status: GOOD ( 23.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 1 Jun 2021 at 16:32, Russell King (Oracle) wrote: > > On Sat, May 29, 2021 at 11:41:37AM +0800, Kefeng Wang wrote: > > 1. cleanup access_error(), make vma flags set and check into > > __do_page_fault() and do_page_fault() directly. > > > > 2. drop fsr and task argument, instead, using vm_flags in > > __do_page_fault(). > > > > 3. cleans up the multiple goto statements in __do_page_fault(). > > > > 4. use current->mm directly in do_page_fault(). > > > > Signed-off-by: Kefeng Wang > > This patch is a really good example of something that is very difficult > to review and see that there are no unintended changes. > > Many people have complained about my patches, where I create a series of > many patches where each patch does exactly _one_ simple transformation to > the code. This is a good example _why_ I do that - a step by step single > transformation approach is way easier to review. > > Sorry, but I'm not able to sensibly review this patch, and therefore > I won't apply it. Please split it into smaller changes. > Agreed. If your commit message contains an enumeration of things the patch does, it is a very strong hint that each of those things needs to be a separate patch if at all possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel