From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74F3523AD for ; Thu, 22 Sep 2022 07:25:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EECDC433D6 for ; Thu, 22 Sep 2022 07:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663831506; bh=9ZIdUm1EHkiXr6vTxgGO3wrm11z3SK70+Mc1Gf/kCQU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PGdiQLrVNwZW3fKW4h5bOd+dNwKPWeJpfELG621mo2Xg+c7kI1PyQwB5n8HsEI6Y4 Z4VmK3S6qjq6EQeBT4Sn8n3UN/XYty8/OyxSAEOc6gn/9e1BwLIPl3mC0xIs6NdzxP 5bS5QOmZdgBt/ZNp0+xj7pKZoPqj88sbfIfuR+rIiTWozG4QM+sZmae9kkXMS7MZ68 IU6qVtynIebPpC61WbBVl5G0Ym54IfJDpSxKAfQ4UxZrq/xDrsSRoVxQUuglgmu8rl VTxBnD3voMZg9G87mGOfY9urpa9GNrdIg1bDgB/U8/QMtMlf0wlugQAhfcFU8tpLaE 9rSr5TMw8Exww== Received: by mail-lf1-f48.google.com with SMTP id s6so13206247lfo.7 for ; Thu, 22 Sep 2022 00:25:06 -0700 (PDT) X-Gm-Message-State: ACrzQf1pja43dw6RsAURc/anmRdQqU3K1wB5klzBYuRM12fd5QjAq10O cRQxnZwoMXMFF/i8eYMqR5Mq6fnTrXarXuw0HUw= X-Google-Smtp-Source: AMsMyM45lsOxIBQmqcVa1eBudEEidYxaHzfYG9gyrthgKWSvqQlKcedoGQfrE5bO2pGLN0aUV2sqzEDeExSKmR2PpWk= X-Received: by 2002:a05:6512:ba1:b0:498:9890:1bb4 with SMTP id b33-20020a0565120ba100b0049898901bb4mr679046lfv.122.1663831504150; Thu, 22 Sep 2022 00:25:04 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220920183554.3870247-1-ardb@kernel.org> <20220920183554.3870247-9-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 22 Sep 2022 09:24:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 8/8] efi/loongarch: libstub: remove dependency on flattened DT To: Huacai Chen Cc: linux-efi , loongarch@lists.linux.dev, Arnd Bergmann , Ilias Apalodimas , Huacai Chen , Xi Ruoyao Content-Type: text/plain; charset="UTF-8" On Thu, 22 Sept 2022 at 09:22, Huacai Chen wrote: > > On Thu, Sep 22, 2022 at 3:13 PM Ard Biesheuvel wrote: > > > > On Thu, 22 Sept 2022 at 04:15, Huacai Chen wrote: > > > > > > On Wed, Sep 21, 2022 at 4:15 PM Ard Biesheuvel wrote: > > > > > > > > On Wed, 21 Sept 2022 at 06:02, Huacai Chen wrote: > > > > > > > > > > Acked-by: Huacai Chen > > > > > > > > > > > > > Thank you Huacai > > > > > > > > I have created a separate tag with these patches applied onto the > > > > first loongarch efi enablement patch (see below) > > > > > > > > I would prefer to keep the loongarch trees separate for the next merge > > > > window, but if needed to avoid massive conflicts, you could merge the > > > > tag into the loongarch tree and rebase your changes on top. But please > > > > take care not to rebase those patches themselves: the commit SHAs need > > > > to remain the same. > > > > > > > > However, if the conflicts are only minor, you can just explain in your > > > > PR to Linus what the resolution should look like. > > > > > > > > The tag can be found here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/tag/?h=efi-loongarch-for-v6.1-2 > > > > > > > > I have merged this into the EFI tree as well and pushed it out; it > > > > should appear in -next tomorrow. > > > > > > > > > > > > > > > > b093dc55ba9a efi/loongarch: libstub: remove dependency on flattened DT > > > > 102faf0747c2 efi: libstub: install boot-time memory map as config table > > > > 7318926e7bc9 efi: libstub: remove DT dependency from generic stub > > > > 7cb6671e3caa efi: libstub: unify initrd loading between architectures > > > > I will have to respin the initrd patch, unfortunately, as it breaks > > x86. So the signed tag will be updated, and the SHAs above will change > > as well. > Emm, initrd is also broken on LoongArch, the core kernel gets an > EFI_INVALID_TABLE_ADDR address. > OK, I will investigate. This was working fine before so I'm not sure what happened there. > > > > > > 1add08ceb15b efi: libstub: remove pointless goto kludge > > > > d2130a9cf0f7 efi: libstub: simplify efi_get_memory_map() and struct > > > > efi_boot_memmap > > > > bc5853aa56de efi: libstub: avoid efi_get_memory_map() for allocating > > > > the virt map > > > > d80ca810f096 efi: libstub: drop pointless get_memory_map() call > > > > ead384d95634 (tag: efi-loongarch-for-v6.1) efi/loongarch: Add efistub > > > > booting support > > > > 568035b01cfb (tag: v6.0-rc1) Linux 6.0-rc1 > > > Hmmm, I want to also merge zboot support in the loongarch-next's base, > > > is that possible? > > > > > > > No, let's keep that separate. LoongArch boots fine without it, so we > > can wait until it arrives via the EFI tree, no? > Both OK but I prefer to use a compressed kernel in daily work. > I understand that. But what you use for daily work and what you send to Linus are two different things, no?