From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 710F0C433E0 for ; Sat, 27 Jun 2020 07:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51C6320706 for ; Sat, 27 Jun 2020 07:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593244688; bh=2/cm0M8v0eEtEFJEA8Dif5Ov9yE8KEk2CBe8/6XUXWM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=NBVFb/Y8WB+G4zYjALgM1zuvXeR60RuHgK7zPX+R948tCNSrF4Tf+jqemKyB0Hpyc Ghk/UJKn3xgdcraiNWj7Id+1AFj3Uf+iT9s/3+7ltUGOmOctcDlOKv6BYp/F0hbKal mODBxbHem53bA6qm/DCWF+Gdckz0k9Ce+UQDzDPQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbgF0H6G (ORCPT ); Sat, 27 Jun 2020 03:58:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:47928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbgF0H6C (ORCPT ); Sat, 27 Jun 2020 03:58:02 -0400 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 790372081A; Sat, 27 Jun 2020 07:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593244682; bh=2/cm0M8v0eEtEFJEA8Dif5Ov9yE8KEk2CBe8/6XUXWM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gOEMIbZQ5LnRjtui26c5ZekgfuHOCD/wNPRfzXO6NWYj/K5k+yrpmPjt+ueSyxrAn tEnXIgGvVa2aqhClJei5hf31zLUuRBVV83FLOBPRf22h1GtSTSZc0BH1827KlPArAA MWBf3/6LUrTmk7lo7nr0XO4PNnhrTQVIrLR3UbQI= Received: by mail-ot1-f45.google.com with SMTP id n24so8539226otr.13; Sat, 27 Jun 2020 00:58:02 -0700 (PDT) X-Gm-Message-State: AOAM533nUW2tFVoOjWQl4OW9xExZL1o36xwtmzgvnFCqe2b2eMZmOKVl xmUSmSp9ru+32jyfN2W1Jn/V8wMhi/DJj7jOwDY= X-Google-Smtp-Source: ABdhPJyvEZ4ya/6GghXmbfDKYZlNzJQbzAIIUY/SlUz7bnD/Np9o6UmM8NkCsnN45BvB9WbnoZS7OhBRZNX9Vc6iEnA= X-Received: by 2002:a4a:9210:: with SMTP id f16mr5775705ooh.13.1593244681878; Sat, 27 Jun 2020 00:58:01 -0700 (PDT) MIME-Version: 1.0 References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> <20200627075659.GA12509@lst.de> In-Reply-To: <20200627075659.GA12509@lst.de> From: Ard Biesheuvel Date: Sat, 27 Jun 2020 09:57:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page To: Christoph Hellwig Cc: Andrew Morton , linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Vitaly Kuznetsov , Will Deacon , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Jun 2020 at 09:57, Christoph Hellwig wrote: > > On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > > + NUMA_NO_NODE, __func__); > > > > Why is this passing a string for the 'caller' argument, and not the > > address of the caller? > > Dementia. Fix sent. :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2095AC433E0 for ; Sat, 27 Jun 2020 07:58:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC28B20706 for ; Sat, 27 Jun 2020 07:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOEMIbZQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC28B20706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 777586B009E; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 727BC6B009F; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 662E06B00A0; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 4B9B26B009E for ; Sat, 27 Jun 2020 03:58:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0319B180AD807 for ; Sat, 27 Jun 2020 07:58:04 +0000 (UTC) X-FDA: 76974238488.30.crack00_5b0de3626e5c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D4EF4180B3C85 for ; Sat, 27 Jun 2020 07:58:03 +0000 (UTC) X-HE-Tag: crack00_5b0de3626e5c X-Filterd-Recvd-Size: 3019 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 07:58:03 +0000 (UTC) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 838A6212CC for ; Sat, 27 Jun 2020 07:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593244682; bh=2/cm0M8v0eEtEFJEA8Dif5Ov9yE8KEk2CBe8/6XUXWM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gOEMIbZQ5LnRjtui26c5ZekgfuHOCD/wNPRfzXO6NWYj/K5k+yrpmPjt+ueSyxrAn tEnXIgGvVa2aqhClJei5hf31zLUuRBVV83FLOBPRf22h1GtSTSZc0BH1827KlPArAA MWBf3/6LUrTmk7lo7nr0XO4PNnhrTQVIrLR3UbQI= Received: by mail-ot1-f41.google.com with SMTP id 95so138393otw.10 for ; Sat, 27 Jun 2020 00:58:02 -0700 (PDT) X-Gm-Message-State: AOAM532hx31ZDus8Dtep1Gk74MdTv9nogTOccrMKsFKWaoOr/Z3tcRLw d7+KRuw+lvYJHv84NX7A8jdOaiZ+ZE9/BAFiuw8= X-Google-Smtp-Source: ABdhPJyvEZ4ya/6GghXmbfDKYZlNzJQbzAIIUY/SlUz7bnD/Np9o6UmM8NkCsnN45BvB9WbnoZS7OhBRZNX9Vc6iEnA= X-Received: by 2002:a4a:9210:: with SMTP id f16mr5775705ooh.13.1593244681878; Sat, 27 Jun 2020 00:58:01 -0700 (PDT) MIME-Version: 1.0 References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> <20200627075659.GA12509@lst.de> In-Reply-To: <20200627075659.GA12509@lst.de> From: Ard Biesheuvel Date: Sat, 27 Jun 2020 09:57:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page To: Christoph Hellwig Cc: Andrew Morton , linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Vitaly Kuznetsov , Will Deacon , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D4EF4180B3C85 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 27 Jun 2020 at 09:57, Christoph Hellwig wrote: > > On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > > + NUMA_NO_NODE, __func__); > > > > Why is this passing a string for the 'caller' argument, and not the > > address of the caller? > > Dementia. Fix sent. :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D8EC433DF for ; Sat, 27 Jun 2020 08:01:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C702320706 for ; Sat, 27 Jun 2020 08:01:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xSQUxLd4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOEMIbZQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C702320706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9UQ2GW04nRw9QOMLpO1LPSupgOm6yRT7j8h189QqAM=; b=xSQUxLd4+1syQF5qQc+EW53tP oymgAt6rpZn1Gb4RxhFf9bAXB70zW4jynVIBMNYIupl//36omRXjzQIXrLxq/E6oh2fQhIOTZXQP8 eQFPNFamShCquOBw6GaAMuUxYPcN2KZDTBx/FLCe5yql294XzAqsr0qfqcnowxDQ8bGBvm9c11r9R in+3Jx7iNcn2xsbFM4if0qCpuy9F1Ya48ORTsNE+az9r8cp7XrbRMEDS8LMUCO4rgW6AAtJNt5Agb YybkIiKfhZOJAwvKu5/NnqIhMA/iDvIC0SrGpgQfUKSq/XSU/S0+KNkNdGlC5peNG6mY5beqZsyJ1 HZ+MkkjvQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5iv-0004Cx-Lm; Sat, 27 Jun 2020 07:58:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jp5it-0004CV-3n for linux-arm-kernel@lists.infradead.org; Sat, 27 Jun 2020 07:58:03 +0000 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7196920706 for ; Sat, 27 Jun 2020 07:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593244682; bh=2/cm0M8v0eEtEFJEA8Dif5Ov9yE8KEk2CBe8/6XUXWM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=gOEMIbZQ5LnRjtui26c5ZekgfuHOCD/wNPRfzXO6NWYj/K5k+yrpmPjt+ueSyxrAn tEnXIgGvVa2aqhClJei5hf31zLUuRBVV83FLOBPRf22h1GtSTSZc0BH1827KlPArAA MWBf3/6LUrTmk7lo7nr0XO4PNnhrTQVIrLR3UbQI= Received: by mail-ot1-f42.google.com with SMTP id k15so10757524otp.8 for ; Sat, 27 Jun 2020 00:58:02 -0700 (PDT) X-Gm-Message-State: AOAM531VEBX1gnQAyhMWQhiEDEuRlxSlGEFYn3CKMSXUVRZbL0YW93y1 TDE7BBjFiwiyqGhjvKxWR2B8vyg3Bo9ndQ4aqOo= X-Google-Smtp-Source: ABdhPJyvEZ4ya/6GghXmbfDKYZlNzJQbzAIIUY/SlUz7bnD/Np9o6UmM8NkCsnN45BvB9WbnoZS7OhBRZNX9Vc6iEnA= X-Received: by 2002:a4a:9210:: with SMTP id f16mr5775705ooh.13.1593244681878; Sat, 27 Jun 2020 00:58:01 -0700 (PDT) MIME-Version: 1.0 References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> <20200627075659.GA12509@lst.de> In-Reply-To: <20200627075659.GA12509@lst.de> From: Ard Biesheuvel Date: Sat, 27 Jun 2020 09:57:50 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page To: Christoph Hellwig X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Andrew Morton , Will Deacon , Vitaly Kuznetsov , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 27 Jun 2020 at 09:57, Christoph Hellwig wrote: > > On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > > + NUMA_NO_NODE, __func__); > > > > Why is this passing a string for the 'caller' argument, and not the > > address of the caller? > > Dementia. Fix sent. :-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel