Re: [PATCH 5/6] crypto: ahash - Remove AHASH_REQUEST_ON_STACK

[Ard Biesheuvel <ardb@kernel.org>]

On Tue, 18 Aug 2020 at 10:25, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> This patch removes AHASH_REQUEST_ON_STACK which is unused.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

and given that any new uses that creep in will trigger -Wvla warnings,
I suggest this is broken out from the series and merged as a fix
instead.


> ---
>
>  include/crypto/hash.h |    5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/include/crypto/hash.h b/include/crypto/hash.h
> index c9d3fd3efa1b0..f16f5d4afc102 100644
> --- a/include/crypto/hash.h
> +++ b/include/crypto/hash.h
> @@ -59,11 +59,6 @@ struct ahash_request {
>         void *__ctx[] CRYPTO_MINALIGN_ATTR;
>  };
>
> -#define AHASH_REQUEST_ON_STACK(name, ahash) \
> -       char __##name##_desc[sizeof(struct ahash_request) + \
> -               crypto_ahash_reqsize(ahash)] CRYPTO_MINALIGN_ATTR; \
> -       struct ahash_request *name = (void *)__##name##_desc
> -
>  /**
>   * struct ahash_alg - asynchronous message digest definition
>   * @init: **[mandatory]** Initialize the transformation context. Intended only to initialize the