From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11DC4C433F5 for ; Tue, 21 Sep 2021 14:36:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3A5261183 for ; Tue, 21 Sep 2021 14:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3A5261183 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WzLho3ozcxu8lDtBhKQxbnczqkvTfEnnUy5wZL+z0MA=; b=N+HDuYkHk7z+Sf jnleH25/Px79Vmtl3u6CVRzcT/kOZ/HwawEWQ/SDsoDVq4LbstUy3n0Hqdaa5Aps7D9ZN++stM4iV 3Uo+q9yUM07DnzdyIy1Y/TPoGp01oozTnANWdJ3JP3O0UoTu42gtq/9FI59oDaiu+Mu09GkO+GWyL seY+TQCKJOYfvQTAzLXj6vEKdCjXuWQMkvugJW/28RzEefckd2ifuO4n+atU0YWvM4PIoit7CRull pxe5hDm31wgPgzXtHH6apzMmkawTcqyDOTPAGvcydc12dgrxA1s1wXHQbRPGwTVW40OCvoaGK7Gmy 7yVcel+TcASYsmPP/cfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSgpt-004lyQ-Bv; Tue, 21 Sep 2021 14:33:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSgpp-004ly6-Mg for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 14:33:26 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A86C611ED for ; Tue, 21 Sep 2021 14:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632234805; bh=5N2bLYgYScLAaFk1+ooqhePzKRmmgv1gWnrc3YTaVr4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=RpkwFf+K7sxXgFayr2iWRytkS/NfZ0UC4GJPzS2+sYC5GO9Pf99Kf8qTtWN/EKOsh SVzWnPcCRHSetPJqg7L5jblY9G07EKUrcrL9bncBCAepSDKrZXrdjvJGE8fV890AGG YndPVKDAAXkCSlpPrMlzrdgB7L5VI7NNwtXCs777ggPm7+6/hTbh2Cr2TXUywQ4sst /a1ygkGsGl5Izn5Pb21k/PUbkkKBVvvktASKnnCJMf0acoVfbHBNWyAGDsewoWWqFk GV6A/0tIOMxoy4paMXbcZWDbj/fSvSJltAX8ReolbS8m1faWQWuPEeyaXQJ8BRrCwX ZRc8NwCIRGX9A== Received: by mail-oi1-f171.google.com with SMTP id r26so29949460oij.2 for ; Tue, 21 Sep 2021 07:33:25 -0700 (PDT) X-Gm-Message-State: AOAM530BAQgvgdTRnOBN3cqQK+IU2zx+UGGIxL6yJt30Mb4/FldVTCEi rG6GEDMzkQ5aqxEkovSHyZYwwAkgocqyvxUAUnk= X-Google-Smtp-Source: ABdhPJySHxJ2mT6V74t9pRTLyBIq0OmOykc2Us194TpaFUwecH2W+hwU7IfB+XlxkPBT4SToQi6bFHaH0d4qA3J5K6k= X-Received: by 2002:a05:6808:15a2:: with SMTP id t34mr3829785oiw.47.1632234804454; Tue, 21 Sep 2021 07:33:24 -0700 (PDT) MIME-Version: 1.0 References: <20210921095408.133210-1-ardb@kernel.org> <20210921095408.133210-2-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 21 Sep 2021 16:33:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault() To: "Russell King (Oracle)" Cc: Linux ARM , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_073325_800258_DC0BE9EA X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 21 Sept 2021 at 16:02, Russell King (Oracle) wrote: > > On Tue, Sep 21, 2021 at 11:53:59AM +0200, Ard Biesheuvel wrote: > > Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead > > of set_fs()") replaced an occurrence of __get_user() with > > get_kernel_nofault(), but inverted the sense of the conditional in the > > process, resulting in no values to be printed at all. > > > > I.e., every exception stack now looks like this: > > > > Exception stack(0xc18d1fb0 to 0xc18d1ff8) > > 1fa0: ???????? ???????? ???????? ???????? > > 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ???????? > > 1fe0: ???????? ???????? ???????? ???????? ???????? ???????? > > > > which is rather unhelpful. > > > > Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()") > > Signed-off-by: Ard Biesheuvel > > This is definitely a bug fix to one of the previous series, and should > be independent of the rest of the series. > > Please put it in the patch system, thanks. > Queued up as 9125/1 -- Ard. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel