From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AABC433F5 for ; Sat, 28 May 2022 09:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbiE1JH6 (ORCPT ); Sat, 28 May 2022 05:07:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbiE1JH5 (ORCPT ); Sat, 28 May 2022 05:07:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1403C217; Sat, 28 May 2022 02:07:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA79B60C59; Sat, 28 May 2022 09:07:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AAAFC34114; Sat, 28 May 2022 09:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653728874; bh=++iIKTzT8BlgqQeTXIS+I91B25rhPAewWrfFC1nVGwM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tCLvLkXr/uCNwwBbTV1Aon10/ImkPIcE6FTSnmc+qzJscoJJ0KWWEegZ0lHU0MMXC FCN+OxkGhJDyYsoY8V6LrmXQgJ1HbXgsDVREgbXkTMIrJY0A13Di1tNx3oXmHeIAkY NhM9HFDjskZ5HaQHzR3qKxgbDdX3OFeFTphCd/2hnBVYuXNeBqW2Pwv7Kr24JRbnrb r+UReUxrzUOct8vORzfy4D8ge++WaDF6kSm+VnBQf78hM9J5Vph2DtIy+4J2hRBtc6 t0pijb485C0fsaLtSf48dYMLlmgjoiEGlhQanpOyCrGGbzVK0uSIeXWLdlqnCNu3YM lx3iuknMyPJvw== Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-edeb6c3642so8478997fac.3; Sat, 28 May 2022 02:07:54 -0700 (PDT) X-Gm-Message-State: AOAM5332DhWMkM0qBBmEiUKRH7pfQKRvMOs1ryuNPiptTdGIjl6j+ag+ Nc3k1gEovyw6hkaK8LZZaeZ9a1wFkYU4hMIB+oI= X-Google-Smtp-Source: ABdhPJw2lq56t4wMHLXUFS9u0ZeTqkLqI18yQz9gIx+j+0hn+/jjzDVvsTaHIzhs8X7gZq5uU08KYWJkz4kHrhqEr5A= X-Received: by 2002:a05:6870:eaa5:b0:da:b3f:2b45 with SMTP id s37-20020a056870eaa500b000da0b3f2b45mr6123131oap.228.1653728873386; Sat, 28 May 2022 02:07:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Sat, 28 May 2022 11:07:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Arnd Bergmann , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sat, 28 May 2022 at 10:29, Yegor Yefremov wrote: > > On Sat, May 28, 2022 at 9:53 AM Arnd Bergmann wrote: > > > > On Sat, May 28, 2022 at 7:48 AM Yegor Yefremov > > wrote: > > > > > > On Fri, May 27, 2022 at 4:13 PM Arnd Bergmann wrote: > > > > > > > > On Fri, May 27, 2022 at 3:12 PM Ard Biesheuvel wrote: > > > > > On Fri, 27 May 2022 at 14:54, Arnd Bergmann wrote: > > > > > > On Fri, May 27, 2022 at 11:50 AM Yegor Yefremov wrote: > > > > > > > > > > Not just per-cpu data: there is also the 'current' global variable > > > > > which gets used now instead of the user thread ID register, and this > > > > > is also different between modules and the core kernel (unless > > > > > CONFIG_ARM_MODULE_PLTS is disabled) > > > > > > > > Right, so if the percpu hack doesn't address it, this one might: > > > > > > > > diff --git a/arch/arm/include/asm/current.h b/arch/arm/include/asm/current.h > > > > index 1e1178bf176d..306d1a4cae40 100644 > > > > --- a/arch/arm/include/asm/current.h > > > > +++ b/arch/arm/include/asm/current.h > > > > @@ -18,6 +18,8 @@ static __always_inline __attribute_const__ struct > > > > task_struct *get_current(void) > > > > { > > > > struct task_struct *cur; > > > > > > > > + return __current; > > > > + > > > > #if __has_builtin(__builtin_thread_pointer) && \ > > > > defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) && \ > > > > !(defined(CONFIG_THUMB2_KERNEL) && \ > > > > > > I have tried this patch and the system still stalls. > > > > Ok, thanks for testing. To clarify: did you test with both the get_current() and > > __my_cpu_offset() changes applied, or just the get_current() one? > > I have tested only the get_current() one. Should I also test > __my_cpu_offset() separately and combined? > That would be helpful, yes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED8BCC433F5 for ; Sat, 28 May 2022 09:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e3DFHe0TN6kd0MErI0Rj2CGh1o1M30cewXTDmbA0bhc=; b=JDJq8ddOCwja6q 84n6Tea2LrWzhXcegVF3xo9uGTZtsThvK31icCTzlo3PYIpIWJSVYozSR2UwrXEh70B5Bsih/uUMf uaji5iPieejxr/qLYSYfrd3VpsTmfNuJO4Q4kX7BMIqvhGv8rrMXeHFpihvsT+WRe9nAQ3GxxjGBa 495tz6vTySKNmXroBq0yQIhHvwXlMqX+RB2qP7Wzl0Iq8/bFNBJKHCDCjb4ZIvUBYbO+AUc9yAgLx VTBWrjOCVIVUDN36OwVrvDiBa8ijS35Bwr/IxIMkHH4rjFFJ8kr/3XwLtIBjkeUNG4scMS8KFbyPw QekVZDearA/celB5zsTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nusQU-001nLT-IZ; Sat, 28 May 2022 09:08:02 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nusQQ-001nL1-Sq for linux-arm-kernel@lists.infradead.org; Sat, 28 May 2022 09:08:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8AE5DB82682 for ; Sat, 28 May 2022 09:07:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38511C34100 for ; Sat, 28 May 2022 09:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653728874; bh=++iIKTzT8BlgqQeTXIS+I91B25rhPAewWrfFC1nVGwM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=tCLvLkXr/uCNwwBbTV1Aon10/ImkPIcE6FTSnmc+qzJscoJJ0KWWEegZ0lHU0MMXC FCN+OxkGhJDyYsoY8V6LrmXQgJ1HbXgsDVREgbXkTMIrJY0A13Di1tNx3oXmHeIAkY NhM9HFDjskZ5HaQHzR3qKxgbDdX3OFeFTphCd/2hnBVYuXNeBqW2Pwv7Kr24JRbnrb r+UReUxrzUOct8vORzfy4D8ge++WaDF6kSm+VnBQf78hM9J5Vph2DtIy+4J2hRBtc6 t0pijb485C0fsaLtSf48dYMLlmgjoiEGlhQanpOyCrGGbzVK0uSIeXWLdlqnCNu3YM lx3iuknMyPJvw== Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-f2cd424b9cso8450477fac.7 for ; Sat, 28 May 2022 02:07:54 -0700 (PDT) X-Gm-Message-State: AOAM533tjPtazpKibEHd+oVpC6JIBRcPih7Z6Bd1Wox7UMYlmoCoCOVl 2dflQjIuwIF5J2h2mIumCT8tz90h6THZ9DUkcVU= X-Google-Smtp-Source: ABdhPJw2lq56t4wMHLXUFS9u0ZeTqkLqI18yQz9gIx+j+0hn+/jjzDVvsTaHIzhs8X7gZq5uU08KYWJkz4kHrhqEr5A= X-Received: by 2002:a05:6870:eaa5:b0:da:b3f:2b45 with SMTP id s37-20020a056870eaa500b000da0b3f2b45mr6123131oap.228.1653728873386; Sat, 28 May 2022 02:07:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ard Biesheuvel Date: Sat, 28 May 2022 11:07:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: am335x: 5.18.x: system stalling To: Yegor Yefremov Cc: Arnd Bergmann , Tony Lindgren , Linux-OMAP , linux-clk , Stephen Boyd , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220528_020759_265045_F74A8E46 X-CRM114-Status: GOOD ( 24.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 28 May 2022 at 10:29, Yegor Yefremov wrote: > > On Sat, May 28, 2022 at 9:53 AM Arnd Bergmann wrote: > > > > On Sat, May 28, 2022 at 7:48 AM Yegor Yefremov > > wrote: > > > > > > On Fri, May 27, 2022 at 4:13 PM Arnd Bergmann wrote: > > > > > > > > On Fri, May 27, 2022 at 3:12 PM Ard Biesheuvel wrote: > > > > > On Fri, 27 May 2022 at 14:54, Arnd Bergmann wrote: > > > > > > On Fri, May 27, 2022 at 11:50 AM Yegor Yefremov wrote: > > > > > > > > > > Not just per-cpu data: there is also the 'current' global variable > > > > > which gets used now instead of the user thread ID register, and this > > > > > is also different between modules and the core kernel (unless > > > > > CONFIG_ARM_MODULE_PLTS is disabled) > > > > > > > > Right, so if the percpu hack doesn't address it, this one might: > > > > > > > > diff --git a/arch/arm/include/asm/current.h b/arch/arm/include/asm/current.h > > > > index 1e1178bf176d..306d1a4cae40 100644 > > > > --- a/arch/arm/include/asm/current.h > > > > +++ b/arch/arm/include/asm/current.h > > > > @@ -18,6 +18,8 @@ static __always_inline __attribute_const__ struct > > > > task_struct *get_current(void) > > > > { > > > > struct task_struct *cur; > > > > > > > > + return __current; > > > > + > > > > #if __has_builtin(__builtin_thread_pointer) && \ > > > > defined(CONFIG_CURRENT_POINTER_IN_TPIDRURO) && \ > > > > !(defined(CONFIG_THUMB2_KERNEL) && \ > > > > > > I have tried this patch and the system still stalls. > > > > Ok, thanks for testing. To clarify: did you test with both the get_current() and > > __my_cpu_offset() changes applied, or just the get_current() one? > > I have tested only the get_current() one. Should I also test > __my_cpu_offset() separately and combined? > That would be helpful, yes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel