From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27C1F28DCB for ; Mon, 19 Feb 2024 10:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340238; cv=none; b=A/qCDZ72TX45iINhEhcQBpQZlKmLSnzeUcsrvPJhmC1H/9aiXzQiziCvLWtvcLpJcTINhSDLs+2r08G1e6+e5w4C/X1LSjM6GKW7NRYvEN4szjZnimCry/lEn3f7O7NXqZMLcOzV0h89EVQz5IiRvwkKIA79WekPInC553Oyt5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340238; c=relaxed/simple; bh=9dOeyiDJsSefv4EBMEfGuKU7J4MB2+An6FzWYy2il5o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=uGyYjhMZ3ilI4J6xGz93r4SkSG+l9jwgt/2vZEdzHfm2Y8c03lesVjJ5kN8q8danw+K5hJxdMXP22RCpZawGsiIrgNlFkKYzUoeFTMrL1WcltQzrPILOitxNOe8rHmSD3cxfWfKIp0+npCIyBlxw7D+1pzlCosHBET/lTGGsq/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HvqTtu1G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HvqTtu1G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C0CC433C7 for ; Mon, 19 Feb 2024 10:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708340237; bh=9dOeyiDJsSefv4EBMEfGuKU7J4MB2+An6FzWYy2il5o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HvqTtu1GDkne6c7hAAj4kowEJY0j5GUBUUZnIYkpw+D6Br7atvu5XQtpHhF80dNSD 5U8YYjjPENNs/6r6OKEWvmq4AU9+iclJ/FW//j+GXhl09mtA3xN66fb9vO1k/zmT4h Ce+tnRbA1oMFTmv/2kcKxBrOEgDq+vmL3PcMFLXGUKOlM0V4c/szqTinzPZw9A60Ep s++XUKH67LEna8+8jZghIMjHvfjrUzET9gecJr+yyElUqniFx4IkbruclWl/gFictk 62TyS/iy1oM0uzy+9SDkLEBfmjxo66z1nMsLsNGjjoOAHI2DRTZeADK2l5Wzv7EGls wRymHK5x6lQfQ== Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-512b84bdaf1so621990e87.1 for ; Mon, 19 Feb 2024 02:57:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWVOMiUVEshnBS8xA2lQFHBA1+lJxTCndmZZEaZcq81UcTxL/AXmlH6bVOH0SDPbBwy8kQJiLmwBo0JyxmvSd84E7gMQA== X-Gm-Message-State: AOJu0YyC3ord+r4fryCfKq0eD05utxK5exsnaaVwQko+3zZ8NvHkDVj5 1ROjN7eTZ3TxrMsIBE/6xrdT55mUASgB/G5BDgoqrH17HfKMb0t4BQo06u9VvWj3zNrrVqURopV a5GLApkW9WgNVVBgOIUSMtPBmgEk= X-Google-Smtp-Source: AGHT+IHmfgSZqvHpLB9jfTiYhxvcFbTevouQkei+SQG31nDOKxX4/f0K3SugmVJlMZ2zwMVxayLYcj4wPTVfUn25ENw= X-Received: by 2002:a05:6512:239c:b0:512:ae18:7492 with SMTP id c28-20020a056512239c00b00512ae187492mr3296031lfv.11.1708340236084; Mon, 19 Feb 2024 02:57:16 -0800 (PST) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240206074552.541154-1-maskray@google.com> In-Reply-To: From: Ard Biesheuvel Date: Mon, 19 Feb 2024 11:57:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" To: Geert Uytterhoeven Cc: Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 19 Feb 2024 at 11:56, Ard Biesheuvel wrote: > > On Mon, 19 Feb 2024 at 11:03, Geert Uytterhoeven w= rote: > > > > Hi Fangrui, > > > > On Tue, Feb 6, 2024 at 8:46=E2=80=AFAM Fangrui Song wrote: > > > The generic constraint "i" seems to be copied from x86 or arm (and wi= th > > > a redundant generic operand modifier "c"). It works with -fno-PIE but > > > not with -fPIE/-fPIC in GCC's aarch64 port. > > > > Thanks for your patch, which is now commit f9daab0ad01cf9d1 ("arm64: > > jump_label: use constraints "Si" instead of "i"") in v6.8-rc5. > > > > > The machine constraint "S", which denotes a symbol or label reference > > > with a constant offset, supports PIC and has been available in GCC si= nce > > > 2012 and in Clang since 7.0. However, Clang before 19 does not suppor= t > > > "S" on a symbol with a constant offset [1] (e.g. > > > `static_key_false(&nf_hooks_needed[pf][hook])` in > > > include/linux/netfilter.h), so we use "i" as a fallback. > > > > https://gcc.gnu.org/releases.html says gcc-5 was released in 2015, > > i.e. after 2012 ... > > > > > Suggested-by: Ard Biesheuvel > > > Signed-off-by: Fangrui Song > > > Link: https://github.com/llvm/llvm-project/pull/80255 [1] > > > > > > --- > > > Changes from > > > arm64: jump_label: use constraint "S" instead of "i" (https://lore.ke= rnel.org/all/20240131065322.1126831-1-maskray@google.com/) > > > > > > * Use "Si" as Ard suggested to support Clang<19 > > > * Make branch a separate operand > > > > > > Changes from v1: > > > > > > * Use asmSymbolicName for readability > > > > But it still fails on gcc-5: > > > > arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': > > invalid operand > > asm goto( > > ^ > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/15129281/ > > > > How odd. godbolt.org has 5.4 and it seems perfectly happy with it. > > https://godbolt.org/z/szzG3s59K Wrong link https://godbolt.org/z/GTnf3vPaT From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95EC5C48BC3 for ; Mon, 19 Feb 2024 10:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ROJU8ms4ohWt+3hXEFgDg3ZJUAchGK3igcTuSgamM0=; b=wgBVKZZf9xJely 7PuSfLjDFNsZJY/ItXLX8g3wjisH2KxaWmFiVoNt365H+FV9ftOLNI99O+D4OQsI2K4//EkOKEDoP xE2rPU7m/i5b7YX/Tgo8lDTlEYT9s3oQW3DnfYGzYs1RR3A10XSlECFhYR7mtYdsk76uk7IYERS5I riek6XjMeGPavgHRE03QJwpBgm+ehd0DwhZOInCP0lTILw2/jKefk8uWgV5JMfZalvP3igLpyk7Z+ ZDDlzTfNUipdHX14mlUz8jjDtAFrA8tsagUrrBBgy0vyxmVKXVWUldLyVMPiWQYNUzp79/VjVRTnt GQiOtBjd0vS6Md6V05mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc1Kr-0000000A7Vy-1gls; Mon, 19 Feb 2024 10:57:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rc1Ko-0000000A7VX-2kYn for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 10:57:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 23E4260C6F for ; Mon, 19 Feb 2024 10:57:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA9CFC43390 for ; Mon, 19 Feb 2024 10:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708340237; bh=9dOeyiDJsSefv4EBMEfGuKU7J4MB2+An6FzWYy2il5o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HvqTtu1GDkne6c7hAAj4kowEJY0j5GUBUUZnIYkpw+D6Br7atvu5XQtpHhF80dNSD 5U8YYjjPENNs/6r6OKEWvmq4AU9+iclJ/FW//j+GXhl09mtA3xN66fb9vO1k/zmT4h Ce+tnRbA1oMFTmv/2kcKxBrOEgDq+vmL3PcMFLXGUKOlM0V4c/szqTinzPZw9A60Ep s++XUKH67LEna8+8jZghIMjHvfjrUzET9gecJr+yyElUqniFx4IkbruclWl/gFictk 62TyS/iy1oM0uzy+9SDkLEBfmjxo66z1nMsLsNGjjoOAHI2DRTZeADK2l5Wzv7EGls wRymHK5x6lQfQ== Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-511acd26c2bso5492553e87.2 for ; Mon, 19 Feb 2024 02:57:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWhFC6qVGsfisgnN1cWC1TxIqjN8SLHj4gnmTyix71trVT7xLqAb6sfPKsYqhpmzs+wWeWuQXutDkaQNsUjzpgC0bcov4tbeOKl9M6E5OwiNHUu9OI= X-Gm-Message-State: AOJu0YymxhV1lGFVSVzg9yRjMp/cHnfki2fiu6k4qQRCpTYsrBBjYYzO IiNkGzeB8Rld9GJSNxyPhR0s6FrQmVNZ3/wbMGlPbUNAUfi1jtwbnDokcKzCYyNg3JZFI8bXSYJ U9eTGQaKLLM8Oae0QrmDG7yduzp0= X-Google-Smtp-Source: AGHT+IHmfgSZqvHpLB9jfTiYhxvcFbTevouQkei+SQG31nDOKxX4/f0K3SugmVJlMZ2zwMVxayLYcj4wPTVfUn25ENw= X-Received: by 2002:a05:6512:239c:b0:512:ae18:7492 with SMTP id c28-20020a056512239c00b00512ae187492mr3296031lfv.11.1708340236084; Mon, 19 Feb 2024 02:57:16 -0800 (PST) MIME-Version: 1.0 References: <20240206074552.541154-1-maskray@google.com> In-Reply-To: From: Ard Biesheuvel Date: Mon, 19 Feb 2024 11:57:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" To: Geert Uytterhoeven Cc: Fangrui Song , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_025718_803908_8F0C0461 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxOSBGZWIgMjAyNCBhdCAxMTo1NiwgQXJkIEJpZXNoZXV2ZWwgPGFyZGJAa2VybmVs Lm9yZz4gd3JvdGU6Cj4KPiBPbiBNb24sIDE5IEZlYiAyMDI0IGF0IDExOjAzLCBHZWVydCBVeXR0 ZXJob2V2ZW4gPGdlZXJ0QGxpbnV4LW02OGsub3JnPiB3cm90ZToKPiA+Cj4gPiBIaSBGYW5ncnVp LAo+ID4KPiA+IE9uIFR1ZSwgRmViIDYsIDIwMjQgYXQgODo0NuKAr0FNIEZhbmdydWkgU29uZyA8 bWFza3JheUBnb29nbGUuY29tPiB3cm90ZToKPiA+ID4gVGhlIGdlbmVyaWMgY29uc3RyYWludCAi aSIgc2VlbXMgdG8gYmUgY29waWVkIGZyb20geDg2IG9yIGFybSAoYW5kIHdpdGgKPiA+ID4gYSBy ZWR1bmRhbnQgZ2VuZXJpYyBvcGVyYW5kIG1vZGlmaWVyICJjIikuIEl0IHdvcmtzIHdpdGggLWZu by1QSUUgYnV0Cj4gPiA+IG5vdCB3aXRoIC1mUElFLy1mUElDIGluIEdDQydzIGFhcmNoNjQgcG9y dC4KPiA+Cj4gPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2gsIHdoaWNoIGlzIG5vdyBjb21taXQgZjlk YWFiMGFkMDFjZjlkMSAoImFybTY0Ogo+ID4ganVtcF9sYWJlbDogdXNlIGNvbnN0cmFpbnRzICJT aSIgaW5zdGVhZCBvZiAiaSIiKSBpbiB2Ni44LXJjNS4KPiA+Cj4gPiA+IFRoZSBtYWNoaW5lIGNv bnN0cmFpbnQgIlMiLCB3aGljaCBkZW5vdGVzIGEgc3ltYm9sIG9yIGxhYmVsIHJlZmVyZW5jZQo+ ID4gPiB3aXRoIGEgY29uc3RhbnQgb2Zmc2V0LCBzdXBwb3J0cyBQSUMgYW5kIGhhcyBiZWVuIGF2 YWlsYWJsZSBpbiBHQ0Mgc2luY2UKPiA+ID4gMjAxMiBhbmQgaW4gQ2xhbmcgc2luY2UgNy4wLiBI b3dldmVyLCBDbGFuZyBiZWZvcmUgMTkgZG9lcyBub3Qgc3VwcG9ydAo+ID4gPiAiUyIgb24gYSBz eW1ib2wgd2l0aCBhIGNvbnN0YW50IG9mZnNldCBbMV0gKGUuZy4KPiA+ID4gYHN0YXRpY19rZXlf ZmFsc2UoJm5mX2hvb2tzX25lZWRlZFtwZl1baG9va10pYCBpbgo+ID4gPiBpbmNsdWRlL2xpbnV4 L25ldGZpbHRlci5oKSwgc28gd2UgdXNlICJpIiBhcyBhIGZhbGxiYWNrLgo+ID4KPiA+IGh0dHBz Oi8vZ2NjLmdudS5vcmcvcmVsZWFzZXMuaHRtbCBzYXlzIGdjYy01IHdhcyByZWxlYXNlZCBpbiAy MDE1LAo+ID4gaS5lLiBhZnRlciAyMDEyIC4uLgo+ID4KPiA+ID4gU3VnZ2VzdGVkLWJ5OiBBcmQg Qmllc2hldXZlbCA8YXJkYkBrZXJuZWwub3JnPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBGYW5ncnVp IFNvbmcgPG1hc2tyYXlAZ29vZ2xlLmNvbT4KPiA+ID4gTGluazogaHR0cHM6Ly9naXRodWIuY29t L2xsdm0vbGx2bS1wcm9qZWN0L3B1bGwvODAyNTUgWzFdCj4gPiA+Cj4gPiA+IC0tLQo+ID4gPiBD aGFuZ2VzIGZyb20KPiA+ID4gYXJtNjQ6IGp1bXBfbGFiZWw6IHVzZSBjb25zdHJhaW50ICJTIiBp bnN0ZWFkIG9mICJpIiAoaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjQwMTMxMDY1MzIy LjExMjY4MzEtMS1tYXNrcmF5QGdvb2dsZS5jb20vKQo+ID4gPgo+ID4gPiAqIFVzZSAiU2kiIGFz IEFyZCBzdWdnZXN0ZWQgdG8gc3VwcG9ydCBDbGFuZzwxOQo+ID4gPiAqIE1ha2UgYnJhbmNoIGEg c2VwYXJhdGUgb3BlcmFuZAo+ID4gPgo+ID4gPiBDaGFuZ2VzIGZyb20gdjE6Cj4gPiA+Cj4gPiA+ ICogVXNlIGFzbVN5bWJvbGljTmFtZSBmb3IgcmVhZGFiaWxpdHkKPiA+Cj4gPiBCdXQgaXQgc3Rp bGwgZmFpbHMgb24gZ2NjLTU6Cj4gPgo+ID4gICAgIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vanVt cF9sYWJlbC5oOjI1OjI6IGVycm9yOiBpbnZhbGlkICdhc20nOgo+ID4gaW52YWxpZCBvcGVyYW5k Cj4gPiAgICAgICBhc20gZ290bygKPiA+ICAgICAgIF4KPiA+Cj4gPiBodHRwOi8va2lzc2tiLmVs bGVybWFuLmlkLmF1L2tpc3NrYi9idWlsZHJlc3VsdC8xNTEyOTI4MS8KPiA+Cj4KPiBIb3cgb2Rk LiBnb2Rib2x0Lm9yZyBoYXMgNS40IGFuZCBpdCBzZWVtcyBwZXJmZWN0bHkgaGFwcHkgd2l0aCBp dC4KPgo+IGh0dHBzOi8vZ29kYm9sdC5vcmcvei9zenpHM3M1OUsKCldyb25nIGxpbmsKCmh0dHBz Oi8vZ29kYm9sdC5vcmcvei9HVG5mM3ZQYVQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK