Re: [build break] aegis128-neon-inner.c fails to build on v5.9-rc1

Re: [build break] aegis128-neon-inner.c fails to build on v5.9-rc1

[Herbert Xu]

On Mon, Aug 17, 2020 at 03:03:11PM +0300, Felipe Balbi wrote:
> 
> Hi,
> 
> I'm not sure if there's already a patch for this, but I notices arm64
> allmodconfig fails to build with GCC 10.2 as shown below:
> 
> crypto/aegis128-neon-inner.c: In function 'crypto_aegis128_init_neon':
> crypto/aegis128-neon-inner.c:151:3: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t'
>   151 |   k ^ vld1q_u8(const0),
>       |   ^
> crypto/aegis128-neon-inner.c:152:3: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t'
>   152 |   k ^ vld1q_u8(const1),
>       |   ^
> crypto/aegis128-neon-inner.c:147:29: warning: missing braces around initializer [-Wmissing-braces]
>   147 |  struct aegis128_state st = {{
>       |                             ^
> ......
>   151 |   k ^ vld1q_u8(const0),
>       |   {
>   152 |   k ^ vld1q_u8(const1),
>   153 |  }};
>       |  }
> 
> Confirmation of GCC version follows:
> 
> $ aarch64-linux-gnu-gcc --version
> aarch64-linux-gnu-gcc (GCC) 10.2.0
> Copyright (C) 2020 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Ard, can you please take a look at this?

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [build break] aegis128-neon-inner.c fails to build on v5.9-rc1

[Ard Biesheuvel]

On Fri, 21 Aug 2020 at 05:55, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Mon, Aug 17, 2020 at 03:03:11PM +0300, Felipe Balbi wrote:
> >
> > Hi,
> >
> > I'm not sure if there's already a patch for this, but I notices arm64
> > allmodconfig fails to build with GCC 10.2 as shown below:
> >
> > crypto/aegis128-neon-inner.c: In function 'crypto_aegis128_init_neon':
> > crypto/aegis128-neon-inner.c:151:3: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t'
> >   151 |   k ^ vld1q_u8(const0),
> >       |   ^
> > crypto/aegis128-neon-inner.c:152:3: error: incompatible types when initializing type 'unsigned char' using type 'uint8x16_t'
> >   152 |   k ^ vld1q_u8(const1),
> >       |   ^
> > crypto/aegis128-neon-inner.c:147:29: warning: missing braces around initializer [-Wmissing-braces]
> >   147 |  struct aegis128_state st = {{
> >       |                             ^
> > ......
> >   151 |   k ^ vld1q_u8(const0),
> >       |   {
> >   152 |   k ^ vld1q_u8(const1),
> >   153 |  }};
> >       |  }
> >
> > Confirmation of GCC version follows:
> >
> > $ aarch64-linux-gnu-gcc --version
> > aarch64-linux-gnu-gcc (GCC) 10.2.0
> > Copyright (C) 2020 Free Software Foundation, Inc.
> > This is free software; see the source for copying conditions.  There is NO
> > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> Ard, can you please take a look at this?
>

This is a known regression in GCC [0] that has already been fixed. GCC
10.3 should work fine.


[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96377