From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D32C8301B for ; Thu, 3 Dec 2020 12:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D64D421D91 for ; Thu, 3 Dec 2020 12:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389128AbgLCMvE (ORCPT ); Thu, 3 Dec 2020 07:51:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:52898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389097AbgLCMvB (ORCPT ); Thu, 3 Dec 2020 07:51:01 -0500 X-Gm-Message-State: AOAM531Y41a1SDwTGwQ0J/XFwie12hZVEW8UkJFzt/TW5M8oTtWlLAoO fzyrOJlFwog4v5vcs4Ltdqca0mtOHYYcfNgQBnU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1606999820; bh=vzl05i7nSGf1kne8kmAzzMVoofwdQKpDIeU8H+Oz5wM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hIruvSBbNhIXCctS/qHJ5SbBqa7zZm7SHZ0Dx1cUCVLVq64wixXp0xqH16DWzBktm fEzRUycRBp0r6RusMyyriQQdZLwj7WlYXuMGuZwAT5FJgb/wLt+Eu3fK02wXA1rRhf Hgq6n9ELmV/4M4noXU4fj65JQHNdY7Rv/Hz/hyf0rYV2acSAUheKKsB6nh0jDlV65V 2EcP2XkHQyWrhXLwH3A89yxbDUq2bwz0iQl00wvT3se3FPVRrAqlpGQomZKCLGAQNx Ga/j8DWgRIl6DIgHaOzmJ1XM3BZxG9xOwxgcaPi0OvXro3Fqz3HH/VYJ4BUW1lE7R9 6di/59PpP2ahQ== X-Google-Smtp-Source: ABdhPJwCVCGuvTrj9Bwk32WG/2YHesLb7zugZFBRceF4d/5Gt/R0tpRuPdXss6gjIUkuvNl6bPm0gGmg7sUKY1gEk84= X-Received: by 2002:aca:5ec2:: with SMTP id s185mr1667470oib.33.1606999819105; Thu, 03 Dec 2020 04:50:19 -0800 (PST) MIME-Version: 1.0 References: <20201203121916.2870975-1-geert+renesas@glider.be> <20201203121916.2870975-3-geert+renesas@glider.be> In-Reply-To: <20201203121916.2870975-3-geert+renesas@glider.be> From: Ard Biesheuvel Date: Thu, 3 Dec 2020 13:50:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 2/3] ARM: uncompress: Add OF_DT_MAGIC macro To: Geert Uytterhoeven Cc: Russell King , Nicolas Pitre , Marek Szyprowski , Dmitry Osipenko , Linus Walleij , Arnd Bergmann , Eric Miao , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lukasz Stelmach , Stephen Boyd , Chris Brandt , Linux ARM , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Dec 2020 at 13:19, Geert Uytterhoeven wrote: > > The DTB magic marker is stored as a 32-bit big-endian value, and thus > depends on the CPU's endianness. Add a macro to define this value in > native endianness, to reduce #ifdef clutter and (future) duplication. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Ard Biesheuvel > --- > v10: > - New. > --- > arch/arm/boot/compressed/head.S | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index aabdc544c03aafdc..d9cce7238a365081 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -11,6 +11,12 @@ > > #include "efi-header.S" > > +#ifdef __ARMEB__ > +#define OF_DT_MAGIC 0xd00dfeed > +#else > +#define OF_DT_MAGIC 0xedfe0dd0 > +#endif > + > AR_CLASS( .arch armv7-a ) > M_CLASS( .arch armv7-m ) > > @@ -335,11 +341,7 @@ restart: adr r0, LC1 > */ > > ldr lr, [r6, #0] > -#ifndef __ARMEB__ > - ldr r1, =0xedfe0dd0 @ sig is 0xd00dfeed big endian > -#else > - ldr r1, =0xd00dfeed > -#endif > + ldr r1, =OF_DT_MAGIC > cmp lr, r1 > bne dtb_check_done @ not found > > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64BC6C8301C for ; Thu, 3 Dec 2020 12:51:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1FEE20709 for ; Thu, 3 Dec 2020 12:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1FEE20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XorBMvjB0CQazUveHCVgsifXCzMoxkgyN/WZZkxYlgY=; b=pgwcOilxoD6SDFoK4ne76jwOZ raKXEnp+6DaXAtVlDHPba2L/QqRyxqvGTG1BrQ6sW9UQHbkRgRmGEfKb0QMIW91BdkllNa6WErR+6 X6/DDZOyo5JT0vHKKzlOFw3JiypN4QV7qBM1jXuNJySN9B3Zqgq5B/OGtgstxifRUrFdBxrXCqiLh lajV7NTRlglHnj9oqQLOqR+TMGj8JvX8+2G7Rhmu1x3KULx0iIlDng3Spl5t/pymnxW/oUSgPkhBs NuJg2b0EHkEEJu0TO8VJMMwz/m+p/bh4vYEF3aKvjiGvLYk+P2eAFY3KVStmEiIADkyZphuoZRfT4 MIpVuvIIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kko3z-0005QX-6J; Thu, 03 Dec 2020 12:50:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kko3x-0005Pn-4D for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 12:50:21 +0000 X-Gm-Message-State: AOAM531MGd2UqhazRyEVlsUHgB9zkWSSGCZOzKek1dJHPpkASkMOlMbC bzNbIpYzHxostj8YCZM2Pgi3LRSV+oIqF+24NDE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1606999820; bh=vzl05i7nSGf1kne8kmAzzMVoofwdQKpDIeU8H+Oz5wM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hIruvSBbNhIXCctS/qHJ5SbBqa7zZm7SHZ0Dx1cUCVLVq64wixXp0xqH16DWzBktm fEzRUycRBp0r6RusMyyriQQdZLwj7WlYXuMGuZwAT5FJgb/wLt+Eu3fK02wXA1rRhf Hgq6n9ELmV/4M4noXU4fj65JQHNdY7Rv/Hz/hyf0rYV2acSAUheKKsB6nh0jDlV65V 2EcP2XkHQyWrhXLwH3A89yxbDUq2bwz0iQl00wvT3se3FPVRrAqlpGQomZKCLGAQNx Ga/j8DWgRIl6DIgHaOzmJ1XM3BZxG9xOwxgcaPi0OvXro3Fqz3HH/VYJ4BUW1lE7R9 6di/59PpP2ahQ== X-Google-Smtp-Source: ABdhPJwCVCGuvTrj9Bwk32WG/2YHesLb7zugZFBRceF4d/5Gt/R0tpRuPdXss6gjIUkuvNl6bPm0gGmg7sUKY1gEk84= X-Received: by 2002:aca:5ec2:: with SMTP id s185mr1667470oib.33.1606999819105; Thu, 03 Dec 2020 04:50:19 -0800 (PST) MIME-Version: 1.0 References: <20201203121916.2870975-1-geert+renesas@glider.be> <20201203121916.2870975-3-geert+renesas@glider.be> In-Reply-To: <20201203121916.2870975-3-geert+renesas@glider.be> From: Ard Biesheuvel Date: Thu, 3 Dec 2020 13:50:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 2/3] ARM: uncompress: Add OF_DT_MAGIC macro To: Geert Uytterhoeven X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_075021_256724_C6BF3B53 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Nicolas Pitre , Stephen Boyd , Linus Walleij , Lukasz Stelmach , Russell King , Linux Kernel Mailing List , Linux-Renesas , Chris Brandt , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Eric Miao , Dmitry Osipenko , Linux ARM , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 3 Dec 2020 at 13:19, Geert Uytterhoeven wrote: > > The DTB magic marker is stored as a 32-bit big-endian value, and thus > depends on the CPU's endianness. Add a macro to define this value in > native endianness, to reduce #ifdef clutter and (future) duplication. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Ard Biesheuvel > --- > v10: > - New. > --- > arch/arm/boot/compressed/head.S | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index aabdc544c03aafdc..d9cce7238a365081 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -11,6 +11,12 @@ > > #include "efi-header.S" > > +#ifdef __ARMEB__ > +#define OF_DT_MAGIC 0xd00dfeed > +#else > +#define OF_DT_MAGIC 0xedfe0dd0 > +#endif > + > AR_CLASS( .arch armv7-a ) > M_CLASS( .arch armv7-m ) > > @@ -335,11 +341,7 @@ restart: adr r0, LC1 > */ > > ldr lr, [r6, #0] > -#ifndef __ARMEB__ > - ldr r1, =0xedfe0dd0 @ sig is 0xd00dfeed big endian > -#else > - ldr r1, =0xd00dfeed > -#endif > + ldr r1, =OF_DT_MAGIC > cmp lr, r1 > bne dtb_check_done @ not found > > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel