From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BFECC433E1 for ; Thu, 9 Jul 2020 06:45:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF99F20708 for ; Thu, 9 Jul 2020 06:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594277106; bh=yqyv6h2XInBV1EY6m64ceNwhddRMrP8QNwYqF1Bx1zM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=aPblpGadTaWdmiLWiH2GvfoGUs4ZduIK2b+WMKpqJIM7Pj4Agg06ms6PjMSQDwYJV rWV66vXlHlu6sAkjTD5zIBw/fgeOqoOTsxwzyKZ2skcoEzBtyHYKL9azSYAbSOwSUu ozPPD6KtC2FPqgURyQ0fA5G1OqqpITjOQMEn3sZg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726356AbgGIGpE (ORCPT ); Thu, 9 Jul 2020 02:45:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:47914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgGIGpD (ORCPT ); Thu, 9 Jul 2020 02:45:03 -0400 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CBCC206C3; Thu, 9 Jul 2020 06:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594277103; bh=yqyv6h2XInBV1EY6m64ceNwhddRMrP8QNwYqF1Bx1zM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=S27nB3x7AqgVsIDI5HG/zYaxeNuKyksZnZr+RRkqGY7MIo9S/41mt5nHh9O9jq+Vh WPb/31fvxPOxVm42lKbgbpNAK2zK/XEvUv8NVrgN/JTAjVACfCwIShtBQ6i2g36f7G +R/TjJuoZaqSWa9RFyQNPXRPr1oNSc6QkvyR6L58= Received: by mail-oo1-f48.google.com with SMTP id p26so157477oos.7; Wed, 08 Jul 2020 23:45:03 -0700 (PDT) X-Gm-Message-State: AOAM532mePkfTX5CFgGA6T07np9+l8/JTQe3q8oJBDJp//JF903BcjlO rNAwkpbLKYmuUuetP9ZnpSu6UvM9AVB3c/ULfNk= X-Google-Smtp-Source: ABdhPJxJg0zCtFdI6GkRc3m2LXwEKb/oojArjl7Y2J0R0eiIZ44Vv+yY/2C03uazutRVzLit4S54OK5Uwh8Pl/WqJ+0= X-Received: by 2002:a4a:de8d:: with SMTP id v13mr31588321oou.45.1594277102535; Wed, 08 Jul 2020 23:45:02 -0700 (PDT) MIME-Version: 1.0 References: <20200623150935.32181-1-geert+renesas@glider.be> In-Reply-To: From: Ard Biesheuvel Date: Thu, 9 Jul 2020 09:44:51 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] efi/libstub: EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER should not default to yes To: Geert Uytterhoeven Cc: Ingo Molnar , Arvind Sankar , linux-efi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020 at 19:11, Ard Biesheuvel wrote: > > On Tue, 23 Jun 2020 at 17:09, Geert Uytterhoeven > wrote: > > > > EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER is deprecated, so it should not > > be enabled by default. > > > > In light of commit 4da0b2b7e67524cc ("efi/libstub: Re-enable command > > line initrd loading for x86"), keep the default for X86. > > > > Fixes: cf6b83664895a5c7 ("efi/libstub: Make initrd file loader configurable") > > Signed-off-by: Geert Uytterhoeven > > Queued as a fix, thanks. > I am going to have to postpone this one - it appears kernelCI uses QEMU firmware that does not implement the new initrd loading protocol yet, so I will need to get that fixed first. > > --- > > drivers/firmware/efi/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig > > index e6fc022bc87e03ab..56055c61904e49f4 100644 > > --- a/drivers/firmware/efi/Kconfig > > +++ b/drivers/firmware/efi/Kconfig > > @@ -127,7 +127,7 @@ config EFI_ARMSTUB_DTB_LOADER > > config EFI_GENERIC_STUB_INITRD_CMDLINE_LOADER > > bool "Enable the command line initrd loader" if !X86 > > depends on EFI_STUB && (EFI_GENERIC_STUB || X86) > > - default y > > + default y if X86 > > help > > Select this config option to add support for the initrd= command > > line parameter, allowing an initrd that resides on the same volume > > -- > > 2.17.1 > >