From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5E8C4338F for ; Thu, 5 Aug 2021 13:22:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 698336113B for ; Thu, 5 Aug 2021 13:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240497AbhHENW6 (ORCPT ); Thu, 5 Aug 2021 09:22:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:52516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbhHENW6 (ORCPT ); Thu, 5 Aug 2021 09:22:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4B9A761158 for ; Thu, 5 Aug 2021 13:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628169764; bh=rABZo6aAjftHjiZ5IWVoUogsJY3wYwnWG2rnzy4liBo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wvd0gPN3bIkbH85Jb8aiK9vAeTaGXkKH0MPPvHrT67OI7Yv4pArZ3mpw+PSlewnAk PnYEYc30nVMFJfbbkDTxRhqH4HilA2dnpEQinC6/a2ywTKEu5145yOWfueC31EFsne QhqBB69I6VY8hq+RW66dpCUIpmO6LVAeWRUefgRrASbWZBtrtYcVZ1bPgZvE8U7j1Z pIK8w0B94XWyw2tc9gxARVmYCPzhqQAjHnGb+TBmGyMiIH1MeZ3T3eUM+Lg7HwHP4C w4DGrWG56tp3VXJvpseidZvpVsG86dLc/vIcckBLXQRwspK+ODQ7dt3zdW1045KQDp 4XqNS2b0S6CLA== Received: by mail-ot1-f43.google.com with SMTP id 61-20020a9d0d430000b02903eabfc221a9so5107954oti.0 for ; Thu, 05 Aug 2021 06:22:44 -0700 (PDT) X-Gm-Message-State: AOAM532vMSah/DbAtyJS1dGVMPc+1diYJGcgHYTWVQD85VxUqIGNSMui WJSTb7zfGAe5CyTRt1J0ffCV7KLS2dt1JmEX+Dc= X-Google-Smtp-Source: ABdhPJx0hDuVxvbP140/VxO38R4dIU/rEbrl3LBsoE8UOKfL6M4pTys5XpazDhygGrztUo1RJOEBxMauD3jhjiaPAZQ= X-Received: by 2002:a9d:5c2:: with SMTP id 60mr3654201otd.77.1628169763566; Thu, 05 Aug 2021 06:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 15:22:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameer Kolothum Cc: Linux ARM , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Robin Murphy , Will Deacon , wanghuiqiang@huawei.com, Hanjun Guo , Steven Price , Sami Mujawar , Jon Nettleton , Eric Auger , yangyicong@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum wrote: > > Hi, > > The series adds support to IORT RMR nodes specified in IORT > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > memory ranges that are used by endpoints and require a unity > mapping in SMMU. > > We have faced issues with 3408iMR RAID controller cards which > fail to boot when SMMU is enabled. This is because these > controllers make use of host memory for various caching related > purposes and when SMMU is enabled the iMR firmware fails to > access these memory regions as there is no mapping for them. > IORT RMR provides a way for UEFI to describe and report these > memory regions so that the kernel can make a unity mapping for > these in SMMU. > Does this mean we are ignoring the RMR memory ranges, and exposing the entire physical address space to devices using the stream IDs in question? > Change History: > > v6 --> v7 > > The only change from v6 is the fix pointed out by Steve to > the SMMUv2 SMR bypass install in patch #8. > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > yet as the series still needs more review[1]. > > Feedback and tests on this series is very much appreciated. > > v5 --> v6 > - Addressed comments from Robin & Lorenzo. > : Moved iort_parse_rmr() to acpi_iort_init() from > iort_init_platform_devices(). > : Removed use of struct iort_rmr_entry during the initial > parse. Using struct iommu_resv_region instead. > : Report RMR address alignment and overlap errors, but continue. > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > on Type of RMR region. Suggested by Jon N. > > Thanks, > Shameer > [0] https://developer.arm.com/documentation/den0049/latest/ > [1] https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.kolothum.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > ------ > v4 --> v5 > -Added a fw_data union to struct iommu_resv_region and removed > struct iommu_rmr (Based on comments from Joerg/Robin). > -Added iommu_put_rmrs() to release mem. > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > yet because of the above changes. > > v3 -->v4 > -Included the SMMUv2 SMR bypass install changes suggested by > Steve(patch #7) > -As per Robin's comments, RMR reserve implementation is now > more generic (patch #8) and dropped v3 patches 8 and 10. > -Rebase to 5.13-rc1 > > RFC v2 --> v3 > -Dropped RFC tag as the ACPICA header changes are now ready to be > part of 5.13[0]. But this series still has a dependency on that patch. > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > PCIe). > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > discussion here[1]. > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > ------ > > Jon Nettleton (1): > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > Shameer Kolothum (8): > iommu: Introduce a union to struct iommu_resv_region > ACPI/IORT: Add support for RMR node parsing > iommu/dma: Introduce generic helper to retrieve RMR info > ACPI/IORT: Add a helper to retrieve RMR memory regions > iommu/arm-smmu-v3: Introduce strtab init helper > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > bypass > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > iommu/dma: Reserve any RMR regions associated with a dev > > drivers/acpi/arm64/iort.c | 172 +++++++++++++++++++- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > drivers/iommu/dma-iommu.c | 89 +++++++++- > include/linux/acpi_iort.h | 7 + > include/linux/dma-iommu.h | 13 ++ > include/linux/iommu.h | 11 ++ > 7 files changed, 393 insertions(+), 23 deletions(-) > > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E043C4338F for ; Thu, 5 Aug 2021 13:22:49 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDF136113B for ; Thu, 5 Aug 2021 13:22:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BDF136113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 97307607AC; Thu, 5 Aug 2021 13:22:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TlVbgGqkR-1X; Thu, 5 Aug 2021 13:22:47 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 7B34F6074D; Thu, 5 Aug 2021 13:22:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 46454C001A; Thu, 5 Aug 2021 13:22:47 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 578C3C000E for ; Thu, 5 Aug 2021 13:22:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 452AC607AC for ; Thu, 5 Aug 2021 13:22:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RGcjJXXqLsXD for ; Thu, 5 Aug 2021 13:22:44 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp3.osuosl.org (Postfix) with ESMTPS id AAFA66074D for ; Thu, 5 Aug 2021 13:22:44 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 48DF461154 for ; Thu, 5 Aug 2021 13:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628169764; bh=rABZo6aAjftHjiZ5IWVoUogsJY3wYwnWG2rnzy4liBo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wvd0gPN3bIkbH85Jb8aiK9vAeTaGXkKH0MPPvHrT67OI7Yv4pArZ3mpw+PSlewnAk PnYEYc30nVMFJfbbkDTxRhqH4HilA2dnpEQinC6/a2ywTKEu5145yOWfueC31EFsne QhqBB69I6VY8hq+RW66dpCUIpmO6LVAeWRUefgRrASbWZBtrtYcVZ1bPgZvE8U7j1Z pIK8w0B94XWyw2tc9gxARVmYCPzhqQAjHnGb+TBmGyMiIH1MeZ3T3eUM+Lg7HwHP4C w4DGrWG56tp3VXJvpseidZvpVsG86dLc/vIcckBLXQRwspK+ODQ7dt3zdW1045KQDp 4XqNS2b0S6CLA== Received: by mail-ot1-f42.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so5088270oth.7 for ; Thu, 05 Aug 2021 06:22:44 -0700 (PDT) X-Gm-Message-State: AOAM533xD7lp7XAJPe/uItAOhFCkdusFqsXTLhJmP66Po2BEdGvNhRLG dywYnBPAxO5yfLUDggmYbxPmu+OYxXQM88WpnAc= X-Google-Smtp-Source: ABdhPJx0hDuVxvbP140/VxO38R4dIU/rEbrl3LBsoE8UOKfL6M4pTys5XpazDhygGrztUo1RJOEBxMauD3jhjiaPAZQ= X-Received: by 2002:a9d:5c2:: with SMTP id 60mr3654201otd.77.1628169763566; Thu, 05 Aug 2021 06:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 15:22:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameer Kolothum Cc: Will Deacon , Jon Nettleton , Linuxarm , Steven Price , ACPI Devel Maling List , Linux IOMMU , wanghuiqiang@huawei.com, Hanjun Guo , yangyicong@huawei.com, Sami Mujawar , Robin Murphy , Linux ARM X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum wrote: > > Hi, > > The series adds support to IORT RMR nodes specified in IORT > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > memory ranges that are used by endpoints and require a unity > mapping in SMMU. > > We have faced issues with 3408iMR RAID controller cards which > fail to boot when SMMU is enabled. This is because these > controllers make use of host memory for various caching related > purposes and when SMMU is enabled the iMR firmware fails to > access these memory regions as there is no mapping for them. > IORT RMR provides a way for UEFI to describe and report these > memory regions so that the kernel can make a unity mapping for > these in SMMU. > Does this mean we are ignoring the RMR memory ranges, and exposing the entire physical address space to devices using the stream IDs in question? > Change History: > > v6 --> v7 > > The only change from v6 is the fix pointed out by Steve to > the SMMUv2 SMR bypass install in patch #8. > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > yet as the series still needs more review[1]. > > Feedback and tests on this series is very much appreciated. > > v5 --> v6 > - Addressed comments from Robin & Lorenzo. > : Moved iort_parse_rmr() to acpi_iort_init() from > iort_init_platform_devices(). > : Removed use of struct iort_rmr_entry during the initial > parse. Using struct iommu_resv_region instead. > : Report RMR address alignment and overlap errors, but continue. > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > on Type of RMR region. Suggested by Jon N. > > Thanks, > Shameer > [0] https://developer.arm.com/documentation/den0049/latest/ > [1] https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.kolothum.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > ------ > v4 --> v5 > -Added a fw_data union to struct iommu_resv_region and removed > struct iommu_rmr (Based on comments from Joerg/Robin). > -Added iommu_put_rmrs() to release mem. > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > yet because of the above changes. > > v3 -->v4 > -Included the SMMUv2 SMR bypass install changes suggested by > Steve(patch #7) > -As per Robin's comments, RMR reserve implementation is now > more generic (patch #8) and dropped v3 patches 8 and 10. > -Rebase to 5.13-rc1 > > RFC v2 --> v3 > -Dropped RFC tag as the ACPICA header changes are now ready to be > part of 5.13[0]. But this series still has a dependency on that patch. > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > PCIe). > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > discussion here[1]. > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > ------ > > Jon Nettleton (1): > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > Shameer Kolothum (8): > iommu: Introduce a union to struct iommu_resv_region > ACPI/IORT: Add support for RMR node parsing > iommu/dma: Introduce generic helper to retrieve RMR info > ACPI/IORT: Add a helper to retrieve RMR memory regions > iommu/arm-smmu-v3: Introduce strtab init helper > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > bypass > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > iommu/dma: Reserve any RMR regions associated with a dev > > drivers/acpi/arm64/iort.c | 172 +++++++++++++++++++- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > drivers/iommu/dma-iommu.c | 89 +++++++++- > include/linux/acpi_iort.h | 7 + > include/linux/dma-iommu.h | 13 ++ > include/linux/iommu.h | 11 ++ > 7 files changed, 393 insertions(+), 23 deletions(-) > > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14191C4338F for ; Thu, 5 Aug 2021 13:24:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB98C6113B for ; Thu, 5 Aug 2021 13:24:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB98C6113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RHUfWPiLSDi3zeL57N2JEDBWi7Rj6FKNwkBexJY/rmw=; b=N3GmH+vB+a0hrF uSQLKgkizX22b5gh/jxPE46UJhbMa7Cl+AMq8NNw1dS9vEfSIopQpxkaHD+dXwa2Zgah1Gn6WBMMq cH4d/o7VpMH57MJEvHxGjUDGK4AnPIPsJyLydMOkKYiSzMfVJ3P8GJfqqLeZK7WmXPQi+4sOSsRfp Y2xvGcWB3MKlAfoJ7f8i3UdGQI2KernPJceihezdQ+rLbiTqnhX8dvQLpxVQ2NaxC3a+56BHn9ZJ1 /oNpwUCJPTCiRt+IwAHY4S4seLn2h42IL9Ek46G6XCAvkSad5rjaDOuQk7bdbfmZCzABUH7rcR8O4 6bArqStV2FgzYRcRHgtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBdKv-009ffd-09; Thu, 05 Aug 2021 13:23:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBdKf-009fch-6l for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 13:22:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3DB5B61155 for ; Thu, 5 Aug 2021 13:22:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628169764; bh=rABZo6aAjftHjiZ5IWVoUogsJY3wYwnWG2rnzy4liBo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wvd0gPN3bIkbH85Jb8aiK9vAeTaGXkKH0MPPvHrT67OI7Yv4pArZ3mpw+PSlewnAk PnYEYc30nVMFJfbbkDTxRhqH4HilA2dnpEQinC6/a2ywTKEu5145yOWfueC31EFsne QhqBB69I6VY8hq+RW66dpCUIpmO6LVAeWRUefgRrASbWZBtrtYcVZ1bPgZvE8U7j1Z pIK8w0B94XWyw2tc9gxARVmYCPzhqQAjHnGb+TBmGyMiIH1MeZ3T3eUM+Lg7HwHP4C w4DGrWG56tp3VXJvpseidZvpVsG86dLc/vIcckBLXQRwspK+ODQ7dt3zdW1045KQDp 4XqNS2b0S6CLA== Received: by mail-ot1-f47.google.com with SMTP id z6-20020a0568302906b02904f268d34f86so4755371otu.2 for ; Thu, 05 Aug 2021 06:22:44 -0700 (PDT) X-Gm-Message-State: AOAM533p2I5nSr/YrLW5ql9dwRJRfMTC8HSVhVpPe73qbfAhEpP0d/uG yAQWWp0dEZqcVzn5WJ86Goz+2wddOSdiEBmt4NI= X-Google-Smtp-Source: ABdhPJx0hDuVxvbP140/VxO38R4dIU/rEbrl3LBsoE8UOKfL6M4pTys5XpazDhygGrztUo1RJOEBxMauD3jhjiaPAZQ= X-Received: by 2002:a9d:5c2:: with SMTP id 60mr3654201otd.77.1628169763566; Thu, 05 Aug 2021 06:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> In-Reply-To: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 15:22:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameer Kolothum Cc: Linux ARM , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Robin Murphy , Will Deacon , wanghuiqiang@huawei.com, Hanjun Guo , Steven Price , Sami Mujawar , Jon Nettleton , Eric Auger , yangyicong@huawei.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_062245_338565_7DF9188C X-CRM114-Status: GOOD ( 32.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum wrote: > > Hi, > > The series adds support to IORT RMR nodes specified in IORT > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > memory ranges that are used by endpoints and require a unity > mapping in SMMU. > > We have faced issues with 3408iMR RAID controller cards which > fail to boot when SMMU is enabled. This is because these > controllers make use of host memory for various caching related > purposes and when SMMU is enabled the iMR firmware fails to > access these memory regions as there is no mapping for them. > IORT RMR provides a way for UEFI to describe and report these > memory regions so that the kernel can make a unity mapping for > these in SMMU. > Does this mean we are ignoring the RMR memory ranges, and exposing the entire physical address space to devices using the stream IDs in question? > Change History: > > v6 --> v7 > > The only change from v6 is the fix pointed out by Steve to > the SMMUv2 SMR bypass install in patch #8. > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > yet as the series still needs more review[1]. > > Feedback and tests on this series is very much appreciated. > > v5 --> v6 > - Addressed comments from Robin & Lorenzo. > : Moved iort_parse_rmr() to acpi_iort_init() from > iort_init_platform_devices(). > : Removed use of struct iort_rmr_entry during the initial > parse. Using struct iommu_resv_region instead. > : Report RMR address alignment and overlap errors, but continue. > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > on Type of RMR region. Suggested by Jon N. > > Thanks, > Shameer > [0] https://developer.arm.com/documentation/den0049/latest/ > [1] https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.kolothum.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > ------ > v4 --> v5 > -Added a fw_data union to struct iommu_resv_region and removed > struct iommu_rmr (Based on comments from Joerg/Robin). > -Added iommu_put_rmrs() to release mem. > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > yet because of the above changes. > > v3 -->v4 > -Included the SMMUv2 SMR bypass install changes suggested by > Steve(patch #7) > -As per Robin's comments, RMR reserve implementation is now > more generic (patch #8) and dropped v3 patches 8 and 10. > -Rebase to 5.13-rc1 > > RFC v2 --> v3 > -Dropped RFC tag as the ACPICA header changes are now ready to be > part of 5.13[0]. But this series still has a dependency on that patch. > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > PCIe). > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > discussion here[1]. > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > ------ > > Jon Nettleton (1): > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > Shameer Kolothum (8): > iommu: Introduce a union to struct iommu_resv_region > ACPI/IORT: Add support for RMR node parsing > iommu/dma: Introduce generic helper to retrieve RMR info > ACPI/IORT: Add a helper to retrieve RMR memory regions > iommu/arm-smmu-v3: Introduce strtab init helper > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > bypass > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > iommu/dma: Reserve any RMR regions associated with a dev > > drivers/acpi/arm64/iort.c | 172 +++++++++++++++++++- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > drivers/iommu/dma-iommu.c | 89 +++++++++- > include/linux/acpi_iort.h | 7 + > include/linux/dma-iommu.h | 13 ++ > include/linux/iommu.h | 11 ++ > 7 files changed, 393 insertions(+), 23 deletions(-) > > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel