From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAB2FC432BE for ; Thu, 5 Aug 2021 14:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C94B66113B for ; Thu, 5 Aug 2021 14:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241428AbhHEOJ1 (ORCPT ); Thu, 5 Aug 2021 10:09:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:60454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239962AbhHEOJ1 (ORCPT ); Thu, 5 Aug 2021 10:09:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F0DF160E53 for ; Thu, 5 Aug 2021 14:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628172553; bh=X0ZBKP2BynT6mUkVamflegnrwl7zM/qOLlWxMOgStJ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qjFnaEAs8MTD53IG1QNkymTsDTZMIfutANeDj4N4kqV6clEFBb099kbvCDcdEJn3F dd/2023D487b2qDAy57LvfWcYMjJsK70Pkc+pdSaL5V5N+cWxsaqf/qfRMAwMUMPcK bXKxBNWlQqs9LBMfWOGQ00pusPDFXDkMcaJnb8rIpJMNG9b3tna+Cs8tiSYxpt9y08 ITlcxwguelYjk6CPUhWN1HWWkMkyw6ZXu4qs1SlBTnkX81ScjMCEF6UVaYYdrr6RVi EaCs+fZsoYPkxcPZIW2hyjp4h8l0Ngks77yQKFryGDnte7Z4mUv1IhjTZEvCRhWQqJ TXwJvpmEF0mgw== Received: by mail-oi1-f178.google.com with SMTP id u25so7500172oiv.5 for ; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) X-Gm-Message-State: AOAM5331XTZMnoTfPhaxz962OY+aEQSVr/L+Tv9lsfmf9HKPlfnva/3a oHVLRfhwQmZAyl2JebymcDnZVeeDq9Iy3T0qCn4= X-Google-Smtp-Source: ABdhPJyHVKR7zzGcPQV2xm5EVEtZyYFzaNP/C6TfKB70DcfcnYGbNIe+jy356hymU7h1io7dkA7w6OMFA0NN5+2eDJk= X-Received: by 2002:aca:39c6:: with SMTP id g189mr5556956oia.47.1628172552322; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <8df7fc81b00142b68126efd3c700a579@huawei.com> In-Reply-To: <8df7fc81b00142b68126efd3c700a579@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 16:09:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameerali Kolothum Thodi Cc: Linux ARM , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Robin Murphy , Will Deacon , wanghuiqiang , "Guohanjun (Hanjun Guo)" , Steven Price , Sami Mujawar , Jon Nettleton , Eric Auger , yangyicong Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, 5 Aug 2021 at 15:35, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ardb@kernel.org] > > Sent: 05 August 2021 14:23 > > To: Shameerali Kolothum Thodi > > Cc: Linux ARM ; ACPI Devel Maling List > > ; Linux IOMMU > > ; Linuxarm ; > > Lorenzo Pieralisi ; Joerg Roedel > > ; Robin Murphy ; Will Deacon > > ; wanghuiqiang ; Guohanjun > > (Hanjun Guo) ; Steven Price > > ; Sami Mujawar ; Jon > > Nettleton ; Eric Auger ; > > yangyicong > > Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node > > > > On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum > > wrote: > > > > > > Hi, > > > > > > The series adds support to IORT RMR nodes specified in IORT > > > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > > > memory ranges that are used by endpoints and require a unity > > > mapping in SMMU. > > > > > > We have faced issues with 3408iMR RAID controller cards which > > > fail to boot when SMMU is enabled. This is because these > > > controllers make use of host memory for various caching related > > > purposes and when SMMU is enabled the iMR firmware fails to > > > access these memory regions as there is no mapping for them. > > > IORT RMR provides a way for UEFI to describe and report these > > > memory regions so that the kernel can make a unity mapping for > > > these in SMMU. > > > > > > > Does this mean we are ignoring the RMR memory ranges, and exposing the > > entire physical address space to devices using the stream IDs in > > question? > > Nope. RMR node is used to describe the memory ranges used by end points > behind SMMU. And this information is used to create 1 : 1 mappings for those > ranges in SMMU. Anything outside those ranges will result in translation > fault(if there are no other dynamic DMA mappings). > Excellent! It was not obvious to me from looking at the patches, so I had to ask. Thanks, Ard. > > > > > > Change History: > > > > > > v6 --> v7 > > > > > > The only change from v6 is the fix pointed out by Steve to > > > the SMMUv2 SMR bypass install in patch #8. > > > > > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > > > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > > > yet as the series still needs more review[1]. > > > > > > Feedback and tests on this series is very much appreciated. > > > > > > v5 --> v6 > > > - Addressed comments from Robin & Lorenzo. > > > : Moved iort_parse_rmr() to acpi_iort_init() from > > > iort_init_platform_devices(). > > > : Removed use of struct iort_rmr_entry during the initial > > > parse. Using struct iommu_resv_region instead. > > > : Report RMR address alignment and overlap errors, but continue. > > > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > > > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > > > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > > > on Type of RMR region. Suggested by Jon N. > > > > > > Thanks, > > > Shameer > > > [0] https://developer.arm.com/documentation/den0049/latest/ > > > [1] > > https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.koloth > > um.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > > > ------ > > > v4 --> v5 > > > -Added a fw_data union to struct iommu_resv_region and removed > > > struct iommu_rmr (Based on comments from Joerg/Robin). > > > -Added iommu_put_rmrs() to release mem. > > > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > > > yet because of the above changes. > > > > > > v3 -->v4 > > > -Included the SMMUv2 SMR bypass install changes suggested by > > > Steve(patch #7) > > > -As per Robin's comments, RMR reserve implementation is now > > > more generic (patch #8) and dropped v3 patches 8 and 10. > > > -Rebase to 5.13-rc1 > > > > > > RFC v2 --> v3 > > > -Dropped RFC tag as the ACPICA header changes are now ready to be > > > part of 5.13[0]. But this series still has a dependency on that patch. > > > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > > > PCIe). > > > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > > > discussion here[1]. > > > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > > > ------ > > > > > > Jon Nettleton (1): > > > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > > > > > Shameer Kolothum (8): > > > iommu: Introduce a union to struct iommu_resv_region > > > ACPI/IORT: Add support for RMR node parsing > > > iommu/dma: Introduce generic helper to retrieve RMR info > > > ACPI/IORT: Add a helper to retrieve RMR memory regions > > > iommu/arm-smmu-v3: Introduce strtab init helper > > > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > > > bypass > > > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > > > iommu/dma: Reserve any RMR regions associated with a dev > > > > > > drivers/acpi/arm64/iort.c | 172 > > +++++++++++++++++++- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > > > drivers/iommu/dma-iommu.c | 89 +++++++++- > > > include/linux/acpi_iort.h | 7 + > > > include/linux/dma-iommu.h | 13 ++ > > > include/linux/iommu.h | 11 ++ > > > 7 files changed, 393 insertions(+), 23 deletions(-) > > > > > > -- > > > 2.17.1 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,URIBL_RED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 889D4C4338F for ; Thu, 5 Aug 2021 14:09:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 419976113B for ; Thu, 5 Aug 2021 14:09:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 419976113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F4217404BC; Thu, 5 Aug 2021 14:09:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vs0GKqslPsQs; Thu, 5 Aug 2021 14:09:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 90A3E404A5; Thu, 5 Aug 2021 14:09:15 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5AEB5C001A; Thu, 5 Aug 2021 14:09:15 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 78CA8C000E for ; Thu, 5 Aug 2021 14:09:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5591B8187F for ; Thu, 5 Aug 2021 14:09:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jkyW7EU1D6pg for ; Thu, 5 Aug 2021 14:09:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4F2D780A4A for ; Thu, 5 Aug 2021 14:09:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E28416113B for ; Thu, 5 Aug 2021 14:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628172552; bh=X0ZBKP2BynT6mUkVamflegnrwl7zM/qOLlWxMOgStJ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o6GDttf/mJMggbRDDFZGHk5bc/nwTrrThHtvhBspW8hKSQmWEjv3okGhHept3I7d8 bCPN6bRimalmig9dv/hHAeoU5g+iLBdZKHqXqQ2cm4siN/WlCDjKMspCiFtvcXclT1 pJyMZnKLi7gUdZXeesfMbPUxjV7sHrn4d77d2/csNaiTZ+7tqWRuJrzAza6CmzZAgK WMK10ST1TZazzvu6HqnkC5zPJrAyGBmm47T4n4yK2rO1lUhpNcL5PBtALjKhQ/8Mua pHM98+yx3YTNJGNSVA1vymXm7kXVdvI8vz3DHI0wBVXG3mo66MBN7jfw+q/caLrqlh QsxtLSIjc0OmA== Received: by mail-oi1-f172.google.com with SMTP id w6so7470379oiv.11 for ; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) X-Gm-Message-State: AOAM532pJINKup7ShdSS4x9B0xqNwh11ggmmzTqnHdNlr2M/KNnV2A7c rp+628KFKqS5YSDdPT0vMWLroCoTnS0wZxJLyuI= X-Google-Smtp-Source: ABdhPJyHVKR7zzGcPQV2xm5EVEtZyYFzaNP/C6TfKB70DcfcnYGbNIe+jy356hymU7h1io7dkA7w6OMFA0NN5+2eDJk= X-Received: by 2002:aca:39c6:: with SMTP id g189mr5556956oia.47.1628172552322; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <8df7fc81b00142b68126efd3c700a579@huawei.com> In-Reply-To: <8df7fc81b00142b68126efd3c700a579@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 16:09:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameerali Kolothum Thodi Cc: Will Deacon , Jon Nettleton , Linuxarm , Steven Price , ACPI Devel Maling List , Linux IOMMU , wanghuiqiang , "Guohanjun \(Hanjun Guo\)" , yangyicong , Sami Mujawar , Robin Murphy , Linux ARM X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, 5 Aug 2021 at 15:35, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ardb@kernel.org] > > Sent: 05 August 2021 14:23 > > To: Shameerali Kolothum Thodi > > Cc: Linux ARM ; ACPI Devel Maling List > > ; Linux IOMMU > > ; Linuxarm ; > > Lorenzo Pieralisi ; Joerg Roedel > > ; Robin Murphy ; Will Deacon > > ; wanghuiqiang ; Guohanjun > > (Hanjun Guo) ; Steven Price > > ; Sami Mujawar ; Jon > > Nettleton ; Eric Auger ; > > yangyicong > > Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node > > > > On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum > > wrote: > > > > > > Hi, > > > > > > The series adds support to IORT RMR nodes specified in IORT > > > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > > > memory ranges that are used by endpoints and require a unity > > > mapping in SMMU. > > > > > > We have faced issues with 3408iMR RAID controller cards which > > > fail to boot when SMMU is enabled. This is because these > > > controllers make use of host memory for various caching related > > > purposes and when SMMU is enabled the iMR firmware fails to > > > access these memory regions as there is no mapping for them. > > > IORT RMR provides a way for UEFI to describe and report these > > > memory regions so that the kernel can make a unity mapping for > > > these in SMMU. > > > > > > > Does this mean we are ignoring the RMR memory ranges, and exposing the > > entire physical address space to devices using the stream IDs in > > question? > > Nope. RMR node is used to describe the memory ranges used by end points > behind SMMU. And this information is used to create 1 : 1 mappings for those > ranges in SMMU. Anything outside those ranges will result in translation > fault(if there are no other dynamic DMA mappings). > Excellent! It was not obvious to me from looking at the patches, so I had to ask. Thanks, Ard. > > > > > > Change History: > > > > > > v6 --> v7 > > > > > > The only change from v6 is the fix pointed out by Steve to > > > the SMMUv2 SMR bypass install in patch #8. > > > > > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > > > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > > > yet as the series still needs more review[1]. > > > > > > Feedback and tests on this series is very much appreciated. > > > > > > v5 --> v6 > > > - Addressed comments from Robin & Lorenzo. > > > : Moved iort_parse_rmr() to acpi_iort_init() from > > > iort_init_platform_devices(). > > > : Removed use of struct iort_rmr_entry during the initial > > > parse. Using struct iommu_resv_region instead. > > > : Report RMR address alignment and overlap errors, but continue. > > > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > > > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > > > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > > > on Type of RMR region. Suggested by Jon N. > > > > > > Thanks, > > > Shameer > > > [0] https://developer.arm.com/documentation/den0049/latest/ > > > [1] > > https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.koloth > > um.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > > > ------ > > > v4 --> v5 > > > -Added a fw_data union to struct iommu_resv_region and removed > > > struct iommu_rmr (Based on comments from Joerg/Robin). > > > -Added iommu_put_rmrs() to release mem. > > > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > > > yet because of the above changes. > > > > > > v3 -->v4 > > > -Included the SMMUv2 SMR bypass install changes suggested by > > > Steve(patch #7) > > > -As per Robin's comments, RMR reserve implementation is now > > > more generic (patch #8) and dropped v3 patches 8 and 10. > > > -Rebase to 5.13-rc1 > > > > > > RFC v2 --> v3 > > > -Dropped RFC tag as the ACPICA header changes are now ready to be > > > part of 5.13[0]. But this series still has a dependency on that patch. > > > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > > > PCIe). > > > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > > > discussion here[1]. > > > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > > > ------ > > > > > > Jon Nettleton (1): > > > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > > > > > Shameer Kolothum (8): > > > iommu: Introduce a union to struct iommu_resv_region > > > ACPI/IORT: Add support for RMR node parsing > > > iommu/dma: Introduce generic helper to retrieve RMR info > > > ACPI/IORT: Add a helper to retrieve RMR memory regions > > > iommu/arm-smmu-v3: Introduce strtab init helper > > > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > > > bypass > > > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > > > iommu/dma: Reserve any RMR regions associated with a dev > > > > > > drivers/acpi/arm64/iort.c | 172 > > +++++++++++++++++++- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > > > drivers/iommu/dma-iommu.c | 89 +++++++++- > > > include/linux/acpi_iort.h | 7 + > > > include/linux/dma-iommu.h | 13 ++ > > > include/linux/iommu.h | 11 ++ > > > 7 files changed, 393 insertions(+), 23 deletions(-) > > > > > > -- > > > 2.17.1 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB84CC4338F for ; Thu, 5 Aug 2021 14:11:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94C7B60238 for ; Thu, 5 Aug 2021 14:11:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 94C7B60238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1vGGGJcUvoq4+p4wEvo9gezWQL4tOLO9oLK/yTINZOc=; b=nyWcgGVVEECVxv 5C98p2NxRybTPhew5WHwZ0kIPc3nCCqgCq4ApcSVSNIkT84F2x4etaSCGLtLYiOPUX2S7B3eHYNII yBAnSnozA+HGJxheHH8PvsWdsqkhH9d0wytRyxaDJgwbTAGhsWXESidGeFdAGQs5d46ZkRG58Hq+Z 1wcdpxQeq0YQNmrygEqGTtsdXJqQ7m6mbFTHbdEqTutdH8ekzwnagYVrcgOgsnB3aGgWMJOW5T7Wj CBPQJvcBON7nSpMPhq0FTTzRDnfdksErOifiHTPoE6cNK4g4iU0rlA7g/keLhc6QOU90BcsVbtMHO QXEt2CjspKhnm/n1/B9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBe3i-009nX9-Oi; Thu, 05 Aug 2021 14:09:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBe3e-009nWV-H1 for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 14:09:16 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E686C6113E for ; Thu, 5 Aug 2021 14:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628172552; bh=X0ZBKP2BynT6mUkVamflegnrwl7zM/qOLlWxMOgStJ8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o6GDttf/mJMggbRDDFZGHk5bc/nwTrrThHtvhBspW8hKSQmWEjv3okGhHept3I7d8 bCPN6bRimalmig9dv/hHAeoU5g+iLBdZKHqXqQ2cm4siN/WlCDjKMspCiFtvcXclT1 pJyMZnKLi7gUdZXeesfMbPUxjV7sHrn4d77d2/csNaiTZ+7tqWRuJrzAza6CmzZAgK WMK10ST1TZazzvu6HqnkC5zPJrAyGBmm47T4n4yK2rO1lUhpNcL5PBtALjKhQ/8Mua pHM98+yx3YTNJGNSVA1vymXm7kXVdvI8vz3DHI0wBVXG3mo66MBN7jfw+q/caLrqlh QsxtLSIjc0OmA== Received: by mail-oi1-f177.google.com with SMTP id o185so7455274oih.13 for ; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) X-Gm-Message-State: AOAM530cq19zssHFUxdekZjuJ1ememUB7glUdwdThEi6CPqk/v0uLr0G xQyVScC3k5o6JHED6Xe92J11JzgC6Fc0udYraW4= X-Google-Smtp-Source: ABdhPJyHVKR7zzGcPQV2xm5EVEtZyYFzaNP/C6TfKB70DcfcnYGbNIe+jy356hymU7h1io7dkA7w6OMFA0NN5+2eDJk= X-Received: by 2002:aca:39c6:: with SMTP id g189mr5556956oia.47.1628172552322; Thu, 05 Aug 2021 07:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20210805080724.480-1-shameerali.kolothum.thodi@huawei.com> <8df7fc81b00142b68126efd3c700a579@huawei.com> In-Reply-To: <8df7fc81b00142b68126efd3c700a579@huawei.com> From: Ard Biesheuvel Date: Thu, 5 Aug 2021 16:09:00 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node To: Shameerali Kolothum Thodi Cc: Linux ARM , ACPI Devel Maling List , Linux IOMMU , Linuxarm , Lorenzo Pieralisi , Joerg Roedel , Robin Murphy , Will Deacon , wanghuiqiang , "Guohanjun (Hanjun Guo)" , Steven Price , Sami Mujawar , Jon Nettleton , Eric Auger , yangyicong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_070914_640746_8016C416 X-CRM114-Status: GOOD ( 43.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 5 Aug 2021 at 15:35, Shameerali Kolothum Thodi wrote: > > > > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ardb@kernel.org] > > Sent: 05 August 2021 14:23 > > To: Shameerali Kolothum Thodi > > Cc: Linux ARM ; ACPI Devel Maling List > > ; Linux IOMMU > > ; Linuxarm ; > > Lorenzo Pieralisi ; Joerg Roedel > > ; Robin Murphy ; Will Deacon > > ; wanghuiqiang ; Guohanjun > > (Hanjun Guo) ; Steven Price > > ; Sami Mujawar ; Jon > > Nettleton ; Eric Auger ; > > yangyicong > > Subject: Re: [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node > > > > On Thu, 5 Aug 2021 at 10:10, Shameer Kolothum > > wrote: > > > > > > Hi, > > > > > > The series adds support to IORT RMR nodes specified in IORT > > > Revision E.b -ARM DEN 0049E[0]. RMR nodes are used to describe > > > memory ranges that are used by endpoints and require a unity > > > mapping in SMMU. > > > > > > We have faced issues with 3408iMR RAID controller cards which > > > fail to boot when SMMU is enabled. This is because these > > > controllers make use of host memory for various caching related > > > purposes and when SMMU is enabled the iMR firmware fails to > > > access these memory regions as there is no mapping for them. > > > IORT RMR provides a way for UEFI to describe and report these > > > memory regions so that the kernel can make a unity mapping for > > > these in SMMU. > > > > > > > Does this mean we are ignoring the RMR memory ranges, and exposing the > > entire physical address space to devices using the stream IDs in > > question? > > Nope. RMR node is used to describe the memory ranges used by end points > behind SMMU. And this information is used to create 1 : 1 mappings for those > ranges in SMMU. Anything outside those ranges will result in translation > fault(if there are no other dynamic DMA mappings). > Excellent! It was not obvious to me from looking at the patches, so I had to ask. Thanks, Ard. > > > > > > Change History: > > > > > > v6 --> v7 > > > > > > The only change from v6 is the fix pointed out by Steve to > > > the SMMUv2 SMR bypass install in patch #8. > > > > > > Thanks to the Tested-by tags by Laurentiu with SMMUv2 and > > > Hanjun/Huiqiang with SMMUv3 for v6. I haven't added the tags > > > yet as the series still needs more review[1]. > > > > > > Feedback and tests on this series is very much appreciated. > > > > > > v5 --> v6 > > > - Addressed comments from Robin & Lorenzo. > > > : Moved iort_parse_rmr() to acpi_iort_init() from > > > iort_init_platform_devices(). > > > : Removed use of struct iort_rmr_entry during the initial > > > parse. Using struct iommu_resv_region instead. > > > : Report RMR address alignment and overlap errors, but continue. > > > : Reworked arm_smmu_init_bypass_stes() (patch # 6). > > > - Updated SMMUv2 bypass SMR code. Thanks to Jon N (patch #8). > > > - Set IOMMU protection flags(IOMMU_CACHE, IOMMU_MMIO) based > > > on Type of RMR region. Suggested by Jon N. > > > > > > Thanks, > > > Shameer > > > [0] https://developer.arm.com/documentation/den0049/latest/ > > > [1] > > https://lore.kernel.org/linux-acpi/20210716083442.1708-1-shameerali.koloth > > um.thodi@huawei.com/T/#m043c95b869973a834b2fd57f3e1ed0325c84f3b7 > > > ------ > > > v4 --> v5 > > > -Added a fw_data union to struct iommu_resv_region and removed > > > struct iommu_rmr (Based on comments from Joerg/Robin). > > > -Added iommu_put_rmrs() to release mem. > > > -Thanks to Steve for verifying on SMMUv2, but not added the Tested-by > > > yet because of the above changes. > > > > > > v3 -->v4 > > > -Included the SMMUv2 SMR bypass install changes suggested by > > > Steve(patch #7) > > > -As per Robin's comments, RMR reserve implementation is now > > > more generic (patch #8) and dropped v3 patches 8 and 10. > > > -Rebase to 5.13-rc1 > > > > > > RFC v2 --> v3 > > > -Dropped RFC tag as the ACPICA header changes are now ready to be > > > part of 5.13[0]. But this series still has a dependency on that patch. > > > -Added IORT E.b related changes(node flags, _DSM function 5 checks for > > > PCIe). > > > -Changed RMR to stream id mapping from M:N to M:1 as per the spec and > > > discussion here[1]. > > > -Last two patches add support for SMMUv2(Thanks to Jon Nettleton!) > > > ------ > > > > > > Jon Nettleton (1): > > > iommu/arm-smmu: Get associated RMR info and install bypass SMR > > > > > > Shameer Kolothum (8): > > > iommu: Introduce a union to struct iommu_resv_region > > > ACPI/IORT: Add support for RMR node parsing > > > iommu/dma: Introduce generic helper to retrieve RMR info > > > ACPI/IORT: Add a helper to retrieve RMR memory regions > > > iommu/arm-smmu-v3: Introduce strtab init helper > > > iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force > > > bypass > > > iommu/arm-smmu-v3: Get associated RMR info and install bypass STE > > > iommu/dma: Reserve any RMR regions associated with a dev > > > > > > drivers/acpi/arm64/iort.c | 172 > > +++++++++++++++++++- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 76 +++++++-- > > > drivers/iommu/arm/arm-smmu/arm-smmu.c | 48 ++++++ > > > drivers/iommu/dma-iommu.c | 89 +++++++++- > > > include/linux/acpi_iort.h | 7 + > > > include/linux/dma-iommu.h | 13 ++ > > > include/linux/iommu.h | 11 ++ > > > 7 files changed, 393 insertions(+), 23 deletions(-) > > > > > > -- > > > 2.17.1 > > > > > > > > > _______________________________________________ > > > linux-arm-kernel mailing list > > > linux-arm-kernel@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel