From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A692AC433E0 for ; Wed, 20 Jan 2021 13:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 611322336E for ; Wed, 20 Jan 2021 13:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387453AbhATNYo (ORCPT ); Wed, 20 Jan 2021 08:24:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:53834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389185AbhATNQw (ORCPT ); Wed, 20 Jan 2021 08:16:52 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F0A823371 for ; Wed, 20 Jan 2021 13:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611148571; bh=87O7GrSH7aFNMKentPe/tHn88Y8PdtjVrGHyPMN/1Ks=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nx/USp8x+a4VErW3+FrTdkcMiu71DTeVUy0+HRIQr3KRZoZ56eS19LkKj+BRzQB9B mgkkI4AxBYx6QWaTf45JAgLtrFUast2bjTzRk65ih2vbik7/0FNEhJhtnYGjZt6HQT da/O5wPcLe9wTkXtuCSaz93E50Vj3eET5tEdytU1F1rvjroXl5UNyfD3d09f6Nj6Zw BryR9RL/SCwVum6VXmBSd+F+UVcVIH6sjDfsng73Ng8BVteGwUjY2wlM3UuFgRs9VT 0+v5uQwK8tdFhNFIIOBubt/WtYtb2uAS6j+9mc5sv8HNb5GQJ4OyAlN8S+smC5mdD8 q+Gft8kAVVRZw== Received: by mail-oi1-f179.google.com with SMTP id w124so24986812oia.6 for ; Wed, 20 Jan 2021 05:16:11 -0800 (PST) X-Gm-Message-State: AOAM531D2ODYriC9ZWJCYesoDk5FVs9LLW2M9JlO+iJ1t6IGzGqLnuxd yNtozNa3Is83JUrttdq0VgE+EKc1X1CXTqI/+uM= X-Google-Smtp-Source: ABdhPJw8vZjz+ynYzeabDu0W9Mkp4ZmuPTi9i1w7KwilsqfguTeO6X1CqhyKq14F6BMDgjhUR8h2OGXCiTzK2zKrLAg= X-Received: by 2002:aca:210f:: with SMTP id 15mr2800820oiz.174.1611148570568; Wed, 20 Jan 2021 05:16:10 -0800 (PST) MIME-Version: 1.0 References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> In-Reply-To: <161114590396.218530.9227813162726341261.b4-ty@kernel.org> From: Ard Biesheuvel Date: Wed, 20 Jan 2021 14:15:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service To: Will Deacon Cc: Marc Zyngier , Russell King , Catalin Marinas , Andre Przywara , Android Kernel Team , "Theodore Ts'o" , Mark Brown , Sudeep Holla , Linux Kernel Mailing List , Linus Walleij , kvmarm , Lorenzo Pieralisi , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > in arch_get_random_seed_long_early(). Apologies for messing this up > > in v5 and thanks to broonie for being on the watch! > > > > Will, Catalin: it would be much appreciated if you could consider taking > > patch 1/5. This contains the common definitions, and is a prerequisite > > for every other patch, although they are somewhat independent and likely > > will need to go through different subsystems. > > > > [...] > > Applied the first patch only to arm64 (for-next/rng), thanks! > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > https://git.kernel.org/arm64/c/67c6bb56b649 > > What's the plan for the rest of the series, and I think the related > change over at [1]? > Given that Ted seems to have lost interest in /dev/random patches, I was hoping [1] could be taken via the arm64 tree instead. Without this patch, I don't think we should expose the SMCCC RNG interface via arch_get_random_seed(), given how insanely often it will be called in that case. Note that the KVM patch implements the opposite end of this interface, and is not affected by [1] at all, so that can be taken at any time. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14ABC433DB for ; Wed, 20 Jan 2021 13:16:18 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2DE4C2339E for ; Wed, 20 Jan 2021 13:16:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DE4C2339E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6ECA14B168; Wed, 20 Jan 2021 08:16:17 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G8ScMPJrriQe; Wed, 20 Jan 2021 08:16:15 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 83EF94B16C; Wed, 20 Jan 2021 08:16:15 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9ECD84B168 for ; Wed, 20 Jan 2021 08:16:13 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sAq9Cv+yN9Vh for ; Wed, 20 Jan 2021 08:16:12 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 835D84B124 for ; Wed, 20 Jan 2021 08:16:12 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 581B8233A1 for ; Wed, 20 Jan 2021 13:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611148571; bh=87O7GrSH7aFNMKentPe/tHn88Y8PdtjVrGHyPMN/1Ks=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nx/USp8x+a4VErW3+FrTdkcMiu71DTeVUy0+HRIQr3KRZoZ56eS19LkKj+BRzQB9B mgkkI4AxBYx6QWaTf45JAgLtrFUast2bjTzRk65ih2vbik7/0FNEhJhtnYGjZt6HQT da/O5wPcLe9wTkXtuCSaz93E50Vj3eET5tEdytU1F1rvjroXl5UNyfD3d09f6Nj6Zw BryR9RL/SCwVum6VXmBSd+F+UVcVIH6sjDfsng73Ng8BVteGwUjY2wlM3UuFgRs9VT 0+v5uQwK8tdFhNFIIOBubt/WtYtb2uAS6j+9mc5sv8HNb5GQJ4OyAlN8S+smC5mdD8 q+Gft8kAVVRZw== Received: by mail-oi1-f182.google.com with SMTP id 15so24957779oix.8 for ; Wed, 20 Jan 2021 05:16:11 -0800 (PST) X-Gm-Message-State: AOAM530s/I633sQtp/PZtDUuYq4OEoRYFbow/bLpRIqg9S9uvk0jPTpx wwrvtr5qtDV/cJEsmtMUUKOfwy9/PC6+lfqhVyw= X-Google-Smtp-Source: ABdhPJw8vZjz+ynYzeabDu0W9Mkp4ZmuPTi9i1w7KwilsqfguTeO6X1CqhyKq14F6BMDgjhUR8h2OGXCiTzK2zKrLAg= X-Received: by 2002:aca:210f:: with SMTP id 15mr2800820oiz.174.1611148570568; Wed, 20 Jan 2021 05:16:10 -0800 (PST) MIME-Version: 1.0 References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> In-Reply-To: <161114590396.218530.9227813162726341261.b4-ty@kernel.org> From: Ard Biesheuvel Date: Wed, 20 Jan 2021 14:15:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service To: Will Deacon Cc: Lorenzo Pieralisi , Theodore Ts'o , Marc Zyngier , Linus Walleij , Sudeep Holla , Russell King , Linux Kernel Mailing List , Catalin Marinas , Mark Brown , Andre Przywara , Android Kernel Team , kvmarm , Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > in arch_get_random_seed_long_early(). Apologies for messing this up > > in v5 and thanks to broonie for being on the watch! > > > > Will, Catalin: it would be much appreciated if you could consider taking > > patch 1/5. This contains the common definitions, and is a prerequisite > > for every other patch, although they are somewhat independent and likely > > will need to go through different subsystems. > > > > [...] > > Applied the first patch only to arm64 (for-next/rng), thanks! > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > https://git.kernel.org/arm64/c/67c6bb56b649 > > What's the plan for the rest of the series, and I think the related > change over at [1]? > Given that Ted seems to have lost interest in /dev/random patches, I was hoping [1] could be taken via the arm64 tree instead. Without this patch, I don't think we should expose the SMCCC RNG interface via arch_get_random_seed(), given how insanely often it will be called in that case. Note that the KVM patch implements the opposite end of this interface, and is not affected by [1] at all, so that can be taken at any time. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D833C433E0 for ; Wed, 20 Jan 2021 13:18:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A284E23357 for ; Wed, 20 Jan 2021 13:18:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A284E23357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zkcwFHSSYBl3+RY4o6MbFdLgYorF9VkgjjQoIsubYPs=; b=lcTvP0tG/I0D3v0L5p9t4Hpzb G0V3skXEwJX43IChOPACnriWIo3JTrcErb+AcA94kEK/7h6aj9i7l/hshqeOTao6iPtyvnGAJx1KV iDWSzc7IS0jhql6mNaX8Ad++Q6iYonuFeOKEOk93wLAQeqO3bgYavqhtmSPmWzmOQlTbwmMWr0QmF pEuL7Y9XqojKqSPkKwsT4o8z3FeB3s3+WprKQk4GFzeaTWpFfKWOY9s8PYjuXwdbZ9/YauBXCy+5H jB1Dnp4jzJjqNyrvzR0+RcUQ0jMKadwzcFaQw2/jWuzbhw+E4XDeM0c5TiTrfvd7Qq2l37aD3c+cP jUhUZF6Kg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2DLP-0008Ay-1h; Wed, 20 Jan 2021 13:16:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2DLI-00088A-3O for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 13:16:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50DAF23384 for ; Wed, 20 Jan 2021 13:16:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611148571; bh=87O7GrSH7aFNMKentPe/tHn88Y8PdtjVrGHyPMN/1Ks=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nx/USp8x+a4VErW3+FrTdkcMiu71DTeVUy0+HRIQr3KRZoZ56eS19LkKj+BRzQB9B mgkkI4AxBYx6QWaTf45JAgLtrFUast2bjTzRk65ih2vbik7/0FNEhJhtnYGjZt6HQT da/O5wPcLe9wTkXtuCSaz93E50Vj3eET5tEdytU1F1rvjroXl5UNyfD3d09f6Nj6Zw BryR9RL/SCwVum6VXmBSd+F+UVcVIH6sjDfsng73Ng8BVteGwUjY2wlM3UuFgRs9VT 0+v5uQwK8tdFhNFIIOBubt/WtYtb2uAS6j+9mc5sv8HNb5GQJ4OyAlN8S+smC5mdD8 q+Gft8kAVVRZw== Received: by mail-oi1-f178.google.com with SMTP id d203so24959168oia.0 for ; Wed, 20 Jan 2021 05:16:11 -0800 (PST) X-Gm-Message-State: AOAM531l4Woe9o1GJRpqDP12af656T08Tt+CYIuTtaCf5inY5I4l6JVa fdD9iPQU9mabmANQ8id7QGFPD7xm6PRfQTCPRfw= X-Google-Smtp-Source: ABdhPJw8vZjz+ynYzeabDu0W9Mkp4ZmuPTi9i1w7KwilsqfguTeO6X1CqhyKq14F6BMDgjhUR8h2OGXCiTzK2zKrLAg= X-Received: by 2002:aca:210f:: with SMTP id 15mr2800820oiz.174.1611148570568; Wed, 20 Jan 2021 05:16:10 -0800 (PST) MIME-Version: 1.0 References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> In-Reply-To: <161114590396.218530.9227813162726341261.b4-ty@kernel.org> From: Ard Biesheuvel Date: Wed, 20 Jan 2021 14:15:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service To: Will Deacon X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_081612_215095_27FE3301 X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Theodore Ts'o , Marc Zyngier , Linus Walleij , Sudeep Holla , Russell King , Linux Kernel Mailing List , Catalin Marinas , Mark Brown , Andre Przywara , Android Kernel Team , kvmarm , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > in arch_get_random_seed_long_early(). Apologies for messing this up > > in v5 and thanks to broonie for being on the watch! > > > > Will, Catalin: it would be much appreciated if you could consider taking > > patch 1/5. This contains the common definitions, and is a prerequisite > > for every other patch, although they are somewhat independent and likely > > will need to go through different subsystems. > > > > [...] > > Applied the first patch only to arm64 (for-next/rng), thanks! > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > https://git.kernel.org/arm64/c/67c6bb56b649 > > What's the plan for the rest of the series, and I think the related > change over at [1]? > Given that Ted seems to have lost interest in /dev/random patches, I was hoping [1] could be taken via the arm64 tree instead. Without this patch, I don't think we should expose the SMCCC RNG interface via arch_get_random_seed(), given how insanely often it will be called in that case. Note that the KVM patch implements the opposite end of this interface, and is not affected by [1] at all, so that can be taken at any time. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel