From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE66EC4332F for ; Thu, 29 Sep 2022 10:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234934AbiI2KK3 (ORCPT ); Thu, 29 Sep 2022 06:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235308AbiI2KKX (ORCPT ); Thu, 29 Sep 2022 06:10:23 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CE007F0B5 for ; Thu, 29 Sep 2022 03:10:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 14B52B823F4 for ; Thu, 29 Sep 2022 10:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C637EC433B5 for ; Thu, 29 Sep 2022 10:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664446217; bh=cz4dMWsON9yrEVJT4yvHVh8L5Bbs3MSlA30bliNofpA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JlBYnZPvya2D3aIV37kbcT91PzgcbU4Pu5GUn/pyZhAZ+FO4MXctt2fYmvAiDAotV eTeR9ckSWMsObftz+zOt0Jl0a4823e/hZMW/7FMZq7msKeQKdLp2Esy5+pikd9QQh3 AtkrUBDQeLOvVk2BZtidk5EKx/BUd3SwmN1YFtOcdyaSjBnaD3qpa+tr0qwOp9MFoJ S4PHv53MwrAF++uBvb4ElBO4M57iIKtfGiKXehbxAxV/fQLzfqI2XwyPRIfa7kbZ6S q8Ql7A/C3AqolMa/blUh10Qn5Hkq0+nsQYCfteozZ7Ks5lvXBmocW4vZfB2kqgPNUZ WN79Vjb4FE5uA== Received: by mail-lf1-f46.google.com with SMTP id a2so1505708lfb.6 for ; Thu, 29 Sep 2022 03:10:17 -0700 (PDT) X-Gm-Message-State: ACrzQf0U1Z+U3li8zSycr4gl9RyE8vEgNjJstPMsaLefdV5Sb5Fbn7f4 BnTw4M3fIno2KP3nWkxe6m2nOGMztSzXMWgypt4= X-Google-Smtp-Source: AMsMyM5vJujibuvo1ihZbn/smR6yjW+H/huttb46k44io0Xzax7OmeGuUWtnoVUjBbdX1RM7uhW7bZDhnvmLMGF+Bhk= X-Received: by 2002:a05:6512:c0f:b0:49b:1e8c:59fd with SMTP id z15-20020a0565120c0f00b0049b1e8c59fdmr971411lfu.426.1664446215783; Thu, 29 Sep 2022 03:10:15 -0700 (PDT) MIME-Version: 1.0 References: <20220912162210.3626215-1-mark.rutland@arm.com> <20220912162210.3626215-7-mark.rutland@arm.com> <3cecc3a5-30b0-f0bd-c3de-9e09bd21909b@nvidia.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 29 Sep 2022 12:10:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 6/8] arm64: alternatives: have callbacks take a cap To: Jon Hunter Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, maz@kernel.org, will@kernel.org, "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Thu, 29 Sept 2022 at 11:54, Jon Hunter wrote: > > > On 27/09/2022 10:31, Jon Hunter wrote: > > ... > > >> diff --git a/arch/arm64/include/asm/alternative-macros.h > >> b/arch/arm64/include/asm/alternative-macros.h > >> index 7e157ab6cd505..189c31be163ce 100644 > >> --- a/arch/arm64/include/asm/alternative-macros.h > >> +++ b/arch/arm64/include/asm/alternative-macros.h > >> @@ -2,10 +2,16 @@ > >> #ifndef __ASM_ALTERNATIVE_MACROS_H > >> #define __ASM_ALTERNATIVE_MACROS_H > >> +#include > >> + > >> #include > >> #include > >> -#define ARM64_CB_PATCH ARM64_NCAPS > >> +#define ARM64_CB_BIT (UL(1) << 15) > >> + > >> +#if ARM64_NCAPS >= ARM64_CB_BIT > >> +#error "cpucaps have overflown ARM64_CB_BIT" > >> +#endif > > > > > > Some of our builders are failing and bisect is pointing to this commit. > > Looks like they don't like the above and I see the following errors ... > > > > CC arch/arm64/kvm/hyp/vhe/debug-sr.o > > /tmp/ccY3kbki.s: Assembler messages: > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: junk at end of line, first unrecognized > > character is `L' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: junk at end of line, first unrecognized > > character is `L' > > scripts/Makefile.build:249: recipe for target > > 'arch/arm64/kvm/hyp/vhe/debug-sr.o' failed > > > > Seems that it does not like the 'UL' macro for some reason. Any thoughts? > > > FYI, this issue is seen with GCC6 but GCC7 and beyond appear to work fine. > Are you using the same version of binutils with those different compilers? And which is/are the exact version(s)? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A1CFC433FE for ; Thu, 29 Sep 2022 10:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nDyV50dczzcNKvHVaIlU8vQVIj/um9gQWw/KzUqcpIE=; b=ayaJcaAlanru3U X3EFiW6Pmo8c2henzVmvaesutI3VkNfy12hGVEK9ToTgyaEyfaiP1Zd9JPYkBkXt6hYSdUebJHMod 3ja/lYTfM8arP/rWoQs/XhtKlwRjlUTJCi0g4p47faBCaeRoUa5qBUhanbXz/RFNjwwQghqA0UEv9 qrQG2Ag2fp8UPffRo9j5cvLwFLrXp8Agty3YtsQ84UGdaj13CR4yZCK/pF0YyJ+gAbg+0I1qfSBUd v9WBD1qo6Dp3U3fmXKonZvpjlVkXfXJd9vxiOZggXoH7WFgoRAsnXZWm64t2PByc6F/5B/Q67o2CN IrLiAwZl0HTufC1K5EWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odqUw-002KcM-Eo; Thu, 29 Sep 2022 10:10:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odqUl-002Ka7-NB for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 10:10:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62C4060EE2 for ; Thu, 29 Sep 2022 10:10:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2FB9C433D6 for ; Thu, 29 Sep 2022 10:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664446217; bh=cz4dMWsON9yrEVJT4yvHVh8L5Bbs3MSlA30bliNofpA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JlBYnZPvya2D3aIV37kbcT91PzgcbU4Pu5GUn/pyZhAZ+FO4MXctt2fYmvAiDAotV eTeR9ckSWMsObftz+zOt0Jl0a4823e/hZMW/7FMZq7msKeQKdLp2Esy5+pikd9QQh3 AtkrUBDQeLOvVk2BZtidk5EKx/BUd3SwmN1YFtOcdyaSjBnaD3qpa+tr0qwOp9MFoJ S4PHv53MwrAF++uBvb4ElBO4M57iIKtfGiKXehbxAxV/fQLzfqI2XwyPRIfa7kbZ6S q8Ql7A/C3AqolMa/blUh10Qn5Hkq0+nsQYCfteozZ7Ks5lvXBmocW4vZfB2kqgPNUZ WN79Vjb4FE5uA== Received: by mail-lf1-f50.google.com with SMTP id k10so1510439lfm.4 for ; Thu, 29 Sep 2022 03:10:17 -0700 (PDT) X-Gm-Message-State: ACrzQf329vgCGeD78rhP/r1/KqpNgnRsrgjD6hF9x9eiQgwFU/l+tFVh NTkTkoScKso4xPucdIxo2R4lAmwvNbKeoTByY6o= X-Google-Smtp-Source: AMsMyM5vJujibuvo1ihZbn/smR6yjW+H/huttb46k44io0Xzax7OmeGuUWtnoVUjBbdX1RM7uhW7bZDhnvmLMGF+Bhk= X-Received: by 2002:a05:6512:c0f:b0:49b:1e8c:59fd with SMTP id z15-20020a0565120c0f00b0049b1e8c59fdmr971411lfu.426.1664446215783; Thu, 29 Sep 2022 03:10:15 -0700 (PDT) MIME-Version: 1.0 References: <20220912162210.3626215-1-mark.rutland@arm.com> <20220912162210.3626215-7-mark.rutland@arm.com> <3cecc3a5-30b0-f0bd-c3de-9e09bd21909b@nvidia.com> In-Reply-To: From: Ard Biesheuvel Date: Thu, 29 Sep 2022 12:10:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 6/8] arm64: alternatives: have callbacks take a cap To: Jon Hunter Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, james.morse@arm.com, joey.gouly@arm.com, maz@kernel.org, will@kernel.org, "linux-tegra@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_031019_885681_370A786F X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Sept 2022 at 11:54, Jon Hunter wrote: > > > On 27/09/2022 10:31, Jon Hunter wrote: > > ... > > >> diff --git a/arch/arm64/include/asm/alternative-macros.h > >> b/arch/arm64/include/asm/alternative-macros.h > >> index 7e157ab6cd505..189c31be163ce 100644 > >> --- a/arch/arm64/include/asm/alternative-macros.h > >> +++ b/arch/arm64/include/asm/alternative-macros.h > >> @@ -2,10 +2,16 @@ > >> #ifndef __ASM_ALTERNATIVE_MACROS_H > >> #define __ASM_ALTERNATIVE_MACROS_H > >> +#include > >> + > >> #include > >> #include > >> -#define ARM64_CB_PATCH ARM64_NCAPS > >> +#define ARM64_CB_BIT (UL(1) << 15) > >> + > >> +#if ARM64_NCAPS >= ARM64_CB_BIT > >> +#error "cpucaps have overflown ARM64_CB_BIT" > >> +#endif > > > > > > Some of our builders are failing and bisect is pointing to this commit. > > Looks like they don't like the above and I see the following errors ... > > > > CC arch/arm64/kvm/hyp/vhe/debug-sr.o > > /tmp/ccY3kbki.s: Assembler messages: > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1600: Error: junk at end of line, first unrecognized > > character is `L' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: found 'L', expected: ')' > > /tmp/ccY3kbki.s:1723: Error: junk at end of line, first unrecognized > > character is `L' > > scripts/Makefile.build:249: recipe for target > > 'arch/arm64/kvm/hyp/vhe/debug-sr.o' failed > > > > Seems that it does not like the 'UL' macro for some reason. Any thoughts? > > > FYI, this issue is seen with GCC6 but GCC7 and beyond appear to work fine. > Are you using the same version of binutils with those different compilers? And which is/are the exact version(s)? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel