From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D748B1854 for ; Thu, 22 Sep 2022 13:10:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8973CC43140 for ; Thu, 22 Sep 2022 13:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663852238; bh=IbGM/byH6H/8dk7VeD2SM8PKn/YjhjgX88MXM7V4MO8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bXchTYVFGGSyYbPBLXv5Sudr4zaXhq4/zEkHJzv9sSjGczkEizbR9ZEN2aYOi1aOQ ihyi4S5gaAaHtT4UJj7w5GYIo9fyKf4kpRUYRp7rplo0DkoGGDT4DSXWBVzHwksFFs ATMY+078eqY3Y546X9zjxtb33F/L0P/awNC5OUEDrfq9J6Iu9YqYVlTJ80qYkjMnLl 2x8/0jv1AvH/dwuyWTVz+pyPflJkV9WpT9P3tGTlmIhx4EiK61TkezBuWxbifRpB30 27VZ1lnzbWYUcBMst+ZRXZnhURsJyE3f1lKbS4D7Oj71lyicji4yluXF7nEYrOCSnT HLyy1Qk8J3t+A== Received: by mail-lf1-f52.google.com with SMTP id a8so14541329lff.13 for ; Thu, 22 Sep 2022 06:10:38 -0700 (PDT) X-Gm-Message-State: ACrzQf16zXrDNlYVxJtvot84RyejSJd45mB/KwIzPr2nNOdQZoWzQCbS VguhrIVzf+zog2ZTIpGTjSpbk7nHvaQo6W1/cLQ= X-Google-Smtp-Source: AMsMyM4GtDozrEtec9pVj09qwv57D2wctSxmAF/XEWP0Vls1jVT995toGoevtsL7yl3xxnolshpmWUlGf1MvHMY+PEQ= X-Received: by 2002:a05:6512:4024:b0:497:4db:6ad0 with SMTP id br36-20020a056512402400b0049704db6ad0mr1288742lfb.637.1663852236554; Thu, 22 Sep 2022 06:10:36 -0700 (PDT) Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220920183554.3870247-1-ardb@kernel.org> <20220920183554.3870247-9-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 22 Sep 2022 15:10:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 8/8] efi/loongarch: libstub: remove dependency on flattened DT To: Huacai Chen Cc: linux-efi , loongarch@lists.linux.dev, Arnd Bergmann , Ilias Apalodimas , Huacai Chen , Xi Ruoyao Content-Type: text/plain; charset="UTF-8" On Thu, 22 Sept 2022 at 15:09, Huacai Chen wrote: > > On Thu, Sep 22, 2022 at 8:50 PM Ard Biesheuvel wrote: > > > > On Thu, 22 Sept 2022 at 14:08, Huacai Chen wrote: > > > > > > Hi, Ard, > > > > > > On Thu, Sep 22, 2022 at 4:59 PM Ard Biesheuvel wrote: > > > > > > > > On Thu, 22 Sept 2022 at 09:42, Huacai Chen wrote: > > > > > > > > > > On Thu, Sep 22, 2022 at 3:25 PM Ard Biesheuvel wrote: > > > > > > > > > > > > On Thu, 22 Sept 2022 at 09:22, Huacai Chen wrote: > > > > > > > > > > > > > > On Thu, Sep 22, 2022 at 3:13 PM Ard Biesheuvel wrote: > > > > > > > > > > > > > > > > On Thu, 22 Sept 2022 at 04:15, Huacai Chen wrote: > > > > > > > > > > > > > > > > > > On Wed, Sep 21, 2022 at 4:15 PM Ard Biesheuvel wrote: > > > > > > > > > > > > > > > > > > > > On Wed, 21 Sept 2022 at 06:02, Huacai Chen wrote: > > > > > > > > > > > > > > > > > > > > > > Acked-by: Huacai Chen > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thank you Huacai > > > > > > > > > > > > > > > > > > > > I have created a separate tag with these patches applied onto the > > > > > > > > > > first loongarch efi enablement patch (see below) > > > > > > > > > > > > > > > > > > > > I would prefer to keep the loongarch trees separate for the next merge > > > > > > > > > > window, but if needed to avoid massive conflicts, you could merge the > > > > > > > > > > tag into the loongarch tree and rebase your changes on top. But please > > > > > > > > > > take care not to rebase those patches themselves: the commit SHAs need > > > > > > > > > > to remain the same. > > > > > > > > > > > > > > > > > > > > However, if the conflicts are only minor, you can just explain in your > > > > > > > > > > PR to Linus what the resolution should look like. > > > > > > > > > > > > > > > > > > > > The tag can be found here: > > > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/tag/?h=efi-loongarch-for-v6.1-2 > > > > > > > > > > > > > > > > > > > > I have merged this into the EFI tree as well and pushed it out; it > > > > > > > > > > should appear in -next tomorrow. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > b093dc55ba9a efi/loongarch: libstub: remove dependency on flattened DT > > > > > > > > > > 102faf0747c2 efi: libstub: install boot-time memory map as config table > > > > > > > > > > 7318926e7bc9 efi: libstub: remove DT dependency from generic stub > > > > > > > > > > 7cb6671e3caa efi: libstub: unify initrd loading between architectures > > > > > > > > > > > > > > > > I will have to respin the initrd patch, unfortunately, as it breaks > > > > > > > > x86. So the signed tag will be updated, and the SHAs above will change > > > > > > > > as well. > > > > > > > Emm, initrd is also broken on LoongArch, the core kernel gets an > > > > > > > EFI_INVALID_TABLE_ADDR address. > > > > > > > > > > > > > > > > > > > OK, I will investigate. This was working fine before so I'm not sure > > > > > > what happened there. > > > > > > > > > > > > > > I cannot reproduce this. Can you reproduce it with qemu? If so, can > > > > you share your command line and .config etc? > > > In qemu we also OK, but on a real machine efistub fails at > > > efi_bs_call(locate_device_path, &lf2_proto_guid, &dp, &handle), maybe > > > our UEFI BIOS has some problems? On a real machine we use grub and > > > there is no "initrd" command in UEFI shell. > > > > > > > Ah ok, so i guess your GRUB lacks the LoadFile2 patches? > > > > https://lists.gnu.org/archive/html/grub-devel/2022-09/msg00057.html > Maybe it is a GRUB problem (I'll discuss with GRUB team), but why > without this series the GRUB can load initrd? Because in the old way > UEFI BIOS fill initrd information to FDT? > No GRUB loads the initrd and creates a DT with a /chosen node to record the initrd base and size.